ledger_sync 2.6.0 → 3.0.2

data/lib/ledger_sync/ledgers/client.rb

@@ -30,9 +30,9 @@ module LedgerSync
           def ledger_attributes_to_save
             return {} if self.class.ledger_attributes_to_save.nil?
 
-            Hash[self.class.ledger_attributes_to_save.map do |attribute|
+            self.class.ledger_attributes_to_save.to_h do |attribute|
               [attribute, send(attribute)]
-            end]
+            end
           end
 
           def operation_for(args = {})
@@ -98,7 +98,7 @@ module LedgerSync
           end
 
           def resource_from_ledger_type(type:, converter: nil)
-            converter ||= proc { |n| n.underscore }
+            converter ||= proc(&:underscore)
             ledger_resource_type_overrides.invert[converter.call(type).to_sym] || resources[converter.call(type).to_sym]
           end
 

data/lib/ledger_sync/ledgers/mixins/infer_serializer_mixin.rb

@@ -9,45 +9,33 @@ module LedgerSync
       module InferSerializerMixin
         module ClassMethods
           def inferred_deserializer_class
-            @inferred_deserializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_deserializer_class_name
-              )
-            end
+            @inferred_deserializer_class ||= inferred_config.base_module.const_get(
+              inferred_deserializer_class_name
+            )
           end
 
           def inferred_deserializer_class_name
-            @inferred_deserializer_class_name ||= begin
-              "#{inferred_resource_class}::Deserializer"
-            end
+            @inferred_deserializer_class_name ||= "#{inferred_resource_class}::Deserializer"
           end
 
           def inferred_searcher_deserializer_class
-            @inferred_searcher_deserializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_searcher_deserializer_class_name
-              )
-            end
+            @inferred_searcher_deserializer_class ||= inferred_config.base_module.const_get(
+              inferred_searcher_deserializer_class_name
+            )
           end
 
           def inferred_searcher_deserializer_class_name
-            @inferred_searcher_deserializer_class_name ||= begin
-              "#{inferred_resource_class}::SearcherDeserializer"
-            end
+            @inferred_searcher_deserializer_class_name ||= "#{inferred_resource_class}::SearcherDeserializer"
           end
 
           def inferred_serializer_class
-            @inferred_serializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_serializer_class_name
-              )
-            end
+            @inferred_serializer_class ||= inferred_config.base_module.const_get(
+              inferred_serializer_class_name
+            )
           end
 
           def inferred_serializer_class_name
-            @inferred_serializer_class_name ||= begin
-              "#{inferred_resource_class}::Serializer"
-            end
+            @inferred_serializer_class_name ||= "#{inferred_resource_class}::Serializer"
           end
         end
 

data/lib/ledger_sync/ledgers/mixins/infer_validation_contract_mixin.rb

@@ -6,11 +6,9 @@ module LedgerSync
       module InferValidationContractMixin
         module ClassMethods
           def inferred_validation_contract_class
-            @inferred_validation_contract_class ||= begin
-              const_get(
-                inferred_validation_contract_class_name
-              )
-            end
+            @inferred_validation_contract_class ||= const_get(
+              inferred_validation_contract_class_name
+            )
           end
 
           def inferred_validation_contract_class_name

data/lib/ledger_sync/resource.rb

@@ -44,13 +44,13 @@ module LedgerSync
     end
 
     def changed?
-      super || resource_attributes.references_many.select(&:changed?).any?
+      super || resource_attributes.references_many.any?(&:changed?)
     end
 
     def changes
-      super.merge(Hash[resource_attributes.references_many.map do |ref|
-                         [ref.name, ref.changes['value']] if ref.changed?
-                       end.compact])
+      super.merge(resource_attributes.references_many.map do |ref|
+        [ref.name, ref.changes['value']] if ref.changed?
+      end.compact.to_h)
     end
 
     def class_from_resource_type(obj)
@@ -62,7 +62,7 @@ module LedgerSync
     end
 
     def self.inherited(subclass)
-      resource_attributes.each do |_name, resource_attribute|
+      resource_attributes.each_value do |resource_attribute|
         subclass._add_resource_attribute(resource_attribute)
       end
 

data/lib/ledger_sync/resource_attribute/dirty_mixin.rb

@@ -40,12 +40,12 @@ module LedgerSync
       end
 
       def dirty_attributes_to_h
-        Hash[self.class.dirty_attributes.keys.map do |k|
+        self.class.dirty_attributes.keys.to_h do |k|
           [
             k,
             public_send(k)
           ]
-        end]
+        end
       end
 
       # Normally you would just call `changes_applied`, but because we

data/lib/ledger_sync/serialization/mixin.rb

@@ -14,7 +14,7 @@ module LedgerSync
         #
         # @return [Serializer::Attribute]
         #
-        def attribute(_hash_attribute, _args = {}, &_block)
+        def attribute(_hash_attribute, _args = {}, &)
           raise NotImplementedError
         end
 

data/lib/ledger_sync/serializer.rb

@@ -60,7 +60,7 @@ module LedgerSync
       @attributes ||= Serialization::SerializerAttributeSet.new(serializer_class: self)
     end
 
-    def self.references_one(hash_attribute, args = {}, &block)
+    def self.references_one(hash_attribute, args = {}, &)
       attribute(
         hash_attribute,
         {
@@ -68,11 +68,11 @@ module LedgerSync
             serializer: serializer_from(hash_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 
-    def self.references_many(hash_attribute, args = {}, &block)
+    def self.references_many(hash_attribute, args = {}, &)
       attribute(
         hash_attribute,
         {
@@ -80,7 +80,7 @@ module LedgerSync
             serializer: serializer_from(hash_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 

data/lib/ledger_sync/test/support/factory_bot.rb

@@ -65,7 +65,7 @@ end
 def generate_resource_factories
   LedgerSync.ledgers.each do |ledger_key, ledger|
     ledger.client_class.resources.each do |resource_key, resource_class|
-      factory_key = "#{ledger_key}_#{resource_key}".to_sym
+      factory_key = :"#{ledger_key}_#{resource_key}"
       next if FactoryBot.factories.registered?(factory_key)
 
       register_factory(prefix: ledger_key, resource_class: resource_class)
@@ -101,7 +101,7 @@ module FactoryBot
   def self.test_run_id(*appends, **keywords)
     @test_run_id ||= rand_id(
       *appends,
-      **keywords.merge(include_test_run_id: false)
+      **keywords, include_test_run_id: false
     )
   end
 

data/lib/ledger_sync/test/support/qa/ledger_support_setup.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 def setup_client_qa_support(*clients, keyed: false) # rubocop:disable Metrics/PerceivedComplexity
-  qa_clients = Hash[clients.uniq.map do |client|
+  qa_clients = clients.uniq.to_h do |client|
     key = client.config.root_key
 
     qa_support "#{key}_helpers"
@@ -14,7 +14,7 @@ def setup_client_qa_support(*clients, keyed: false) # rubocop:disable Metrics/Pe
         key: key
       }
     ]
-  end]
+  end
 
   RSpec.configure do |config|
     qa_clients.each_value do |data|

data/lib/ledger_sync/test/support/record_collection.rb

@@ -29,7 +29,7 @@ module LedgerSync
         Gem.find_files(File.join(dir, '*.json')).map do |file_path|
           record = File.basename(file_path, '.json').to_sym
           @records[record] = record_class.new(
-            hash: JSON.parse(File.open(file_path).read),
+            hash: JSON.parse(File.read(file_path)),
             path: file_path,
             record: record
           )

data/lib/ledger_sync/type/reference_many.rb

@@ -35,7 +35,7 @@ module LedgerSync
       def valid?(args = {})
         value = args.fetch(:value)
         return false unless value.is_a?(Array)
-        return true if (resource_classes & value.map(&:class)).any?
+        return true if resource_classes.intersect?(value.map(&:class))
         return true if value.is_a?(Array) && value.empty?
 
         false

data/lib/ledger_sync/type/value_mixin.rb

@@ -44,7 +44,7 @@ module LedgerSync
         value = args.fetch(:value)
 
         return true if value.nil?
-        return true if valid_classes.select { |e| value.is_a?(e) }.any?
+        return true if valid_classes.any? { |e| value.is_a?(e) }
 
         false
       end

data/lib/ledger_sync/util/dotenv_updator.rb

@@ -24,7 +24,7 @@ module LedgerSync
               client_method = env_key.split(prefix).last.downcase
 
               if line =~ /\A#{prefix}/ && to_save.key?(client_method)
-                env_value = ENV[env_key]
+                env_value = ENV.fetch(env_key, nil)
                 new_value = to_save.delete(client_method)
                 tempfile.puts "#{env_key}=#{new_value}"
                 next if env_value == new_value.to_s

data/lib/ledger_sync/util/resource_converter/attribute_set.rb

@@ -22,7 +22,7 @@ module LedgerSync
         def add(attribute)
           unless attribute.destination_attribute.nil?
             if @attribute_keys.key?(attribute.destination_attribute.to_s)
-              raise "destination_attribute already defined for #{resource_converter_class.name}: "\
+              raise "destination_attribute already defined for #{resource_converter_class.name}: " \
                     "#{attribute.destination_attribute}"
             end
 

data/lib/ledger_sync/util/resource_converter.rb

@@ -54,15 +54,15 @@ module LedgerSync
         )
       end
 
-      def self.attribute(*args, &block)
-        _attribute(*args, &block)
+      def self.attribute(...)
+        _attribute(...)
       end
 
       def self.attributes
         @attributes ||= ResourceConverter::AttributeSet.new(resource_converter_class: self)
       end
 
-      def self._references(destination_attribute = nil, args = {}, &block)
+      def self._references(destination_attribute = nil, args = {}, &)
         reference_type     = args.fetch(:reference_type)
         resource_converter = args.fetch(:resource_converter)
 
@@ -89,27 +89,27 @@ module LedgerSync
               ]
             )
           ),
-          &block
+          &
         )
       end
 
-      def self.references_one(destination_attribute = nil, args = {}, &block)
+      def self.references_one(destination_attribute = nil, args = {}, &)
         _references(
           destination_attribute,
           {
             reference_type: :one
           }.merge(args),
-          &block
+          &
         )
       end
 
-      def self.references_many(destination_attribute = nil, args = {}, &block)
+      def self.references_many(destination_attribute = nil, args = {}, &)
         _references(
           destination_attribute,
           {
             reference_type: :many
           }.merge(args),
-          &block
+          &
         )
       end
     end

data/lib/ledger_sync/util/resources_builder.rb

@@ -51,37 +51,35 @@ module LedgerSync
                          end
         raise "#{type} is an invalid resource type" if resource_class.nil?
 
-        current_data = Hash[
-          current_data.map do |k, v|
-            k = k.to_sym
+        current_data = current_data.to_h do |k, v|
+          k = k.to_sym
 
-            attribute = resource_class.resource_attributes[k]
-            if attribute.nil? && !ignore_unrecognized_attributes
-              raise "Unrecognized attribute for #{resource_class.name}: #{k}"
-            end
+          attribute = resource_class.resource_attributes[k]
+          if attribute.nil? && !ignore_unrecognized_attributes
+            raise "Unrecognized attribute for #{resource_class.name}: #{k}"
+          end
 
-            v = if attribute.is_a?(ResourceAttribute::Reference::One)
-                  resource_type = resource_type_by(external_id: current_data[k])
+          v = if attribute.is_a?(ResourceAttribute::Reference::One)
+                resource_type = resource_type_by(external_id: current_data[k])
+                resource_or_build(
+                  external_id: current_data[k],
+                  type: resource_type
+                )
+              elsif attribute.is_a?(ResourceAttribute::Reference::Many)
+                current_data[k].map do |many_reference|
                   resource_or_build(
-                    external_id: current_data[k],
-                    type: resource_type
+                    external_id: many_reference,
+                    type: attribute.type.resource_class.resource_type
                   )
-                elsif attribute.is_a?(ResourceAttribute::Reference::Many)
-                  current_data[k].map do |many_reference|
-                    resource_or_build(
-                      external_id: many_reference,
-                      type: attribute.type.resource_class.resource_type
-                    )
-                  end
-                elsif cast
-                  attribute.type.cast(value: v)
-                else
-                  v
                 end
+              elsif cast
+                attribute.type.cast(value: v)
+              else
+                v
+              end
 
-            [k, v]
-          end
-        ]
+          [k, v]
+        end
 
         @all_resources[resource_key(external_id: external_id, type: type)] ||= resource_class.new(
           external_id: external_id,

data/lib/ledger_sync/util/signer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'base64'
+
 module LedgerSync
   module Util
     class Signer
@@ -25,11 +27,11 @@ module LedgerSync
       end
 
       def self.escape(str:)
-        CGI.escape(str).gsub(/\+/, '%20')
+        CGI.escape(str).gsub('+', '%20')
       end
 
       def self.unescape(str:)
-        CGI.unescape(str.gsub(/%20/, '+'))
+        CGI.unescape(str.gsub('%20', '+'))
       end
     end
   end

data/lib/ledger_sync/util/string_helpers.rb

@@ -10,7 +10,7 @@ module LedgerSync
       end
 
       def underscore!(str)
-        str.gsub!(/::/, '/')
+        str.gsub!('::', '/')
         str.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
         str.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
         str.tr!('-', '_')

data/lib/ledger_sync/version.rb

@@ -2,11 +2,11 @@
 
 # :nocov:
 module LedgerSync
-  VERSION = '2.6.0'
+  VERSION = '3.0.2'
 
   def self.version
     if ENV['PRE_RELEASE']
-      "#{VERSION}.pre.#{ENV['GITHUB_RUN_NUMBER']}"
+      "#{VERSION}.pre.#{ENV.fetch('GITHUB_RUN_NUMBER', nil)}"
     else
       VERSION
     end