ledger_sync 2.6.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac42694f93ad3896cc137816aa7e18a538eae97e35a038b3fc5a521d6611f977
-  data.tar.gz: 0e9d7ddf37ac6adec2f9034416f7de6d2a69a9213779154e13082ed52ec8c3f4
+  metadata.gz: b63db8eefe2b7ef796c61c32d875751b2a3959086f01ae9f1706e0248a0a8875
+  data.tar.gz: 4cb44ba51344f600e60a3f10e33ef3d4d4bad7d1530d2935a732e33f0d63a75d
 SHA512:
-  metadata.gz: 2140601d6f915415de8cc82a7aff64e8c9d4149fd3c5283ab59a8dfaa33c6e3da35fb6204dace43b9b248d5892fb1138139b6b8de36b7ad59ee72949d6f16dcc
-  data.tar.gz: 69fa17ff3daf957a57c52ae9294f641600bb25d983231bfa46a183a898015fb38602df07178551a5ecd9a9a9221761b8d78fbbd4c5599d804c0400689652e5cd
+  metadata.gz: 9039f8c4f393591c4a048f89c30344bf83329580b753edfbc65c2ad256f0e4c4c6f25656de6aec20261686157754c5353c8a86329c62b4092ce025e5d3bccbd4
+  data.tar.gz: 5038845e3146b964d104686c11e89744245f7c708f8811f813e222ac485dedb1dc4304757d642346c48b158b02a7afc6173f5ce7b7e13767dce3cd4dec391a0b

data/.github/workflows/gem-workflow.yml

@@ -9,28 +9,30 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby-version: ['2.7', '3.0']
+        ruby-version: ['3.1.6', '3.2.6', '3.3.6']
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
         with:
           persist-credentials: false
           fetch-depth: 0
-      - name: Ruby Setup and Bundle
+      - name: Ruby Setup
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
-          run: |
-            gem install bundler
-            bundle update
-            bundle install
-      - run: bundle exec rubocop
+      - name: Bundle install
+        run: |
+          gem install bundler
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      - name: Rubocop
+        run: bundle exec rubocop
   rspec:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby-version: ['2.7', '3.0']
+        ruby-version: ['3.1.6', '3.2.6', '3.3.6']
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3

data/.gitignore

@@ -27,4 +27,6 @@ _site/
 *.local
 
 .tool-versions
-.ruby-version
+.ruby-version
+
+.vscode

data/.rubocop.yml

@@ -4,9 +4,12 @@ AllCops:
   Exclude:
     - "documentation/site/_plugins/**/*"
     - "vendor/**/*"
-  TargetRubyVersion: 2.5.8
+  TargetRubyVersion: 3.1
   NewCops: enable
 
+Gemspec/DevelopmentDependencies:
+  Enabled: False
+
 Layout/LineLength:
   Enabled: True
   Max: 120
@@ -41,6 +44,9 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: True
 
+Naming/VariableNumber:
+  Enabled: False
+
 Style/AccessorGrouping:
   Enabled: True
 

data/Gemfile

@@ -6,3 +6,5 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in ledger_sync.gemspec
 gemspec
+
+gem 'rubocop', '~> 1.62'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ledger_sync (2.6.0)
+    ledger_sync (3.0.0)
       activemodel
       dotenv
       dry-schema
@@ -21,46 +21,61 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (7.0.6)
-      activesupport (= 7.0.6)
-    activesupport (7.0.6)
+    activemodel (7.1.5)
+      activesupport (= 7.1.5)
+    activesupport (7.1.5)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
+      mutex_m
+      securerandom (>= 0.3)
       tzinfo (~> 2.0)
-    addressable (2.8.4)
-      public_suffix (>= 2.0.2, < 6.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.2)
     awesome_print (1.9.2)
+    base64 (0.2.0)
+    benchmark (0.4.0)
+    bigdecimal (3.1.8)
     bump (0.9.0)
     byebug (11.1.3)
     childprocess (4.1.0)
     climate_control (1.2.0)
     colorize (1.1.0)
-    concurrent-ruby (1.2.2)
-    coveralls_reborn (0.27.0)
+    concurrent-ruby (1.3.4)
+    connection_pool (2.4.1)
+    coveralls_reborn (0.28.0)
       simplecov (~> 0.22.0)
       term-ansicolor (~> 1.7)
       thor (~> 1.2)
       tins (~> 1.32)
-    crack (0.4.5)
+    crack (1.0.0)
+      bigdecimal
       rexml
-    diff-lcs (1.5.0)
-    docile (1.4.0)
-    dotenv (2.8.1)
-    dry-configurable (1.0.1)
+    diff-lcs (1.5.1)
+    docile (1.4.1)
+    dotenv (3.1.4)
+    drb (2.2.1)
+    dry-configurable (1.2.0)
       dry-core (~> 1.0, < 2)
       zeitwerk (~> 2.6)
-    dry-core (1.0.0)
+    dry-core (1.0.2)
       concurrent-ruby (~> 1.0)
+      logger
       zeitwerk (~> 2.6)
-    dry-inflector (1.0.0)
+    dry-inflector (1.1.0)
     dry-initializer (3.1.1)
     dry-logic (1.5.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 1.0, < 2)
       zeitwerk (~> 2.6)
-    dry-schema (1.13.2)
+    dry-schema (1.13.4)
       concurrent-ruby (~> 1.0)
       dry-configurable (~> 1.0, >= 1.0.1)
       dry-core (~> 1.0, < 2)
@@ -68,7 +83,8 @@ GEM
       dry-logic (>= 1.4, < 2)
       dry-types (>= 1.7, < 2)
       zeitwerk (~> 2.6)
-    dry-types (1.7.1)
+    dry-types (1.7.2)
+      bigdecimal (~> 3.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 1.0)
       dry-inflector (~> 1.0)
@@ -82,7 +98,7 @@ GEM
       zeitwerk (~> 2.6)
     factory_bot (6.1.0)
       activesupport (>= 5.0.0)
-    faraday (1.10.3)
+    faraday (1.10.4)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
@@ -102,94 +118,103 @@ GEM
     faraday-httpclient (1.0.1)
     faraday-multipart (1.0.4)
       multipart-post (~> 2)
-    faraday-net_http (1.0.1)
+    faraday-net_http (1.0.2)
     faraday-net_http_persistent (1.2.0)
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    faraday_middleware (1.2.0)
+    faraday_middleware (1.2.1)
       faraday (~> 1.0)
     fingerprintable (1.2.1)
       colorize
-    hashdiff (1.0.1)
-    i18n (1.14.1)
+    hashdiff (1.1.2)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     iniparse (1.5.0)
-    mini_portile2 (2.8.2)
-    minitest (5.18.1)
-    multipart-post (2.3.0)
-    nokogiri (1.15.2)
+    json (2.9.1)
+    language_server-protocol (3.17.0.3)
+    logger (1.6.1)
+    mini_portile2 (2.8.8)
+    minitest (5.25.2)
+    multipart-post (2.4.1)
+    mutex_m (0.3.0)
+    nokogiri (1.16.7)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.15.2-x86_64-darwin)
+    nokogiri (1.16.7-x86_64-darwin)
       racc (~> 1.4)
-    openssl (3.1.0)
+    openssl (3.2.0)
     overcommit (0.57.0)
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    parallel (1.26.3)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
     pd_ruby (0.2.3)
       colorize
-    public_suffix (5.0.1)
-    racc (1.7.1)
-    rack (3.0.8)
+    public_suffix (6.0.1)
+    racc (1.8.1)
+    rack (3.1.8)
     rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.8.1)
+    rake (13.2.1)
+    regexp_parser (2.9.3)
     resonad (1.4.0)
-    rexml (3.2.5)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.2)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.3)
+    rexml (3.4.0)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.2)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.5)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.1)
-    rubocop (1.0.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.69.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
-      rexml
-      rubocop-ast (>= 0.6.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.36.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.29.0)
-      parser (>= 3.2.1.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.37.0)
+      parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
+    securerandom (0.3.2)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
+    simplecov-html (0.13.1)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.4)
     simply_serializable (1.5.1)
       fingerprintable (>= 1.2.1)
     sync (0.5.0)
-    term-ansicolor (1.7.1)
+    term-ansicolor (1.11.2)
       tins (~> 1.0)
-    thor (1.2.2)
-    tins (1.32.1)
+    thor (1.3.2)
+    tins (1.37.0)
+      bigdecimal
       sync
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (1.8.0)
-    webmock (3.18.1)
+    unicode-display_width (3.1.2)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    webmock (3.24.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.6.8)
+    zeitwerk (2.6.18)
 
 PLATFORMS
   ruby
@@ -207,10 +232,10 @@ DEPENDENCIES
   overcommit (~> 0.57.0)
   rake (~> 13.0)
   rspec (~> 3.2)
-  rubocop (= 1.0.0)
+  rubocop (~> 1.62)
   simplecov
   simplecov-lcov
   webmock
 
 BUNDLED WITH
-   2.2.22
+   2.6.2

data/documentation/generators/generator.rb

@@ -29,7 +29,7 @@ module Docs
       end
 
       def destination_path(*args, **keywords)
-        docs_path(*args, **{ format: :md }.merge(keywords))
+        docs_path(*args, format: :md, **keywords)
       end
 
       def docs_path(*path, format: nil)

data/documentation/generators/reference/generator.rb

@@ -67,9 +67,7 @@ module Docs
           end
         end
 
-        File.open(config_path, 'w') do |h|
-          h.write config.to_yaml
-        end
+        File.write(config_path, config.to_yaml)
       end
     end
   end

data/documentation/generators/template.rb

@@ -15,7 +15,7 @@ module Docs
     def write
       template = ERB.new(File.read(template_path), trim_mode: '-')
       yellow "Generating template: #{template_path}"
-      File.open(destination_path, 'w') { |f| f.write template.result_with_hash(data) }
+      File.write(destination_path, template.result_with_hash(data))
       green "Wrote to destination: #{destination_path}"
     end
   end

data/ledger_sync.gemspec

@@ -8,17 +8,15 @@ Gem::Specification.new do |spec|
   spec.name = 'ledger_sync'
   spec.version = LedgerSync.version
 
-  spec.required_ruby_version = '>= 2.5.8'
+  spec.required_ruby_version = '>= 3.1'
 
   # spec.required_rubygems_version = Gem::Requirement.new('>= 0') if spec.respond_to? :required_rubygems_version=
   spec.authors = ['Ryan Jackson']
-  spec.date = '2019-05-21'
-  spec.description = 'LedgerSync is a simple library that allows you to sync common objects to popular accounting '\
+  spec.description = 'LedgerSync is a simple library that allows you to sync common objects to popular accounting ' \
                      'software like QuickBooks Online, Xero, NetSuite, etc.'
   spec.email = ['ryanwjackson@gmail.com']
   spec.homepage = 'https://github.com/LedgerSync/ledger_sync'
   spec.licenses = ['MIT']
-  spec.rubygems_version = '3.0.3'
   spec.summary = 'Sync common objects to accounting software.'
 
   # Specify which files should be added to the gem when it is released.
@@ -40,23 +38,24 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('overcommit', '~> 0.57.0')
   spec.add_development_dependency('rake', '~> 13.0')
   spec.add_development_dependency('rspec', '~> 3.2')
-  spec.add_development_dependency('rubocop', '1.0.0')
+  spec.add_development_dependency('rubocop', '~> 1.62')
   spec.add_development_dependency('simplecov')
   spec.add_development_dependency('simplecov-lcov')
   spec.add_development_dependency('webmock', '>= 0')
-  spec.add_runtime_dependency('activemodel', '>= 0')
-  spec.add_runtime_dependency('dotenv')
-  spec.add_runtime_dependency('dry-schema')
-  spec.add_runtime_dependency('dry-validation')
-  spec.add_runtime_dependency('faraday', '>= 0')
-  spec.add_runtime_dependency('faraday-detailed_logger', '>= 0')
-  spec.add_runtime_dependency('faraday_middleware', '>= 0')
-  spec.add_runtime_dependency('fingerprintable', '>= 1.2.1')
-  spec.add_runtime_dependency('nokogiri', '>= 0')
-  spec.add_runtime_dependency('openssl', '> 2.2.0')
-  spec.add_runtime_dependency('pd_ruby', '>= 0')
-  spec.add_runtime_dependency('rack', '>= 2.2.3')
-  spec.add_runtime_dependency('rainbow', '~> 3.0')
-  spec.add_runtime_dependency('resonad', '>= 0')
-  spec.add_runtime_dependency('simply_serializable', '>= 1.5.1')
+  spec.add_dependency('activemodel', '>= 0')
+  spec.add_dependency('dotenv')
+  spec.add_dependency('dry-schema')
+  spec.add_dependency('dry-validation')
+  spec.add_dependency('faraday', '>= 0')
+  spec.add_dependency('faraday-detailed_logger', '>= 0')
+  spec.add_dependency('faraday_middleware', '>= 0')
+  spec.add_dependency('fingerprintable', '>= 1.2.1')
+  spec.add_dependency('nokogiri', '>= 0')
+  spec.add_dependency('openssl', '> 2.2.0')
+  spec.add_dependency('pd_ruby', '>= 0')
+  spec.add_dependency('rack', '>= 2.2.3')
+  spec.add_dependency('rainbow', '~> 3.0')
+  spec.add_dependency('resonad', '>= 0')
+  spec.add_dependency('simply_serializable', '>= 1.5.1')
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/ledger_sync/deserializer.rb

@@ -71,7 +71,7 @@ module LedgerSync
       @attributes ||= Serialization::DeserializerAttributeSet.new(serializer_class: self)
     end
 
-    def self.references_one(resource_attribute, args = {}, &block)
+    def self.references_one(resource_attribute, args = {}, &)
       attribute(
         resource_attribute,
         {
@@ -79,11 +79,11 @@ module LedgerSync
             deserializer: deserializer_from(resource_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 
-    def self.references_many(resource_attribute, args = {}, &block)
+    def self.references_many(resource_attribute, args = {}, &)
       attribute(
         resource_attribute,
         {
@@ -91,7 +91,7 @@ module LedgerSync
             deserializer: deserializer_from(resource_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 

data/lib/ledger_sync/error/ledger_errors.rb

@@ -46,11 +46,7 @@ module LedgerSync
             client_class: client.class
           ).rate_limiting_wait_in_seconds
 
-          super(
-            client: client,
-            message: message,
-            response: response
-          )
+          super
         end
       end
 
@@ -62,9 +58,7 @@ module LedgerSync
 
           super(
             *args,
-            **{
-              message: "Unknown URL format for #{resource.class}"
-            }.merge(keywords)
+            message: "Unknown URL format for #{resource.class}", **keywords
           )
         end
       end

data/lib/ledger_sync/error/operation_errors.rb

@@ -15,6 +15,7 @@ module LedgerSync
       class DuplicateLedgerResourceError < self; end
       class NotFoundError < self; end
       class LedgerValidationError < self; end
+
       class PerformedOperationError < self
         def initialize(operation:, message: nil, response: nil)
           message ||= 'Operation has already been performed. Please check the result.'

data/lib/ledger_sync/error/resource_errors.rb

@@ -22,8 +22,8 @@ module LedgerSync
                when LedgerSync::ResourceAttribute::Reference::Many
                  invalid_classes = value.reject { |e| e.is_a?(type_resource_class) }.map(&:class)
                  if type_resource_class.is_a?(Array)
-                   "an array of one or more of the following: #{type_resource_class.name}.  Given array containing: "\
-                   "#{invalid_classes.join(', ')}"
+                   "an array of one or more of the following: #{type_resource_class.name}.  Given array containing: " \
+                     "#{invalid_classes.join(', ')}"
                  else
                    "an array of #{type_resource_class.name}.  Given array containing: #{invalid_classes.join(', ')}"
                  end

data/lib/ledger_sync/ledger_configuration_store.rb

@@ -32,12 +32,12 @@ module LedgerSync
       @base_module_to_config_mapping.fetch(base_module, nil)
     end
 
-    def each(&block)
-      configs.each(&block)
+    def each(&)
+      configs.each(&)
     end
 
-    def find(&block)
-      configs.values.find(&block)
+    def find(&)
+      configs.values.find(&)
     end
 
     def register_ledger(ledger_config:)

data/lib/ledger_sync/ledgers/client.rb

@@ -30,9 +30,9 @@ module LedgerSync
           def ledger_attributes_to_save
             return {} if self.class.ledger_attributes_to_save.nil?
 
-            Hash[self.class.ledger_attributes_to_save.map do |attribute|
+            self.class.ledger_attributes_to_save.to_h do |attribute|
               [attribute, send(attribute)]
-            end]
+            end
           end
 
           def operation_for(args = {})
@@ -98,7 +98,7 @@ module LedgerSync
           end
 
           def resource_from_ledger_type(type:, converter: nil)
-            converter ||= proc { |n| n.underscore }
+            converter ||= proc(&:underscore)
             ledger_resource_type_overrides.invert[converter.call(type).to_sym] || resources[converter.call(type).to_sym]
           end
 

data/lib/ledger_sync/ledgers/mixins/infer_serializer_mixin.rb

@@ -9,45 +9,33 @@ module LedgerSync
       module InferSerializerMixin
         module ClassMethods
           def inferred_deserializer_class
-            @inferred_deserializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_deserializer_class_name
-              )
-            end
+            @inferred_deserializer_class ||= inferred_config.base_module.const_get(
+              inferred_deserializer_class_name
+            )
           end
 
           def inferred_deserializer_class_name
-            @inferred_deserializer_class_name ||= begin
-              "#{inferred_resource_class}::Deserializer"
-            end
+            @inferred_deserializer_class_name ||= "#{inferred_resource_class}::Deserializer"
           end
 
           def inferred_searcher_deserializer_class
-            @inferred_searcher_deserializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_searcher_deserializer_class_name
-              )
-            end
+            @inferred_searcher_deserializer_class ||= inferred_config.base_module.const_get(
+              inferred_searcher_deserializer_class_name
+            )
           end
 
           def inferred_searcher_deserializer_class_name
-            @inferred_searcher_deserializer_class_name ||= begin
-              "#{inferred_resource_class}::SearcherDeserializer"
-            end
+            @inferred_searcher_deserializer_class_name ||= "#{inferred_resource_class}::SearcherDeserializer"
           end
 
           def inferred_serializer_class
-            @inferred_serializer_class ||= begin
-              inferred_config.base_module.const_get(
-                inferred_serializer_class_name
-              )
-            end
+            @inferred_serializer_class ||= inferred_config.base_module.const_get(
+              inferred_serializer_class_name
+            )
           end
 
           def inferred_serializer_class_name
-            @inferred_serializer_class_name ||= begin
-              "#{inferred_resource_class}::Serializer"
-            end
+            @inferred_serializer_class_name ||= "#{inferred_resource_class}::Serializer"
           end
         end
 

data/lib/ledger_sync/ledgers/mixins/infer_validation_contract_mixin.rb

@@ -6,11 +6,9 @@ module LedgerSync
       module InferValidationContractMixin
         module ClassMethods
           def inferred_validation_contract_class
-            @inferred_validation_contract_class ||= begin
-              const_get(
-                inferred_validation_contract_class_name
-              )
-            end
+            @inferred_validation_contract_class ||= const_get(
+              inferred_validation_contract_class_name
+            )
           end
 
           def inferred_validation_contract_class_name

data/lib/ledger_sync/resource.rb

@@ -44,13 +44,13 @@ module LedgerSync
     end
 
     def changed?
-      super || resource_attributes.references_many.select(&:changed?).any?
+      super || resource_attributes.references_many.any?(&:changed?)
     end
 
     def changes
-      super.merge(Hash[resource_attributes.references_many.map do |ref|
-                         [ref.name, ref.changes['value']] if ref.changed?
-                       end.compact])
+      super.merge(resource_attributes.references_many.map do |ref|
+        [ref.name, ref.changes['value']] if ref.changed?
+      end.compact.to_h)
     end
 
     def class_from_resource_type(obj)
@@ -62,7 +62,7 @@ module LedgerSync
     end
 
     def self.inherited(subclass)
-      resource_attributes.each do |_name, resource_attribute|
+      resource_attributes.each_value do |resource_attribute|
         subclass._add_resource_attribute(resource_attribute)
       end
 

data/lib/ledger_sync/resource_attribute/dirty_mixin.rb

@@ -40,12 +40,12 @@ module LedgerSync
       end
 
       def dirty_attributes_to_h
-        Hash[self.class.dirty_attributes.keys.map do |k|
+        self.class.dirty_attributes.keys.to_h do |k|
           [
             k,
             public_send(k)
           ]
-        end]
+        end
       end
 
       # Normally you would just call `changes_applied`, but because we

data/lib/ledger_sync/serialization/mixin.rb

@@ -14,7 +14,7 @@ module LedgerSync
         #
         # @return [Serializer::Attribute]
         #
-        def attribute(_hash_attribute, _args = {}, &_block)
+        def attribute(_hash_attribute, _args = {}, &)
           raise NotImplementedError
         end
 

data/lib/ledger_sync/serializer.rb

@@ -60,7 +60,7 @@ module LedgerSync
       @attributes ||= Serialization::SerializerAttributeSet.new(serializer_class: self)
     end
 
-    def self.references_one(hash_attribute, args = {}, &block)
+    def self.references_one(hash_attribute, args = {}, &)
       attribute(
         hash_attribute,
         {
@@ -68,11 +68,11 @@ module LedgerSync
             serializer: serializer_from(hash_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 
-    def self.references_many(hash_attribute, args = {}, &block)
+    def self.references_many(hash_attribute, args = {}, &)
       attribute(
         hash_attribute,
         {
@@ -80,7 +80,7 @@ module LedgerSync
             serializer: serializer_from(hash_attribute, args)
           )
         }.merge(args),
-        &block
+        &
       )
     end
 

data/lib/ledger_sync/test/support/factory_bot.rb

@@ -65,7 +65,7 @@ end
 def generate_resource_factories
   LedgerSync.ledgers.each do |ledger_key, ledger|
     ledger.client_class.resources.each do |resource_key, resource_class|
-      factory_key = "#{ledger_key}_#{resource_key}".to_sym
+      factory_key = :"#{ledger_key}_#{resource_key}"
       next if FactoryBot.factories.registered?(factory_key)
 
       register_factory(prefix: ledger_key, resource_class: resource_class)
@@ -101,7 +101,7 @@ module FactoryBot
   def self.test_run_id(*appends, **keywords)
     @test_run_id ||= rand_id(
       *appends,
-      **keywords.merge(include_test_run_id: false)
+      **keywords, include_test_run_id: false
     )
   end
 

data/lib/ledger_sync/test/support/qa/ledger_support_setup.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 def setup_client_qa_support(*clients, keyed: false) # rubocop:disable Metrics/PerceivedComplexity
-  qa_clients = Hash[clients.uniq.map do |client|
+  qa_clients = clients.uniq.to_h do |client|
     key = client.config.root_key
 
     qa_support "#{key}_helpers"
@@ -14,7 +14,7 @@ def setup_client_qa_support(*clients, keyed: false) # rubocop:disable Metrics/Pe
         key: key
       }
     ]
-  end]
+  end
 
   RSpec.configure do |config|
     qa_clients.each_value do |data|

data/lib/ledger_sync/test/support/record_collection.rb

@@ -29,7 +29,7 @@ module LedgerSync
         Gem.find_files(File.join(dir, '*.json')).map do |file_path|
           record = File.basename(file_path, '.json').to_sym
           @records[record] = record_class.new(
-            hash: JSON.parse(File.open(file_path).read),
+            hash: JSON.parse(File.read(file_path)),
             path: file_path,
             record: record
           )

data/lib/ledger_sync/type/reference_many.rb

@@ -35,7 +35,7 @@ module LedgerSync
       def valid?(args = {})
         value = args.fetch(:value)
         return false unless value.is_a?(Array)
-        return true if (resource_classes & value.map(&:class)).any?
+        return true if resource_classes.intersect?(value.map(&:class))
         return true if value.is_a?(Array) && value.empty?
 
         false

data/lib/ledger_sync/type/value_mixin.rb

@@ -44,7 +44,7 @@ module LedgerSync
         value = args.fetch(:value)
 
         return true if value.nil?
-        return true if valid_classes.select { |e| value.is_a?(e) }.any?
+        return true if valid_classes.any? { |e| value.is_a?(e) }
 
         false
       end

data/lib/ledger_sync/util/dotenv_updator.rb

@@ -24,7 +24,7 @@ module LedgerSync
               client_method = env_key.split(prefix).last.downcase
 
               if line =~ /\A#{prefix}/ && to_save.key?(client_method)
-                env_value = ENV[env_key]
+                env_value = ENV.fetch(env_key, nil)
                 new_value = to_save.delete(client_method)
                 tempfile.puts "#{env_key}=#{new_value}"
                 next if env_value == new_value.to_s

data/lib/ledger_sync/util/resource_converter/attribute_set.rb

@@ -22,7 +22,7 @@ module LedgerSync
         def add(attribute)
           unless attribute.destination_attribute.nil?
             if @attribute_keys.key?(attribute.destination_attribute.to_s)
-              raise "destination_attribute already defined for #{resource_converter_class.name}: "\
+              raise "destination_attribute already defined for #{resource_converter_class.name}: " \
                     "#{attribute.destination_attribute}"
             end
 

data/lib/ledger_sync/util/resource_converter.rb

@@ -54,15 +54,15 @@ module LedgerSync
         )
       end
 
-      def self.attribute(*args, &block)
-        _attribute(*args, &block)
+      def self.attribute(...)
+        _attribute(...)
       end
 
       def self.attributes
         @attributes ||= ResourceConverter::AttributeSet.new(resource_converter_class: self)
       end
 
-      def self._references(destination_attribute = nil, args = {}, &block)
+      def self._references(destination_attribute = nil, args = {}, &)
         reference_type     = args.fetch(:reference_type)
         resource_converter = args.fetch(:resource_converter)
 
@@ -89,27 +89,27 @@ module LedgerSync
               ]
             )
           ),
-          &block
+          &
         )
       end
 
-      def self.references_one(destination_attribute = nil, args = {}, &block)
+      def self.references_one(destination_attribute = nil, args = {}, &)
         _references(
           destination_attribute,
           {
             reference_type: :one
           }.merge(args),
-          &block
+          &
         )
       end
 
-      def self.references_many(destination_attribute = nil, args = {}, &block)
+      def self.references_many(destination_attribute = nil, args = {}, &)
         _references(
           destination_attribute,
           {
             reference_type: :many
           }.merge(args),
-          &block
+          &
         )
       end
     end

data/lib/ledger_sync/util/resources_builder.rb

@@ -51,37 +51,35 @@ module LedgerSync
                          end
         raise "#{type} is an invalid resource type" if resource_class.nil?
 
-        current_data = Hash[
-          current_data.map do |k, v|
-            k = k.to_sym
+        current_data = current_data.to_h do |k, v|
+          k = k.to_sym
 
-            attribute = resource_class.resource_attributes[k]
-            if attribute.nil? && !ignore_unrecognized_attributes
-              raise "Unrecognized attribute for #{resource_class.name}: #{k}"
-            end
+          attribute = resource_class.resource_attributes[k]
+          if attribute.nil? && !ignore_unrecognized_attributes
+            raise "Unrecognized attribute for #{resource_class.name}: #{k}"
+          end
 
-            v = if attribute.is_a?(ResourceAttribute::Reference::One)
-                  resource_type = resource_type_by(external_id: current_data[k])
+          v = if attribute.is_a?(ResourceAttribute::Reference::One)
+                resource_type = resource_type_by(external_id: current_data[k])
+                resource_or_build(
+                  external_id: current_data[k],
+                  type: resource_type
+                )
+              elsif attribute.is_a?(ResourceAttribute::Reference::Many)
+                current_data[k].map do |many_reference|
                   resource_or_build(
-                    external_id: current_data[k],
-                    type: resource_type
+                    external_id: many_reference,
+                    type: attribute.type.resource_class.resource_type
                   )
-                elsif attribute.is_a?(ResourceAttribute::Reference::Many)
-                  current_data[k].map do |many_reference|
-                    resource_or_build(
-                      external_id: many_reference,
-                      type: attribute.type.resource_class.resource_type
-                    )
-                  end
-                elsif cast
-                  attribute.type.cast(value: v)
-                else
-                  v
                 end
+              elsif cast
+                attribute.type.cast(value: v)
+              else
+                v
+              end
 
-            [k, v]
-          end
-        ]
+          [k, v]
+        end
 
         @all_resources[resource_key(external_id: external_id, type: type)] ||= resource_class.new(
           external_id: external_id,

data/lib/ledger_sync/util/signer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'base64'
+
 module LedgerSync
   module Util
     class Signer
@@ -25,11 +27,11 @@ module LedgerSync
       end
 
       def self.escape(str:)
-        CGI.escape(str).gsub(/\+/, '%20')
+        CGI.escape(str).gsub('+', '%20')
       end
 
       def self.unescape(str:)
-        CGI.unescape(str.gsub(/%20/, '+'))
+        CGI.unescape(str.gsub('%20', '+'))
       end
     end
   end

data/lib/ledger_sync/util/string_helpers.rb

@@ -10,7 +10,7 @@ module LedgerSync
       end
 
       def underscore!(str)
-        str.gsub!(/::/, '/')
+        str.gsub!('::', '/')
         str.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
         str.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
         str.tr!('-', '_')

data/lib/ledger_sync/version.rb

@@ -2,11 +2,11 @@
 
 # :nocov:
 module LedgerSync
-  VERSION = '2.6.0'
+  VERSION = '3.0.0'
 
   def self.version
     if ENV['PRE_RELEASE']
-      "#{VERSION}.pre.#{ENV['GITHUB_RUN_NUMBER']}"
+      "#{VERSION}.pre.#{ENV.fetch('GITHUB_RUN_NUMBER', nil)}"
     else
       VERSION
     end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ledger_sync
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Ryan Jackson
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-05-21 00:00:00.000000000 Z
+date: 2024-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print
@@ -154,16 +153,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.62'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.62'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -776,8 +775,8 @@ files:
 homepage: https://github.com/LedgerSync/ledger_sync
 licenses:
 - MIT
-metadata: {}
-post_install_message:
+metadata:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -785,15 +784,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.8
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Sync common objects to accounting software.
 test_files: []