ledger_sync 1.3.4 → 1.4.4

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/serializer.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require_relative '../currency/serializer'
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class Transfer
+        class Serializer < QuickBooksOnline::Serializer
+          id
+
+          amount 'Amount',
+                 resource_attribute: :amount
+
+          attribute 'PrivateNote',
+                    resource_attribute: :memo
+
+          attribute 'FromAccountRef.value',
+                    resource_attribute: 'from_account.ledger_id'
+
+          attribute 'ToAccountRef.value',
+                    resource_attribute: 'to_account.ledger_id'
+
+          date 'TxnDate',
+               resource_attribute: :transaction_date
+
+          references_one :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::Serializer
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/util/error_matcher.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Util
+      class Util
         class ErrorMatcher
           attr_reader :error,
                       :message
@@ -19,20 +19,23 @@ module LedgerSync
             nil
           end
 
-          def error_klass
+          def error_class
             raise NotImplementedError
           end
 
           def error_message
-            (body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('message')) ||
-            (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Message')) ||
-              (body && JSON.parse(body).dig('error')) ||
-              error.message
+            return error.message unless body
+
+            parsed_body = JSON.parse(body)
+
+            parsed_body.dig('fault', 'error')&.first&.fetch('message') ||
+              parsed_body.dig('Fault', 'Error')&.first&.fetch('Message') ||
+              parsed_body.dig('error')
           end
 
           def detail
             (body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('detail')) ||
-            (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Detail'))
+              (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Detail'))
           end
 
           def code

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/util/error_parser.rb

@@ -3,9 +3,9 @@
 require_relative 'error_matcher'
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Util
+      class Util
         class ErrorParser
           attr_reader :error
 
@@ -13,7 +13,7 @@ module LedgerSync
             @error = error
           end
 
-          def error_klass
+          def error_class
             raise NotImplementedError
           end
 

data/lib/ledger_sync/{adaptors/quickbooks_online/util/adaptor_error_parser.rb → ledgers/quickbooks_online/util/ledger_error_parser.rb}

@@ -3,17 +3,17 @@
 require_relative 'error_parser'
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Util
-        class AdaptorErrorParser < ErrorParser
+      class Util
+        class LedgerErrorParser < ErrorParser
           class ThrottleMatcher < ErrorMatcher
-            def error_klass
-              Error::AdaptorError::ThrottleError
+            def error_class
+              Error::LedgerError::ThrottleError
             end
 
             def output_message
-              "Request trhottled with: #{error_message}"
+              "Request throttle with: #{error_message}"
             end
 
             def match?
@@ -23,8 +23,8 @@ module LedgerSync
           end
 
           class AuthenticationMatcher < ErrorMatcher
-            def error_klass
-              Error::AdaptorError::AuthenticationError
+            def error_class
+              Error::LedgerError::AuthenticationError
             end
 
             def output_message
@@ -33,14 +33,14 @@ module LedgerSync
 
             def match?
               code == 3200 ||
-              message.include?('authenticationfailed') ||
+                message.include?('authenticationfailed') ||
                 message.include?('errorcode=003200')
             end
           end
 
           class AuthorizationMatcher < ErrorMatcher
-            def error_klass
-              Error::AdaptorError::AuthorizationError
+            def error_class
+              Error::LedgerError::AuthorizationError
             end
 
             def output_message
@@ -49,14 +49,14 @@ module LedgerSync
 
             def match?
               code == 3100 ||
-              message.include?('authorizationfailed') ||
+                message.include?('authorizationfailed') ||
                 message.include?('errorcode=003100')
             end
           end
 
           class ClientMatcher < ErrorMatcher
-            def error_klass
-              Error::AdaptorError::ConfigurationError
+            def error_class
+              Error::LedgerError::ConfigurationError
             end
 
             def output_message
@@ -76,10 +76,10 @@ module LedgerSync
             ThrottleMatcher
           ].freeze
 
-          attr_reader :adaptor
+          attr_reader :client
 
-          def initialize(adaptor:, error:)
-            @adaptor = adaptor
+          def initialize(client:, error:)
+            @client = client
             super(error: error)
           end
 
@@ -88,8 +88,8 @@ module LedgerSync
               matcher = parser.new(error: error)
               next unless matcher.match?
 
-              return matcher.error_klass.new(
-                adaptor: adaptor,
+              return matcher.error_class.new(
+                client: client,
                 message: matcher.output_message,
                 response: error
               )

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/util/operation_error_parser.rb

@@ -3,12 +3,12 @@
 require_relative 'error_parser'
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Util
+      class Util
         class OperationErrorParser < ErrorParser
           class DuplicateNameMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::DuplicateLedgerResourceError
             end
 
@@ -18,12 +18,12 @@ module LedgerSync
 
             def match?
               code == 6240 ||
-              message.include?('the name supplied already exists')
+                message.include?('the name supplied already exists')
             end
           end
 
           class NotFoundMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::NotFoundError
             end
 
@@ -33,12 +33,12 @@ module LedgerSync
 
             def match?
               code == 610 ||
-              message.include?('object not found')
+                message.include?('object not found')
             end
           end
 
           class ValidationError < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::LedgerValidationError
             end
 
@@ -52,7 +52,7 @@ module LedgerSync
           end
 
           class GenericMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError
             end
 
@@ -85,7 +85,7 @@ module LedgerSync
               matcher = parser.new(error: error)
               next unless matcher.match?
 
-              return matcher.error_klass.new(
+              return matcher.error_class.new(
                 operation: operation,
                 message: matcher.output_message,
                 response: error

data/lib/ledger_sync/ledgers/quickbooks_online/vendor/deserializer.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Ledgers
+    module QuickBooksOnline
+      class Vendor
+        class Deserializer < QuickBooksOnline::Deserializer
+          id
+
+          attribute :display_name,
+                    hash_attribute: 'DisplayName'
+
+          attribute :first_name,
+                    hash_attribute: 'GivenName'
+
+          attribute :last_name,
+                    hash_attribute: 'FamilyName'
+
+          attribute :email,
+                    hash_attribute: 'PrimaryEmailAddr.Address'
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/vendor/operations/create.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Vendor
+      class Vendor
         module Operations
           class Create < Operation::Create
-            class Contract < LedgerSync::Adaptors::Contract
+            class Contract < LedgerSync::Ledgers::Contract
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/vendor/operations/find.rb

@@ -1,19 +1,19 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Vendor
+      class Vendor
         module Operations
           class Find < Operation::Find
-            class Contract < LedgerSync::Adaptors::Contract
+            class Contract < LedgerSync::Ledgers::Contract
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:display_name).maybe(:string)
                 required(:first_name).maybe(:string)
                 required(:last_name).maybe(:string)
-                optional(:email).maybe(:string)
+                required(:email).maybe(:string)
                 optional(:company_name).maybe(:string)
                 optional(:phone_number).maybe(:string)
                 optional(:subsidiary).maybe(:hash, Types::Reference)

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/vendor/operations/update.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Vendor
+      class Vendor
         module Operations
           class Update < Operation::FullUpdate
-            class Contract < LedgerSync::Adaptors::Contract
+            class Contract < LedgerSync::Ledgers::Contract
               params do
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/vendor/searcher.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Vendor
+      class Vendor
         class Searcher < Searcher
           def query_string
             "DisplayName LIKE '%#{query}%'"

data/lib/ledger_sync/{adaptors/quickbooks_online/vendor/ledger_serializer.rb → ledgers/quickbooks_online/vendor/serializer.rb}

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
-      module Vendor
-        class LedgerSerializer < QuickBooksOnline::LedgerSerializer
+      class Vendor
+        class Serializer < QuickBooksOnline::Serializer
           id
 
-          attribute ledger_attribute: 'DisplayName',
+          attribute 'DisplayName',
                     resource_attribute: :display_name
 
-          attribute ledger_attribute: 'GivenName',
+          attribute 'GivenName',
                     resource_attribute: :first_name
 
-          attribute ledger_attribute: 'FamilyName',
+          attribute 'FamilyName',
                     resource_attribute: :last_name
 
-          attribute ledger_attribute: 'PrimaryEmailAddr.Address',
+          attribute 'PrimaryEmailAddr.Address',
                     resource_attribute: :email
         end
       end

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/webhook.rb

@@ -4,7 +4,7 @@ require_relative 'webhook_event'
 
 # ref: https://developer.intuit.com/app/developer/qbo/docs/develop/webhooks/managing-webhooks-notifications#validating-the-notification
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
       class Webhook
         attr_reader :notifications,

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/webhook_event.rb

@@ -2,7 +2,7 @@
 
 # ref: https://developer.intuit.com/app/developer/qbo/docs/develop/webhooks/managing-webhooks-notifications#validating-the-notification
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
       class WebhookEvent
         attr_reader :deleted_id,
@@ -39,19 +39,19 @@ module LedgerSync
           @webhook = webhook_notification.try(:webhook)
         end
 
-        def find(adaptor:)
-          find_operation(adaptor: adaptor).perform
+        def find(client:)
+          find_operation(client: client).perform
         end
 
-        def find_operation(adaptor:)
-          find_operation_class(adaptor: adaptor).new(
-            adaptor: adaptor,
+        def find_operation(client:)
+          find_operation_class(client: client).new(
+            client: client,
             resource: resource_class.new(ledger_id: ledger_id)
           )
         end
 
-        def find_operation_class(adaptor:)
-          adaptor.class.base_operation_module_for(resource_class: resource_class)::Find
+        def find_operation_class(client:)
+          client.class.base_operation_module_for(resource_class: resource_class)::Find
         end
 
         def local_resource_type
@@ -65,13 +65,15 @@ module LedgerSync
         end
 
         def resource!
-          raise "Resource class does not exist for QuickBooks Online object: #{quickbooks_online_resource_type}" if resource.nil?
+          if resource.nil?
+            raise "Resource class does not exist for QuickBooks Online object: #{quickbooks_online_resource_type}"
+          end
 
           resource
         end
 
         def resource_class
-          @resource_class ||= Adaptor.resource_from_ledger_type(type: quickbooks_online_resource_type.downcase)
+          @resource_class ||= Client.resource_from_ledger_type(type: quickbooks_online_resource_type.downcase)
         end
       end
     end

data/lib/ledger_sync/{adaptors → ledgers}/quickbooks_online/webhook_notification.rb

@@ -4,7 +4,7 @@ require_relative 'webhook_event'
 
 # ref: https://developer.intuit.com/app/developer/qbo/docs/develop/webhooks/managing-webhooks-notifications#validating-the-notification
 module LedgerSync
-  module Adaptors
+  module Ledgers
     module QuickBooksOnline
       class WebhookNotification
         attr_reader :events,
@@ -13,9 +13,10 @@ module LedgerSync
                     :realm_id,
                     :webhook
 
-        def initialize(payload:, webhook: nil)
-          @original_payload = payload
-          @payload = payload.is_a?(String) ? JSON.parse(payload) : payload
+        def initialize(args = {})
+          @original_payload = args.fetch(:payload)
+          @webhook          = args.fetch(:webhook, nil)
+          @payload          = original_payload.is_a?(String) ? JSON.parse(original_payload) : original_payload
 
           @realm_id = @payload.dig('realmId')
           raise 'Invalid payload: Could not find realmId' if @realm_id.blank?