ledger_sync 1.3.4 → 1.3.5

data/lib/ledger_sync/adaptors/netsuite/record/http_method.rb

@@ -16,7 +16,7 @@ module LedgerSync
           def initialize(args = {})
             super(
               args.merge(
-                key: "#{method} #{path}".downcase
+                key: "#{args.fetch(:method)} #{args.fetch(:path)}".downcase
               )
             )
           end

data/lib/ledger_sync/adaptors/netsuite/record/metadata.rb

@@ -21,11 +21,11 @@ module LedgerSync
           end
 
           def create
-            @create ||= http_methods.find { |_e| "post /#{record}" }
+            @create ||= http_methods.find { |e| e.key == "post /#{record}" }
           end
 
           def delete
-            @delete ||= http_methods.find { |_e| "delete /#{record}/{id}" }
+            @delete ||= http_methods.find { |e| e.key == "delete /#{record}/{id}" }
           end
 
           def find
@@ -51,6 +51,10 @@ module LedgerSync
             end
           end
 
+          def index
+            @index ||= http_methods.find { |e| e.key == "get /#{record}" }
+          end
+
           def metadata_response
             @metadata_response = begin
               adaptor.get(
@@ -79,20 +83,20 @@ module LedgerSync
             end
           end
 
-          def index
-            @index ||= http_methods.find { |_e| "get /#{record}" }
+          def patch
+            @patch ||= http_methods.find { |e| e.key == "patch /#{record}/{id}" }
           end
 
           def show
-            @show ||= http_methods.find { |_e| "get /#{record}/{id}" }
+            @show ||= http_methods.find { |e| e.key == "get /#{record}/{id}" }
           end
 
           def update
-            @update ||= http_methods.find { |_e| "patch /#{record}/{id}" }
+            @update ||= http_methods.find { |e| e.key == "patch /#{record}/{id}" }
           end
 
           def upsert
-            @upsert ||= http_methods.find { |_e| "put /#{record}/{id}" }
+            @upsert ||= http_methods.find { |e| e.key == "put /#{record}/{id}" }
           end
         end
       end

data/lib/ledger_sync/adaptors/netsuite/searcher.rb

@@ -6,25 +6,47 @@ module LedgerSync
       class Searcher < Adaptors::Searcher
         include Mixins::OffsetAndLimitPaginationSearcherMixin
 
+        def query_attributes
+          @query_attributes ||= searcher_ledger_deserializer_class.attributes.map(&:ledger_attribute)
+        end
+
+        def query_string
+          "SELECT #{query_attributes.join(', ')} FROM #{query_table}"
+        end
+
+        def query_table
+          @query_table ||= self.class.inferred_resource_class.resource_type
+        end
+
         def resources
           resource_class = self.class.inferred_resource_class
 
           @resources ||= begin
             @request = adaptor
-              .get(
-                path: "/#{adaptor.class.ledger_resource_type_for(resource_class: resource_class)}?limit=#{limit}&offset=#{offset}"
-              )
-
-            request.body
-              .fetch('items')
-              .map do |c|
-                ledger_deserializer_class.new(
+                       .post(
+                         body: { q: query_string.to_s },
+                         request_url: adaptor.api_base_url.gsub('/record/v1', '') + "/query/v1/suiteql?limit=#{limit}&offset=#{offset}"
+                       )
+
+            case request.status
+            when 200
+              request.body
+                     .fetch('items')
+                     .map do |c|
+                searcher_ledger_deserializer_class.new(
                   resource: resource_class.new
                 ).deserialize(hash: c)
               end
+            when 404
+              []
+            end
           end
         end
 
+        def searcher_ledger_deserializer_class
+          @searcher_ledger_deserializer_class ||= self.class.inferred_searcher_ledger_deserializer_class
+        end
+
         private
 
         def default_offset

data/lib/ledger_sync/adaptors/netsuite/vendor/searcher.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module NetSuite
+      module Vendor
+        class Searcher < Searcher
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/netsuite/vendor/searcher_ledger_deserializer.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module NetSuite
+      module Vendor
+        class SearcherLedgerDeserializer < NetSuite::LedgerSerializer
+          attribute ledger_attribute: :id,
+                    resource_attribute: :ledger_id
+
+          attribute ledger_attribute: :email,
+                    resource_attribute: :email
+
+          attribute ledger_attribute: :companyname,
+                    resource_attribute: :company_name
+
+          attribute ledger_attribute: :phone,
+                    resource_attribute: :phone_number
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/operation.rb

@@ -5,8 +5,12 @@ module LedgerSync
     module Operation
       module Mixin
         module ClassMethods
-          def adaptor_klass
-            @adaptor_klass ||= Class.const_get("#{name.split('::')[0..2].join('::')}::Adaptor")
+          def adaptor_class
+            @adaptor_class ||= Class.const_get("#{name.split('::')[0..2].join('::')}::Adaptor")
+          end
+
+          def operation_method
+            @operation_method ||= name.split('::').last.snakecase.to_sym
           end
 
           def operations_module
@@ -164,7 +168,7 @@ module LedgerSync
         end
       end
 
-      def self.klass_from(adaptor:, method:, object:)
+      def self.class_from(adaptor:, method:, object:)
         adaptor.base_module.const_get(
           LedgerSync::Util::StringHelpers.camelcase(object)
         )::Operations.const_get(

data/lib/ledger_sync/adaptors/quickbooks_online/adaptor.rb

@@ -11,6 +11,8 @@ module LedgerSync
         ROOT_URI          = 'https://quickbooks.api.intuit.com'
         REVOKE_TOKEN_URI  = 'https://developer.api.intuit.com/v2/oauth2/tokens/revoke'
         ROOT_SANDBOX_URI  = 'https://sandbox-quickbooks.api.intuit.com'
+        PRODUCTION_APP_URL_BASE = 'https://qbo.intuit.com/app'
+        SANDBOX_APP_URL_BASE    = 'https://app.sandbox.qbo.intuit.com/app'
 
         attr_reader :access_token,
                     :client_id,
@@ -142,7 +144,7 @@ module LedgerSync
         def update_secrets_in_dotenv
           return if ENV['TEST_ENV'] && !ENV['USE_DOTENV_ADAPTOR_SECRETS']
 
-          filename = File.join(LedgerSync.root, '.env')
+          filename = File.join(Dir.pwd, '.env')
           return unless File.exist?(filename)
 
           prefix = 'QUICKBOOKS_ONLINE_'
@@ -172,7 +174,10 @@ module LedgerSync
         end
 
         def url_for(resource:)
-          DashboardURLHelper.new(resource: resource, test: test).url
+          DashboardURLHelper.new(
+            resource: resource,
+            base_url: (test ? SANDBOX_APP_URL_BASE : PRODUCTION_APP_URL_BASE)
+          ).url
         end
 
         def self.ledger_attributes_to_save

data/lib/ledger_sync/adaptors/quickbooks_online/dashboard_url_helper.rb

@@ -3,22 +3,7 @@
 module LedgerSync
   module Adaptors
     module QuickBooksOnline
-      class DashboardURLHelper
-        PRODUCTION_APP_URL_BASE = 'https://qbo.intuit.com/app'
-        SANDBOX_APP_URL_BASE    = 'https://app.sandbox.qbo.intuit.com/app'
-
-        attr_reader :resource,
-                    :test
-
-        def initialize(resource:, test:)
-          @resource = resource
-          @test = test
-        end
-
-        def production_url
-          @production_url ||= PRODUCTION_APP_URL_BASE + resource_path
-        end
-
+      class DashboardURLHelper < LedgerSync::Adaptors::DashboardURLHelper
         def resource_path
           @resource_path = case resource
           when LedgerSync::Account
@@ -43,16 +28,6 @@ module LedgerSync
             "/vendordetail?nameId=#{resource.ledger_id}"
           end
         end
-
-        def sandbox_url
-          @sandbox_url ||= SANDBOX_APP_URL_BASE + resource_path
-        end
-
-        def url
-          return production_url unless test
-
-          sandbox_url
-        end
       end
     end
   end

data/lib/ledger_sync/adaptors/quickbooks_online/department/ledger_serializer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../ledger_serializer_type/department_reference_type'
+
 module LedgerSync
   module Adaptors
     module QuickBooksOnline
@@ -16,14 +18,15 @@ module LedgerSync
           attribute ledger_attribute: 'FullyQualifiedName',
                     resource_attribute: :fully_qualified_name
 
-          attribute ledger_attribute: 'ParentRef.value',
-                    resource_attribute: 'parent.ledger_id'
+          attribute ledger_attribute: :ParentRef,
+                    resource_attribute: :parent,
+                    type: LedgerSerializerType::DepartmentReferenceType
 
           # Sending "ParentRef": {"value": null} results in QBO API crash
           # This patches serialized hash to exclude it unless we don't set value
           def to_ledger_hash(deep_merge_unmapped_values: {}, only_changes: false)
             ret = super(only_changes: only_changes)
-            ret = ret.except('ParentRef') unless resource.parent_changed?
+
             return ret unless deep_merge_unmapped_values.any?
 
             deep_merge_if_not_mapped(

data/lib/ledger_sync/adaptors/quickbooks_online/ledger_serializer.rb

@@ -107,7 +107,7 @@ module LedgerSync
         def deep_merge_if_not_mapped(current_hash:, hash_to_search:)
           hash_to_search.each do |key, value|
             current_hash[key] = if current_hash.key?(key)
-                                  if value.is_a?(Hash)
+                                  if value.is_a?(Hash) && current_hash[key].present?
                                     deep_merge_if_not_mapped(
                                       current_hash: current_hash[key],
                                       hash_to_search: value

data/lib/ledger_sync/adaptors/quickbooks_online/ledger_serializer_type/department_reference_type.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module QuickBooksOnline
+      module LedgerSerializerType
+        class DepartmentReferenceType < Adaptors::LedgerSerializerType::ValueType
+          def convert_from_ledger(value:)
+            return if value.nil?
+            return if value['value'].nil?
+
+            LedgerSync::Department.new(ledger_id: value['value'])
+          end
+
+          def convert_from_local(value:)
+            return if value.nil?
+
+            {
+              'value' => value.ledger_id
+            }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/quickbooks_online/operation/full_update.rb

@@ -28,7 +28,6 @@ module LedgerSync
             merged_serializer = ledger_serializer.class.new(
               resource: merged_resource
             )
-
             response_to_operation_result(
               response: adaptor.post(
                 path: ledger_resource_type_for_path,

data/lib/ledger_sync/adaptors/quickbooks_online/util/adaptor_error_parser.rb

@@ -8,7 +8,7 @@ module LedgerSync
       module Util
         class AdaptorErrorParser < ErrorParser
           class ThrottleMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::AdaptorError::ThrottleError
             end
 
@@ -23,7 +23,7 @@ module LedgerSync
           end
 
           class AuthenticationMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::AdaptorError::AuthenticationError
             end
 
@@ -39,7 +39,7 @@ module LedgerSync
           end
 
           class AuthorizationMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::AdaptorError::AuthorizationError
             end
 
@@ -55,7 +55,7 @@ module LedgerSync
           end
 
           class ClientMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::AdaptorError::ConfigurationError
             end
 
@@ -88,7 +88,7 @@ module LedgerSync
               matcher = parser.new(error: error)
               next unless matcher.match?
 
-              return matcher.error_klass.new(
+              return matcher.error_class.new(
                 adaptor: adaptor,
                 message: matcher.output_message,
                 response: error

data/lib/ledger_sync/adaptors/quickbooks_online/util/error_matcher.rb

@@ -19,7 +19,7 @@ module LedgerSync
             nil
           end
 
-          def error_klass
+          def error_class
             raise NotImplementedError
           end
 

data/lib/ledger_sync/adaptors/quickbooks_online/util/error_parser.rb

@@ -13,7 +13,7 @@ module LedgerSync
             @error = error
           end
 
-          def error_klass
+          def error_class
             raise NotImplementedError
           end
 

data/lib/ledger_sync/adaptors/quickbooks_online/util/operation_error_parser.rb

@@ -8,7 +8,7 @@ module LedgerSync
       module Util
         class OperationErrorParser < ErrorParser
           class DuplicateNameMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::DuplicateLedgerResourceError
             end
 
@@ -23,7 +23,7 @@ module LedgerSync
           end
 
           class NotFoundMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::NotFoundError
             end
 
@@ -38,7 +38,7 @@ module LedgerSync
           end
 
           class ValidationError < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError::LedgerValidationError
             end
 
@@ -52,7 +52,7 @@ module LedgerSync
           end
 
           class GenericMatcher < ErrorMatcher
-            def error_klass
+            def error_class
               Error::OperationError
             end
 
@@ -85,7 +85,7 @@ module LedgerSync
               matcher = parser.new(error: error)
               next unless matcher.match?
 
-              return matcher.error_klass.new(
+              return matcher.error_class.new(
                 operation: operation,
                 message: matcher.output_message,
                 response: error

data/lib/ledger_sync/adaptors/stripe/adaptor.rb

@@ -15,18 +15,10 @@ module LedgerSync
         end
 
         def url_for(resource:)
-          base_url = 'https://dashboard.stripe.com'
-          resource_path = case resource
-                          when LedgerSync::Customer
-                            "/customers/#{resource.ledger_id}"
-                          else
-                            raise Error::AdaptorError::UnknownURLFormat.new(
-                              adaptor: self,
-                              resource: resource
-                            )
-                          end
-
-          base_url + resource_path
+          DashboardURLHelper.new(
+            resource: resource,
+            base_url: "https://dashboard.stripe.com"
+          ).url
         end
 
         def wrap_perform