learn_linter 1.6.9 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dd5cb1e1a21941f889c8f0d26fdade640d150e0
-  data.tar.gz: 8a31c1280f1d6cf72ca68ecdccd6c95efe884e73
+  metadata.gz: 2591ce2673e8253953b70b5cd03c115b0dec2e46
+  data.tar.gz: 9400f8228d373ef061e55b786093fee3dbd9ef68
 SHA512:
-  metadata.gz: 5e0cc594e0ae450f060029e69f1d48578f3ee930435287765a00eadcf4b59a43fe5201f3522fdb058bf3118f71d20c26ed7ca2cadcc980897bbf1f0c4c4fe757
-  data.tar.gz: 41706f9d007cfa4664f45dda42de257568eecd63af0e76c7b80435433f6cd77c7df7dcf91487a5b1e6811b193b6b762c5672a9ce3b2d8b34ca368e31bc75ee45
+  metadata.gz: 8c4c8b2d1becb8a718a96fe9ae38e1de50220590a13d0c7c6d402ab79e5f2663ab8f62f52970a50ff31f5dc896f1d22f25526c258447655ea6b24ad30a154f90
+  data.tar.gz: 4200cdfb63629d2eac2ea8fef9c1c10fe87b3f7a052f9bd8688afe973791ce65c86dfadc63b3154e260898277d2d902be35b0a98d5625bb77677f5ca1bdea6be

data/lib/learn_linter/learn_error.rb

@@ -20,7 +20,7 @@ class LearnError < StandardError
 
     @valid_yaml = {message: "invalid yaml", color: :red}
     @valid_license = {message: "invalid or missing license content", color: :yellow}
-    @valid_readme = {message: "invalid code snippet. Must have three backticks + optional language designator to open and close all code blocks. In-line code snippets must use one backtic", color: :red}
+    @valid_readme = {message: "", color: :red}
     @valid_contributing = {message: "invalid or missing contributing content", color: :yellow}
 
     @present_learn = {message: "missing .learn file", color: :red}

data/lib/learn_linter/readme_linter.rb

@@ -1,11 +1,13 @@
+require 'english'
+
 class ReadmeLinter
 
   def self.parse_file(file, learn_error)
-    file_string = File.open(file).read
-    if has_code_snippets?(file_string)
-      validate_snippets(file_string, learn_error)
+    if has_code_snippets?(file)
+      lines = collect_lines(file)
+      validate_snippets(lines, learn_error)
     else
-      green_light(learn_error)
+       green_light(learn_error)
     end
   end
 
@@ -15,19 +17,35 @@ class ReadmeLinter
   end
 
   def self.has_code_snippets?(file)
-    file.match(/``/)
+    file_content = File.open(file).read
+    file_content.match(/``/)
   end
 
-  def self.validate_snippets(file, learn_error)
-    file.split(" ").each do |chars|
-      if chars.match(/``/)
-        if !(chars.match(/^```(ruby|bash|swift|html|erb|js|javascript|objc|java|sql)?$/))
-          break
-        else
-          green_light(learn_error)
+  def self.collect_lines(file)
+    lines = {}
+    File.foreach(file) do |line_content|
+      lines["#{$INPUT_LINE_NUMBER}"] = line_content
+    end
+    lines
+  end
+
+  def self.validate_snippets(lines, learn_error)
+    lines.each do |line_num, line_content|
+      if line_content.match(/``/)
+        if !(line_content.match(/^```(ruby|bash|swift|html|erb|js|javascript|objc|java|sql)?$/)) 
+          learn_error.valid_readme[:message] << "INVALID CODE SNIPPET - line #{line_num}: #{line_content}\n"
         end
       end
     end
+    total_errors?(learn_error)
+  end
+
+  def self.total_errors?(learn_error)
+    if !learn_error.valid_readme[:message].include?("INVALID CODE SNIPPET")
+        green_light(learn_error)
+    end
   end
 end
+
+
     

data/lib/learn_linter/version.rb

@@ -1,3 +1,3 @@
 class LearnLinter
-  VERSION = "1.6.9"
+  VERSION = "1.7.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: learn_linter
 version: !ruby/object:Gem::Version
-  version: 1.6.9
+  version: 1.7.0
 platform: ruby
 authors:
 - Sophie DeBenedetto