learn-open 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 187cbff6f0a0e54e2c1eeee9df256c855cda0fdc
-  data.tar.gz: 73c0bb51b2d5dd3512d06ad889130987c13a6eb4
+  metadata.gz: e3956d3ee82551fddb6e65f916bae370b8b90dc7
+  data.tar.gz: ec2a1c366eeec4a0756b20883406b4eca9a1c519
 SHA512:
-  metadata.gz: f2b5157421e1cdb8b5a791ee963153ad43ed7fc50c797b90d772bd5e2b1c466b8a8c2e7f35c1e2d7a16e457f100e036112d207b860261c11f44c241dba92663e
-  data.tar.gz: 6c70af6367cab4362834610ccfc3cdbbee44e614fa8a7625ffc75dbc109b97c73197879b6c3a8ce018ec5ee56e8bfcb72a4a282cd339b6aed4917814ab7b5bc7
+  metadata.gz: 4d2bf84191e5b578e0563d4d92e3db05460fea2d3bff766a39bd0151162508d3310852ac7d1b4b92bc9fca5903fe1957fd38976f10d9d81ffc50be3f36d80fe7
+  data.tar.gz: 277b383633ddf01fd09fee7fa310c1951869a081413c6191e18032661fd6e588475c85ad1e3be779323ca77f4459fb3b1786ca05a85a44e153a5eef60833f3e7

data/lib/learn_open/opener.rb

@@ -41,12 +41,11 @@ module LearnOpen
     def repo_exists?
       cloned_labs = "#{HOME_DIR}/.cloned_labs"
       if File.exists?(cloned_labs)
+        puts "Loading..."
+        syncing_done = "#{HOME_DIR}/.syncing_started"
+        sleep 1 until File.exists?(syncing_done)
         if File.readlines(cloned_labs).grep(/#{repo_dir}/).any?
-          until File.exists?("#{lessons_dir}/#{repo_dir}")
-            puts "Loading..."
-            puts Dir["#{lessons_dir}/*"].count
-            sleep 1
-          end
+          sleep 1 until File.exists?("#{lessons_dir}/#{repo_dir}")
           true
         else
           false

data/lib/learn_open/version.rb

@@ -1,3 +1,3 @@
 module LearnOpen
-  VERSION = '1.2.2'
+  VERSION = '1.2.3'
 end

data/spec/learn_open/opener_spec.rb

@@ -5,16 +5,20 @@ describe LearnOpen::Opener do
 
   context "Verifying repo existance" do
     let(:opener) { LearnOpen::Opener.new("","","") }
-    before do
+    after do
       path = File.join(__dir__, "..", "home_dir", "code")
       FileUtils.rm_rf(path)
     end
 
     context "with .cloned_labs file" do
-      before do
+      after do
         cloned_labs = "#{LearnOpen::Opener::HOME_DIR}/.cloned_labs"
         FileUtils.rm(cloned_labs) if File.exists?(cloned_labs)
+
+        syncing_started = "#{LearnOpen::Opener::HOME_DIR}/.syncing_started"
+        FileUtils.rm(syncing_started) if File.exists?(syncing_started)
       end
+
       it "returns true if lab is in the .cloned_labs file" do
         expect(opener).to receive(:repo_dir).at_least(:once).and_return("js-rubber-duck-wrangling")
 
@@ -22,14 +26,35 @@ describe LearnOpen::Opener do
           f.puts("js-rubber-duck-wrangling")
         end
 
+        File.open("#{LearnOpen::Opener::HOME_DIR}/.syncing_started", "w+") do |f|
+          f.puts("done")
+        end
+
         FileUtils.mkdir_p("#{opener.lessons_dir}/js-rubber-duck-wrangling")
 
         expect(opener.repo_exists?).to be_truthy
       end
+
       it "returns false if lab is not in the .cloned_labs file" do
+        File.open("#{LearnOpen::Opener::HOME_DIR}/.syncing_started", "w+") do |f|
+          f.puts("done")
+        end
         expect(opener).to receive(:repo_dir).and_return("js-rubber-duck-wrangling")
         expect(opener.repo_exists?).to be_falsy
       end
+
+      context "before filesyncing starts" do
+        it "waits for .syncing_started " do
+          File.open("#{LearnOpen::Opener::HOME_DIR}/.cloned_labs", "w+") do |f|
+            f.puts("js-rubber-duck-wrangling")
+          end
+
+          FileUtils.mkdir_p("#{opener.lessons_dir}/js-rubber-duck-wrangling")
+          expect do
+            Timeout::timeout(2) { opener.repo_exists? }
+          end.to raise_error(Timeout::Error)
+        end
+      end
     end
 
     context "without .cloned_labs file" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: learn-open
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Flatiron School
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-14 00:00:00.000000000 Z
+date: 2016-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler