leap_salesforce 0.2.7 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb7154cf99cf12053647574f3638760270b3d0e18cfdcb2f5680561765c49aa9
-  data.tar.gz: 66016e3b7e5999e8df24bdef7031bf3b40e9f0662aa6e2fcd76bdbd176390ee4
+  metadata.gz: 0727f9b6fbfb3b1c1b20b77a96eae10a2769574e7aeefd9af1282bffa2c9ce1d
+  data.tar.gz: 6ebb6a6246a65acec84880ac0b0c06f5757f0cad273bcff6e03c974973e2b41b
 SHA512:
-  metadata.gz: c9a1048067ba6873d69ce44313e88573be5be000c544ff0d00f036f35dcae4d0e92d2884be69f5486c8da3e09ed8f4ca42670cbab1dfae33a16a351120bf6285
-  data.tar.gz: 930e8204a42e3285f2eec5ffdacb94596658e4a4983862b538463c79a8faa00d29c04a3c77f35703f51f000962a3d8010a8cecc7d8f1fb2fd9b975c8343dc841
+  metadata.gz: 15c74d38ab17892e205e0682ecdc677357a7810b384b60ed8b09b182de08abfca49320ba092af86e3f74a48293c158faf5544d24fc496b4f05831426e4c2e492
+  data.tar.gz: 4bf6d4319d775a085f1083128b36adbfe02d824238fa830c4f08a3f932c7077a0476235917d86e0aada28fbec9dc9986f1d400a918a39af6acd6ef809f22919b

data/.idea/leap-salesforce.iml

@@ -4,7 +4,9 @@
     <shared />
   </component>
   <component name="NewModuleRootManager">
-    <content url="file://$MODULE_DIR$" />
+    <content url="file://$MODULE_DIR$">
+      <excludeFolder url="file://$MODULE_DIR$/doc" />
+    </content>
     <orderEntry type="jdk" jdkName="RVM: ruby-2.6.0" jdkType="RUBY_SDK" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" scope="PROVIDED" name="activemodel (v6.0.0, RVM: ruby-2.6.0) [gem]" level="application" />
@@ -21,7 +23,7 @@
     <orderEntry type="library" scope="PROVIDED" name="diff-lcs (v1.3, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="domain_name (v0.5.20190701, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="factory_bot (v5.1.0, RVM: ruby-2.6.0) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="faker (v2.4.0, RVM: ruby-2.6.0) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="faker (v2.5.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="gyoku (v1.3.1, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="hashie (v3.6.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="http-accept (v1.7.0, RVM: ruby-2.6.0) [gem]" level="application" />
@@ -60,7 +62,7 @@
     <orderEntry type="library" scope="PROVIDED" name="rspec-its (v1.3.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rspec-mocks (v3.8.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rspec-support (v3.8.0, RVM: ruby-2.6.0) [gem]" level="application" />
-    <orderEntry type="library" scope="PROVIDED" name="rubocop (v0.74.0, RVM: ruby-2.6.0) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="rubocop (v0.75.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="ruby-progressbar (v1.10.0, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="rubykeyword (v0.0.4, RVM: ruby-2.6.0) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="savon (v2.12.0, RVM: ruby-2.6.0) [gem]" level="application" />

data/ChangeLog

@@ -1,3 +1,7 @@
+Version 0.2.8
+* Bug fix
+  * Could not handle double and boolean values in SOQL query
+
 Version 0.2.7
 * Bug Fix
   * New way of handling [] method broke error message's ability to diagnose

data/lib/leap_salesforce/soql_data/soql_global_object_data.rb

@@ -61,7 +61,7 @@ module SoqlGlobalObjectData
     lookup.each do |key, value|
       conditional_term = conditional.empty? ? 'WHERE' : 'AND'
       key_used = map_key key
-      conditional += "#{conditional_term} #{key_used} #{condition_for(value)} "
+      conditional += "#{conditional_term} #{key_used} #{condition_for(key_used, value)} "
     end
     query = conditional + "ORDER BY #{@default_filter} DESC NULLS FIRST"
     query += " LIMIT #{limit}" if limit
@@ -238,24 +238,30 @@ module SoqlGlobalObjectData
   # Returns SOQL condition for value passed to be used in SOQL query
   # @example Greater than or equal to yesterday's date
   #   condition_for("<=#{Time.mktime(2019,1,1)}") # => '<= 2019-01-01T00:00:00.000Z'
+  # @param [String] field_name Backend field name
   # @param [String, Object] value Value to search for. Certain characters modify this to be more of a complex
   #   check. Object will be converted String if not already one
   # @return [String] Condition criteria to match value using SOQL
-  def condition_for(value)
-    value = value.to_s
+  def condition_for(field_name, value)
+    value = value.nil? ? 'null' : value.to_s
     operator, value = case value[0]
                       when '>', '<', '!', 'I' then extract_comparator(value)
                       when '~' then ['LIKE', value[1..-1]]
-                      else
-                        return "= '#{value}'" unless value.type_of_time?
-
-                        return "= #{value.to_zulu_date_string}"
+                      else ['=', value]
                       end
-    return "#{operator} #{value.to_zulu_date_string}" if value.type_of_time?
-
-    return "#{operator} #{value}" if operator.end_with? 'IN'
+    case type_for(field_name)
+    when 'boolean', 'double', 'int' then "#{operator} #{value}"
+    when 'date', 'datetime', 'time'
+      unless value.type_of_time?
+        raise LeapSalesforce::RequestError,
+              "Value '#{value}' cannot be interpreted as date for #{field_name}"
+      end
+      "#{operator} #{value.to_zulu_date_string}"
+    else # string, picklist, reference, id, textarea
+      return "#{operator} #{value}" if operator.end_with?('IN') || value == 'null'
 
-    "#{operator} '#{value}'"
+      "#{operator} '#{value}'"
+    end
   end
 
   # @param [String] value Value to extract comparator for

data/lib/leap_salesforce/version.rb

@@ -2,5 +2,5 @@
 
 module LeapSalesforce
   # @return [String] Version of leap salesforce
-  VERSION = '0.2.7'
+  VERSION = '0.2.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leap_salesforce
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - IQA
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-26 00:00:00.000000000 Z
+date: 2019-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler