ldp 0.7.1 → 1.0.3

data/lib/ldp/client/prefer_headers.rb

@@ -2,7 +2,7 @@ module Ldp
   class PreferHeaders
     attr_reader :headers_string
 
-    def initialize(headers_string="")
+    def initialize(headers_string = "")
       @headers_string = headers_string
     end
 
@@ -54,11 +54,11 @@ module Ldp
     end
 
     def options
-      headers_string.gsub('"',"").
-        split(";").
-        map{|x| x.strip.split("=")}.
-        map{|x| { x[0] => x[1].split(" ") }}.
-        inject({}, &:merge)
+      headers_string.gsub('"', "")
+                    .split(";")
+                    .map { |x| x.strip.split("=") }
+                    .map { |x| { x[0] => x[1].split(" ") } }
+                    .inject({}, &:merge)
     end
   end
 end

data/lib/ldp/error.rb

@@ -1,6 +1,6 @@
 module Ldp
   class Error < StandardError; end
-  
+
   class HttpError          < RuntimeError; end
   class BadRequest         < HttpError; end # 400
   class NotFound           < HttpError; end # 404

data/lib/ldp/orm.rb

@@ -1,6 +1,5 @@
 module Ldp
   class Orm
-
     attr_reader :resource
     attr_reader :last_response
 

data/lib/ldp/resource.rb

@@ -57,8 +57,8 @@ module Ldp
     def head
       @head ||= begin
         @get || client.head(subject)
-      rescue Ldp::NotFound
-        None
+                rescue Ldp::NotFound
+                  None
       end
     end
 
@@ -79,7 +79,7 @@ module Ldp
     # @return [RdfSource] the new representation
     # @raise [Ldp::Conflict] if you attempt to call create on an existing resource
     def create &block
-      raise Ldp::Conflict, "Can't call create on an existing resource" unless new?
+      raise Ldp::Conflict, "Can't call create on an existing resource (#{subject})" unless new?
       verb = subject.nil? ? :post : :put
       resp = client.send(verb, (subject || @base_path), content) do |req|
         req.headers["Link"] = "<#{interaction_model}>;rel=\"type\"" if interaction_model
@@ -130,6 +130,5 @@ module Ldp
     def interaction_model
       nil
     end
-
   end
 end

data/lib/ldp/resource/binary_source.rb

@@ -2,16 +2,21 @@ module Ldp
   class Resource::BinarySource < Ldp::Resource
     attr_accessor :content
 
+    # @param client [Ldp::Client]
+    # @param subject [String] the URI for the resource
+    # @param content_or_response [String,Ldp::Response]
+    # @param base_path [String] ('')
     def initialize client, subject, content_or_response = nil, base_path = ''
       super
 
       case content_or_response
-      when Faraday::Response
+      when Ldp::Response
       else
         @content = content_or_response
       end
     end
 
+    # @return [Ldp::Response]
     def content
       @content ||= get.body
     end
@@ -25,7 +30,7 @@ module Ldp
     # Override inspect so that `content` is never shown. It is typically too big to be helpful
     def inspect
       string = "#<#{self.class.name}:#{self.object_id} "
-      fields = [:subject].map{|field| "#{field}=\"#{self.send(field)}\""}
+      fields = [:subject].map { |field| "#{field}=\"#{self.send(field)}\"" }
       string << fields.join(", ") << ">"
     end
 

data/lib/ldp/resource/rdf_source.rb

@@ -1,18 +1,17 @@
 require 'rdf/turtle'
 module Ldp
   class Resource::RdfSource < Ldp::Resource
-
     def initialize client, subject, graph_or_response = nil, base_path = ''
       super
 
       case graph_or_response
-        when RDF::Enumerable
-          @graph = graph_or_response
-        when Ldp::Response
-        when NilClass
-          #nop
-        else
-          raise ArgumentError, "Third argument to #{self.class}.new should be a RDF::Enumerable or a Ldp::Response. You provided #{graph_or_response.class}"
+      when RDF::Enumerable
+        @graph = graph_or_response
+      when Ldp::Response
+      when NilClass
+      # nop
+      else
+        raise ArgumentError, "Third argument to #{self.class}.new should be a RDF::Enumerable or a Ldp::Response. You provided #{graph_or_response.class}"
       end
     end
 
@@ -66,41 +65,32 @@ module Ldp
     end
 
     private
-      ##
-      # @param [Faraday::Response] graph query response
-      # @return [RDF::Graph]
-      def response_as_graph(resp)
-        graph = build_empty_graph
-        resp.each_statement do |stmt|
-          graph << stmt
-        end
-        graph
-      end
-
-      ##
-      # @param [RDF::Graph] original_graph The graph returned by the LDP server
-      # @return [RDF::Graph] A graph stripped of any inlined resources present in the original
-      def filtered_graph(original_graph)
-        inlined_resources = original_graph.query(predicate: RDF::Vocab::LDP.contains).map { |x| x.object }
 
-        # we want to scope this graph to just statements about this model, not contained relations
-        if inlined_resources.empty?
-          original_graph
-        else
-          graph_without_inlined_resources(original_graph, inlined_resources)
-        end
-      end
-
-      def graph_without_inlined_resources(original_graph, inlined_resources)
-        new_graph = build_empty_graph
+    ##
+    # @note tries to avoid doing a large scale copy of the {RDF::Repository}
+    #   data structure by using the existing {Ldp::Response#graph} if
+    #   {#graph_class} is {RDF::Graph}. otherwise, it tries to instantiate a
+    #   new graph projected over the same underlying {RDF::Graph#data}. finally,
+    #   if {#graph_class}'s initailizer doesn't accept a `data:` parameter, it
+    #   shovels {Ldp::Response#graph} into a new object of that class.
+    #
+    # @param [Faraday::Response] graph query response
+    # @return [RDF::Graph]
+    def response_as_graph(resp)
+      build_empty_graph << resp.graph
+    end
 
-        original_graph.each_statement do |s|
-          unless inlined_resources.include? s.subject
-            new_graph << s
-          end
-        end
+    ##
+    # @param [RDF::Graph] original_graph The graph returned by the LDP server
+    # @return [RDF::Graph] A graph stripped of any inlined resources present in the original
+    def filtered_graph(original_graph)
+      contains_statements = original_graph.query(predicate: RDF::Vocab::LDP.contains)
 
-        new_graph
+      contains_statements.each_object do |contained_uri|
+        original_graph.delete(original_graph.query(subject: contained_uri))
       end
+
+      original_graph
+    end
   end
 end

data/lib/ldp/response.rb

@@ -10,6 +10,7 @@ module Ldp
 
     attr_writer :etag, :last_modified
 
+    # @param response [Faraday::Response]
     def initialize(response)
       @response = response
     end
@@ -78,10 +79,10 @@ module Ldp
     # Get the subject for the response
     def subject
       @subject ||= if has_page?
-        graph.first_object [page_subject, RDF::Vocab::LDP.pageOf, nil]
-      else
-        page_subject
-      end
+                     graph.first_object [page_subject, RDF::Vocab::LDP.pageOf, nil]
+                   else
+                     page_subject
+                   end
     end
 
     ##
@@ -104,9 +105,7 @@ module Ldp
     # Get the graph for the resource (or a blank graph if there is no metadata for the resource)
     def graph
       @graph ||= begin
-        graph = RDF::Graph.new
-        each_statement { |s| graph << s }
-        graph
+        RDF::Graph.new << reader
       end
     end
 
@@ -114,6 +113,8 @@ module Ldp
       reader_for_content_type.new(body, base_uri: page_subject, &block)
     end
 
+    ##
+    # @deprecated use {#graph} instead
     def each_statement(&block)
       reader do |reader|
         reader.each_statement(&block)
@@ -154,17 +155,9 @@ module Ldp
     # Statements about the page
     def page
       @page_graph ||= begin
-        g = RDF::Graph.new
-
-        if resource?
-          res = graph.query RDF::Statement.new(page_subject, nil, nil)
-
-          res.each_statement do |s|
-            g << s
-          end
-        end
-
-        g
+        page_graph = RDF::Graph.new
+        page_graph << graph.query([page_subject, nil, nil]) if resource?
+        page_graph
       end
     end
 
@@ -208,7 +201,7 @@ module Ldp
     def content_disposition_attributes
       parts = headers['Content-Disposition'].split(/;\s*/).collect { |entry| entry.split(/\s*=\s*/) }
       entries = parts.collect do |part|
-        value = part[1].respond_to?(:sub) ? part[1].sub(%r{^"(.+)"$}, '\1') : part[1]
+        value = part[1].respond_to?(:sub) ? part[1].sub(%r{^"(.*)"$}, '\1') : part[1]
         [part[0], value]
       end
       Hash[entries]

data/lib/ldp/version.rb

@@ -1,3 +1,3 @@
 module Ldp
-  VERSION = "0.7.1"
+  VERSION = "1.0.3"
 end

data/spec/lib/ldp/resource/binary_source_spec.rb

@@ -4,21 +4,26 @@ describe Ldp::Resource::BinarySource do
   let(:client) { instance_double(Ldp::Client) }
   let(:uri) { 'http://example.com/foo/bar' }
   let(:content) { 'somecontent' }
-  subject { described_class.new(client, uri, content) }
+  let(:instance) { described_class.new(client, uri, content) }
 
-  it "should not display content to inspect" do
-    expect(subject.inspect).to match /subject=\"http:\/\/example\.com\/foo\/bar\"/
-    expect(subject.inspect).not_to match /somecontent/
+  describe "#inspect" do
+    subject { instance.inspect }
+
+    it "does not display content" do
+      expect(subject).to match /subject=\"http:\/\/example\.com\/foo\/bar\"/
+      expect(subject).not_to match /somecontent/
+    end
   end
 
   describe '#described_by' do
+    subject { instance.described_by }
     context 'without a description' do
       before do
         allow(client).to receive(:head).and_return(instance_double(Ldp::Response, links: { }))
       end
 
       it 'retrieves the description object' do
-        expect(subject.described_by).to eq nil
+        expect(subject).to eq nil
       end
     end
 
@@ -31,8 +36,20 @@ describe Ldp::Resource::BinarySource do
       let(:desc) { double }
 
       it 'retrieves the description object' do
-        expect(subject.described_by).to eq desc
+        expect(subject).to eq desc
       end
     end
   end
+
+  describe "#content" do
+    context "when an Ldp::Response is passed in" do
+      let(:mock_response) { instance_double(Faraday::Response, headers: {}, env: { url: "info:a" }) }
+      let(:content) { Ldp::Response.new(mock_response) }
+      let(:client) { instance_double(Ldp::Client, get: double(body: 'retrieved value')) }
+      
+      subject { instance.content }
+
+      it { is_expected.to eq 'retrieved value' }
+    end
+  end
 end

data/spec/lib/ldp/resource/rdf_source_spec.rb

@@ -107,6 +107,24 @@ describe Ldp::Resource::RdfSource do
         expect(subject.graph.size).to eql(1)
       end
     end
+
+    context 'with inlined resources' do
+      subject { Ldp::Resource::RdfSource.new mock_client, "http://my.ldp.server/existing_object" }
+
+      let(:simple_graph) do
+        graph = RDF::Graph.new
+        graph << [RDF::URI.new(), RDF::Vocab::DC.title, "Hello, world!"]
+        graph << [RDF::URI.new(), RDF::Vocab::LDP.contains, contained_uri]
+        graph << [contained_uri, RDF::Vocab::DC.title, "delete me"]
+      end
+
+      let(:contained_uri) { RDF::URI.new('http://example.com/contained') }
+
+      it do
+        expect(subject.graph.subjects)
+          .to contain_exactly(RDF::URI('http://my.ldp.server/existing_object'))
+      end
+    end
   end
 
   context "When graph_class is overridden" do
@@ -130,5 +148,14 @@ describe Ldp::Resource::RdfSource do
     it "should use the specified class" do
       expect(subject.graph).to be_a SpecialGraph
     end
+
+    context "with a response body" do
+      subject { SpecialResource.new mock_client, "http://my.ldp.server/existing_object" }
+
+
+      it "should use the specified class" do
+        expect(subject.graph).to be_a SpecialGraph
+      end
+    end
   end
 end

data/spec/lib/ldp/response_spec.rb

@@ -202,11 +202,13 @@ describe Ldp::Response do
         { 'Content-Disposition' => 'filename="xyz.txt";' },
         { 'Content-Disposition' => 'attachment; filename=xyz.txt' },
         { 'Content-Disposition' => 'attachment; filename="xyz.txt"; size="12345"' },
+        { 'Content-Disposition' => 'attachment; filename=""; size="12345"' },
       )
     end
 
     it 'provides the filename from the content disposition header' do
       3.times { expect(subject.content_disposition_filename).to eq 'xyz.txt' }
+      expect(subject.content_disposition_filename).to eq ''
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ldp
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 1.0.3
 platform: ruby
 authors:
 - Chris Beer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-03-13 00:00:00.000000000 Z
+date: 2021-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -206,6 +206,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bixby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: github_changelog_generator
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Linked Data Platform client library
 email:
 - chris@cbeer.info
@@ -214,13 +256,19 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
+- ".github_changelog_generator"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- SUPPORT.md
 - bin/ldp
 - ldp.gemspec
 - lib/ldp.rb
@@ -252,7 +300,7 @@ homepage: https://github.com/projecthydra/ldp
 licenses:
 - APACHE2
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -267,9 +315,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Linked Data Platform client library
 test_files: