ldp 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 956f52c643432907584236bd1d46ee3ceeaa720e
-  data.tar.gz: caf6a6247b19c4d86aacb9d882f62254bdc4b682
+  metadata.gz: 0e8d452c791e099e1a633bcc58b3861b1fadb599
+  data.tar.gz: edac475bb689f7e2cbd582d620aeb7249935d843
 SHA512:
-  metadata.gz: e5b586a5af1bbcfd97850786ed8cd139e53ed103a4770b27ff9774681247d54bc9c493f3eada647b6282efc6b55b5829174139734fd84d434f75e661da4d01f4
-  data.tar.gz: d742e30ac69b306314885a11352ae248a1e516c136758663a3d18ff27329682b2a03d7f8cc3dfdf629b6cfb4a20ec51ec3c822263f0dd299de76a3a8ce7a53e6
+  metadata.gz: 14049aa77e903891b22c95f294d091ec859ea87a640ab137dc41a639477a1b23f0c1f752bec23a4505bdc504d0dd3448e54571d474559bed5287b8519c21add3
+  data.tar.gz: 3f61c96706429e86ba276f9c1d7a52df970f926e9f26f81f89aa3f8aaa2abd3ae414596f712a2c3a52dcbac83030585fbe82bcc14b0426de3ac0b6deef870741

data/.gitignore

@@ -15,4 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-.storage
+.storage
+/spec/examples.txt

data/lib/ldp/client/methods.rb

@@ -115,7 +115,7 @@ module Ldp::Client::Methods
 
   def check_for_errors resp
     resp.tap do |resp|
-      unless resp.success?
+      unless resp.status < 400
         raise case resp.status
           when 400
             if resp.env.method == :head

data/lib/ldp/resource.rb

@@ -66,7 +66,7 @@ module Ldp
     # Delete the resource
     def delete
       client.delete subject do |req|
-        req.headers['If-Match'] = get.etag if retrieved_content?
+        req.headers['If-Unmodified-Since'] = get.last_modified if retrieved_content?
       end
     end
 
@@ -95,7 +95,7 @@ module Ldp
     def update new_content = nil
       new_content ||= content
       resp = client.put subject, new_content do |req|
-        req.headers['If-Match'] = get.etag if retrieved_content?
+        req.headers['If-Unmodified-Since'] = get.last_modified if retrieved_content?
         yield req if block_given?
       end
       update_cached_get(resp) if retrieved_content?

data/lib/ldp/version.rb

@@ -1,3 +1,3 @@
 module Ldp
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

data/spec/lib/ldp/client_spec.rb

@@ -29,6 +29,10 @@ describe "Ldp::Client" do
       stub.put("/forbidden_resource") { [403, {}, ''] }
       stub.put("/conflict_resource") { [409, {}, ''] }
       stub.get("/deleted_resource") { [410, {}, 'Gone'] }
+      stub.head("/temporary_redirect1") { [302, {"Location" => "http://example.com/new"}] }
+      stub.head("/temporary_redirect2") { [307, {"Location" => "http://example.com/new"}] }
+      stub.head("/permanent_redirect1") { [301, {"Location" => "http://example.com/new"}] }
+      stub.head("/permanent_redirect2") { [308, {"Location" => "http://example.com/new"}] }
     end
   end
 
@@ -276,6 +280,17 @@ describe "Ldp::Client" do
       resource = subject.find_or_initialize "a_binary_resource"
       expect(resource).to be_a_kind_of(Ldp::Resource::BinarySource)
     end
+  end
+
+  describe "head" do
+    it "treats temporary redirects as successful" do
+      expect { subject.head "temporary_redirect1" }.not_to raise_error
+      expect { subject.head "temporary_redirect2" }.not_to raise_error
+    end
 
+    it "treats permanent redirects as successful" do
+      expect { subject.head "permanent_redirect1" }.not_to raise_error
+      expect { subject.head "permanent_redirect2" }.not_to raise_error
+    end
   end
 end

data/spec/lib/ldp/resource/binary_source_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Ldp::Resource::BinarySource do
-  let(:client) { double }
+  let(:client) { instance_double(Ldp::Client) }
   let(:uri) { 'http://example.com/foo/bar' }
   let(:content) { 'somecontent' }
   subject { described_class.new(client, uri, content) }
@@ -14,7 +14,7 @@ describe Ldp::Resource::BinarySource do
   describe '#described_by' do
     context 'without a description' do
       before do
-        allow(client).to receive(:head).and_return(double(links: { }))
+        allow(client).to receive(:head).and_return(instance_double(Ldp::Response, links: { }))
       end
 
       it 'retrieves the description object' do
@@ -24,7 +24,7 @@ describe Ldp::Resource::BinarySource do
 
     context 'with a description' do
       before do
-        allow(client).to receive(:head).and_return(double(links: { 'describedby' => ['http://example.com/foo/bar/desc']}))
+        allow(client).to receive(:head).and_return(instance_double(Ldp::Response, links: { 'describedby' => ['http://example.com/foo/bar/desc']}))
         allow(client).to receive(:find_or_initialize).with('http://example.com/foo/bar/desc').and_return(desc)
       end
 
@@ -35,5 +35,4 @@ describe Ldp::Resource::BinarySource do
       end
     end
   end
-
 end

data/spec/lib/ldp/response_spec.rb

@@ -4,8 +4,8 @@ describe Ldp::Response do
   LDP_RDF_RESOURCE_HEADERS = { "Link" => "<#{RDF::Vocab::LDP.Resource}>;rel=\"type\", <#{RDF::Vocab::LDP.DirectContainer}>;rel=\"type\""}
   LDP_NON_RDF_SOURCE_HEADERS = { "Link" => "<#{RDF::Vocab::LDP.Resource}>;rel=\"type\", <#{RDF::Vocab::LDP.NonRDFSource}>;rel=\"type\""}
 
-  let(:mock_response) { double("mock response", headers: {}, env: { url: "info:a" }) }
-  let(:mock_client) { double(Ldp::Client) }
+  let(:mock_response) { instance_double(Faraday::Response, headers: {}, env: { url: "info:a" }) }
+  let(:mock_client) { instance_double(Ldp::Client) }
 
   subject do
     Ldp::Response.new mock_response

data/spec/spec_helper.rb

@@ -17,5 +17,82 @@ require 'faraday'
 require 'active_support/notifications'
 
 RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
 
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = 'spec/examples.txt'
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ldp
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Chris Beer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-18 00:00:00.000000000 Z
+date: 2016-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday