ldap_groups_lookup 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89497393dbd1cb8187e740a5867c0758a6a47eb79ae4719bf2e09ba0952011ac
-  data.tar.gz: e9e7db4530168f315c7b7463beeb395d94aa49411fc2a7d92cba6152136600ce
+  metadata.gz: 93b710e0c55641a70229aef31de0eb3bcbac110ee8ea7f34e4aea784cd605c74
+  data.tar.gz: eaa38276bd60526a24ce3979e757cb1423985b71bc05647017ce04a13566ac46
 SHA512:
-  metadata.gz: be721599c153b22b93fc7769377610619d24d74973e3316f7ebd427341a1c5830cc71d45df67cb78671773347c865999b65e18e2cf349759e005d42c84b5b337
-  data.tar.gz: f5f4aa7a0d10008ee984cc495076fb669b6113bf8ac52012f8c6806f7b14cb8c1ac12bd340a98a1585168be8cb2101d29da1aa6aef154d04d8222e6f3e8c9f11
+  metadata.gz: 5041fe650a03a4a70732df646a1b86e61c28c1c5e366f6254dc156edc6e6a46afb35e315bd7985e90c4097ffb280f1b617e5fe0ea8641d2ff300222e8ec6feb3
+  data.tar.gz: aee6357c288d1b069a274c7aa413ac8a26170a177d1b269b2ea0d871f4f6c1e77d5a375994a45eadc28159f1e126cc62504db747e5e45cc679a1245835da8707

data/.travis.yml

@@ -3,3 +3,5 @@ rvm:
  - 2.3
  - 2.4
  - 2.5
+ - 2.6
+ - 2.7

data/lib/ldap_groups_lookup/configuration.rb

@@ -45,6 +45,10 @@ module LDAPGroupsLookup
       config[:tree]
     end
 
+    def member_whitelist
+      config[:member_whitelist].to_a
+    end
+
     private
 
     def configure(value)

data/lib/ldap_groups_lookup/search.rb

@@ -57,7 +57,9 @@ module LDAPGroupsLookup
         next if seen.include? g
         seen << g
         member_groups = members.collect do |mg|
-          dn_to_cn(mg) if (mg.include?('OU=Groups') || mg.include?('OU=Applications'))
+          dn_to_cn(mg) if member_whitelist.empty? || member_whitelist.any? do |fil|
+            mg.include? fil
+          end
         end
         member_groups.compact!
         return true if walk_ldap_members(member_groups, dn, seen)

data/lib/ldap_groups_lookup/version.rb

@@ -1,5 +1,5 @@
 # Gem version release tracking
 module LDAPGroupsLookup
   # Define release version
-  VERSION = '0.6.1'.freeze
+  VERSION = '0.7.0'.freeze
 end

data/spec/fixtures/ldap_groups_lookup.yml.example

@@ -6,4 +6,6 @@
   :password: changeme
 :tree: dc=ads,dc=example,dc=net
 :account_ou: ou=Accounts
-:group_ou: ou=Groups
+:group_ou: ou=Groups
+:member_whitelist:
+  - OU=Groups

data/spec/lib/ldap_groups_lookup_spec.rb

@@ -216,16 +216,39 @@ RSpec.describe LDAPGroupsLookup do
           end
         end
         context 'when searching for a group that user is a nested member of' do
-          it 'should return true' do
+          before do
             expect(@service).to receive(:search).with(
                 hash_including(filter: Net::LDAP::Filter.equals('cn', 'Top-Group'))).and_return([@top_group])
-            expect(@service).to receive(:search).with(
+            allow(@service).to receive(:search).with(
                 hash_including(filter: Net::LDAP::Filter.equals('cn', 'Nested-Group'),
                                attributes: ['member;range=0-*'])).and_return([@nested_group_page_1])
-            expect(@service).to receive(:search).with(
+            allow(@service).to receive(:search).with(
                 hash_including(filter: Net::LDAP::Filter.equals('cn', 'Nested-Group'),
                                attributes: ['member;range=1-*'])).and_return([@nested_group_page_2])
-            expect(user.member_of_ldap_group?('Top-Group')).to eq(true)
+          end
+          context 'when the group is whitelisted' do
+            before do
+              allow(LDAPGroupsLookup).to receive(:member_whitelist).and_return(['OU=Groups'])
+            end
+            it 'should return true' do
+              expect(user.member_of_ldap_group?('Top-Group')).to eq(true)
+            end
+          end
+          context 'when the whitelist is empty' do
+            before do
+              allow(LDAPGroupsLookup).to receive(:member_whitelist).and_return([])
+            end
+            it 'should return true (whitelisting is disabled)' do
+              expect(user.member_of_ldap_group?('Top-Group')).to eq(true)
+            end
+          end
+          context 'when the group is not whitelisted' do
+            before do
+              allow(LDAPGroupsLookup).to receive(:member_whitelist).and_return(['OU=Not-A-Match'])
+            end
+            it 'should return false' do
+              expect(user.member_of_ldap_group?('Top-Group')).to eq(false)
+            end
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ldap_groups_lookup
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Adam Ploshay
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-27 00:00:00.000000000 Z
+date: 2020-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ldap