lda_gov 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b11b53da03541ac152c2f82a616f5d148f25df35746066d8407abcaeed0ec2a
-  data.tar.gz: eed3157d2c8714c4c218652ecc727ecd4c399208a19054063a9ba75dbb4cf626
+  metadata.gz: cf17a5d9cbdfc0ff212fb8f075783ddd2f56ac188e8545e1f7d50b5b89be6c37
+  data.tar.gz: 7da8f3b41336685e1ac6d76c282f9d391b3908d65cf28d8dd0c400e87765994a
 SHA512:
-  metadata.gz: c442d0857cbe0ce7da7e5abc3bc2971ff06c014f21bcde21c5a85a9de52d531187d81b3f0e4556cc98c73b046c961acf3cc3db771f7243ec10e9ab5c7817d671
-  data.tar.gz: 96c78265857b7b05a135806c09e8c60826575d94cf7b6e963a09e3b538ab9664d01936a76bd11ee94e264019c7d11d038b7b9722b9bf0136d8a43c564cfbc7d3
+  metadata.gz: d70c7f8f430f62be97f5bf346b392856c9ffd0eee8bbd55286cd415962c388d78a0bec9131fed99f38ade6fa3a66527d5f210cad2abb6a4699c3bef205169993
+  data.tar.gz: a04c274f5636e3c69f9c026d775f4fd65f3e4fc69d9a00cbb1e00409c9ac2135b0159c4cc37450fb388293f06c5c3d201561f8e9eb19b00817b758a83640be66

data/CHANGELOG.md

@@ -1,10 +1,24 @@
 # Changelog
 
+## [0.2.1] - 2026-03-23
+
+### Changed
+- Pagination `max_pages` is now configurable via `LDA.configure { |c| c.max_pages = 800 }` instead of a hardcoded constant. Default raised from 100 to 1,000.
+
+## [0.2.0] - 2026-03-22
+
+### Removed
+- `Filings#by_issue` — the LDA.gov API does not support server-side filtering by lobbying issue code. The parameter was silently ignored, returning unfiltered results. Filter client-side via `lobbying_activities` on each filing instead. See README for example.
+
+### Added
+- API Limitations section in README documenting supported vs unsupported server-side filters
+- `filing_type` filter example in README (`Q1`–`Q4`, `RR`, `RA`, etc.)
+
 ## [0.1.0] - 2025-03-13
 
 ### Added
 - Initial release
-- Filings resource (list, find, quarterly, by_registrant_and_client, by_issue)
+- Filings resource (list, find, quarterly, by_registrant_and_client)
 - Contributions resource (list, find)
 - Registrants resource (list, find)
 - Clients resource (list, find)

data/README.md

@@ -48,8 +48,8 @@ LDA.filings.by_registrant_and_client(
   client_name: 'Big Corp'
 )
 
-# Filter by lobbying issue
-LDA.filings.by_issue(issue_code: 'HCR')
+# Filter by filing type (quarterly reports, registrations, etc.)
+LDA.filings.list(filing_year: 2024, filing_type: 'Q1')
 ```
 
 ### Contributions
@@ -120,8 +120,9 @@ LDA.lobbyists.all_lobbyists
 LDA.configure do |config|
   config.api_key = ENV['LDA_API_KEY']       # Optional — enables higher rate limits
   config.timeout = 60                        # Request timeout in seconds (default: 30)
-  config.retries = 5                         # Max retries on 429/5xx (default: 3)
-  config.logger  = Logger.new($stdout)       # Optional request logging
+  config.retries   = 5                        # Max retries on 429/5xx (default: 3)
+  config.max_pages = 800                      # Max pages per paginate call (default: 1000)
+  config.logger    = Logger.new($stdout)      # Optional request logging
 end
 ```
 
@@ -207,6 +208,30 @@ LDA::Error
 
 All `ClientError` and `ServerError` subclasses expose `.status` and `.body`.
 
+## API Limitations
+
+The LDA.gov API does not support server-side filtering by lobbying issue code. Passing a `lobbying_issue` parameter to the filings endpoint has no effect — the API returns all filings regardless.
+
+**Supported filters** (confirmed working server-side):
+- `filing_year` — calendar year
+- `filing_type` — filing type code (`Q1`–`Q4`, `RR`, `RA`, `1T`, `1TY`, etc.)
+- `filing_period` — filing period (`first_quarter`, `second_quarter`, etc.)
+- `registrant_name` — registrant name search
+- `client_name` — client name search
+
+To filter by issue code, iterate over filings and check `lobbying_activities` on each filing:
+
+```ruby
+LDA.filings.each_page(filing_year: 2024, filing_type: 'Q1') do |page|
+  page.each do |filing|
+    issues = filing['lobbying_activities']&.map { |a| a['general_issue_code'] } || []
+    next unless issues.include?('DEF')
+
+    process(filing)
+  end
+end
+```
+
 ## Development
 
 ```bash
@@ -223,6 +248,10 @@ bundle exec rubocop     # Lint
 - Ruby >= 3.1
 - Faraday ~> 2.0
 
+## Support
+
+[![ko-fi](https://ko-fi.com/img/githubbutton_sm.svg)](https://ko-fi.com/omgjack)
+
 ## License
 
 MIT License. See [LICENSE.txt](LICENSE.txt).

data/lib/lda_gov/client.rb

@@ -5,8 +5,6 @@ require 'faraday/retry'
 
 module LDA
   class Client
-    MAX_PAGES = 100
-
     attr_reader :config
 
     def initialize(config = LDA.configuration)
@@ -38,7 +36,7 @@ module LDA
 
         page = response.next_page_number
         break if page.nil?
-        break if iterations >= MAX_PAGES
+        break if iterations >= config.max_pages
       end
     end
 

data/lib/lda_gov/configuration.rb

@@ -2,19 +2,21 @@
 
 module LDA
   class Configuration
-    DEFAULT_BASE_URL = 'https://lda.gov/api/v1/'
-    DEFAULT_TIMEOUT  = 30
-    DEFAULT_RETRIES  = 3
+    DEFAULT_BASE_URL  = 'https://lda.gov/api/v1/'
+    DEFAULT_TIMEOUT   = 30
+    DEFAULT_RETRIES   = 3
+    DEFAULT_MAX_PAGES = 1000
 
-    attr_accessor :base_url, :timeout, :retries, :logger, :adapter, :api_key
+    attr_accessor :base_url, :timeout, :retries, :logger, :adapter, :api_key, :max_pages
 
     def initialize
-      @base_url = DEFAULT_BASE_URL
-      @timeout  = DEFAULT_TIMEOUT
-      @retries  = DEFAULT_RETRIES
-      @logger   = nil
-      @adapter  = Faraday.default_adapter
-      @api_key  = ENV.fetch('LDA_API_KEY', nil)
+      @base_url  = DEFAULT_BASE_URL
+      @timeout   = DEFAULT_TIMEOUT
+      @retries   = DEFAULT_RETRIES
+      @max_pages = DEFAULT_MAX_PAGES
+      @logger    = nil
+      @adapter   = Faraday.default_adapter
+      @api_key   = ENV.fetch('LDA_API_KEY', nil)
     end
 
     def to_h
@@ -22,6 +24,7 @@ module LDA
         base_url: base_url,
         timeout: timeout,
         retries: retries,
+        max_pages: max_pages,
         logger: logger,
         adapter: adapter,
         api_key: api_key

data/lib/lda_gov/resources/filings.rb

@@ -26,10 +26,6 @@ module LDA
       def by_registrant_and_client(registrant_name:, client_name:, **params)
         get('filings/', params.merge(registrant_name: registrant_name, client_name: client_name))
       end
-
-      def by_issue(issue_code:, **params)
-        get('filings/', params.merge(lobbying_issue: issue_code))
-      end
     end
   end
 end

data/lib/lda_gov/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LDA
-  VERSION = '0.1.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lda_gov
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jack Killilea
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2026-03-14 00:00:00.000000000 Z
+date: 2026-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday