ld-eventsource 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcf2b9358b588b57f4bba285ed1a91bd399fe04c74622a0d944fd3fa0c56e9bb
-  data.tar.gz: 22514811554b69e1225aebebb18bb531b65daf27c8f0d2284717791f21aeb771
+  metadata.gz: 8b9f8e00c1bed855a376158eb3a77bb6b72192d6bb432a231df00be8c5576712
+  data.tar.gz: 697c406733e7590e591632493d3ff30a2f239ad3600382cf862063e2c8cf39ae
 SHA512:
-  metadata.gz: b20450c7187809e03706778149944c6268782c0b307b58874f569af2c6eb635ec125c65ed2d1c3077438f63a95e1dc86411743deb432f7da71aa4945bbfc12c1
-  data.tar.gz: 06dc4097880991e04e3ad8a8c3c3f0d01488849d84f0cc98444cbb8cb558b7a9949fc56169e3b18e569b2fe18b1900cd25404bf882f114c9816f0a715b1f9480
+  metadata.gz: 7c9a9d34b776c35cdd2f54bad3abbc53b658669996878267f375e5e36e4160f6aafad06e1275b67ce9667d81e71917f5c6b01e5daf214f9b29f8ad4f96b73c6c
+  data.tar.gz: 4561ccd51021a0eeb33a82528e45738d8cda462060a05a9fa17df010485d32e98817740c12611164ff7ebeb4935a12027ce11be13d98ced17864e73828e779a9

data/lib/ld-eventsource/client.rb

@@ -315,7 +315,8 @@ module SSE
 
     def run_stream
       until @stop_event.set?
-        close_connection
+        log_close_errors { close_connection }
+        error = nil
         begin
           resp = connect
           @lock.synchronize do
@@ -330,25 +331,25 @@ module SSE
           end
           read_stream(resp) unless resp.nil?
         rescue => e
+          error = e
+        end
+        # Close the connection before the error handler runs, because the handler can block for a long time.
+        log_close_errors { reset_http }
+        unless error.nil?
           # When we deliberately close the connection, it will usually trigger an exception. The exact type
           # of exception depends on the specific Ruby runtime. But the client will always be closed in this case.
           if @stop_event.set?
             @logger.info { "Stream connection closed" }
           else
-            log_and_dispatch_error(e, "Unexpected error from event source")
+            log_and_dispatch_error(error, "Unexpected error from event source")
           end
         end
-        begin
-          reset_http
-        rescue StandardError => e
-          log_and_dispatch_error(e, "Unexpected error while closing stream")
-        end
 
         return close unless @retry_enabled
       end
     end
 
-    # Try to establish a streaming connection. Returns the StreamingHTTPConnection object if successful.
+    # Try to establish a streaming connection. Returns the HTTP::Response object if successful.
     def connect
       loop do
         return if @stop_event.set?
@@ -392,8 +393,7 @@ module SSE
       end
     end
 
-    # Pipe the output of the StreamingHTTPConnection into the EventParser, and dispatch events as
-    # they arrive.
+    # Pipe the output of the HTTP::Response into the EventParser, and dispatch events as they arrive.
     def read_stream(cxn)
       # Tell the Backoff object that the connection is now in a valid state. It uses that information so
       # it can automatically reset itself if enough time passes between failures.
@@ -453,6 +453,15 @@ module SSE
       end
     end
 
+    # A failure to close is logged but not dispatched, so each connection attempt gives the error
+    # handler at most one error, and the worker thread continues.
+    def log_close_errors
+      yield
+    rescue StandardError => e
+      @logger.warn { "Unexpected error while closing stream: #{e.inspect}" }
+      @logger.debug { "Exception trace: #{e.backtrace}" }
+    end
+
     def build_headers
       h = {
         'Accept' => 'text/event-stream',

data/lib/ld-eventsource/impl/backoff.rb

@@ -39,13 +39,13 @@ module SSE
           @attempts = 0 if good_duration >= @reconnect_reset_interval
         end
         @last_good_time = nil
+        # A zero base must not be multiplied: 0.0 * Infinity is NaN. Also, rand(0) is not permitted.
+        return 0 if @base_interval <= 0 || @max_interval <= 0
+
         target = [@base_interval * (2 ** @attempts), @max_interval].min.to_f
-        @attempts += 1
-        if target == 0
-          0  # in some Ruby versions it's illegal to call rand(0)
-        else
-          (target / 2) + @jitter_rand.rand(target / 2)
-        end
+        # Stop at the ceiling, so that the power of 2 cannot grow without limit.
+        @attempts += 1 if target < @max_interval
+        (target / 2) + @jitter_rand.rand(target / 2)
       end
 
       #

data/lib/ld-eventsource/version.rb

@@ -1,3 +1,3 @@
 module SSE
-  VERSION = "3.0.0" # x-release-please-version
+  VERSION = "3.0.1" # x-release-please-version
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ld-eventsource
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-09-28 00:00:00.000000000 Z
+date: 2026-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec