lcgstyle 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f6dd155d5ff3cb439b02173ca467654cd5e660e
-  data.tar.gz: 71374c4b676c446e04bd597d53a45f2f97de3b47
+  metadata.gz: cc02e8d9bc1bfc0c9ae1016e9b35ad4f7c9d36b8
+  data.tar.gz: 2097d7d115f520481145fbbe8082e5b0636059b9
 SHA512:
-  metadata.gz: 84fd27d76c66ce70e0fac6cad8f99162da21284e7633c4713d56c340e1f2911d39a27387ce9c1c2424222e1e2f1e2dae47c71f41f6ddc107c574b393da856298
-  data.tar.gz: 25a9e43dd497bbc6f317da55fe99e57c1b8e74cbb35afcb85c99193c3f1711e4cbf3eb6f21995ba415613f3d4e6b50ebc6b31034e0a46b9acd11164a21462cc1
+  metadata.gz: acb07cb3e984f30d999ccbb9bc7a2df94a72ef28a7ac645ac0a58cf26ac43c2bfbea3333a9b375dca70e2d3281e2ddc20df2086a0314363a38b56ee160a39d02
+  data.tar.gz: c6f1703ad11ba725f8213101c2c32d8494ead64c7e63b75336122a74ced529b61c34c7ac6532c413d32efe414ec1d88d9da427b2bd8f4193a725072c5620db6d

data/config/chefstyle.yml

@@ -14,6 +14,8 @@ Lint/Debugger:
   Enabled: true
 Lint/DefEndAlignment:
   Enabled: true
+Lint/DuplicateCaseCondition:
+  Enabled: true
 Lint/DuplicateMethods:
   Enabled: true
 Lint/DuplicatedKey:
@@ -24,6 +26,8 @@ Lint/ElseLayout:
   Enabled: true
 Lint/EmptyEnsure:
   Enabled: true
+Lint/EmptyExpression:
+  Enabled: true
 Lint/EmptyInterpolation:
   Enabled: true
 Lint/EndAlignment:
@@ -38,6 +42,8 @@ Lint/FormatParameterMismatch:
   Enabled: true
 Lint/ImplicitStringConcatenation:
   Enabled: true
+Lint/InheritException:
+  Enabled: true
 Lint/InvalidCharacterLiteral:
   Enabled: true
 Lint/LiteralInCondition:
@@ -60,6 +66,8 @@ Lint/StringConversionInInterpolation:
   Enabled: true
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
+Lint/UnifiedInteger:
+  Enabled: true
 Lint/UnreachableCode:
   Enabled: true
 Lint/UselessAccessModifier:
@@ -138,6 +146,8 @@ Performance/Sample:
   Enabled: true
 Performance/Size:
   Enabled: true
+Performance/SortWithBlock:
+  Enabled: true
 Performance/StartWith:
   Enabled: true
 Performance/StringReplacement:
@@ -184,6 +194,8 @@ Metrics/AbcSize:
   Enabled: false
 Metrics/BlockNesting:
   Enabled: false
+Metrics/BlockLength:
+  Enabled: false
 Metrics/ClassLength:
   Enabled: false
 Metrics/CyclomaticComplexity:
@@ -230,6 +242,8 @@ Style/CommandLiteral:
   Enabled: true
 Style/ConstantName:
   Enabled: true
+Style/DefWithParenthesis:
+  Enabled: true
 Style/ElseAlignment:
   Enabled: true
 Style/EmptyLineBetweenDefs:
@@ -274,8 +288,12 @@ Style/MethodDefParentheses:
   Enabled: true
 Style/MultilineBlockLayout:
   Enabled: true
+Style/MultilineIfModifer:
+  Enabled: true
 Style/MultilineIfThen:
   Enabled: true
+Style/MultilineMemoization:
+  Enabled: true
 Style/MultilineMethodDefinitionBraceLayout:
   Enabled: true
 Style/MultilineOperationIndentation:
@@ -289,6 +307,14 @@ Style/NestedModifier:
   Enabled: true
 Style/NestedTernaryOperator:
   Enabled: true
+Style/NilComparison:
+  Enabled: true
+Style/NonNilCheck:
+  Enabled: true
+# `foo.zero?` is slower and substantially more annoying to read than `foo == 0`
+Style/NumericPredicate:
+  Enabled: true
+  EnforcedStyle: comparison
 Style/OneLineConditional:
   Enabled: true
 Style/OpMethod:
@@ -307,6 +333,7 @@ Style/PercentLiteralDelimiters:
   PreferredDelimiters:
     '%':  '{}'
     '%i': '{}'
+    '%I': '{}'
     '%q': '{}'
     '%Q': '{}'
     '%r': '{}'
@@ -322,6 +349,10 @@ Style/RedundantFreeze:
   Enabled: true
 Style/RescueEnsureAlignment:
   Enabled: true
+Style/SafeNavigation:
+  Enabled: true
+Style/SelfAssignment:
+  Enabled: true
 Style/Semicolon:
   AllowAsExpressionSeparator: true
   Enabled: true
@@ -353,12 +384,18 @@ Style/SpaceBeforeSemicolon:
   Enabled: true
 Style/SpaceAroundKeyword:
   Enabled: true
+Style/SpaceInLambdaLiteral:
+  Enabled: true
+Style/SpaceInsideArrayPercentLiteral:
+  Enabled: true
 Style/SpaceInsideBlockBraces:
   Enabled: true
 Style/SpaceInsideHashLiteralBraces:
   Enabled: true
 Style/SpaceInsideRangeLiteral:
   Enabled: true
+Style/SpaceInsideStringInterpolation:
+  Enabled: true
 Style/StabbyLambdaParentheses:
   Enabled: true
 # core chef community prefers double quotes over single quotes
@@ -391,6 +428,8 @@ Style/UnneededCapitalW:
 #  Enabled: true
 Style/VariableName:
   Enabled: true
+Style/VariableInterpolation:
+  Enabled: true
 Style/WhenThen:
   Enabled: true
 Style/WhileUntilDo:
@@ -408,6 +447,8 @@ Style/WordArray:
 # This is a cop that we /should/ have enabled, but tactically we can't really enable.
 Style/Documentation:
   Enabled: false
+Style/DocumentationMethod:
+  Enabled: false
 
 # this makes whitespace formatting of DSL code impossible
 Style/SpaceBeforeFirstArg:
@@ -467,3 +508,17 @@ Style/AsciiComments:
 # Parens around ternaries often make them more readable and reduces cognitive load over operator precidence
 Style/TernaryParentheses:
   Enabled: false
+
+# Underscores in numbers are super ugly for port numbers, freebsd versions, etc.
+# If we could mandate that this gets turned on only for numbers >= 1e9 which require three _'s then maybe.
+Style/NumericLiterals:
+  Enabled: false
+
+# I tend to find this more readable than long elsif chains
+Style/EmptyCaseCondition:
+  Enabled: false
+
+# This didn't quite do what we need
+Style/MultilineArrayBraceLayout:
+  Enabled: false
+

data/lib/lcgstyle/version.rb

@@ -1,4 +1,4 @@
 module Lcgstyle
-  VERSION = "0.0.6".freeze
+  VERSION = "0.0.7".freeze
   RUBOCOP_VERSION = "0.45.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lcgstyle
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Thom May
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-14 00:00:00.000000000 Z
+date: 2016-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler