lbank 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e97309035b55a0607c7e25877d7b93d47efd7798
-  data.tar.gz: 2f2ab7d5612edd9509d501dc0f15b308275dced4
+SHA256:
+  metadata.gz: 105dd10eb94b5ae8f077e82c6bb9b40391982beae9552453b074c4711162fd31
+  data.tar.gz: 6ddfdc8992576c21265e3d483b5772e886f59bc1fe85317d2ea189f27baee901
 SHA512:
-  metadata.gz: 47701d086875ab0ba6e85b98e942378ff2940f33c1f391ca6b4738294b897eb746be03616fa5a14c785ce399651e5c488b237b5fe6d4a029a347619ad5513cc2
-  data.tar.gz: 154a81cf41ab3b91b817ce3d92d66e349daeccd85ed7afa8325b93f33d6680dc8f8e2bf245e5364174c5bc36944108e9265e000da14cfb709dbacadaf179d9a2
+  metadata.gz: 34f984ba0a8daffc9e4a85cb0a9103b52b9fb5e0ba4c909707fee3a79a640d1656e0ce24a08ff4efd5a1dafa99c30f2f5510fe86bf9bd8f1165696631b257bd7
+  data.tar.gz: bdfb9de226b979fa473d3b91f03b51a064eaf08c4ce3f0fd295a06bca525cb9882e959eefedd94b146c7d5f4f8e0561b70559c9f000793011bbd16d877e8225c

data/.github/workflows/main.yml

@@ -0,0 +1,19 @@
+name: Build
+on: [push,pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+          - 3.0
+          - 3.4
+          - 4.0
+    name: Ruby ${{ matrix.ruby-version }} sample
+    steps:
+      - uses: actions/checkout@v7
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - run: bundle install
+      - run: bundle exec rake spec

data/.github/workflows/publish.yml

@@ -0,0 +1,21 @@
+name: Publish gem to rubygems
+on:
+  release:
+    types: [published]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: ruby/setup-ruby@v1
+
+      # setup .gem/credentials
+      - run: mkdir -p ~/.gem
+      - env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: >-
+          echo -e "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}" > ~/.gem/credentials
+      - run: chmod 0600 ~/.gem/credentials
+
+      - run: gem build lbank.gemspec --output=release.gem
+      - run: gem push release.gem

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+3.3.5

data/Gemfile

@@ -4,4 +4,5 @@ gemspec
 
 group :test do
   gem 'rake'
+  gem 'nokogiri'
 end

data/README.md

@@ -1,8 +1,10 @@
 # Lbank
 
-[![Build Status](https://secure.travis-ci.org/laurynas/lbank.png)](http://travis-ci.org/laurynas/lbank)
+[![Gem](https://img.shields.io/gem/v/lbank.svg)](https://rubygems.org/gems/lbank)
+[![Build Status](https://github.com/laurynas/lbank/actions/workflows/main.yml/badge.svg)](https://github.com/laurynas/lbank/actions)
+[![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-Fetches currency rates from Lithuanian Central Bank website http://lbank.lt.
+Fetches currency rates from Lithuanian Central Bank website https://lb.lt.
 Does currency conversion.
 Supports historic currency rates.
 

data/lbank.gemspec

@@ -14,11 +14,14 @@ Gem::Specification.new do |gem|
   gem.name          = 'lbank'
   gem.require_paths = ['lib']
   gem.version       = Lbank::VERSION
+  gem.required_ruby_version = '>= 3.0'
 
-  gem.add_dependency 'faraday'
-  gem.add_dependency 'faraday_middleware'
-  gem.add_dependency 'activesupport'
+  gem.add_dependency 'faraday', '>= 2.0', '< 3'
+  gem.add_dependency 'faraday-xml'
+  gem.add_dependency 'faraday-net_http'
+  gem.add_dependency 'tzinfo'
   gem.add_dependency 'multi_xml'
+  gem.add_dependency 'rexml'
 
   gem.add_development_dependency 'rspec', '~> 3.5'
   gem.add_development_dependency 'rspec-its', '~> 1.2'

data/lib/lbank/errors.rb

@@ -0,0 +1,4 @@
+module Lbank
+  class Error < StandardError; end
+  class ResponseError < Error; end
+end

data/lib/lbank/version.rb

@@ -1,3 +1,3 @@
 module Lbank
-  VERSION = '1.0.0'
+  VERSION = '2.0.0'
 end

data/lib/lbank.rb

@@ -1,8 +1,11 @@
 require 'lbank/version'
 require 'lbank/memory_cache'
-require 'active_support/time'
+require 'lbank/errors'
+require 'date'
+require 'tzinfo'
 require 'faraday'
-require 'faraday_middleware'
+require 'faraday/net_http'
+require 'faraday/xml'
 require 'bigdecimal'
 
 module Lbank
@@ -23,12 +26,14 @@ module Lbank
   end
 
   def currency_rates(time = nil)
-    time ||= Time.now
-    bank_time = time.to_time.in_time_zone(TIMEZONE)
-    date = bank_time.strftime('%Y-%m-%d')
+    date = bank_date(time || Time.now)
 
     cache.fetch(cache_key(date)) do
       response = connection.post(URL, tp: RATE_TYPE, dt: date)
+      error = response.body['FxRates']['OprlErr']
+
+      raise ResponseError.new(error['Desc']) if error
+
       fx_rates = response.body['FxRates']['FxRate']
 
       rates = { fx_rates[0]['CcyAmt'][0]['Ccy'] => 1 }
@@ -41,8 +46,8 @@ module Lbank
     end
   end
 
-  def convert_currency(amount, from_currency, to_currency, date = nil)
-    rates = currency_rates(date)
+  def convert_currency(amount, from_currency, to_currency, time = nil)
+    rates = currency_rates(time)
     from_rate = rates[from_currency.to_s]
     to_rate = rates[to_currency.to_s]
 
@@ -53,6 +58,15 @@ module Lbank
     "lbank-#{date}"
   end
 
+  def bank_date(time)
+    if time.is_a?(Date) && !time.is_a?(DateTime)
+      time.strftime('%Y-%m-%d')
+    else
+      local_time = TZInfo::Timezone.get(TIMEZONE).utc_to_local(time.to_time.utc)
+      local_time.strftime('%Y-%m-%d')
+    end
+  end
+
   def connection
     @connection ||= Faraday.new do |builder|
       builder.request :url_encoded

data/spec/lbank_spec.rb

@@ -1,28 +1,27 @@
 require 'spec_helper'
 
 describe Lbank do
+  let(:date) { Date.new(2012, 8, 4) }
+
   describe '#currency_rates' do
-    subject { described_class.currency_rates }
+    subject { described_class.currency_rates(date) }
 
     its(['USD']) { is_expected.to be > 0 }
-  end
-
-  describe '#convert_currency' do
-    it 'converts currency' do
-      expect(subject.convert_currency(10, 'USD', 'EUR')).to be > 0
-      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
 
-      date = Date.new(2012, 8, 4)
+    context 'when invalid time' do
+      let(:date) { Time.now + 7 * 24 * 60 * 60 }
 
-      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
-      expect(round(subject.convert_currency(1, 'USD', 'EUR', date))).to eq 0.82
-      expect(round(subject.convert_currency(100, 'RUB', 'USD', date))).to eq 3.08
+      it 'raises error' do
+        expect { subject }.to raise_error(Lbank::ResponseError, /No data/)
+      end
     end
   end
 
-  private
-
-  def round(number, precision = 2)
-    ("%.#{precision}f" % number).to_f
+  describe '#convert_currency' do
+    it 'converts currency' do
+      expect(subject.convert_currency(10, 'EUR', 'LTL', date).round(2)).to eq 34.53
+      expect(subject.convert_currency(1, 'USD', 'EUR', date).round(2)).to eq 0.82
+      expect(subject.convert_currency(100, 'RUB', 'USD', date).round(2)).to eq 3.08
+    end
   end
 end

metadata

@@ -1,17 +1,37 @@
 --- !ruby/object:Gem::Specification
 name: lbank
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Laurynas Butkus
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-09-24 00:00:00.000000000 Z
+date: 2026-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: faraday-xml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +45,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: faraday-net_http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +59,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: tzinfo
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -66,6 +86,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,16 +135,18 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
+- ".github/workflows/publish.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lbank.gemspec
 - lib/lbank.rb
+- lib/lbank/errors.rb
 - lib/lbank/memory_cache.rb
 - lib/lbank/version.rb
 - spec/lbank_spec.rb
@@ -118,7 +154,7 @@ files:
 homepage: https://github.com/laurynas/lbank
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -126,16 +162,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: Fetches currency rates from Lithuanian Central Bank website. Does currency
   conversion. Supports historic currency rates.

data/.travis.yml

@@ -1,5 +0,0 @@
-rvm:
-  - ruby-head
-  - 2.2.2
-script: "bundle exec rake spec"
-