lbank 0.0.3 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: e42cbb5d1055bb80343d70d081956c326c8c155f614a37a7d578d20312fd7331
+  data.tar.gz: d00fa3314b87dc16a75c4ea993088e0551e6f9bcc254c89e3ab7afc3895b1936
+SHA512:
+  metadata.gz: 7494eea07bb8049fb3ded4845d54176df58803f97458295483ba760c4ff0b74e1a6ec68266ceccaf3d14f96eabfcf2c55a44ba8faeb3b3504e75b73280c07485
+  data.tar.gz: 8702c03fe0f58083025262832af803d80331d2ea1fa131a134353fb683a4373d70a50be9e700c0813012e18c7e5382c54d04a4a6a9c3ada1dc3c572dc8533794

data/.github/workflows/main.yml

@@ -0,0 +1,18 @@
+name: Build
+on: [push,pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+          - 3.0
+          - 3.4
+    name: Ruby ${{ matrix.ruby-version }} sample
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - run: bundle install
+      - run: bundle exec rake spec

data/.github/workflows/publish.yml

@@ -0,0 +1,21 @@
+name: Publish gem to rubygems
+on:
+  release:
+    types: [published]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+
+      # setup .gem/credentials
+      - run: mkdir -p ~/.gem
+      - env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: >-
+          echo -e "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}" > ~/.gem/credentials
+      - run: chmod 0600 ~/.gem/credentials
+
+      - run: gem build lbank.gemspec --output=release.gem
+      - run: gem push release.gem

data/.ruby-version

@@ -0,0 +1 @@
+3.3.5

data/.travis.yml

@@ -1,7 +1,5 @@
 rvm:
-  - 1.9.3
-  - 1.9.2
-  - jruby
-  - rbx
+  - ruby-head
+  - 2.2.2
 script: "bundle exec rake spec"
 

data/Gemfile

@@ -2,10 +2,7 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rake'
-gem 'tzinfo'
-gem 'activesupport'
-
 group :test do
-  gem "rspec"
-end
+  gem 'rake'
+  gem 'nokogiri'
+end

data/README.md

@@ -1,8 +1,10 @@
 # Lbank
 
-[![Build Status](http://travis-ci.org/laurynas/lbank.png)](http://travis-ci.org/laurynas/lbank)
+[![Gem](https://img.shields.io/gem/v/lbank.svg)](https://rubygems.org/gems/lbank)
+[![Build Status](https://github.com/laurynas/lbank/actions/workflows/main.yml/badge.svg)](https://github.com/laurynas/lbank/actions)
+[![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-Fetches currency rates from Lithuanian Central Bank website http://lbank.lt.
+Fetches currency rates from Lithuanian Central Bank website https://lb.lt.
 Does currency conversion.
 Supports historic currency rates.
 

data/lbank.gemspec

@@ -2,16 +2,24 @@
 require File.expand_path('../lib/lbank/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Laurynas Butkus"]
-  gem.email         = ["laurynas.butkus@gmail.com"]
+  gem.authors       = ['Laurynas Butkus']
+  gem.email         = ['laurynas.butkus@gmail.com']
   gem.description   = %q{lbank.lt currency rates fetcher and converter}
   gem.summary       = %q{Fetches currency rates from Lithuanian Central Bank website. Does currency conversion. Supports historic currency rates.}
-  gem.homepage      = "https://github.com/laurynas/lbank"
+  gem.homepage      = 'https://github.com/laurynas/lbank'
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = "lbank"
-  gem.require_paths = ["lib"]
+  gem.name          = 'lbank'
+  gem.require_paths = ['lib']
   gem.version       = Lbank::VERSION
+
+  gem.add_dependency 'faraday'
+  gem.add_dependency 'faraday_middleware'
+  gem.add_dependency 'activesupport'
+  gem.add_dependency 'multi_xml'
+
+  gem.add_development_dependency 'rspec', '~> 3.5'
+  gem.add_development_dependency 'rspec-its', '~> 1.2'
 end

data/lib/lbank/errors.rb

@@ -0,0 +1,4 @@
+module Lbank
+  class Error < StandardError; end
+  class ResponseError < Error; end
+end

data/lib/lbank/memory_cache.rb

@@ -0,0 +1,21 @@
+class Lbank::MemoryCache
+  def initialize
+    @store = {}
+  end
+
+  def store(key, value)
+    @store[key] = value
+  end
+
+  def read(key)
+    @store[key]
+  end
+
+  def fetch(key, &block)
+    return self[key] if self[key]
+    self[key] = block.call
+  end
+
+  alias :[]= :store
+  alias :[] :read
+end

data/lib/lbank/version.rb

@@ -1,3 +1,3 @@
 module Lbank
-  VERSION = "0.0.3"
+  VERSION = '1.1.0'
 end

data/lib/lbank.rb

@@ -1,46 +1,69 @@
-require "lbank/version"
-require 'open-uri'
-require 'csv'
+require 'lbank/version'
+require 'lbank/memory_cache'
+require 'lbank/errors'
 require 'active_support/time'
+require 'faraday'
+require 'faraday_middleware'
+require 'bigdecimal'
 
 module Lbank
+  RATE_TYPE = 'LT'
+  TIMEZONE = 'Europe/Vilnius'
+  URL = 'http://www.lb.lt/webservices/FxRates/FxRates.asmx/getFxRates'
+  LTL = 'LTL'
+  LTL_RATE = BigDecimal('3.45280')
 
-  BASE_CURRENCY = 'LTL'
-  TIMEZONE      = 'Europe/Vilnius'
-  SOURCE        = 'http://lbank.lt/exchange/Results.asp'
+  module_function
 
-  @@cache       = {}
+  def cache
+    @cache ||= MemoryCache.new
+  end
+
+  def cache=(store)
+    @cache = store
+  end
 
-  def self.currency_rates(time = nil)
-    time      ||= Time.now
+  def currency_rates(time = nil)
+    time ||= Time.now
     bank_time = time.to_time.in_time_zone(TIMEZONE)
-    date      = [ bank_time.year, bank_time.month, bank_time.day ]
+    date = bank_time.strftime('%Y-%m-%d')
 
-    if @@cache[date].nil?
-      url   = "#{SOURCE}?Y=%i&M=%i&D=%i&S=csv" % date
-      rates = {}
+    cache.fetch(cache_key(date)) do
+      response = connection.post(URL, tp: RATE_TYPE, dt: date)
+      error = response.body['FxRates']['OprlErr']
 
-      data  = open(url).read
+      raise ResponseError.new(error['Desc']) if error
 
-      CSV.parse(data).each do |row|
-        rates[row[1]] = row[2].to_i / row[3].to_f
-      end
+      fx_rates = response.body['FxRates']['FxRate']
 
-      rates[BASE_CURRENCY] = 1.0
+      rates = { fx_rates[0]['CcyAmt'][0]['Ccy'] => 1 }
+      rates[LTL] ||= LTL_RATE
 
-      @@cache[date] = rates
+      fx_rates.each_with_object(rates) do |rate, result|
+        base, foreign = rate['CcyAmt']
+        result[foreign['Ccy']] = BigDecimal(foreign['Amt']) / BigDecimal(base['Amt'])
+      end
     end
-
-    @@cache[date]
   end
 
-  def self.convert_currency(amount, from_currency, to_currency,  date = nil)
-    rates     = self.currency_rates(date)
-
+  def convert_currency(amount, from_currency, to_currency, time = nil)
+    rates = currency_rates(time)
     from_rate = rates[from_currency.to_s]
-    to_rate   = rates[to_currency.to_s]
+    to_rate = rates[to_currency.to_s]
 
     amount / from_rate * to_rate
   end
 
+  def cache_key(date)
+    "lbank-#{date}"
+  end
+
+  def connection
+    @connection ||= Faraday.new do |builder|
+      builder.request :url_encoded
+      builder.response :raise_error
+      builder.response :xml, content_type: /\bxml$/
+      builder.adapter Faraday.default_adapter
+    end
+  end
 end

data/spec/lbank_spec.rb

@@ -1,28 +1,27 @@
 require 'spec_helper'
 
 describe Lbank do
+  let(:date) { Date.new(2012, 8, 4) }
 
-  it "should return currency rates" do
-    currency_rates = subject.currency_rates
+  describe '#currency_rates' do
+    subject { described_class.currency_rates(date) }
 
-    currency_rates['USD'].should be > 0
-  end
-
-  it "should convert currency" do
-    subject.convert_currency(10, 'LTL', 'EUR').should be > 0
+    its(['USD']) { is_expected.to be > 0 }
 
-    date = Date.new(2012, 8, 4)
+    context 'when invalid time' do
+      let(:date) { Time.now + 1.week }
 
-    round(subject.convert_currency(10, 'LTL', 'EUR', date)).should == 2.90
-    round(subject.convert_currency(10, 'LTL', 'USD', date)).should == 3.55
-    round(subject.convert_currency(100, 'RUB', 'LTL', date)).should == 8.68
-    round(subject.convert_currency(100, 'RUB', 'USD', date)).should == 3.08
+      it 'raises error' do
+        expect { subject }.to raise_error(Lbank::ResponseError, /No data/)
+      end
+    end
   end
 
-  private
-
-  def round(number, precision = 2)
-    ("%.#{precision}f" % number).to_f
+  describe '#convert_currency' do
+    it 'converts currency' do
+      expect(subject.convert_currency(10, 'EUR', 'LTL', date).round(2)).to eq 34.53
+      expect(subject.convert_currency(1, 'USD', 'EUR', date).round(2)).to eq 0.82
+      expect(subject.convert_currency(100, 'RUB', 'USD', date).round(2)).to eq 3.08
+    end
   end
-
-end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'rubygems'
 require 'bundler/setup'
+require 'rspec/its'
 require 'lbank'
 
 RSpec.configure do |config|

metadata

@@ -1,16 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: lbank
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Laurynas Butkus
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2012-08-04 00:00:00.000000000 Z
-dependencies: []
+date: 2025-02-22 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: faraday_middleware
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: multi_xml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
 description: lbank.lt currency rates fetcher and converter
 email:
 - laurynas.butkus@gmail.com
@@ -18,44 +101,46 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".github/workflows/main.yml"
+- ".github/workflows/publish.yml"
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lbank.gemspec
 - lib/lbank.rb
+- lib/lbank/errors.rb
+- lib/lbank/memory_cache.rb
 - lib/lbank/version.rb
 - spec/lbank_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/laurynas/lbank
 licenses: []
-post_install_message: 
+metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.24
-signing_key: 
-specification_version: 3
+rubygems_version: 3.5.16
+signing_key:
+specification_version: 4
 summary: Fetches currency rates from Lithuanian Central Bank website. Does currency
   conversion. Supports historic currency rates.
 test_files:
 - spec/lbank_spec.rb
 - spec/spec_helper.rb
-has_rdoc: