lazylead 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fde968b00a6b6868ea644d731c54d23d08f365b133926fa2cf13699e982a0802
-  data.tar.gz: 3340adabd89a6699cf0ba2fdc723ccc9e372d505b8b14b81cd7eef6c816c7fdc
+  metadata.gz: 81d974a6e2fd3b5417524a420005f1d12714fabab71ead5dd7c9fc6e04582981
+  data.tar.gz: a181d093106c36c8d57a47a802fd21bd2a7c0b9ce4bbf09622721ed648481c07
 SHA512:
-  metadata.gz: ecbf953aa53ae51b6ed4cc056794f3b8eb9e693d07cc3262070a95592546f9d45797f4ebdf4bbbacc650ad369033e9fd433e6d1975fd3f37688f5c7c3c321ee9
-  data.tar.gz: f2dae8c55b5b98ddca9fe769a007eb4ea40d6c2b52675fa47911bc924d9ad7b56453f1a4c3705275f2ba2840d9d662ffde58bd92c179ea2af5a2da5baf1b3156
+  metadata.gz: 82388742ae4f14b8012b034631beb488ecdef5632c189ffa45fc1cc1947992051eef45d4444a2bef7d950b71e7e634f1c1ab8a63be77e355596ec87a3879cfd4
+  data.tar.gz: c1d297f36c42b0e4676211c52da716d05cca80561706d2e38406076d4b5ccd83834f431919803fd576428dae1d422c95f79473c3643e95d1a54bbf8278ec9fbd

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.8.2"
+  s.version = "0.8.3"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.8.2!
+  s.post_install_message = "Thanks for installing Lazylead v0.8.3!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead
@@ -90,8 +90,8 @@ tasks instead of solving technical problems."
   s.add_development_dependency "rake", "13.0.3"
   s.add_development_dependency "random-port", "0.5.1"
   s.add_development_dependency "rdoc", "6.3.0"
-  s.add_development_dependency "rubocop", "1.12.0"
-  s.add_development_dependency "rubocop-minitest", "0.11.0"
+  s.add_development_dependency "rubocop", "1.12.1"
+  s.add_development_dependency "rubocop-minitest", "0.11.1"
   s.add_development_dependency "rubocop-performance", "1.10.2"
   s.add_development_dependency "rubocop-rake", "0.5.1"
   s.add_development_dependency "rubocop-rspec", "2.2.0"

data/lib/lazylead/task/accuracy/accuracy.rb

@@ -47,7 +47,7 @@ module Lazylead
         Requires.new(__dir__).load
         opts[:rules] = opts.construct("rules")
         opts[:total] = opts[:rules].sum(&:score)
-        opts[:tickets] = sys.issues(opts["jql"], opts.jira_defaults)
+        opts[:tickets] = sys.issues(opts["jql"], opts.jira_defaults.merge(expand: "changelog"))
                             .map { |i| Score.new(i, opts) }
                             .each(&:evaluate)
                             .each(&:post)
@@ -83,7 +83,7 @@ module Lazylead
     # The jira comment in markdown format
     def comment
       comment = [
-        "Hi [~#{@issue.reporter.id}],",
+        "Hi [~#{reporter}],",
         "",
         "The triage accuracy is '{color:#{color}}#{@score}{color}'" \
           " (~{color:#{color}}#{@accuracy}%{color}), here are the reasons why:",
@@ -133,5 +133,17 @@ module Lazylead
     def grade(value)
       (value / 10).floor * 10
     end
+
+    # Detect the ticket reporter.
+    #
+    # If ticket created by some automatic/admin user account then reporter is the first non-system
+    #  user account who modified the ticket.
+    def reporter
+      return @issue.reporter.id unless @opts.key? "system-users"
+      sys = @opts.slice("system-users", ",")
+      return @issue.reporter.id if sys.empty? || sys.none? { |susr| @issue.reporter.id.eql? susr }
+      @issue.history
+            .find { |h| sys.none? { |susr| susr.eql? h["author"]["key"] } }["author"]["key"]
+    end
   end
 end

data/lib/lazylead/task/accuracy/screenshots.rb

@@ -29,11 +29,12 @@ module Lazylead
   # Check that ticket has screenshot(s).
   # The screenshots should
   #  1. present as attachments
-  #  2. mentioned in description with !<name>.<extension>|thumbnail! (read more https://bit.ly/3rusNgW)
+  #  2. has extension .jpg .jpeg .exif .tiff .tff .bmp .png .svg
+  #  3. mentioned in description with !<name>.<extension>|thumbnail! (read more https://bit.ly/3rusNgW)
   #
   class Screenshots < Lazylead::Requirement
     # @param minimum The number of expected screenshots
-    def initialize(minimum: 2, score: 2, ext: %w[.jpg .jpeg .exif .tiff .tff .bmp .png .svg])
+    def initialize(minimum: 1, score: 2, ext: %w[.jpg .jpeg .exif .tiff .tff .bmp .png .svg])
       super "Screenshots", score, "Description,Attachments"
       @minimum = minimum
       @ext = ext
@@ -41,11 +42,19 @@ module Lazylead
 
     def passed(issue)
       return false if issue.attachments.nil? || blank?(issue, "description")
-      regexps = issue.attachments
-                     .select { |a| @ext.include? File.extname(a.filename) }
-                     .map { |a| /!#{a.filename}\|thumbnail!/ }
-      return false if regexps.size < @minimum
-      regexps.all? { |r| issue.description.match? r }
+      references = issue.description
+                        .to_enum(:scan, /!.+!/)
+                        .map { Regexp.last_match }
+                        .map(&:to_s)
+      return false if references.size < @minimum
+      references.all? { |ref| pictures(issue).any? { |file| ref.include? file } }
+    end
+
+    # Detect all pictures in ticket attachments and returns an array with file names.
+    def pictures(issue)
+      @pictures ||= issue.attachments
+                         .select { |a| @ext.include? File.extname(a.filename).downcase }
+                         .map(&:filename)
     end
   end
 end

data/lib/lazylead/version.rb

@@ -23,5 +23,5 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Lazylead
-  VERSION = "0.8.2"
+  VERSION = "0.8.3"
 end

data/test/lazylead/task/accuracy/score_test.rb

@@ -23,6 +23,7 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 require_relative "../../../test"
+require_relative "../../../../lib/lazylead/system/jira"
 require_relative "../../../../lib/lazylead/task/accuracy/accuracy"
 require_relative "../../../../lib/lazylead/task/accuracy/affected_build"
 
@@ -69,5 +70,15 @@ module Lazylead
                      )
                    ).evaluate.comment
     end
+
+    test "detect non-system reporter" do
+      assert_equal "grussell",
+                   Score.new(
+                     NoAuthJira.new("https://jira.spring.io")
+                               .issues("key=INT-4116", expand: "changelog")
+                               .first,
+                     Opts.new("system-users" => "abilan")
+                   ).reporter
+    end
   end
 end

data/test/lazylead/task/accuracy/screenshots_test.rb

@@ -51,13 +51,11 @@ module Lazylead
       )
     end
 
-    test "issue has only one .png file however minimum 2 are required" do
+    test "issue has no .png file however minimum 1 are required" do
       refute Screenshots.new.passed(
         OpenStruct.new(
-          description: "Hi,\n here are snapshots !img1.jpg|thumbnail!\n",
-          fields: {
-            "description" => "Hi,\n here are snapshots !img1.jpg|thumbnail!\n"
-          },
+          description: "Hi,\n here are snapshots !img1.zip!\n",
+          fields: { "description" => "Hi,\n here are snapshots !img1.zip!\n" },
           attachments: [
             OpenStruct.new("filename" => "img1.jpg"),
             OpenStruct.new("filename" => "img2.jpg")
@@ -80,5 +78,49 @@ module Lazylead
         )
       )
     end
+
+    test "issue has two .png file in description but three .png in attachments" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.JPG|thumbnail!\n!img2.jpg|thumbnail!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.JPG|thumbnail!\n!img2.jpg|thumbnail!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img1.JPG"),
+            OpenStruct.new("filename" => "img2.jpg"),
+            OpenStruct.new("filename" => "img3.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png files with reference in description without thumbnail" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n",
+          fields: { "description" => "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n" },
+          attachments: [
+            OpenStruct.new("filename" => "img1.jpg"),
+            OpenStruct.new("filename" => "img2.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png files with reference in description but absent in attachments" do
+      refute Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img3.jpg"),
+            OpenStruct.new("filename" => "img4.jpg")
+          ]
+        )
+      )
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lazylead
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Yurii Dubinka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-28 00:00:00.000000000 Z
+date: 2021-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -506,28 +506,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.12.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.12.1
 - !ruby/object:Gem::Dependency
   name: rubocop-minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.11.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -783,7 +783,7 @@ licenses:
 - MIT
 metadata: {}
 post_install_message: |-
-  Thanks for installing Lazylead v0.8.2!
+  Thanks for installing Lazylead v0.8.3!
     Read our blog posts: https://lazylead.org
     Stay in touch with the community in Telegram: https://t.me/lazylead
     Follow us on Twitter: https://twitter.com/lazylead