lazylead 0.8.1 → 0.9.2

data/lib/lazylead/task/loading.rb

@@ -36,7 +36,7 @@ module Lazylead
       end
 
       def run(sys, postman, opts)
-        assignments = sys.issues(opts["jql"])
+        assignments = sys.issues(opts["jql"], opts.jira_defaults)
                          .group_by(&:assignee)
                          .map { |user, tasks| [user.id, Teammate.new(user, tasks)] }
                          .to_h
@@ -71,6 +71,11 @@ module Lazylead
       def to_s
         "#{id} has #{total} tasks"
       end
+
+      def sprints(*label)
+        return @tasks.group_by(&:sprint).sort if label.empty? || label.nil?
+        @tasks.group_by { |t| t.sprint(label) }.sort
+      end
     end
 
     # The teammate without tasks.

data/lib/lazylead/task/micromanager.rb

@@ -0,0 +1,111 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require "date"
+require_relative "../log"
+require_relative "../opts"
+require_relative "../system/jira"
+
+module Lazylead
+  module Task
+    #
+    # Email alerts about due date modification by not-authorized persons.
+    #
+    # Author:: Yurii Dubinka (yurii.dubinka@gmail.com)
+    # Copyright:: Copyright (c) 2019-2020 Yurii Dubinka
+    # License:: MIT
+    class Micromanager
+      def initialize(log = Log.new)
+        @log = log
+      end
+
+      def run(sys, postman, opts)
+        allowed = opts.slice "allowed", ","
+        dues = sys.issues(opts["jql"], opts.jira_defaults.merge(expand: "changelog"))
+                  .map { |i| Due.new(i, allowed, since(opts)) }
+                  .select(&:illegal?)
+                  .reject(&:obsolete?)
+        return if dues.empty?
+        postman.send opts.merge(dues: dues)
+      end
+
+      # Detect history period where search should start.
+      #
+      # opts["period"] The default period for past is 1 day (86400 seconds).
+      #                So, if now 2017-04-06 15:50:58.674+0000
+      #                it returns 2017-04-05 15:50:58 +0000
+      #
+      # opts["now"]    The current time for unit tests.
+      #                If absent the "Time.now" is used.
+      #
+      def since(opts)
+        @since ||= if opts.key? "now"
+                     Time.parse(opts["now"])
+                   else
+                     Time.now - opts.fetch("period", "86400").to_i
+                   end
+      end
+    end
+
+    # Instance of "Due" history item for the particular ticket.
+    class Due
+      attr_reader :issue, :when
+
+      def initialize(issue, allowed, since)
+        @issue = issue
+        @allowed = allowed
+        @since = since
+      end
+
+      # Gives true when last change of "Due Date" field was done
+      #  by not authorized person.
+      def illegal?
+        return false if @issue.assignee.id.eql?(last.id)
+        @allowed.none? { |a| a.eql? last.id }
+      end
+
+      # Give true when "Due Date" changes happens in past and its alert already sent.
+      def obsolete?
+        @when < @since
+      end
+
+      # Detect details about last change of "Due Date" to non-null value
+      def last
+        @last ||= begin
+          dd = @issue.history
+                     .reverse
+                     .find { |h| h["items"].any? { |i| i["field"] == "duedate" } }
+          if dd.nil? && !@issue.duedate.nil?
+            @when = @issue["created"]
+            dd = @issue.reporter
+          else
+            @when = dd["created"]
+            dd = Lazylead::User.new(dd["author"])
+          end
+          dd
+        end
+      end
+    end
+  end
+end

data/lib/lazylead/task/svn/diff.rb

@@ -22,6 +22,7 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
+require "zip"
 require "tempfile"
 require "nokogiri"
 require "backtrace"
@@ -49,6 +50,7 @@ module Lazylead
             "-r#{opts['since_rev']}:HEAD #{opts['svn_url']}"
           ]
           stdout = `#{cmd.join(" ")}`
+          stdout.scrub!
           send_email postman, opts.merge(stdout: stdout) unless stdout.blank?
         end
 
@@ -58,19 +60,39 @@ module Lazylead
         def send_email(postman, opts)
           Dir.mktmpdir do |dir|
             name = "svn-log-#{Date.today.strftime('%d-%b-%Y')}.html"
-            f = File.open(File.join(dir, name), "w")
             begin
-              f.write opts.msg_body("template-attachment")
-              f.close
-              postman.send opts.merge(attachments: [f.path])
+              postman.send opts.merge(attachments: [to_f(File.join(dir, name), opts)])
             ensure
-              File.delete(f)
+              FileUtils.rm_rf("#{dir}/*")
             end
           rescue StandardError => e
             @log.error "ll-010: Can't send an email '#{opts['subject']}' to #{opts['to']} due to " \
                        "#{Backtrace.new(e)}'"
           end
         end
+
+        # Wrap attachment content to a *.zip file and archive.
+        #   to_f('my-content.html', opts)   => my-content.html.zip
+        #
+        # You may disable archiving option by passing option *no_archive*
+        #   to_f('my-content.html', "no_archive" => true)
+        def to_f(path, opts)
+          if opts.key? "no_archive"
+            f = File.open(path, "w")
+            body = opts.msg_body("template-attachment")
+          else
+            f = File.new("#{path}.zip", "wb")
+            bytes = Zip::OutputStream.write_buffer do |zio|
+              zio.put_next_entry(File.basename(path))
+              zio.write opts.msg_body("template-attachment")
+            end
+            bytes.rewind # reposition buffer pointer to the beginning
+            body = bytes.sysread
+          end
+          f.write body
+          f.close
+          f.path
+        end
       end
     end
   end

data/lib/lazylead/version.rb

@@ -23,5 +23,5 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Lazylead
-  VERSION = "0.8.1"
+  VERSION = "0.9.2"
 end

data/lib/messages/illegal_duedate_change.erb

@@ -0,0 +1,122 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+  <style>
+    /* CSS styles taken from https://github.com/yegor256/tacit */
+    th {
+      font-weight: 600
+    }
+
+    table tr {
+      border-bottom-width: 2.16px
+    }
+
+    table tr th {
+      border-bottom-width: 2.16px
+    }
+
+    table tr td, table tr th {
+      overflow: hidden;
+      padding: 5.4px 3.6px
+    }
+
+    a {
+      color: #275a90;
+      text-decoration: none
+    }
+
+    a:hover {
+      text-decoration: underline
+    }
+
+    pre, code, kbd, samp, var, output {
+      font-family: Menlo, Monaco, Consolas, "Courier New", monospace;
+      font-size: 13px
+    }
+
+    pre code {
+      background: none;
+      border: 0;
+      line-height: 29.7px;
+      padding: 0
+    }
+
+    code, kbd {
+      background: #daf1e0;
+      border-radius: 3.6px;
+      color: #2a6f3b;
+      display: inline-block;
+      line-height: 18px;
+      padding: 3.6px 6.3px 2.7px
+    }
+
+    * {
+      border: 0;
+      border-collapse: separate;
+      border-spacing: 0;
+      box-sizing: border-box;
+      margin: 0;
+      max-width: 100%;
+      padding: 0;
+      vertical-align: baseline;
+      font-family: system-ui, "Helvetica Neue", Helvetica, Arial, sans-serif;
+      font-size: 13px;
+      font-stretch: normal;
+      font-style: normal;
+      font-weight: 400;
+      line-height: 29.7px
+    }
+
+    html, body {
+      width: 100%
+    }
+
+    html {
+      height: 100%
+    }
+
+    body {
+      background: #fff;
+      color: #1a1919;
+      padding: 36px
+    }
+  </style>
+  <title>Not authorized "Assignee" change</title>
+</head>
+<body>
+<p>Hi,</p>
+
+<p>The <span style='font-weight:bold'>'Duedate'</span> for the following
+  ticket(s) changed by not authorized person(s):</p>
+<table summary="ticket(s) where duedate changed">
+  <tr>
+    <th id="key">Key</th>
+    <th id="priority">Priority</th>
+    <th id="when">When</th>
+    <th id="who">Who</th>
+    <th id="to">To</th>
+    <th id="assignee">Assignee</th>
+    <th id="reporter">Reporter</th>
+    <th id="summary">Summary</th>
+  </tr>
+  <% dues.each do |d| %>
+    <tr>
+      <td><a href='<%= d.issue.url %>'><%= d.issue.key %></a></td>
+      <td><%= d.issue.priority %></td>
+      <td><%= d.when.to_date %></td>
+      <td><span style='color: red'><%= d.last.name %></span> (<%= d.last.id %>)</td>
+      <td><span style='color: red'><%= d.issue.duedate %></span></td>
+      <td><%= d.issue.assignee.name %></td>
+      <td><%= d.issue.reporter.name %></td>
+      <td><%= d.issue.summary %></td>
+    </tr>
+  <% end %>
+</table>
+
+<p>Authorized person(s) are: <code><%= allowed %></code>.</p>
+
+<p>Posted by
+  <a href="https://github.com/dgroup/lazylead">lazylead v<%= version %></a>.
+</p>
+</body>
+</html>

data/lib/messages/loading.erb

@@ -69,10 +69,9 @@
 <body>
 <table summary="tickets">
   <tr>
-    <th id="uid">ID</th>
     <th id="name">User</th>
     <th id="total">
-      <a href="https://jira.spring.io/issues/?jql=<%= CGI.escape(jql) %>">Assigned From</a>
+      <a href="<%= search_link %><%= CGI.escape(jql) %>">Assigned From</a>
     </th>
     <th id="duedate">Next Due date</th>
   </tr>
@@ -83,17 +82,19 @@
       <tr>
     <% end %>
     <td>
-      <div class="auto"><a href="<%= user_link %>"><%= teammate %></a></div>
-    </td>
-    <td>
-      <div class="auto"><%= assignment.name %></div>
+      <div class="auto"><a href="<%= user_link %><%= teammate %>"><%= assignment.name %></a></div>
     </td>
     <td>
       <div class="auto">
         <% if assignment.free? %>
           <span style="color: red">0</span>
         <% else %>
-          <a href="https://jira.spring.io/issues/?jql=<%= CGI.escape("#{jql} and assignee=#{teammate}") %>"><%= assignment.size %></a>
+          <% assignment.sprints(defined?(sprint) ? sprint : "customfield_10480").each do |s| %>
+            <a href="<%= search_link %><%= CGI.escape("#{jql} and assignee=#{teammate}") %>">
+              <%= s.first.blank? ? "No sprint" : s.first %>: <%= s.last.size %>
+            </a>
+            <br/>
+          <% end %>
         <% end %>
       </div>
     </td>

data/readme.md

@@ -48,13 +48,15 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 | Create a meeting(s) automatically in case some tickets appeared (group by assignee/reporters/component/ticket type/etc) | ⌛ | ⌛ | ⌛ | ❌ | 
 | Propogate fields from parent tickets to sub-tasks | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets without comments with expected text | ✅ | ⌛ | ⌛ | ❌ | 
-| Notify about team loading (no tasks on teammates) | ✅ | ⌛ | ⌛ | ❌ | 
+| [Notify about team loading (no tasks on teammates)](lib/lazylead/task/loading.rb) | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets matches predefined multiple conditions | ✅ | ⌛ | ⌛ | ❌ | 
 | Link automatically the ticket and Confluence page if link found in ticket's comments/description | ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about tickets assigned to your team members not by effective managers| ✅ | ⌛ | ⌛ | ❌ | 
 | Notify about modifications of important files in VCS | ❌ | ⌛ | ❌ | ✅ | 
 | Notify about diff changes for past X period in VCS | ❌ | ⌛ | ❌ | ✅ | 
 | Notify about changes with some text for past X period in VCS | ❌ | ⌛ | ❌ | ✅ | 
+| [Notify when someone outside of your team changed the due date on tickets for your team](lib/lazylead/task/micromanager.rb)| ✅ | ⌛ | ❌ | ❌ | 
+| [Notify when someone outside of your team assigned a ticket directly to the developer](lib/lazylead/task/assignment.rb)| ✅ | ⌛ | ❌ | ❌ | 
 
 | Integration                                           | Type          | Status |
 | :---------------------------------------------------- | :-----------: | :----: |
@@ -65,7 +67,7 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 | calendar.google.com                                   | Calendar      | ⌛ |
 | slack.com                                             | Notifications | ⌛ |
 
-✅ - implemented, ⌛ - planned, 🌵 - implemented, but not tested, ❌ - not supported by ticketing system.
+✅ - implemented, ⌛ - planned, 🌵 - implemented, but not tested, ❌ - not supported/planned.
 
 New ideas, bugs, suggestions or questions are welcome [via GitHub issues](https://github.com/dgroup/lazylead/issues/new)!
 

data/test/lazylead/task/accuracy/score_test.rb

@@ -23,6 +23,7 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 require_relative "../../../test"
+require_relative "../../../../lib/lazylead/system/jira"
 require_relative "../../../../lib/lazylead/task/accuracy/accuracy"
 require_relative "../../../../lib/lazylead/task/accuracy/affected_build"
 
@@ -69,5 +70,15 @@ module Lazylead
                      )
                    ).evaluate.comment
     end
+
+    test "detect non-system reporter" do
+      assert_equal "grussell",
+                   Score.new(
+                     NoAuthJira.new("https://jira.spring.io")
+                               .issues("key=INT-4116", expand: "changelog")
+                               .first,
+                     Opts.new("system-users" => "abilan")
+                   ).reporter
+    end
   end
 end

data/test/lazylead/task/accuracy/screenshots_test.rb

@@ -0,0 +1,140 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../../test"
+require_relative "../../../../lib/lazylead/task/accuracy/screenshots"
+require_relative "../../../../lib/lazylead/system/jira"
+
+module Lazylead
+  class ScreenshotsTest < Lazylead::Test
+    test "issue has two .png files with reference in description" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img1.jpg"),
+            OpenStruct.new("filename" => "img2.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has several .png attachments mentioned using !xxx|thumbnail! option" do
+      assert Screenshots.new.passed(
+        NoAuthJira.new("https://jira.spring.io")
+                  .issues("key=SPR-15729", fields: %w[attachment description])
+                  .first
+      )
+    end
+
+    test "issue has no .png file however minimum 1 are required" do
+      refute Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.zip!\n",
+          fields: { "description" => "Hi,\n here are snapshots !img1.zip!\n" },
+          attachments: [
+            OpenStruct.new("filename" => "img1.jpg"),
+            OpenStruct.new("filename" => "img2.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png files with reference in description but with extension mismatch" do
+      refute Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.jpg|thumbnail!\n!img2.jpg|thumbnail!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img1.JPG"),
+            OpenStruct.new("filename" => "img2.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png file in description but three .png in attachments" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.JPG|thumbnail!\n!img2.jpg|thumbnail!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.JPG|thumbnail!\n!img2.jpg|thumbnail!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img1.JPG"),
+            OpenStruct.new("filename" => "img2.jpg"),
+            OpenStruct.new("filename" => "img3.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png files with reference in description without thumbnail" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n",
+          fields: { "description" => "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n" },
+          attachments: [
+            OpenStruct.new("filename" => "img1.jpg"),
+            OpenStruct.new("filename" => "img2.jpg")
+          ]
+        )
+      )
+    end
+
+    test "issue has two .png files with reference in description but absent in attachments" do
+      refute Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n",
+          fields: {
+            "description" => "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n"
+          },
+          attachments: [
+            OpenStruct.new("filename" => "img3.jpg"),
+            OpenStruct.new("filename" => "img4.jpg")
+          ]
+        )
+      )
+    end
+
+    test "two screenshots with docx attach" do
+      assert Screenshots.new.passed(
+        OpenStruct.new(
+          description: "Hi,\n here are snapshots !img1.jpg!\n!img2.jpg!\n[example.docx^!https://jira.com/images/icons/link_attachment_5.gif|width=7,height=7! ^|https://jira.com/secure/attachment/23/23_example.docx]",
+          fields: { "description" => "-" },
+          attachments: [
+            OpenStruct.new("filename" => "img1.jpg"),
+            OpenStruct.new("filename" => "img2.jpg"),
+            OpenStruct.new("filename" => "example.docx")
+          ]
+        )
+      )
+    end
+  end
+end