lazylead 0.8.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 422600b27880dd0aa96889f7fb8e2f55dc371ac8638dc7065d5e57bc8556aece
-  data.tar.gz: 4c8fd293522b890072ef45af8fbefe5cce59594023a38e12ef275e5ef3453d90
+  metadata.gz: 2cbd092ef55bfdcf7887c4e0fcf5e5838a70b91eac82011893dc9423b22a0b74
+  data.tar.gz: 5d71b27626fbf5e9d60ea38cce1e06ab6637aa874daa057ff9b9f8451b095dbf
 SHA512:
-  metadata.gz: 59932534b571e92e9c8877d365292de759081444ac629c7d59d9b09897519ca19043d6886afc45291df327af3e4eec2524e0019e159ad0564e270eeceb0cad8f
-  data.tar.gz: cd6cdbe78ca38b738005fc91184e7fe4390276fcde446da0180f009d406d081cceb5e617ab62a76d9417559b071972d603a1b4adfbe4a70fba98b482d8f84ebf
+  metadata.gz: 748f97ab75655642143bd13d562aab38693df3f6496429d794e75f4c6bb9f0315537ad656027f639a9481ed0399345b3cef0f9ebcd83af680c69f5cf3be6380d
+  data.tar.gz: ea40e803198075657c05df31b251599aac4dbb55bf628a01e1d68bcffeedd09c713ca9d0858d153301ab88f518e5ab50a1486fbc58be3801e5a57264611d915c

data/.docker/docker-compose.yml

@@ -20,4 +20,4 @@ services:
     volumes:
       - .local/dumps:/lazylead/dumps
       - .local/logs:/lazylead/logs
-    entrypoint: bin/lazylead --trace --verbose
+    entrypoint: bin/lazylead --trace --verbose --log-file /lazylead/logs/ll{{.%Y-%m-%dT%H:%M:%S}}.log

data/.rubocop.yml

@@ -3,6 +3,7 @@ require:
   - rubocop-performance
 
 AllCops:
+  NewCops: enable
   DisplayCopNames: true
   DisplayStyleGuide: true
   TargetRubyVersion: 2.6
@@ -14,6 +15,7 @@ Layout/LineLength:
   Exclude:
     - "*.gemspec"
     - "test/**/*"
+    - "bin/lazylead"
 
 Metrics/AbcSize:
   Max: 21

data/Rakefile

@@ -45,7 +45,7 @@ def version
   Gem::Specification.load(Dir["*.gemspec"].first).version
 end
 
-task default: %i[clean test rubocop sqlint xcop copyright docker]
+task default: %i[clean rubocop test sqlint xcop copyright docker]
 
 require "rake/testtask"
 desc "Run all unit tests"

data/bin/lazylead

@@ -70,6 +70,9 @@ Available options:"
   o.bool "--testdata",
          "Apply the database VCS migration with test data",
          default: false
+  o.string "--log-file", "The path to the log file"
+  o.string "--rolling-age", "The maximum age (in seconds) of a log file before it is rolled. The age can also be given as 'daily', 'weekly', or 'monthly'"
+  o.string "--rolling-files", "The number of rolled log files to keep."
   o.on "--verbose", "Enable extra logging information" do
     log.verbose
   end

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.8.0"
+  s.version = "0.9.1"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.8.0!
+  s.post_install_message = "Thanks for installing Lazylead v0.9.1!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead
@@ -58,7 +58,7 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "activerecord", "6.1.3"
   s.add_runtime_dependency "backtrace", "0.3"
   s.add_runtime_dependency "colorize", "0.8.1"
-  s.add_runtime_dependency "faraday", "1.3.0"
+  s.add_runtime_dependency "faraday", "1.4.1"
   s.add_runtime_dependency "get_process_mem", "0.2.7"
   s.add_runtime_dependency "inifile", "3.0.0"
   s.add_runtime_dependency "jira-ruby", "2.1.5"
@@ -69,6 +69,7 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "openssl", "2.1.2"
   s.add_runtime_dependency "railties", "6.1.3"
   s.add_runtime_dependency "require_all", "3.0.0"
+  s.add_runtime_dependency "rubyzip", "2.3.0"
   s.add_runtime_dependency "rufus-scheduler", "3.7.0"
   s.add_runtime_dependency "slop", "4.8.2"
   s.add_runtime_dependency "sqlite3", "1.4.2"
@@ -78,7 +79,7 @@ tasks instead of solving technical problems."
   s.add_runtime_dependency "tzinfo-data", "1.2021.1"
   s.add_runtime_dependency "vcs4sql", "0.1.1"
   s.add_runtime_dependency "viewpoint", "1.1.1"
-  s.add_development_dependency "codecov", "0.5.1"
+  s.add_development_dependency "codecov", "0.5.2"
   s.add_development_dependency "guard", "2.16.2"
   s.add_development_dependency "guard-minitest", "2.4.6"
   s.add_development_dependency "minitest", "5.14.4"
@@ -89,12 +90,12 @@ tasks instead of solving technical problems."
   s.add_development_dependency "rake", "13.0.3"
   s.add_development_dependency "random-port", "0.5.1"
   s.add_development_dependency "rdoc", "6.3.0"
-  s.add_development_dependency "rubocop", "1.11.0"
-  s.add_development_dependency "rubocop-minitest", "0.10.3"
-  s.add_development_dependency "rubocop-performance", "1.10.1"
+  s.add_development_dependency "rubocop", "1.13.0"
+  s.add_development_dependency "rubocop-minitest", "0.12.1"
+  s.add_development_dependency "rubocop-performance", "1.11.0"
   s.add_development_dependency "rubocop-rake", "0.5.1"
-  s.add_development_dependency "rubocop-rspec", "2.2.0"
-  s.add_development_dependency "sqlint", "0.1.10"
+  s.add_development_dependency "rubocop-rspec", "2.3.0"
+  s.add_development_dependency "sqlint", "0.2.0"
   s.add_development_dependency "tempfile", "0.1.1"
   s.add_development_dependency "xcop", "0.6.2"
 end

data/lib/lazylead/cc.rb

@@ -80,13 +80,11 @@ module Lazylead
     end
 
     def cc
-      @cc ||= begin
-        if @text.include? ","
-          @text.split(",").map(&:strip).select { |e| e[@regxp] }
-        elsif @text[@regxp]
-          [@text.strip]
-        end
-      end
+      @cc ||= if @text.include? ","
+                @text.split(",").map(&:strip).select { |e| e[@regxp] }
+              elsif @text[@regxp]
+                [@text.strip]
+              end
     end
 
     def each(&block)
@@ -125,15 +123,13 @@ module Lazylead
     end
 
     def to_h
-      @to_h ||= begin
-        if @orig.is_a? Hash
-          @orig.each_with_object({}) do |i, o|
-            o[i.first] = Lazylead::PlainCC.new(i.last).cc
-          end
-        else
-          {}
-        end
-      end
+      @to_h ||= if @orig.is_a? Hash
+                  @orig.each_with_object({}) do |i, o|
+                    o[i.first] = Lazylead::PlainCC.new(i.last).cc
+                  end
+                else
+                  {}
+                end
     end
   end
 
@@ -151,12 +147,10 @@ module Lazylead
     end
 
     def to_h
-      @to_h ||= begin
-        components.each_with_object({}) do |c, h|
-          email = lead(c.attrs["id"])
-          next if email.nil? || email.blank?
-          h[c.attrs["name"]] = email
-        end
+      @to_h ||= components.each_with_object({}) do |c, h|
+        email = lead(c.attrs["id"])
+        next if email.nil? || email.blank?
+        h[c.attrs["name"]] = email
       end
     end
 

data/lib/lazylead/log.rb

@@ -74,6 +74,15 @@ module Lazylead
       )
     )
 
+    if ARGV.include? "--log-file"
+      name = ARGV[ARGV.find_index("--log-file") + 1]
+      age = "daily"
+      age = ARGV[ARGV.find_index("--rolling-age") + 1] if ARGV.include? "--rolling-age"
+      files = 7
+      files = ARGV[ARGV.find_index("--rolling-files") + 1] if ARGV.include? "--rolling-files"
+      FILE_APPENDER = Logging.appenders.rolling_file("file", filename: name, age: age, keep: files)
+    end
+
     # Nothing to log
     NOTHING = Logging.logger["nothing"]
     NOTHING.level = :off
@@ -83,12 +92,14 @@ module Lazylead
     DEBUG = Logging.logger["debug"]
     DEBUG.level = :debug
     DEBUG.add_appenders "stdout"
+    DEBUG.add_appenders(FILE_APPENDER) if ARGV.include? "--log-file"
     DEBUG.freeze
 
     # Alerts/errors
     ERRORS = Logging.logger["errors"]
     ERRORS.level = :error
     ERRORS.add_appenders "stdout"
+    ERRORS.add_appenders(FILE_APPENDER) if ARGV.include? "--log-file"
     ERRORS.freeze
   end
 end

data/lib/lazylead/model.rb

@@ -135,13 +135,11 @@ module Lazylead
       end
 
       def props
-        @props ||= begin
-          if team.nil?
-            Opts.new(env(to_hash))
-          else
-            Opts.new(env(team.to_hash.merge(to_hash)))
-          end
-        end
+        @props ||= if team.nil?
+                     Opts.new(env(to_hash))
+                   else
+                     Opts.new(env(team.to_hash.merge(to_hash)))
+                   end
       end
 
       def postman

data/lib/lazylead/system/jira.rb

@@ -26,6 +26,7 @@ require "jira-ruby"
 require "forwardable"
 require_relative "../salt"
 require_relative "../opts"
+require_relative "../log"
 
 module Lazylead
   # Jira system for manipulation with issues.
@@ -128,11 +129,7 @@ module Lazylead
     end
 
     def to_s
-      inspect
-    end
-
-    def inspect
-      "#{@opts['site']} (#{@opts['username']})"
+      "#{name} (#{id})"
     end
   end
 
@@ -256,13 +253,20 @@ module Lazylead
 
     # Update the labels for a particular issue
     def labels!(lbl)
-      return if lbl.nil? || lbl.empty?
-      save!("fields" => { "labels" => lbl.uniq })
+      save!("fields" => { "labels" => lbl.uniq }) unless lbl.empty?
     end
 
     def save!(opts)
       @issue.save(opts)
     end
+
+    def sprint(field = "customfield_10480")
+      @sprint ||= if fields[field].nil? || fields[field].empty?
+                    ""
+                  else
+                    fields[field].first.split(",").find { |text| text.starts_with? "name=" }[5..]
+                  end
+    end
   end
 
   # The jira issue comments

data/lib/lazylead/task/accuracy/accuracy.rb

@@ -47,7 +47,7 @@ module Lazylead
         Requires.new(__dir__).load
         opts[:rules] = opts.construct("rules")
         opts[:total] = opts[:rules].sum(&:score)
-        opts[:tickets] = sys.issues(opts["jql"], opts.jira_defaults)
+        opts[:tickets] = sys.issues(opts["jql"], opts.jira_defaults.merge(expand: "changelog"))
                             .map { |i| Score.new(i, opts) }
                             .each(&:evaluate)
                             .each(&:post)
@@ -58,7 +58,7 @@ module Lazylead
 
   # The ticket score based on fields content.
   class Score
-    attr_reader :issue, :total, :score, :accuracy
+    attr_reader :issue, :score, :accuracy
 
     def initialize(issue, opts)
       @issue = issue
@@ -70,6 +70,7 @@ module Lazylead
     def evaluate(digits = 2)
       @score = @opts[:rules].select { |r| r.passed(@issue) }.sum(&:score)
       @accuracy = (score / @opts[:total] * 100).round(digits)
+      self
     end
 
     # Post the comment with score and accuracy to the ticket.
@@ -82,13 +83,13 @@ module Lazylead
     # The jira comment in markdown format
     def comment
       comment = [
-        "Hi [~#{@issue.reporter.id}],",
+        "Hi [~#{reporter}],",
         "",
         "The triage accuracy is '{color:#{color}}#{@score}{color}'" \
           " (~{color:#{color}}#{@accuracy}%{color}), here are the reasons why:",
         "|| Ticket requirement || Status || Field ||"
       ]
-      @rules.each do |r|
+      @opts[:rules].each do |r|
         comment << "|#{r.desc}|#{r.passed(@issue) ? '(/)' : '(-)'}|#{r.field}|"
       end
       comment << docs_link
@@ -117,13 +118,11 @@ module Lazylead
     end
 
     def colors
-      @colors ||= begin
-        JSON.parse(@opts["colors"])
-            .to_h
-            .to_a
-            .each { |e| e[0] = e[0].to_i }
-            .sort_by { |e| e[0] }
-      end
+      @colors ||= JSON.parse(@opts["colors"])
+                      .to_h
+                      .to_a
+                      .each { |e| e[0] = e[0].to_i }
+                      .sort_by { |e| e[0] }
     end
 
     # Calculate grade for accuracy
@@ -134,5 +133,17 @@ module Lazylead
     def grade(value)
       (value / 10).floor * 10
     end
+
+    # Detect the ticket reporter.
+    #
+    # If ticket created by some automatic/admin user account then reporter is the first non-system
+    #  user account who modified the ticket.
+    def reporter
+      sys = @opts.slice("system-users", ",")
+      return @issue.reporter.id if sys.empty? || sys.none? { |susr| susr.eql? @issue.reporter.id }
+      first = @issue.history.find { |h| sys.none? { |susr| susr.eql? h["author"]["key"] } }
+      return @issue.reporter.id if first.nil?
+      first["author"]["key"]
+    end
   end
 end

data/lib/lazylead/task/accuracy/onlyll.rb

@@ -94,13 +94,11 @@ module Lazylead
 
     # Detect the percentage grid for tickets, by default its 0%, 10%, 20%, etc.
     def grid
-      @grid ||= begin
-        if @opts.key? "grid"
-          @opts.slice("grid", ",")
-        else
-          %w[0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%]
-        end
-      end
+      @grid ||= if @opts.key? "grid"
+                  @opts.slice("grid", ",")
+                else
+                  %w[0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%]
+                end
     end
 
     # Remove score labels from the ticket.

data/lib/lazylead/task/accuracy/screenshots.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2021 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "requirement"
+
+module Lazylead
+  #
+  # Check that ticket has screenshot(s).
+  # The screenshots should
+  #  1. present as attachments
+  #  2. has extension .jpg .jpeg .exif .tiff .tff .bmp .png .svg
+  #  3. mentioned in description with !<name>.<extension>|thumbnail! (read more https://bit.ly/3rusNgW)
+  #
+  class Screenshots < Lazylead::Requirement
+    # @param minimum The number of expected screenshots
+    def initialize(minimum: 1, score: 2, ext: %w[.jpg .jpeg .exif .tiff .tff .bmp .png .svg])
+      super "Screenshots", score, "Description,Attachments"
+      @minimum = minimum
+      @ext = ext
+    end
+
+    def passed(issue)
+      return false if issue.attachments.nil? || blank?(issue, "description")
+      ref = references(issue)
+      ref.size < @minimum ? false : ref.all? { |r| pictures(issue).any? { |file| r.include? file } }
+    end
+
+    # Detect all references in ticket description to attachments (including web links).
+    def references(issue)
+      issue.description
+           .to_enum(:scan, /!.+!/)
+           .map { Regexp.last_match }
+           .map(&:to_s)
+           .reject { |r| r.match?(%r{(http|https)://.*/images/icons/link_attachment.*.gif}) }
+    end
+
+    # Detect all pictures in ticket attachments and returns an array with file names.
+    def pictures(issue)
+      @pictures ||= issue.attachments
+                         .select { |a| @ext.include? File.extname(a.filename).downcase }
+                         .map(&:filename)
+    end
+  end
+end

data/lib/lazylead/task/assignment.rb

@@ -43,14 +43,12 @@ module Lazylead
       def run(sys, postman, opts)
         allowed = opts.slice "allowed", ","
         silent = opts.key? "silent"
-        issues = sys.issues opts["jql"],
-                            opts.jira_defaults.merge(expand: "changelog")
-        return if issues.empty?
-        postman.send opts.merge(
-          assignees: issues.map { |i| Assignee.new(i, allowed, silent) }
-                           .select(&:illegal?)
-                           .each(&:add_label)
-        )
+        assignees = sys.issues(opts["jql"], opts.jira_defaults.merge(expand: "changelog"))
+                       .map { |i| Assignee.new(i, allowed, silent) }
+                       .select(&:illegal?)
+                       .each(&:add_label)
+        return if assignees.empty?
+        postman.send opts.merge(assignees: assignees)
       end
     end
 
@@ -67,10 +65,8 @@ module Lazylead
       # Gives true when last change of "Assignee" field was done
       #  by not authorized person.
       def illegal?
-        @allowed.none? do |a|
-          return false if last.nil?
-          a == last["author"]["name"]
-        end
+        return false if last.nil? || @issue.assignee.id.eql?(last["author"]["name"])
+        @allowed.none? { |a| a.eql? last["author"]["name"] }
       end
 
       # Detect details about last change of "Assignee" to non-null value
@@ -89,7 +85,7 @@ module Lazylead
 
       # The name of current assignee for ticket
       def to
-        @issue.fields["assignee"]["name"]
+        @issue.fields["assignee"]["displayName"]
       end
     end
   end