lazylead 0.6.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 669da4d2f993894e78fcd42508429667cb29afe9082012c8dadee88e77dc0518
-  data.tar.gz: '0976452e6d5aaf5e282f468f05620915e73ee5cb2566ff9e4441d094d4f3dc3f'
+  metadata.gz: e5a5b0412fc9cb5796b066940c57e50785b64920718a09ecd4ef8794fc8b3908
+  data.tar.gz: 148b21d628c91d27abee8fb1bb86aeaf78cfdc96b01f9cbed16c9f4f8b5c7ef3
 SHA512:
-  metadata.gz: ec9719d37253c81db0d59d6d3f216e8d677a8d3a4543776409782236c01428fe97a07e3c58e95150c031506d894a8188b2ce551a2ffa79c4b364edf60774ad8a
-  data.tar.gz: 57662e5ba79d877e4b7310f0ff20fa767e6b4246ba46f7ffd30afeee86215f311dffeb2e947a86c867b3554ac20b1711b1d69edbd493e971c01d170fccd85aed
+  metadata.gz: 58539cbff1ccdc9c392aaa67af4e6dc0ade92311cbf2118202392b069de15f3872f833d2081b59d97439029901b569fe72e6a54e22ddfe011c06cddef576b6e2
+  data.tar.gz: 658f24b1dde5272d17c6cdd77f570f71de818f83a7acda9c5b3cdebf497f514e7f890862963caa49e577f2c566829be7d247bee1e236ec1248cdf0fbc4a58de2

data/.rubocop.yml

@@ -16,10 +16,13 @@ Layout/LineLength:
     - "test/**/*"
 
 Metrics/AbcSize:
-  Max: 20
+  Max: 21
   Exclude:
     - "test/**/*"
 
+Metrics/CyclomaticComplexity:
+  Max: 8
+
 Metrics/BlockLength:
   Exclude:
     - "*.gemspec"
@@ -91,3 +94,48 @@ Lint/StructNewOverride:
 
 # @todo #/DEV Add violation regarding methods without documentation using RDoc
 #  https://stackoverflow.com/questions/1681467/how-to-document-ruby-code
+
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: true

data/.simplecov

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
   [SimpleCov::Formatter::HTMLFormatter]

data/Guardfile

@@ -25,7 +25,7 @@
 # Guardfile for Lazylead
 guard :minitest, all_after_pass: false, all_on_start: false do
   # with Minitest::Unit
-  watch(%r{^test/(.*)\/?test_(.*)\.rb$})
+  watch(%r{^test/(.*)/?test_(.*)\.rb$})
   watch(%r{^test/test\.rb$}) { "test" }
   watch(%r{^lib/lazylead/(.*/)?([^/]+)\.rb$}) do |m|
     "test/#{m[1]}test_#{m[2]}.rb"

data/bin/lazylead

@@ -25,11 +25,12 @@
 
 # When sync mode is true, all output is immediately flushed
 # to the underlying operating system and is not buffered internally.
-STDOUT.sync = true
+$stdout.sync = true
 
 require "slop"
 require "sqlite3"
 require "colorize"
+require "inifile"
 require "logging"
 require "backtrace"
 require "memory_profiler"
@@ -81,6 +82,7 @@ log.debug "Version: #{Lazylead::VERSION.colorize(:green)}"
 log.debug "Memory footprint at start is " \
           "#{Lazylead::Allocated.new.to_s.colorize(:light_blue)}."
 cmd = lambda do
+  IniFile.new(filename: "lazylead.ini").each { |_, k, v| ENV[k] = v }
   Lazylead::CLI::App.new(
     log,
     Lazylead::Schedule.new(log: log),

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.6.2"
+  s.version = "0.7.0"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.6.2!
+  s.post_install_message = "Thanks for installing Lazylead v0.7.0!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead
@@ -55,42 +55,46 @@ tasks instead of solving technical problems."
   s.test_files = s.files.grep(%r{^(test|features)/})
   s.rdoc_options = ["--charset=UTF-8"]
   s.extra_rdoc_files = %w[readme.md license.txt]
-  s.add_runtime_dependency "activerecord", "6.0.3"
+  s.add_runtime_dependency "activerecord", "6.1.1"
   s.add_runtime_dependency "backtrace", "0.3"
   s.add_runtime_dependency "colorize", "0.8.1"
   s.add_runtime_dependency "faraday", "1.0.1"
-  s.add_runtime_dependency "get_process_mem", "0.2.5"
+  s.add_runtime_dependency "get_process_mem", "0.2.7"
+  s.add_runtime_dependency "inifile", "3.0.0"
   s.add_runtime_dependency "jira-ruby", "1.7.1"
-  s.add_runtime_dependency "json", "2.3.0"
-  s.add_runtime_dependency "logging", "2.2.2"
+  s.add_runtime_dependency "json", "2.5.1"
+  s.add_runtime_dependency "logging", "2.3.0"
   s.add_runtime_dependency "mail", "2.7.1"
   s.add_runtime_dependency "memory_profiler", "0.9.13"
   s.add_runtime_dependency "openssl", "2.1.2"
+  s.add_runtime_dependency "railties", "6.1.1"
   s.add_runtime_dependency "require_all", "3.0.0"
   s.add_runtime_dependency "rufus-scheduler", "3.6.0"
   s.add_runtime_dependency "slop", "4.4"
   s.add_runtime_dependency "sqlite3", "1.4.2"
   s.add_runtime_dependency "tempfile", "0.1.0"
   s.add_runtime_dependency "tilt", "2.0.10"
-  s.add_runtime_dependency "tzinfo", "1.1"
-  s.add_runtime_dependency "tzinfo-data", "1.2019.3"
-  s.add_runtime_dependency "vcs4sql", "0.1.0"
+  s.add_runtime_dependency "tzinfo", "2.0.4"
+  s.add_runtime_dependency "tzinfo-data", "1.2020.6"
+  s.add_runtime_dependency "vcs4sql", "0.1.1"
   s.add_runtime_dependency "viewpoint", "1.1.0"
-  s.add_development_dependency "codecov", "0.2.3"
+  s.add_development_dependency "codecov", "0.2.15"
   s.add_development_dependency "guard", "2.15.0"
   s.add_development_dependency "guard-minitest", "2.4.6"
-  s.add_development_dependency "minitest", "5.11.3"
+  s.add_development_dependency "minitest", "5.14.3"
   s.add_development_dependency "minitest-fail-fast", "0.1.0"
   s.add_development_dependency "minitest-hooks", "1.5.0"
   s.add_development_dependency "minitest-reporters", "1.3.6"
   s.add_development_dependency "net-ping", "2.0.8"
   s.add_development_dependency "rake", "12.3.3"
   s.add_development_dependency "random-port", "0.3.1"
-  s.add_development_dependency "rdoc", "6.1.1"
-  s.add_development_dependency "rubocop", "0.82"
+  s.add_development_dependency "rdoc", "6.3.0"
+  s.add_development_dependency "rubocop", "1.8.1"
   s.add_development_dependency "rubocop-minitest", "0.5.1"
   s.add_development_dependency "rubocop-performance", "1.5.2"
+  s.add_development_dependency "rubocop-rake", "0.5.1"
   s.add_development_dependency "rubocop-rspec", "1.33.0"
   s.add_development_dependency "sqlint", "0.1.10"
-  s.add_development_dependency "xcop", "0.6"
+  s.add_development_dependency "tempfile", "0.1.0"
+  s.add_development_dependency "xcop", "0.6.2"
 end

data/lib/lazylead/cc.rb

@@ -81,12 +81,12 @@ module Lazylead
 
     def cc
       @cc ||= begin
-                if @text.include? ","
-                  @text.split(",").map(&:strip).select { |e| e[@regxp] }
-                elsif @text[@regxp]
-                  [@text.strip]
-                end
-              end
+        if @text.include? ","
+          @text.split(",").map(&:strip).select { |e| e[@regxp] }
+        elsif @text[@regxp]
+          [@text.strip]
+        end
+      end
     end
 
     def each(&block)
@@ -126,14 +126,14 @@ module Lazylead
 
     def to_h
       @to_h ||= begin
-                  if @orig.is_a? Hash
-                    @orig.each_with_object({}) do |i, o|
-                      o[i.first] = Lazylead::PlainCC.new(i.last).cc
-                    end
-                  else
-                    {}
-                  end
-                end
+        if @orig.is_a? Hash
+          @orig.each_with_object({}) do |i, o|
+            o[i.first] = Lazylead::PlainCC.new(i.last).cc
+          end
+        else
+          {}
+        end
+      end
     end
   end
 
@@ -145,18 +145,19 @@ module Lazylead
   # License:: MIT
   class ComponentCC < Lazylead::PredefinedCC
     def initialize(prj, jira)
+      super({})
       @prj = prj
       @jira = jira
     end
 
     def to_h
       @to_h ||= begin
-                  components.each_with_object({}) do |c, h|
-                    email = lead(c.attrs["id"])
-                    next if email.nil? || email.blank?
-                    h[c.attrs["name"]] = email
-                  end
-                end
+        components.each_with_object({}) do |c, h|
+          email = lead(c.attrs["id"])
+          next if email.nil? || email.blank?
+          h[c.attrs["name"]] = email
+        end
+      end
     end
 
     private

data/lib/lazylead/cli/app.rb

@@ -57,8 +57,8 @@ module Lazylead
       private
 
       def apply_vcs_migration(opts)
-        @db = File.expand_path(opts[:home]) + "/" + opts[:sqlite]
-        vcs = File.expand_path(opts[:home]) + "/" + opts[:vcs4sql]
+        @db = "#{File.expand_path(opts[:home])}/#{opts[:sqlite]}"
+        vcs = "#{File.expand_path(opts[:home])}/#{opts[:vcs4sql]}"
         @log.debug "Database: '#{@db.colorize(:light_blue)}', "\
                    "sql migration dir: '#{vcs.colorize(:light_blue)}'"
         Vcs4sql::Sqlite::Migration.new(@db).upgrade vcs, opts[:testdata]

data/lib/lazylead/confluence.rb

@@ -104,16 +104,23 @@ module Lazylead
     end
 
     # Detect links mentioned in ticket comments
+    # @todo #/DEV Refactor this method in order to make it more human-readable and remove the
+    #  suppresion below
+    #
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/PerceivedComplexity
     def mentioned_links(ticket)
       ticket.comments
             .map { |cmnt| cmnt.attrs["body"] }
             .select { |cmnt| @confl.any? { |c| cmnt.include? c.url } }
-            .flat_map { |cmnt| cmnt.split " " }
+            .flat_map(&:split)
             .select { |cmnt| @confl.any? { |c| cmnt.start_with? c.url } }
             .map(&method(:to_page_id))
             .reject(&:blank?)
             .uniq
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
 
     # Convert confluence page url to the following format:
     #  http://confluence.com/pages/viewpage.action?pageId=xxxxx

data/lib/lazylead/model.rb

@@ -68,9 +68,7 @@ module Lazylead
       opts.each_with_object({}) do |e, o|
         k = e[0]
         v = e[1]
-        if v.respond_to? :start_with?
-          v = ENV[v.slice(2, v.length - 3)] if v.start_with? "${"
-        end
+        v = ENV[v.slice(2, v.length - 3)] if v.respond_to?(:start_with?) && v.start_with?("${")
         o[k] = v
       end
     end
@@ -106,6 +104,7 @@ module Lazylead
         sys = system.connect
         opts = props
         opts = detect_cc(sys) if opts.key? "cc"
+        opts["system"] = second_sys if opts.numeric? "system"
         action.constantize.new.run(sys, postman, opts)
       end
 
@@ -137,12 +136,12 @@ module Lazylead
 
       def props
         @props ||= begin
-                     if team.nil?
-                       Opts.new(env(to_hash))
-                     else
-                       Opts.new(env(team.to_hash.merge(to_hash)))
-                     end
-                   end
+          if team.nil?
+            Opts.new(env(to_hash))
+          else
+            Opts.new(env(team.to_hash.merge(to_hash)))
+          end
+        end
       end
 
       def postman
@@ -153,17 +152,21 @@ module Lazylead
         end
       end
 
+      def second_sys
+        sys = System.find(props["system"])
+        raise "ll-014: No ticketing system found for #{self}" if sys.nil?
+        sys.connect
+      end
+
       private
 
       # Parse scheduling #type and #unit
       def trigger
         @trigger ||= begin
-                       trg = schedule.split(":")
-                       unless trg.size == 2
-                         raise "ll-007: illegal schedule format '#{schedule}'"
-                       end
-                       trg.map(&:strip).map(&:chomp)
-                     end
+          trg = schedule.split(":")
+          raise "ll-007: illegal schedule format '#{schedule}'" unless trg.size == 2
+          trg.map(&:strip).map(&:chomp)
+        end
       end
     end
 
@@ -179,6 +182,10 @@ module Lazylead
         @log = log
       end
 
+      # @todo #/DEV Remove the suppression during next refactoring (or enhancements)
+      #  for the method below
+      #
+      # rubocop:disable Metrics/AbcSize
       def exec
         Logging.mdc["tid"] = "task #{id}"
         @log.debug "'#{name}' is started."
@@ -189,12 +196,13 @@ module Lazylead
       rescue StandardError => e
         msg = <<~MSG
           ll-006: Task ##{id} #{e} (#{e.class}) at #{self}
-          #{Backtrace.new(e) if ARGV.include? '--trace'}"
+          #{Backtrace.new(e) if ARGV.include? '--trace'}
         MSG
         @log.error msg
       ensure
         Logging.mdc["tid"] = ""
       end
+      # rubocop:enable Metrics/AbcSize
     end
 
     # Ticketing systems to monitor.

data/lib/lazylead/opts.rb

@@ -44,7 +44,13 @@ module Lazylead
     # Split text value by delimiter, trim all spaces and reject blank items
     def slice(key, delim)
       return [] unless to_h.key? key
-      to_h[key].split(delim).map(&:chomp).map(&:strip).reject(&:blank?)
+      trim to_h[key].split(delim)
+    end
+
+    # Trim all spaces and reject blank items in array
+    def trim(arr)
+      return [] if arr.nil?
+      arr.map(&:chomp).map(&:strip).reject(&:blank?)
     end
 
     def blank?(key)
@@ -124,5 +130,14 @@ module Lazylead
       return [val] unless val.include? delim
       slice key, delim
     end
+
+    # Ensure that particular key from options is a positive numer
+    #   Opts.new("key" => "1").numeric? "key"   => true
+    #   Opts.new("key" => "0").numeric? "key"   => false
+    #   Opts.new("key" => ".").numeric? "key"   => false
+    #   Opts.new("key" => "nil").numeric? "key" => false
+    def numeric?(key)
+      to_h[key].to_i.positive?
+    end
   end
 end

data/lib/lazylead/salt.rb

@@ -39,6 +39,7 @@ module Lazylead
   #
   class Salt
     attr_reader :id
+
     #
     # Each salt should be defined as a environment variable with id, like
     #  salt1=E1F53135E559C253

data/lib/lazylead/system/jira.rb

@@ -177,7 +177,7 @@ module Lazylead
     end
 
     def url
-      @issue.attrs["self"].split("/rest/api/").first + "/browse/" + key
+      "#{@issue.attrs['self'].split('/rest/api/').first}/browse/#{key}"
     end
 
     def duedate
@@ -257,13 +257,20 @@ module Lazylead
       lbl = [] if lbl.nil?
       lbl << label
       lbl += more if more.size.positive?
-      save!("fields" => { "labels" => lbl.uniq })
+      labels! lbl
     end
 
+    # Get the labels for a particular issue
     def labels
       fields["labels"]
     end
 
+    # Update the labels for a particular issue
+    def labels!(lbl)
+      return if lbl.nil? || lbl.empty?
+      save!("fields" => { "labels" => lbl.uniq })
+    end
+
     def save!(opts)
       @issue.save(opts)
     end