lazylead 0.5.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b58ee14de8c573012698a15d145941155e6c282249bc2938bf4938c4e677d7cd
-  data.tar.gz: 34bed5a73b2186b9e229a121973ad11891037d604faa0134fe31d5a9380ead6a
+  metadata.gz: e5a5b0412fc9cb5796b066940c57e50785b64920718a09ecd4ef8794fc8b3908
+  data.tar.gz: 148b21d628c91d27abee8fb1bb86aeaf78cfdc96b01f9cbed16c9f4f8b5c7ef3
 SHA512:
-  metadata.gz: f1a8e4032492f97b2672078c908f37599f3d32a01bf31d7a67911732b90f682410123fb1234e07315b9ccd6d4e675e4b9d4867e06f265c06ace44f33c7d1cb1f
-  data.tar.gz: 22f2d3fb9b3ed8a8bb9e2e8f6f29393f65e2ab6bea033c9f0f82741775032098383614f280433f64fcd16dbd6ab6c4c46115b197307c684a9c03ffc736b95714
+  metadata.gz: 58539cbff1ccdc9c392aaa67af4e6dc0ade92311cbf2118202392b069de15f3872f833d2081b59d97439029901b569fe72e6a54e22ddfe011c06cddef576b6e2
+  data.tar.gz: 658f24b1dde5272d17c6cdd77f570f71de818f83a7acda9c5b3cdebf497f514e7f890862963caa49e577f2c566829be7d247bee1e236ec1248cdf0fbc4a58de2

data/.rubocop.yml

@@ -16,10 +16,13 @@ Layout/LineLength:
     - "test/**/*"
 
 Metrics/AbcSize:
-  Max: 20
+  Max: 21
   Exclude:
     - "test/**/*"
 
+Metrics/CyclomaticComplexity:
+  Max: 8
+
 Metrics/BlockLength:
   Exclude:
     - "*.gemspec"
@@ -91,3 +94,48 @@ Lint/StructNewOverride:
 
 # @todo #/DEV Add violation regarding methods without documentation using RDoc
 #  https://stackoverflow.com/questions/1681467/how-to-document-ruby-code
+
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: true

data/.simplecov

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
   [SimpleCov::Formatter::HTMLFormatter]

data/Guardfile

@@ -25,7 +25,7 @@
 # Guardfile for Lazylead
 guard :minitest, all_after_pass: false, all_on_start: false do
   # with Minitest::Unit
-  watch(%r{^test/(.*)\/?test_(.*)\.rb$})
+  watch(%r{^test/(.*)/?test_(.*)\.rb$})
   watch(%r{^test/test\.rb$}) { "test" }
   watch(%r{^lib/lazylead/(.*/)?([^/]+)\.rb$}) do |m|
     "test/#{m[1]}test_#{m[2]}.rb"

data/Rakefile

@@ -26,7 +26,7 @@ require "rubygems"
 require "rake"
 require "date"
 require "rdoc"
-require "rainbow"
+require "colorize"
 require "rake/clean"
 
 # @todo #/DEV Investigate the possibility of using migrations from active_record
@@ -112,9 +112,10 @@ task :sqlint do
     total += violations.count { |lint| lint.type == :error }
   end
   if total.positive?
-    abort "#{Rainbow(total).red} SQL violations found."
+    abort "#{total.colorize(:red)} SQL violations found."
   else
-    puts "#{src.size} files inspected, #{Rainbow('no offenses').green} detected"
+    puts "#{src.size} files inspected, #{'no offenses'.colorize(:green)} " \
+          "detected"
   end
 end
 

data/bin/lazylead

@@ -25,11 +25,12 @@
 
 # When sync mode is true, all output is immediately flushed
 # to the underlying operating system and is not buffered internally.
-STDOUT.sync = true
+$stdout.sync = true
 
 require "slop"
 require "sqlite3"
-require "rainbow"
+require "colorize"
+require "inifile"
 require "logging"
 require "backtrace"
 require "memory_profiler"
@@ -77,9 +78,11 @@ Available options:"
     exit
   end
 end
-log.debug("Version: #{Lazylead::VERSION}")
-log.debug("Memory footprint at start is #{Lazylead::Allocated.new}")
+log.debug "Version: #{Lazylead::VERSION.colorize(:green)}"
+log.debug "Memory footprint at start is " \
+          "#{Lazylead::Allocated.new.to_s.colorize(:light_blue)}."
 cmd = lambda do
+  IniFile.new(filename: "lazylead.ini").each { |_, k, v| ENV[k] = v }
   Lazylead::CLI::App.new(
     log,
     Lazylead::Schedule.new(log: log),
@@ -103,5 +106,6 @@ if opts["memory-dump"]
 else
   code = cmd.call
 end
-log.debug("Memory footprint at the end is #{Lazylead::Allocated.new}")
+log.debug "Memory footprint at the end is " \
+          "#{Lazylead::Allocated.new.to_s.colorize(:light_blue)}."
 exit(code) unless code.zero?

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.5.1"
+  s.version = "0.7.0"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.5.1!
+  s.post_install_message = "Thanks for installing Lazylead v0.7.0!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead
@@ -55,41 +55,46 @@ tasks instead of solving technical problems."
   s.test_files = s.files.grep(%r{^(test|features)/})
   s.rdoc_options = ["--charset=UTF-8"]
   s.extra_rdoc_files = %w[readme.md license.txt]
-  s.add_runtime_dependency "activerecord", "6.0.3"
+  s.add_runtime_dependency "activerecord", "6.1.1"
   s.add_runtime_dependency "backtrace", "0.3"
+  s.add_runtime_dependency "colorize", "0.8.1"
   s.add_runtime_dependency "faraday", "1.0.1"
-  s.add_runtime_dependency "get_process_mem", "0.2.5"
+  s.add_runtime_dependency "get_process_mem", "0.2.7"
+  s.add_runtime_dependency "inifile", "3.0.0"
   s.add_runtime_dependency "jira-ruby", "1.7.1"
-  s.add_runtime_dependency "json", "2.3.0"
-  s.add_runtime_dependency "logging", "2.2.2"
+  s.add_runtime_dependency "json", "2.5.1"
+  s.add_runtime_dependency "logging", "2.3.0"
   s.add_runtime_dependency "mail", "2.7.1"
   s.add_runtime_dependency "memory_profiler", "0.9.13"
   s.add_runtime_dependency "openssl", "2.1.2"
-  s.add_runtime_dependency "rainbow", "3.0.0"
+  s.add_runtime_dependency "railties", "6.1.1"
   s.add_runtime_dependency "require_all", "3.0.0"
   s.add_runtime_dependency "rufus-scheduler", "3.6.0"
   s.add_runtime_dependency "slop", "4.4"
   s.add_runtime_dependency "sqlite3", "1.4.2"
+  s.add_runtime_dependency "tempfile", "0.1.0"
   s.add_runtime_dependency "tilt", "2.0.10"
-  s.add_runtime_dependency "tzinfo", "1.1"
-  s.add_runtime_dependency "tzinfo-data", "1.2019.3"
-  s.add_runtime_dependency "vcs4sql", "0.1.0"
+  s.add_runtime_dependency "tzinfo", "2.0.4"
+  s.add_runtime_dependency "tzinfo-data", "1.2020.6"
+  s.add_runtime_dependency "vcs4sql", "0.1.1"
   s.add_runtime_dependency "viewpoint", "1.1.0"
-  s.add_development_dependency "codecov", "0.2.3"
+  s.add_development_dependency "codecov", "0.2.15"
   s.add_development_dependency "guard", "2.15.0"
   s.add_development_dependency "guard-minitest", "2.4.6"
-  s.add_development_dependency "minitest", "5.11.3"
+  s.add_development_dependency "minitest", "5.14.3"
   s.add_development_dependency "minitest-fail-fast", "0.1.0"
   s.add_development_dependency "minitest-hooks", "1.5.0"
   s.add_development_dependency "minitest-reporters", "1.3.6"
   s.add_development_dependency "net-ping", "2.0.8"
   s.add_development_dependency "rake", "12.3.3"
   s.add_development_dependency "random-port", "0.3.1"
-  s.add_development_dependency "rdoc", "6.1.1"
-  s.add_development_dependency "rubocop", "0.82"
+  s.add_development_dependency "rdoc", "6.3.0"
+  s.add_development_dependency "rubocop", "1.8.1"
   s.add_development_dependency "rubocop-minitest", "0.5.1"
   s.add_development_dependency "rubocop-performance", "1.5.2"
+  s.add_development_dependency "rubocop-rake", "0.5.1"
   s.add_development_dependency "rubocop-rspec", "1.33.0"
   s.add_development_dependency "sqlint", "0.1.10"
-  s.add_development_dependency "xcop", "0.6"
+  s.add_development_dependency "tempfile", "0.1.0"
+  s.add_development_dependency "xcop", "0.6.2"
 end

data/lib/lazylead/cc.rb

@@ -81,12 +81,12 @@ module Lazylead
 
     def cc
       @cc ||= begin
-                if @text.include? ","
-                  @text.split(",").map(&:strip).select { |e| e[@regxp] }
-                elsif @text[@regxp]
-                  [@text.strip]
-                end
-              end
+        if @text.include? ","
+          @text.split(",").map(&:strip).select { |e| e[@regxp] }
+        elsif @text[@regxp]
+          [@text.strip]
+        end
+      end
     end
 
     def each(&block)
@@ -126,14 +126,14 @@ module Lazylead
 
     def to_h
       @to_h ||= begin
-                  if @orig.is_a? Hash
-                    @orig.each_with_object({}) do |i, o|
-                      o[i.first] = Lazylead::PlainCC.new(i.last).cc
-                    end
-                  else
-                    {}
-                  end
-                end
+        if @orig.is_a? Hash
+          @orig.each_with_object({}) do |i, o|
+            o[i.first] = Lazylead::PlainCC.new(i.last).cc
+          end
+        else
+          {}
+        end
+      end
     end
   end
 
@@ -145,18 +145,19 @@ module Lazylead
   # License:: MIT
   class ComponentCC < Lazylead::PredefinedCC
     def initialize(prj, jira)
+      super({})
       @prj = prj
       @jira = jira
     end
 
     def to_h
       @to_h ||= begin
-                  components.each_with_object({}) do |c, h|
-                    email = lead(c.attrs["id"])
-                    next if email.nil? || email.blank?
-                    h[c.attrs["name"]] = email
-                  end
-                end
+        components.each_with_object({}) do |c, h|
+          email = lead(c.attrs["id"])
+          next if email.nil? || email.blank?
+          h[c.attrs["name"]] = email
+        end
+      end
     end
 
     private

data/lib/lazylead/cli/app.rb

@@ -22,6 +22,7 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
+require "colorize"
 require "vcs4sql/sqlite/migration"
 require_relative "../smtp"
 require_relative "../schedule"
@@ -56,11 +57,13 @@ module Lazylead
       private
 
       def apply_vcs_migration(opts)
-        @db = File.expand_path(opts[:home]) + "/" + opts[:sqlite]
-        vcs = File.expand_path(opts[:home]) + "/" + opts[:vcs4sql]
-        @log.debug "Database: '#{@db}', sql migration dir: '#{vcs}'"
+        @db = "#{File.expand_path(opts[:home])}/#{opts[:sqlite]}"
+        vcs = "#{File.expand_path(opts[:home])}/#{opts[:vcs4sql]}"
+        @log.debug "Database: '#{@db.colorize(:light_blue)}', "\
+                   "sql migration dir: '#{vcs.colorize(:light_blue)}'"
         Vcs4sql::Sqlite::Migration.new(@db).upgrade vcs, opts[:testdata]
-        @log.debug "Migration applied to #{@db} from #{vcs}"
+        @log.debug "Migration applied to '#{@db.colorize(:light_blue)}' from " \
+                   "'#{vcs.colorize(:light_blue)}'"
       end
 
       def enable_active_record(opts)
@@ -78,7 +81,12 @@ module Lazylead
           @log.warn "ll-001: No tasks found."
         else
           todo.find_each do |task|
-            @schedule.register task
+            if task.to_h?
+              @schedule.register task
+            else
+              @log.warn "ll-011: Scheduling skipped due to configuration " \
+                        "mistake in #{task}"
+            end
           end
           @schedule.join
         end

data/lib/lazylead/confluence.rb

@@ -104,16 +104,23 @@ module Lazylead
     end
 
     # Detect links mentioned in ticket comments
+    # @todo #/DEV Refactor this method in order to make it more human-readable and remove the
+    #  suppresion below
+    #
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/PerceivedComplexity
     def mentioned_links(ticket)
       ticket.comments
             .map { |cmnt| cmnt.attrs["body"] }
             .select { |cmnt| @confl.any? { |c| cmnt.include? c.url } }
-            .flat_map { |cmnt| cmnt.split " " }
+            .flat_map(&:split)
             .select { |cmnt| @confl.any? { |c| cmnt.start_with? c.url } }
             .map(&method(:to_page_id))
             .reject(&:blank?)
             .uniq
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
 
     # Convert confluence page url to the following format:
     #  http://confluence.com/pages/viewpage.action?pageId=xxxxx

data/lib/lazylead/email.rb

@@ -25,26 +25,6 @@
 require "tilt"
 
 module Lazylead
-  # Email notifications utilities.
-  module Emailing
-    # Construct html document from template and binds.
-    def make_body(opts)
-      Email.new(
-        opts["template"],
-        opts.merge(version: Lazylead::VERSION)
-      ).render
-    end
-
-    # Split text with email addresses by ',' and trim all elements if needed.
-    def split(type, opts)
-      if opts[type].include? ","
-        opts[type].split(",").map(&:strip).reject(&:empty?)
-      else
-        [opts[type]]
-      end
-    end
-  end
-
   # An email regarding tickets based on file with markup.
   #
   # The 'tilt' gem was used as a template engine.

data/lib/lazylead/exchange.rb

@@ -39,8 +39,6 @@ module Lazylead
   # Copyright:: Copyright (c) 2019-2020 Yurii Dubinka
   # License:: MIT
   class Exchange
-    include Emailing
-
     def initialize(
       log = Log.new, salt = Salt.new("exchange_salt"), opts = ENV.to_h
     )
@@ -52,38 +50,28 @@ module Lazylead
     # Send an email.
     # :opts   :: the mail configuration like from, cc, subject, template.
     def send(opts)
-      to = opts["to"] || opts[:to]
-      to = [to] unless to.is_a? Array
-      if to.reject { |e| e.nil? || e.blank? }.empty?
-        @log.warn "Email can't be sent to '#{to}, more: '#{opts}'"
-        return
+      if opts.msg_to.empty?
+        @log.warn "ll-012: Email can't be sent to '#{opts.msg_to}," \
+                  " more: '#{opts}'"
+      else
+        msg = make_msg opts
+        cli.send_message msg
+        msg[:file_attachments].each(&:close) unless opts.msg_attachments.empty?
+        @log.debug "#{__FILE__} sent '#{opts['subject']}' to '#{opts.msg_to}'."
       end
-      msg = make_msg(to, opts)
-      msg.update(cc_recipients: opts["cc"]) if opts.key? "cc"
-      add_attachments(msg, opts)
-      cli.send_message msg
-      close_attachments msg
-      @log.debug "#{__FILE__} sent email based on #{opts}."
     end
 
-    def make_msg(to, opts)
-      {
+    def make_msg(opts)
+      msg = {
         subject: opts["subject"],
-        body: make_body(opts),
+        body: opts.msg_body,
         body_type: "HTML",
-        to_recipients: to
+        to_recipients: opts.msg_to
       }
-    end
-
-    def add_attachments(msg, opts)
-      return unless opts.key? "attachments"
-      files = split("attachments", opts).map { |f| File.open(f, "r") }
-      msg[:file_attachments] = files
-    end
-
-    def close_attachments(msg)
-      return if msg[:file_attachments].nil? || msg[:file_attachments].empty?
-      msg[:file_attachments].each(&:close)
+      files = opts.msg_attachments.map { |f| File.open(f, "r") }
+      msg[:file_attachments] = files unless files.empty?
+      msg[:cc_recipients] = opts["cc"] if opts.key? "cc"
+      msg
     end
 
     private