lazylead 0.3.0 → 0.4.3

data/readme.md

@@ -19,7 +19,7 @@
 [![DevOps By Rultor.com](http://www.rultor.com/b/dgroup/lazylead)](http://www.rultor.com/p/dgroup/lazylead)
 [![EO badge](http://www.elegantobjects.org/badge.svg)](http://www.elegantobjects.org/#principles)
 
-⚠️ We're still in a very early alpha version, the API may change frequently until we release version 1.0.
+⚠️ We're still in a very early alpha version, the API may change frequently until we release version `1.0`.
 
 ### Overview
 Ticketing systems (Github, Jira, etc.) are strongly integrated into our processes and everyone understands their necessity. As soon as a developer becomes a lead/technical manager, he or she faces a set of routine tasks that are related to ticketing work. On large projects this becomes a problem, more and more you spend time running around on dashboards and tickets, looking for incorrect deviations in tickets and performing routine tasks instead of solving technical problems.
@@ -38,6 +38,7 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 | [Notify about illegal "Fix Version" modification](lib/lazylead/task/fix_version.rb) | ✅ | ❌ | ❌ | 
 | [Expected comment in ticket is missing](lib/lazylead/task/missing_comment.rb)       | ✅ | ⌛ | ⌛ |
 | [Propagate some fields from parent ticket into sub-tasks](.docs/propagate_down.md)  | ✅ | ❌ | ❌ |  
+| [Evaluate the ticket formatting accuracy](.docs/accuracy.md)                        | ✅ | ⌛ | ⌛ |  
 | Print the current capacity of team into newly created tasks                         | ⌛ | ⌛ | ⌛ |  
 | Create/retrofit the defect automatically into latest release                        | ⌛ | ⌛ | ❌ |  
 | [Notify about expired(ing) due dates](.docs/duedate_expired.md)                     | ✅ | ❌ | ⌛ |
@@ -61,7 +62,7 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 New ideas, bugs, suggestions or questions are welcome [via GitHub issues](https://github.com/dgroup/lazylead/issues/new)!
 
 ### Get started
-⚠️ We're still in a very early alpha version, the API may change frequently until we release version 1.0.
+⚠️ We're still in a very early alpha version, the API may change frequently until we release version `1.0`.
 
 Let's assume that:
 - your team is using jira as a ticketing system
@@ -112,13 +113,14 @@ For simplicity, we are using [docker-compose](https://docs.docker.com/compose/):
     ll > docker-compose -f .github/tasks.yml up                                                         
     Creating lazylead ... done
     Attaching to lazylead
-    lazylead    | [2020-06-06T10:35:13] DEBUG Memory footprint at start is 52MB
-    lazylead    | [2020-06-06T10:35:13] DEBUG Database: '/lazylead/db/ll.db', sql migration dir: '/lazylead/upgrades/sqlite'
-    lazylead    | [2020-06-06T10:35:13] DEBUG Migration applied to /lazylead/db/ll.db from /lazylead/upgrades/sqlite
-    lazylead    | [2020-06-06T10:35:13] DEBUG Database connection established
-    lazylead    | [2020-06-06T10:35:13] WARN  SMTP connection enabled in test mode.
-    lazylead    | [2020-06-06T10:35:13] WARN  ll-001: No tasks found.
-    lazylead    | [2020-06-06T10:35:13] DEBUG Memory footprint at the end is 66MB
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Version: 0.4.0
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Memory footprint at start is 52MB
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Database: '/lazylead/db/ll.db', sql migration dir: '/lazylead/upgrades/sqlite'
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Migration applied to /lazylead/db/ll.db from /lazylead/upgrades/sqlite
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Database connection established
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] SMTP connection established with {host} as {user}.
+    lazylead    | [2020-08-09T06:17:32] WARN  [main] ll-001: No tasks found.
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Memory footprint at the end is 67MB
     lazylead exited with code 0
     ll > 
     ```
@@ -152,15 +154,14 @@ For simplicity, we are using [docker-compose](https://docs.docker.com/compose/):
     check the logs and stop container if needed
     ```bash
     ll > docker logs lazylead
-    2020-06-06T11:37:36] DEBUG Memory footprint at start is 52MB
-    [2020-06-06T11:37:37] DEBUG Database: '/lazylead/db/ll.db', sql migration dir: '/lazylead/upgrades/sqlite'
-    [2020-06-06T11:37:37] DEBUG Migration applied to /lazylead/db/ll.db from /lazylead/upgrades/sqlite
-    [2020-06-06T11:37:37] DEBUG Database connection established
-    [2020-06-06T11:37:37] WARN  SMTP connection enabled in test mode.
-    [2020-06-06T11:37:37] DEBUG Task scheduled: id='1', name='Expired due dates', cron='0 8 * * 1-5', system='1', action='Lazylead::Task::AssigneeAlert', team_id='1', description='', enabled='true', properties='{"sql":"filter=555", "cc":"my.email@google.com", "subject":"[LL] Expired due dates", "template":"lib/messages/due_date_expired.erb", "postman":"Lazylead::Exchange"}'
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Version: 0.4.0
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Memory footprint at start is 52MB
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Database: '/lazylead/db/ll.db', sql migration dir: '/lazylead/upgrades/sqlite'
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Migration applied to /lazylead/db/ll.db from /lazylead/upgrades/sqlite
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Database connection established
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] SMTP connection established with {host} as {user}.
+    lazylead    | [2020-08-09T06:17:32] DEBUG [main] Task scheduled: id='1', name='Expired due dates', cron='0 8 * * 1-5', system='1', action='Lazylead::Task::AssigneeAlert', team_id='1', description='', enabled='true', properties='{"sql":"filter=555", "cc":"my.email@google.com", "subject":"[LL] Expired due dates", "template":"lib/messages/due_date_expired.erb", "postman":"Lazylead::Exchange"}'
     ...
-    ll > docker stop lazylead
-    lazylead
     ```
 
 ### How to contribute?
@@ -173,4 +174,4 @@ bundle exec rake
 Everyone interacting in this project’s codebases, issue trackers, chat rooms is expected to follow the [code of conduct](.github/CODE_OF_CONDUCT.md).
 
 Contributors:
- * [dgroup](https://github.com/dgroup) as Yurii Dubinka (yurii.dubinka@gmail.com)
+ * [dgroup](https://github.com/dgroup) as Yurii Dubinka ([yurii.dubinka@gmail.com](mailto:yurii.dubinka@gmail.com))

data/test/lazylead/cc_test.rb

@@ -29,6 +29,26 @@ require_relative "../../lib/lazylead/cc"
 require_relative "../../lib/lazylead/system/jira"
 
 module Lazylead
+  class CcTest < Lazylead::Test
+    test "plain cc detected as text" do
+      assert Lazylead::CC.new.plain? "a@fake.com,b@fake.com"
+    end
+    test "plain cc not found in text" do
+      refute Lazylead::CC.new.plain? "justatext.com,eeeee.com"
+    end
+    test "plain cc detected as object" do
+      assert Lazylead::CC.new.recognized? Lazylead::PlainCC.new("a@fake.com")
+    end
+    test "cc is incorrect" do
+      refute Lazylead::CC.new.recognized? key: "value"
+    end
+    test "cc is not found in hash" do
+      assert Lazylead::CC.new.undefined? key: "value"
+    end
+    test "cc type is blank" do
+      assert Lazylead::CC.new.undefined? "type" => "    "
+    end
+  end
   class PlainCcTest < Lazylead::Test
     test "cc has valid email" do
       assert_equal "a@fake.com", Lazylead::PlainCC.new("a@fake.com").cc.first
@@ -109,7 +129,7 @@ module Lazylead
     end
 
     test "detect plain cc" do
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",
@@ -120,7 +140,7 @@ module Lazylead
     end
 
     test "detect complex cc by predefined component" do
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",

data/test/lazylead/cli/app_test.rb

@@ -31,7 +31,7 @@ module Lazylead
   module CLI
     class AppTest < Lazylead::SqliteTest
       test "LL database structure installed successfully" do
-        CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+        CLI::App.new(Log.new, NoSchedule.new).run(
           home: ".",
           sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
           vcs4sql: "upgrades/sqlite"
@@ -46,7 +46,7 @@ module Lazylead
       end
 
       test "activesupport is activated for access to domain entities" do
-        CLI::App.new(Log::NOTHING, Schedule.new(Log::NOTHING, false)).run(
+        CLI::App.new(Log.new, Schedule.new(cling: false)).run(
           home: ".",
           sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
           vcs4sql: "upgrades/sqlite",

data/test/lazylead/exchange_test.rb

@@ -36,7 +36,7 @@ module Lazylead
                                                              "exchange_user",
                                                              "exchange_password",
                                                              "exchange_to"
-      Exchange.new(Log::NOTHING, NoSalt.new).send(
+      Exchange.new(Log.new, NoSalt.new).send(
         to: ENV["exchange_to"],
         tickets: NoAuthJira.new("https://jira.spring.io")
                            .issues("key = DATAJDBC-480"),
@@ -52,7 +52,7 @@ module Lazylead
                                                              "enc_exchange_psw",
                                                              "enc_exchange_to"
       Exchange.new(
-        Log::NOTHING,
+        Log.new,
         Salt.new("exchange_salt"),
         "exchange_url" => ENV["exchange_url"],
         "exchange_user" => ENV["enc_exchange_usr"],
@@ -72,7 +72,7 @@ module Lazylead
                                                              "exchange_password",
                                                              "exchange_to"
       Exchange.new(
-        Log::NOTHING,
+        Log.new,
         Salt.new("exchange_salt"),
         "exchange_url" => ENV["exchange_url"],
         "exchange_user" => ENV["enc_exchange_usr"],

data/test/lazylead/model_test.rb

@@ -31,7 +31,7 @@ require_relative "../../lib/lazylead/schedule"
 module Lazylead
   class OrmTest < Lazylead::SqliteTest
     test "convert column to json" do
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",
@@ -42,7 +42,7 @@ module Lazylead
 
     test "env properties injected" do
       ENV["usr"] = "Mike"
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",
@@ -53,7 +53,7 @@ module Lazylead
     end
 
     test "postman initiated through orm" do
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",
@@ -64,7 +64,7 @@ module Lazylead
 
     test "task properties are using ENV variables" do
       ENV["key171"] = "value"
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",

data/test/lazylead/opts_test.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2020 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../test"
+require_relative "../../lib/lazylead/opts"
+
+module Lazylead
+  class OptsTest < Lazylead::Test
+    test "able to read by symbol" do
+      assert_equal "1", Opts.new(one: "1", two: "2")[:one]
+    end
+
+    test "able to read by key" do
+      assert_equal "1", Opts.new("one" => "1", two: "2")["one"]
+    end
+
+    test "able to write by key" do
+      opts = Opts.new
+      opts["key"] = "value"
+      assert_equal "value", opts["key"]
+    end
+
+    test "has jira defaults" do
+      assert_entries(
+        {
+          max_results: 50
+        },
+        Opts.new.jira_defaults
+      )
+    end
+
+    test "split and trim" do
+      assert_equal %w[one two three],
+                   Opts.new("text" => " one,two ,three, ,\n").slice("text", ",")
+    end
+
+    test "blank for null value cases" do
+      assert Opts.new("one" => "1", "two" => nil).blank? "two"
+    end
+
+    test "to hash" do
+      assert_kind_of Hash, Opts.new("one" => "1", "two" => nil).to_h
+    end
+
+    test "except keys" do
+      assert_equal 1, Opts.new("one" => "1", "two" => "2").except("one").size
+    end
+  end
+end

data/test/lazylead/postman_test.rb

@@ -38,7 +38,7 @@ module Lazylead
                                                          "LL_SMTP_TO",
                                                          "LL_SMTP_FROM"
       Smtp.new(
-        Log::NOTHING,
+        Log.new,
         NoSalt.new,
         smtp_host: ENV["LL_SMTP_HOST"],
         smtp_port: ENV["LL_SMTP_PORT"],

data/test/lazylead/smtp_test.rb

@@ -48,7 +48,7 @@ module Lazylead
     test "email has been sent to the remote server" do
       skip "Not implemented yet" unless env? "LL_SMTP_HOST", "LL_SMTP_USER"
       Smtp.new(
-        Log::NOTHING, NoSalt.new,
+        Log.new, NoSalt.new,
         smtp_host: ENV["LL_SMTP_HOST"],
         smtp_port: ENV["LL_SMTP_PORT"],
         smtp_user: ENV["LL_SMTP_USER"],

data/test/lazylead/system/jira_test.rb

@@ -40,7 +40,7 @@ module Lazylead
 
     test "found issue by jira (ORM)" do
       skip "No Jira credentials provided" unless env? "jsi_usr", "jsi_psw"
-      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+      CLI::App.new(Log.new, NoSchedule.new).run(
         home: ".",
         sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
         vcs4sql: "upgrades/sqlite",
@@ -114,5 +114,39 @@ module Lazylead
                              .first
                              .status
     end
+
+    test "issue has 1 field" do
+      assert_equal 1,
+                   NoAuthJira.new("https://jira.spring.io")
+                             .issues("key='DATAJDBC-480'", fields: ["summary"])
+                             .first
+                             .fields
+                             .size
+    end
+
+    test "make an jira comment" do
+      issue = Struct.new(:comment) do
+        def comments
+          self
+        end
+
+        def build
+          self
+        end
+
+        def save!(body)
+          self[:comment] = body
+        end
+      end.new
+      Issue.new(issue, Fake.new).post("Hi there!")
+      assert_equal "Hi there!", issue.comment[:body]
+    end
+
+    test "search by limit in 1 issue" do
+      assert_equal 1,
+                   NoAuthJira.new("https://jira.spring.io")
+                             .issues("key in (DATAJDBC-480, DATAJDBC-500)", max_results: "1")
+                             .size
+    end
   end
 end

data/test/lazylead/task/accuracy/accuracy_test.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2020 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../../test"
+require_relative "../../../../lib/lazylead/smtp"
+require_relative "../../../../lib/lazylead/task/accuracy/accuracy"
+require_relative "../../../../lib/lazylead/opts"
+require_relative "../../../../lib/lazylead/postman"
+require_relative "../../../../lib/lazylead/cli/app"
+require_relative "../../../../lib/lazylead/system/jira"
+
+module Lazylead
+  class AccuracyTest < Lazylead::Test
+    test "detect affected build" do
+      Lazylead::Smtp.new.enable
+      Task::Accuracy.new.run(
+        NoAuthJira.new("https://jira.spring.io"),
+        Postman.new,
+        Opts.new(
+          "from" => "ll@fake.com",
+          "to" => "lead@fake.com",
+          "rules" => "Lazylead::RequirementAffectedBuild",
+          "silent" => "true",
+          "colors" => {
+            "0" => "#FF4F33",
+            "35" => "#FF9F33",
+            "57" => "#19DD1E",
+            "90" => "#0FA81A"
+          }.to_json.to_s,
+          "docs" => "https://github.com/dgroup/lazylead/blob/master/.github/ISSUE_TEMPLATE/bug_report.md",
+          "jql" => "key in (DATAJDBC-490, DATAJDBC-492, DATAJDBC-493)",
+          "max_results" => 200,
+          "subject" => "[LL] Raised tickets",
+          "template" => "lib/messages/accuracy.erb"
+        )
+      )
+      assert_email "[LL] Raised tickets",
+                   %w[DATAJDBC-493 0.5 100% MyeongHyeonLee Deadlock\ occurs]
+    end
+
+    test "construct accuracy from orm" do
+      CLI::App.new(Log.new, NoSchedule.new).run(
+        home: ".",
+        sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
+        vcs4sql: "upgrades/sqlite",
+        testdata: true
+      )
+      assert_kind_of Lazylead::Task::Accuracy,
+                     ORM::Task.find(195).action.constantize.new
+    end
+  end
+end

data/test/lazylead/task/accuracy/affected_build_test.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2020 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../../test"
+require_relative "../../../../lib/lazylead/task/accuracy/affected_build"
+
+module Lazylead
+  class AffectedBuildTest < Lazylead::Test
+    test "affected version absent" do
+      refute RequirementAffectedBuild.new.passed(
+        OpenStruct.new(fields: { "versions" => [] })
+      )
+    end
+
+    test "affected version provided" do
+      assert RequirementAffectedBuild.new.passed(
+        OpenStruct.new(fields: { "versions" => ["0.4.0"] })
+      )
+    end
+  end
+end