lazylead 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1515ec779095fe067759c774a8f81a7f563d55e7f7c9dc9f8cb96644688d1a7e
-  data.tar.gz: dfe37f6ed725f609ea1c685c85d17581a87dea40ff1bc3be7967cb15d5c81405
+  metadata.gz: 4564fa672731c29fe8e9dc32d2f09c56bf0b9245fce2900b4335c49442d08fb2
+  data.tar.gz: 58ff724cc12437d3106978913f0c2ef12a189f2e80b87ec07a2202bcd0f90267
 SHA512:
-  metadata.gz: 24246a8ef909f298256a358e6c59778b5e9440aeb8dadfd32dbae21a079832ef3ee6e8126949803784aa2543866626ee3e71a0ee1ef5a102d725b0269aef155c
-  data.tar.gz: 445720af7f02f9497b9baf42b2657ea4c428fd2f088d72b1db03b9679f617fc45f049ba6af22dc9e05669c41c0d262fc63d76be06df051ab7e0cbf7f79a03923
+  metadata.gz: e7b23097dca908102e6863d5527769bfe3d5405003cbab920da7ee6fd7f4118b554eb3d3a5f1170830dfdbf8fb08f752e6276fae4157f919f6e39ec070a91089
+  data.tar.gz: be8745b87907ab9ad30e9e4eb67f0ebf44ae0dcc01dcdbedefd79ab480e1222bbdc8835a397d465b5e491e995ee7ceaf685464385d7d87c0f0014900325d38ac

data/.circleci/config.yml

@@ -21,6 +21,7 @@ jobs:
           command: |
             set -e
             COMMIT_URL="https://github.com/dgroup/lazylead/commit/${CIRCLE_SHA1}"
+            sed -i "s/0\.0\.0/${DOCKER_RELEASE_TAGS}/g" lib/lazylead/version.rb
             docker build --build-arg release_tags="${CIRCLE_SHA1}, ${CIRCLE_BRANCH}, ${COMMIT_URL}" --build-arg version="${DOCKER_RELEASE_TAGS:7}" \
               -t dgroup/lazylead:$CIRCLE_BRANCH . \
               -f .docker/Dockerfile
@@ -40,6 +41,7 @@ jobs:
           name: "Build & push LL VCS image"
           command: |
             sed -i "s/0\.0\.0/${DOCKER_RELEASE_TAGS}/g" .docker/vcs.dockerfile
+            sed -i "s/0\.0\.0/${DOCKER_RELEASE_TAGS}/g" lib/lazylead/version.rb
             docker build -t dgroup/lazylead:${DOCKER_RELEASE_TAGS}-vcs . -f .docker/vcs.dockerfile
             docker push dgroup/lazylead:${DOCKER_RELEASE_TAGS}-vcs
       - run:

data/bin/lazylead

@@ -60,6 +60,9 @@ Available options:"
   o.string "--vcs4sql",
            "Home directory with database version control(vcs) scripts",
            default: "upgrades/sqlite"
+  o.integer "--max-connections",
+            "SQL connections pool size",
+            default: 5
   o.bool "--testdata",
          "Apply the database VCS migration with test data",
          default: false

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.3.0"
+  s.version = "0.3.1"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.3.0!
+  s.post_install_message = "Thanks for installing Lazylead v0.3.1!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead

data/lib/lazylead/cc.rb

@@ -37,20 +37,26 @@ module Lazylead
     #  - Empty
     #
     def detect(emails, sys)
+      return emails if recognized?(emails)
       return PlainCC.new(emails) if plain?(emails)
-      return EmptyCC unless emails.key? "type"
-      return EmptyCC if emails["type"].blank? || emails["type"].nil?
+      return EmptyCC.new if undefined?(emails)
       type = emails["type"].constantize
       return ComponentCC.new(emails["project"], sys) if type.is_a? ComponentCC
       type.new(emails["opts"])
     end
 
-    private
-
     # Detect that raw CC is a string which may has plain email addresses
     def plain?(text)
-      (text.is_a? String) &&
-        (text.to_s.include?(",") || text.to_s.include?("@"))
+      (text.is_a? String) && text.to_s.include?("@")
+    end
+
+    def recognized?(emails)
+      [EmptyCC, PlainCC, ComponentCC, PredefinedCC].member? emails.class
+    end
+
+    def undefined?(emails)
+      return true unless emails.key? "type"
+      emails["type"].nil? || emails["type"].blank?
     end
   end
 

data/lib/lazylead/cli/app.rb

@@ -48,7 +48,7 @@ module Lazylead
 
       def run(opts)
         apply_vcs_migration opts
-        enable_active_record
+        enable_active_record opts
         @smtp.enable
         schedule_tasks
       end
@@ -63,10 +63,11 @@ module Lazylead
         @log.debug "Migration applied to #{@db} from #{vcs}"
       end
 
-      def enable_active_record
+      def enable_active_record(opts)
         ActiveRecord::Base.establish_connection(
           adapter: "sqlite3",
-          database: @db
+          database: @db,
+          pool: opts[:max_connections]
         )
         @log.debug "Database connection established"
       end

data/lib/lazylead/model.rb

@@ -91,6 +91,10 @@ module Lazylead
       belongs_to :team, foreign_key: "team_id"
       belongs_to :system, foreign_key: "system"
 
+      # @todo #/DEV Add error handling for StandartError with support of
+      #  verbose key from ARGV like in /bin/lazylead. That will make error
+      #  messages more human readable. Maybe there is some integration between
+      #  Slop and ARGV in order to avoid logic duplication.
       def exec(log = Log::NOTHING)
         log.debug("Task ##{id} '#{name}' is started")
         sys = system.connect(log)

data/lib/lazylead/schedule.rb

@@ -22,7 +22,7 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
-require "json"
+require "active_support"
 require "rufus-scheduler"
 require_relative "log"
 require_relative "model"
@@ -51,7 +51,9 @@ module Lazylead
     def register(task)
       raise "ll-002: task can't be a null" if task.nil?
       @trigger.cron task.cron do
-        task.exec @log
+        ActiveRecord::Base.connection_pool.with_connection do
+          task.exec @log
+        end
       end
       @log.debug "Task scheduled: #{task}"
     end

data/lib/lazylead/system/fake.rb

@@ -34,7 +34,7 @@ module Lazylead
       @issues = issues
     end
 
-    def issues(_, _)
+    def issues(*)
       @issues
     end
   end

data/lib/lazylead/system/jira.rb

@@ -273,7 +273,7 @@ module Lazylead
       @issues = issues
     end
 
-    def issues(_, _)
+    def issues(*)
       @issues
     end
 

data/lib/lazylead/version.rb

@@ -23,5 +23,5 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Lazylead
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/readme.md

@@ -19,7 +19,7 @@
 [![DevOps By Rultor.com](http://www.rultor.com/b/dgroup/lazylead)](http://www.rultor.com/p/dgroup/lazylead)
 [![EO badge](http://www.elegantobjects.org/badge.svg)](http://www.elegantobjects.org/#principles)
 
-⚠️ We're still in a very early alpha version, the API may change frequently until we release version 1.0.
+⚠️ We're still in a very early alpha version, the API may change frequently until we release version `1.0`.
 
 ### Overview
 Ticketing systems (Github, Jira, etc.) are strongly integrated into our processes and everyone understands their necessity. As soon as a developer becomes a lead/technical manager, he or she faces a set of routine tasks that are related to ticketing work. On large projects this becomes a problem, more and more you spend time running around on dashboards and tickets, looking for incorrect deviations in tickets and performing routine tasks instead of solving technical problems.
@@ -61,7 +61,7 @@ Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 New ideas, bugs, suggestions or questions are welcome [via GitHub issues](https://github.com/dgroup/lazylead/issues/new)!
 
 ### Get started
-⚠️ We're still in a very early alpha version, the API may change frequently until we release version 1.0.
+⚠️ We're still in a very early alpha version, the API may change frequently until we release version `1.0`.
 
 Let's assume that:
 - your team is using jira as a ticketing system

data/test/lazylead/cc_test.rb

@@ -29,6 +29,26 @@ require_relative "../../lib/lazylead/cc"
 require_relative "../../lib/lazylead/system/jira"
 
 module Lazylead
+  class CcTest < Lazylead::Test
+    test "plain cc detected as text" do
+      assert Lazylead::CC.new.plain? "a@fake.com,b@fake.com"
+    end
+    test "plain cc not found in text" do
+      refute Lazylead::CC.new.plain? "justatext.com,eeeee.com"
+    end
+    test "plain cc detected as object" do
+      assert Lazylead::CC.new.recognized? Lazylead::PlainCC.new("a@fake.com")
+    end
+    test "cc is incorrect" do
+      refute Lazylead::CC.new.recognized? key: "value"
+    end
+    test "cc is not found in hash" do
+      assert Lazylead::CC.new.undefined? key: "value"
+    end
+    test "cc type is blank" do
+      assert Lazylead::CC.new.undefined? "type" => "    "
+    end
+  end
   class PlainCcTest < Lazylead::Test
     test "cc has valid email" do
       assert_equal "a@fake.com", Lazylead::PlainCC.new("a@fake.com").cc.first

data/test/lazylead/task/duedate_test.rb

@@ -119,7 +119,7 @@ module Lazylead
                                    .first.cc
     end
 
-    test "reporter got alert about his/her tickets with expired due dates" do
+    test "reporter got alert about his/her tickets with expired DD" do
       Smtp.new.enable
       Task::ReporterAlert.new.run(
         NoAuthJira.new("https://jira.spring.io"),

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lazylead
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Yurii Dubinka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-12 00:00:00.000000000 Z
+date: 2020-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -622,7 +622,6 @@ files:
 - test/lazylead/version_test.rb
 - test/sqlite_test.rb
 - test/test.rb
-- todo.yml
 - upgrades/sqlite/001-install-main-lazylead-tables.sql
 - upgrades/sqlite/999.testdata.sql
 homepage: http://github.com/dgroup/lazylead
@@ -630,7 +629,7 @@ licenses:
 - MIT
 metadata: {}
 post_install_message: |-
-  Thanks for installing Lazylead v0.3.0!
+  Thanks for installing Lazylead v0.3.1!
     Read our blog posts: https://lazylead.org
     Stay in touch with the community in Telegram: https://t.me/lazylead
     Follow us on Twitter: https://twitter.com/lazylead

data/todo.yml

@@ -1,6 +0,0 @@
-# @todo #/DEV Enable Travis CI as second CI server once the project
-#  became a public. This might be alternative for Circle CI (just in case)
-
-# @todo #/DEV Add Github integration for lazylead with the same methods as in Jira.
-
-# @todo #/DEV Add Trello integration for lazylead with the same methods as in Jira.