lazy_mapper 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '08c13aa83740c1719069305ba2be381b32c65ed59017fa251d16a2c5590dd945'
-  data.tar.gz: 5f1febab53594a456df8b842972f8ea26015270fd3043853a991ab7b467eae9e
+  metadata.gz: cdd5ce6d6e5cfaffaac7c6e73fc0692d5b3657888d26bb12bd54eb9f1bf48799
+  data.tar.gz: e38a3b2f0c571627583feceb7ac3dc87e4c47f2170cbc815e16779e57c083e07
 SHA512:
-  metadata.gz: d4c44f93957f6b04c7069b3f7991862f75d6539ab8b2ae70ebbbcdfbfe4080d59548b9a7b2364cc18dd0c16a1b4b223df6417fb039d57fd36718fd17aa36da17
-  data.tar.gz: 05523ef4f8fc5d26a335c0b8be671d8e38e677ada3a350e6817cc1a13691b616ed6d8c0b7617c16735894bfe6e799117076dfd100abe15ab44c5798afa8aa2e3
+  metadata.gz: a9e5ae539bb7ca177712621f9f7416e636d4cf101cb311a8e0ab257dca496f7bd9d675936e982b61a94f3035bed6f38c833cd8f4cfe0fc406f0f5a30d1f2e3ff
+  data.tar.gz: 894084472c088c23256ed76b9e4c568d56e2a2d986104b50c28550358e65fea9ca89326323f26d58f703dbe0c3f7b7f51b73d9f006414e1821fdccce4fd2c91c

data/.gitignore

@@ -7,3 +7,4 @@ log/
 tmp/
 .idea/
 Gemfile.lock
+*.gem

data/README.md

@@ -1,6 +1,6 @@
-# LazyModel
+# LazyMapper
 
-Wraps a JSON object and lazily maps its attributes to rich domain objects using either a set of default mappers (for Ruby's built-in types), or custom mappers specified by the client.
+Wraps a Hash and lazily maps its attributes to rich domain objects using either a set of default mappers (for Ruby's built-in types), or custom mappers specified by the client.
 
 The mapped values are memoized.
 

data/lazy_mapper.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lazy_mapper'
-  spec.version       = '0.1.0'
+  spec.version       = '0.1.1'
   spec.summary       = "A lazy object mapper"
   spec.description   = "Wraps primitive data in a semantically rich model"
   spec.authors       = ["Adam Lett"]

data/lib/lazy_mapper.rb

@@ -122,29 +122,35 @@ class LazyMapper
 
   # = ::one
   #
-  # Defines an attribute
+  # Defines an attribute and creates a reader and a writer for it.
+  # The writer verifies the type of it's supplied value.
   #
   # == Arguments
   #
-  # +name+ - The name of the attribue
+  # +name+    - The name of the attribue
   #
-  # +type+ - The type of the attribute. If  the wrapped value is already of
-  #          that type, the mapper is bypassed.
+  # +type+    - The type of the attribute. If the wrapped value is already of
+  #             that type, the mapper is bypassed.
+  #             If the type is allowed be one of several, use an Array to
+  #             to specify which ones
   #
-  # +from:+ - Specifies the name of the wrapped value in the JSON object.
-  #           Defaults to camelCased version of +name+.
+  # +from:+    - Specifies the name of the wrapped value in the JSON object.
+  #              Defaults to camelCased version of +name+.
   #
-  # +map:+  - Specifies a custom mapper to apply to the wrapped value. Must be
-  #           a Callable. If unspecified, it defaults to the default mapper for the
-  #           specified +type+ or simply the identity mapper if no default mapper exists.
+  # +map:+     - Specifies a custom mapper to apply to the wrapped value. Must be
+  #              a Callable. If unspecified, it defaults to the default mapper for the
+  #              specified +type+ or simply the identity mapper if no default mapper exists.
   #
-  # +default:+ - The default value to use, if the wrapped value is not present
+  # +default:+  - The default value to use, if the wrapped value is not present
   #              in the wrapped JSON object.
   #
+  # +allow_nil:+ - If true, allows the mapped value to be nil. Defaults to true.
+  #
   # == Example
   #
   #    class Foo < LazyMapper
   #      one :boss, Person, from: "supervisor", map: ->(p) { Person.new(p) }
+  #      one :weapon, [BladedWeapon, Firearm], default: Sixshooter.new
   #      # ...
   #    end
   #
@@ -259,6 +265,9 @@ class LazyMapper
   end
 
   def inspect
+    @__under_inspection__ ||= 0
+    return "<#{ self.class.name } ... >" if @__under_inspection__ > 0
+    @__under_inspection__ += 1
     attributes = self.class.attributes
     if self.class.superclass.respond_to? :attributes
       attributes = self.class.superclass.attributes.merge attributes
@@ -268,6 +277,9 @@ class LazyMapper
       memo[name] = value unless value.nil?
     }
     "<#{ self.class.name } #{ present_attributes.map {|k,v| k.to_s + ': ' + v.inspect }.join(', ') } >"
+    res = "<#{ self.class.name } #{ present_attributes.map {|k,v| k.to_s + ': ' + v.inspect }.join(', ') } >"
+    @__under_inspection__ -= 1
+    res
   end
 
   protected
@@ -281,10 +293,10 @@ class LazyMapper
   # to the corresponding name in the unmapped
   # JSON object.
   #
-  # Defaults to #camelize
+  # Defaults to CAMELIZE
   #
   def self.map_name(name)
-    camelize(name)
+    CAMELIZE[name]
   end
 
   private
@@ -332,10 +344,5 @@ class LazyMapper
   end
 
   SNAKE_CASE_PATTERN = /(_[a-z])/
-
-  # "foo_bar_baz" -> "fooBarBaz"
-  # "foo_bar?" -> "fooBar"
-  def self.camelize(name)
-    name.to_s.gsub(SNAKE_CASE_PATTERN) { |x| x[1].upcase }.gsub('?', '')
-  end
+  CAMELIZE = -> name { name.to_s.gsub(SNAKE_CASE_PATTERN) { |x| x[1].upcase }.gsub('?', '') }
 end

data/spec/lazy_mapper_spec.rb

@@ -5,7 +5,7 @@ require 'lazy_mapper'
 
 describe LazyMapper do
 
-  describe '.from_json' do
+  describe 'when constructed with .from_json' do
 
     subject(:instance) { klass.from_json json }
 
@@ -74,6 +74,36 @@ describe LazyMapper do
           expect(mapper).to have_received(:map).exactly(1).times.with('42')
         end
       end
+
+      context 'when the model has circular references' do
+
+        subject(:instance) { foo }
+
+        let(:foo) { klass_foo.from_json 'bar' => 'bar' }
+        let(:bar) { klass_bar.from_json 'foo' => 'foo' }
+        let(:foo_builder) { proc { foo } }
+        let(:bar_builder) { proc { bar } }
+
+        let(:klass_foo) {
+          b = bar_builder
+          Class.new LazyMapper do
+            one :bar, Object, map: b
+          end
+        }
+
+        let(:klass_bar) {
+          b = foo_builder
+          Class.new LazyMapper do
+            one :foo, Object, map: b
+          end
+        }
+
+        it 'avoids infinit recursion, when inspected' do
+          stub_const('Bar', klass_bar)
+          stub_const('Foo', klass_foo)
+          expect(foo.inspect).to eq('<Foo bar: <Bar foo: <Foo ... > > >')
+        end
+      end
     end
 
     describe 'the :from option' do
@@ -167,7 +197,7 @@ describe LazyMapper do
     end
   end
 
-  context 'construction' do
+  context 'when constructed with .new' do
 
     subject(:instance) { klass.new values }
     let(:values) { {} }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lazy_mapper
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Adam Lett
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-21 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport