launchy 2.5.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45f9c18d9b5afe8a29abfbdfb770545f3616ee1ec2547d60762e14604fd5c2e6
-  data.tar.gz: e84671dd85e089af53899b7ee595450536522bf5f00bf88d61a775a70dfc0647
+  metadata.gz: 147fa0dafa116ae097364aab290ffdb2f508ff44b87019dc266aeaccf1963ab7
+  data.tar.gz: aad595ea32b9a1b1027c0650fd23b1a19865dda3f60c76890e6b0bb1be9e6c0d
 SHA512:
-  metadata.gz: ffb4ab18f93e33bbedfe05f3506574dc7163974bcaca7057d46eae15c1a3a7369d6031cf4779769e873c33bcfb16808e0e2dddfa4477fc72c469549b68ec5685
-  data.tar.gz: f43067afd034ea8b145a3b183ccd5ed3c4cfff4c2524233310112fdbb39e69fb7d1493f4b0816a58e7297dde8ef4efd783dec699ff262317dfe27b959b9d3943
+  metadata.gz: b8193061c42405778b539067521999e9ff2776c0317ba8fae47ce300d901e55473abccad60486b93952e101a32c15a8d462205880c1ceaf7a1a6fe04833b6404
+  data.tar.gz: 57b74c3a254e4437b04b4baa367abb384e733bef508f8f746a22c13997ce13b063208fe6c5c9b16bb8e6963aad2d59367d1aea1188e3326c7aaac69f1e53cae9

data/CONTRIBUTING.md

@@ -51,6 +51,7 @@ easiest way to contribute.
 * [Daniel Farina](https://github.com/fdr)
 * [Jack Turnbull](https://github.com/jackturnbull)
 * [Jeremy Moritz](https://github.com/jeremymoritz)
+* [Jamie Donnelly](https://github.com/JamieKDonnelly)
 
 [GitHub Account]: https://github.com/signup/free "GitHub Signup"
 [GitHub Issues]:  https://github.com/copiousfreetime/launchy/issues "Launchy Issues"

data/HISTORY.md

@@ -1,4 +1,30 @@
 # Launchy Changelog
+## Version 3.1.1 - 2025-02-21
+* Fix the quoted parameter for windows launching - <https://github.com/copiousfreetime/launchy/issues/164>
+
+## Version 3.1.0 - 2025-01-23
+* Fix the argv array when passing to ChildProcess on windows - <https://github.com/copiousfreetime/launchy/issues/159>
+* Update the ruby test matrix for 3.4
+* Update the ruby test matrix to drop 3.0
+
+## Version 3.0.1 - 2024-05-03
+* Added rubocop and fix all the warnings
+* Fix rubygem changelog_uri - Spone
+* Update the semaphore flow
+* Update the ruby test matrix
+* Change to Gemfile for development
+
+## Version 3.0.0 - 2024-03-03
+* Remove unused `deprecated.rb` file - <https://github.com/copiousfreetime/launchy/issues/148>
+* Update supported ruby version to be 3.x
+* use the `:application` parameter - <https://github.com/copiousfreetime/launchy/issues/121>
+* adjust the semaphore configuration to allow better caching
+* replace the homegrown process runner with [`childprocess`](https://rubygems.org/gems/childprocess)
+
+## Version 2.5.2 - 2022-12-27
+* Update Addressable - <https://github.com/copiousfreetime/launchy/pull/145> - JamieKDonnelly
+* Fix deprecated usage of `Object#=~` - <https://github.com/copiousfreetime/launchy/pull/138> - marcrohloff
+* Move to sempahore for matrix builds and macos tests
 
 ## Version 2.5.0 - 2020-02-27
 * Update depedencies
@@ -21,12 +47,12 @@
 * Abstract out the argv of the commandline - <https://github.com/copiousfreetime/launchy/issues/71>
 
 ## Version 2.4.0 - 2013-11-12
-* Support `Launchy.open( url, :debug => true )` - <http://github.com/copiousfreetime/launchy/issues/63> - schmich
-* Fix inconsistencies in `debug?` and `dry_run?` methods - <http://github.com/copiousfreetime/launchy/issues/63> - schmich
-* Fix detection of missing *nix desktops - <http://github.com/copiousfreetime/launchy/issues/70>
-* Fix running tests in bare Linux environment - <http://github.com/copiousfreetime/launchy/issues/67> - gioele
-* Fix mistaking windows drive as uri schema - <http://github.com/copiousfreetime/launchy/issues/65>
-* Attempt fixing windows `start` command oddities, again - <http://github.com/copiousfreetime/launchy/issues/62>
+* Support `Launchy.open( url, :debug => true )` - <https://github.com/copiousfreetime/launchy/issues/63> - schmich
+* Fix inconsistencies in `debug?` and `dry_run?` methods - <https://github.com/copiousfreetime/launchy/issues/63> - schmich
+* Fix detection of missing *nix desktops - <https://github.com/copiousfreetime/launchy/issues/70>
+* Fix running tests in bare Linux environment - <https://github.com/copiousfreetime/launchy/issues/67> - gioele
+* Fix mistaking windows drive as uri schema - <https://github.com/copiousfreetime/launchy/issues/65>
+* Attempt fixing windows `start` command oddities, again - <https://github.com/copiousfreetime/launchy/issues/62>
 
 ## Version 2.3.0 - 2013-04-11
 
@@ -34,39 +60,39 @@
 
 ## Version 2.2.0 - 2013-02-06
 
-* Change XFCE detection to not depend on grep <http://github.com/copiousfreetime/launchy/issues/52> - bogdan
-* Suppress forked process output <http://github.com/copiousfreetime/launchy/issues/51>
-* Display help/usage if no url is given <http://github.com/copiousfreetime/launchy/issues/54>
-* Detect the fluxbox environment <http://github.com/copiousfreetime/launchy/issues/53>
-* Automatically detect `http` url's if they are missing the `http://` <http://github.com/copiousfreetime/launchy/issues/55>
+* Change XFCE detection to not depend on grep <https://github.com/copiousfreetime/launchy/issues/52> - bogdan
+* Suppress forked process output <https://github.com/copiousfreetime/launchy/issues/51>
+* Display help/usage if no url is given <https://github.com/copiousfreetime/launchy/issues/54>
+* Detect the fluxbox environment <https://github.com/copiousfreetime/launchy/issues/53>
+* Automatically detect `http` url's if they are missing the `http://` <https://github.com/copiousfreetime/launchy/issues/55>
 * Update to latest project management rake tasks
 
 ## Version 2.1.2 - 2012-08-06
 
-* Fix where HostOS would fail to convert to string on JRuby in 1.9 mode <http://github.com/copiousfreetime/launchy/issues/45>
+* Fix where HostOS would fail to convert to string on JRuby in 1.9 mode <https://github.com/copiousfreetime/launchy/issues/45>
 
 ## Version 2.1.1 - 2012-07-28
 
-* Update addressable runtime dependency <http://github.com/copiousfreetime/launchy/issues/47>
+* Update addressable runtime dependency <https://github.com/copiousfreetime/launchy/issues/47>
 * Bring minitest and ffi development dependencies up to date
 
 ## Version 2.1.0 - 2012-03-18
 
-* Fix raising exception when no browser program found <http://github.com/copiousfreetime/launchy/issues/42>
+* Fix raising exception when no browser program found <https://github.com/copiousfreetime/launchy/issues/42>
 * Add `LAUNCHY_DRY_RUN` environment variable (Mariusz Pietrzyk / wijet)
 * Update dependencies
 
 ## Version 2.0.5 - 2011-07-24
 
-* Fix the case where `$BROWSER` is set and no *nix desktop was found <http://github.com/copiousfreetime/launchy/issues/33>
+* Fix the case where `$BROWSER` is set and no *nix desktop was found <https://github.com/copiousfreetime/launchy/issues/33>
 
 ## Version 2.0.4 - 2011-07-23
 
-* Fix windows `start` commandline <http://github.com/copiousfreetime/launchy/issues/5>
-* Add capability to open local files with no file: scheme present <http://github.com/copiousfreetime/launchy/issues/29>
-* Added `rake how_to_contribute` task <http://github.com/copiousfreetime/launchy/issues/30>
-* Make better decisions on when to do shell escaping <http://github.com/copiousfreetime/launchy/issues/31>
-* Switch to Addressable::URI so UTF-8 urls may be parsed. <http://github.com/copiousfreetime/launchy/issues/32>
+* Fix windows `start` commandline <https://github.com/copiousfreetime/launchy/issues/5>
+* Add capability to open local files with no file: scheme present <https://github.com/copiousfreetime/launchy/issues/29>
+* Added `rake how_to_contribute` task <https://github.com/copiousfreetime/launchy/issues/30>
+* Make better decisions on when to do shell escaping <https://github.com/copiousfreetime/launchy/issues/31>
+* Switch to Addressable::URI so UTF-8 urls may be parsed. <https://github.com/copiousfreetime/launchy/issues/32>
 
 ## Version 2.0.3 - 2011-07-17
 

data/{LICENSE → LICENSE.txt}

@@ -1,4 +1,4 @@
-ISC LICENSE - http://opensource.org/licenses/isc-license.txt
+ISC LICENSE - https://opensource.org/licenses/isc-license.txt
 
 Copyright (c) 2007-2020 Jeremy Hinegardner
 

data/Manifest.txt

@@ -1,38 +1,21 @@
 CONTRIBUTING.md
 HISTORY.md
-LICENSE
+LICENSE.txt
 Manifest.txt
 README.md
-Rakefile
-bin/launchy
+exe/launchy
+launchy.gemspec
 lib/launchy.rb
 lib/launchy/application.rb
 lib/launchy/applications/browser.rb
 lib/launchy/argv.rb
 lib/launchy/cli.rb
-lib/launchy/deprecated.rb
 lib/launchy/descendant_tracker.rb
 lib/launchy/detect.rb
 lib/launchy/detect/host_os.rb
 lib/launchy/detect/host_os_family.rb
 lib/launchy/detect/nix_desktop_environment.rb
-lib/launchy/detect/ruby_engine.rb
-lib/launchy/detect/runner.rb
 lib/launchy/error.rb
 lib/launchy/os_family.rb
+lib/launchy/runner.rb
 lib/launchy/version.rb
-spec/application_spec.rb
-spec/applications/browser_spec.rb
-spec/cli_spec.rb
-spec/detect/host_os_family_spec.rb
-spec/detect/host_os_spec.rb
-spec/detect/nix_desktop_environment_spec.rb
-spec/detect/ruby_engine_spec.rb
-spec/detect/runner_spec.rb
-spec/launchy_spec.rb
-spec/mock_application.rb
-spec/spec_helper.rb
-spec/tattle-host-os.yaml
-spec/version_spec.rb
-tasks/default.rake
-tasks/this.rb

data/README.md

@@ -1,7 +1,6 @@
 # launchy
 
-[![Build Status](https://travis-ci.org/copiousfreetime/launchy.svg?branch=master)](https://travis-ci.org/copiousfreetime/launchy)
-
+[![Build Status](https://copiousfreetime.semaphoreci.com/badges/launchy/branches/main.svg)](https://copiousfreetime.semaphoreci.com/projects/launchy)
 
 * [Homepage](https://github.com/copiousfreetime/launchy)
 * [Github Project](https://github.com/copiousfreetime/launchy)
@@ -27,14 +26,14 @@ testing environment, or via its API.
 
 ### Commandline
 
-    % launchy http://www.ruby-lang.org/
+    % launchy https://www.ruby-lang.org/
 
 There are additional command line options, use `launchy --help` to see them.
 
 ### Using the `BROWSER` environment variable
 
 Launchy has a predefined set of common browsers on each platform that it
-attempts to use, and of course it is not exhaustive. As a fallbabck you can make
+attempts to use, and of course it is not exhaustive. As a fallback you can make
 use of the somewhat standard `BROWSER` environment variable.
 
 `BROWSER` works in a similar same way to `PATH`. It is a colon (`:`) separated
@@ -43,10 +42,10 @@ you are attempting to open will be substituted there.
 
 As an example if you set `BROWSER=/usr/local/bin/firefox-bin -new-tab
 '%s':/usr/local/bin/google-chrome-stable` and you call
-`Launchy.open("http://www.ruby-lang.org/")` then Launchy will try, in order:
+`Launchy.open("https://www.ruby-lang.org/")` then Launchy will try, in order:
 
-* `/usr/local/bin/firefox-bin -new-tab 'http://www.ruby-lang.org'`
-* `/usr/local/bin/google-chrome-stable http://www.ruby-lang.org`
+* `/usr/local/bin/firefox-bin -new-tab 'https://www.ruby-lang.org'`
+* `/usr/local/bin/google-chrome-stable https://www.ruby-lang.org`
 
 Additional links on the use of `BROWSER` as an environment variable.
 
@@ -83,7 +82,7 @@ in integration tests. For example:
 
 ### Public API
 
-In the vein of [Semantic Versioning](http://semver.org), this is the sole
+In the vein of [Semantic Versioning](https://semver.org), this is the sole
 supported public API.
 
     Launchy.open( uri, options = {} ) { |exception| }
@@ -93,7 +92,6 @@ At the moment, the only available options are:
     :debug        Turn on debugging output
     :application  Explicitly state what application class is going to be used
     :host_os      Explicitly state what host operating system to pretend to be
-    :ruby_engine  Explicitly state what ruby engine to pretend to be under
     :dry_run      Do nothing and print the command that would be executed on $stdout
 
 If `Launchy.open` is invoked with a block, then no exception will be thrown, and
@@ -102,53 +100,18 @@ exception that was raised.
 
 ### An example of using the public API:
 
-    Launchy.open( "http://www.ruby-lang.org" )
+    Launchy.open( "https://www.ruby-lang.org" )
 
 ### An example of using the public API and using the error block:
 
-    uri = "http://www.ruby-lang.org"
+    uri = "https://www.ruby-lang.org"
     Launchy.open( uri ) do |exception|
       puts "Attempted to open #{uri} and failed because #{exception}"
     end
 
-## UPGRADING from versions before 2.0.0
-
-The previously published version of Launchy before the 2.0.0 series was 0.4.0.
-There have been so many changes, and a mistaken tag at 1.0.0, that I have
-decided to bump all the way to 2.x.y.
-
-I have attempted to keep backward compatibility with the previous examples. The
-previous API examples of:
-
-    Launchy::Browser.run("http://www.ruby-lang.org/")
-
-and
-
-    Launchy::Browser.new.visit("http://www.ruby-lang.org/")
-
-will still work, and you will get a deprecation notice, along with the line
-of code you should probably update. For example, this is what would print out
-in the github gem if it was updated to use 2.0.x but not use the supported API.
-
-    % gh home
-    WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
-    WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
-    WARNING:
-    WARNING: /Users/jeremy/.rvm/gems/ruby-1.8.7-p334/gems/github-0.6.2/lib/commands/helpers.rb:275:in `open'
-    WARNING: helper :open do |url|
-    WARNING:   has_launchy? proc {
-    WARNING:     Launchy::Browser.new.visit url
-    WARNING:   }
-    WARNING: end
-    WARNING:
-    WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new
-
-These deprecation notices will go away with version 3.0 and the only available
-API will be the documented one.
-
 ## ISC LICENSE
 
-http://opensource.org/licenses/isc-license.txt
+https://opensource.org/licenses/isc-license.txt
 
 Copyright (c) 2007-2020 Jeremy Hinegardner
 

data/exe/launchy

@@ -0,0 +1,5 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require "launchy"
+Launchy::Cli.new.run(ARGV, ENV)

data/launchy.gemspec

@@ -0,0 +1,33 @@
+# DO NOT EDIT - This file is automatically generated
+# Make changes to Manifest.txt and/or Rakefile and regenerate
+# -*- encoding: utf-8 -*-
+# stub: launchy 3.1.1 ruby lib
+
+Gem::Specification.new do |s|
+  s.name = "launchy".freeze
+  s.version = "3.1.1".freeze
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.metadata = { "bug_tracker_uri" => "https://github.com/copiousfreetime/launchy/issues", "changelog_uri" => "https://github.com/copiousfreetime/launchy/blob/master/HISTORY.md", "homepage_uri" => "https://github.com/copiousfreetime/launchy", "source_code_uri" => "https://github.com/copiousfreetime/launchy" } if s.respond_to? :metadata=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Jeremy Hinegardner".freeze]
+  s.bindir = "exe".freeze
+  s.date = "2025-02-21"
+  s.description = "Launchy is helper class for launching cross-platform applications in a fire and forget manner. There are application concepts (browser, email client, etc) that are common across all platforms, and they may be launched differently on each platform. Launchy is here to make a common approach to launching external applications from within ruby programs.".freeze
+  s.email = "jeremy@copiousfreetime.org".freeze
+  s.executables = ["launchy".freeze]
+  s.extra_rdoc_files = ["CONTRIBUTING.md".freeze, "HISTORY.md".freeze, "LICENSE.txt".freeze, "Manifest.txt".freeze, "README.md".freeze]
+  s.files = ["CONTRIBUTING.md".freeze, "HISTORY.md".freeze, "LICENSE.txt".freeze, "Manifest.txt".freeze, "README.md".freeze, "exe/launchy".freeze, "launchy.gemspec".freeze, "lib/launchy.rb".freeze, "lib/launchy/application.rb".freeze, "lib/launchy/applications/browser.rb".freeze, "lib/launchy/argv.rb".freeze, "lib/launchy/cli.rb".freeze, "lib/launchy/descendant_tracker.rb".freeze, "lib/launchy/detect.rb".freeze, "lib/launchy/detect/host_os.rb".freeze, "lib/launchy/detect/host_os_family.rb".freeze, "lib/launchy/detect/nix_desktop_environment.rb".freeze, "lib/launchy/error.rb".freeze, "lib/launchy/os_family.rb".freeze, "lib/launchy/runner.rb".freeze, "lib/launchy/version.rb".freeze]
+  s.homepage = "https://github.com/copiousfreetime/launchy".freeze
+  s.licenses = ["ISC".freeze]
+  s.rdoc_options = ["--main".freeze, "README.md".freeze, "--markup".freeze, "tomdoc".freeze]
+  s.required_ruby_version = Gem::Requirement.new(">= 2.3.0".freeze)
+  s.rubygems_version = "3.6.3".freeze
+  s.summary = "Launchy is helper class for launching cross-platform applications in a fire and forget manner.".freeze
+
+  s.specification_version = 4
+
+  s.add_runtime_dependency(%q<addressable>.freeze, ["~> 2.8".freeze])
+  s.add_runtime_dependency(%q<childprocess>.freeze, ["~> 5.0".freeze])
+  s.add_runtime_dependency(%q<logger>.freeze, ["~> 1.6".freeze])
+end

data/lib/launchy/application.rb

@@ -1,4 +1,6 @@
-require 'set'
+# frozen_string_literal: true
+
+require "set"
 module Launchy
   #
   # Application is the base class of all the application types that launchy may
@@ -18,45 +20,61 @@ module Launchy
       # Find the application that handles the given uri.
       #
       # returns the Class that can handle the uri
-      def handling( uri )
-        klass = find_child( :handles?, uri )
+      def handling(uri)
+        klass = find_child(:handles?, uri)
         return klass if klass
+
         raise ApplicationNotFoundError, "No application found to handle '#{uri}'"
       end
 
+      # Find the application with the given name
       #
+      # returns the Class that has the given name
+      def for_name(name)
+        klass = find_child(:has_name?, name)
+        return klass if klass
+
+        raise ApplicationNotFoundError, "No application found named '#{name}'"
+      end
+
       # Find the given executable in the available paths
-      def find_executable( bin, *paths )
-        paths = Launchy.path.split( File::PATH_SEPARATOR ) if paths.empty?
+      #
+      # returns the path to the executable or nil if not found
+      def find_executable(bin, *paths)
+        paths = Launchy.path.split(File::PATH_SEPARATOR) if paths.empty?
         paths.each do |path|
-          file = File.join( path, bin )
-          if File.executable?( file ) then
-            Launchy.log "#{self.name} : found executable #{file}"
+          file = File.join(path, bin)
+          if File.executable?(file)
+            Launchy.log "#{name} : found executable #{file}"
             return file
           end
         end
-        Launchy.log "#{self.name} : Unable to find `#{bin}' in #{paths.join(", ")}"
-        return nil
+        Launchy.log "#{name} : Unable to find `#{bin}' in #{paths.join(', ')}"
+        nil
+      end
+
+      # Does this class have the given name-like string?
+      #
+      # returns true if the class has the given name
+      def has_name?(qname)
+        qname.to_s.downcase == name.split("::").last.downcase
       end
     end
 
-    attr_reader :host_os_family
-    attr_reader :ruby_engine
-    attr_reader :runner
+    attr_reader :host_os_family, :runner
 
     def initialize
       @host_os_family = Launchy::Detect::HostOsFamily.detect
-      @ruby_engine    = Launchy::Detect::RubyEngine.detect
-      @runner         = Launchy::Detect::Runner.detect
+      @runner         = Launchy::Runner.new
     end
 
-    def find_executable( bin, *paths )
-      Application.find_executable( bin, *paths )
+    def find_executable(bin, *paths)
+      Application.find_executable(bin, *paths)
     end
 
-    def run( cmd, *args )
-      runner.run( cmd, *args )
+    def run(cmd, *args)
+      runner.run(cmd, *args)
     end
   end
 end
-require 'launchy/applications/browser'
+require "launchy/applications/browser"

data/lib/launchy/applications/browser.rb

@@ -1,82 +1,89 @@
-class Launchy::Application
-  #
-  # The class handling the browser application and all of its schemes
-  #
-  class Browser < Launchy::Application
-    def self.schemes
-      %w[ http https ftp file ]
-    end
+# frozen_string_literal: true
 
-    def self.handles?( uri )
-      return true if schemes.include?( uri.scheme )
-      return true if File.exist?( uri.path )
-    end
+module Launchy
+  class Application
+    #
+    # The class handling the browser application and all of its schemes
+    #
+    class Browser < Launchy::Application
+      def self.schemes
+        %w[http https ftp file]
+      end
 
-    def windows_app_list
-      [ 'start "launchy" /b' ]
-    end
+      def self.handles?(uri)
+        return true if schemes.include?(uri.scheme)
 
-    def cygwin_app_list
-      [ 'cmd /C start "launchy" /b' ]
-    end
+        true if File.exist?(uri.path)
+      end
 
-    # hardcode this to open?
-    def darwin_app_list
-      [ find_executable( "open" ) ]
-    end
+      # The escaped \\ is necessary so that when shellsplit is done later,
+      # the "launchy", with quotes, goes through to the commandline, since that
+      def windows_app_list
+        ['start \\"launchy\\" /b']
+      end
 
-    def nix_app_list
-      nix_de = Launchy::Detect::NixDesktopEnvironment.detect
-      list   = nix_de.browsers
-      list.find_all { |argv| argv.valid? }
-    end
+      def cygwin_app_list
+        ['cmd /C start \\"launchy\\" /b']
+      end
 
-    # use a call back mechanism to get the right app_list that is decided by the 
-    # host_os_family class.
-    def app_list
-      host_os_family.app_list( self )
-    end
+      # hardcode this to open?
+      def darwin_app_list
+        [find_executable("open")]
+      end
 
-    def browser_env
-      return [] unless ENV['BROWSER']
-      browser_env = ENV['BROWSER'].split( File::PATH_SEPARATOR )
-      browser_env.flatten!
-      browser_env.delete_if { |b| b.nil? || (b.strip.size == 0) }
-      return browser_env
-    end
+      def nix_app_list
+        nix_de = Launchy::Detect::NixDesktopEnvironment.detect
+        list   = nix_de.browsers
+        list.find_all(&:valid?)
+      end
 
-    # Get the full commandline of what we are going to add the uri to
-    def browser_cmdline
-      browser_env.each do |p|
-        Launchy.log "#{self.class.name} : possibility from BROWSER environment variable : #{p}"
+      # use a call back mechanism to get the right app_list that is decided by the
+      # host_os_family class.
+      def app_list
+        host_os_family.app_list(self)
       end
-      app_list.each do |p|
-        Launchy.log "#{self.class.name} : possibility from app_list : #{p}"
+
+      def browser_env
+        return [] unless ENV["BROWSER"]
+
+        browser_env = ENV["BROWSER"].split(File::PATH_SEPARATOR)
+        browser_env.flatten!
+        browser_env.delete_if { |b| b.nil? || b.strip.empty? }
+        browser_env
       end
 
-      possibilities = (browser_env + app_list).flatten
+      # Get the full commandline of what we are going to add the uri to
+      def browser_cmdline
+        browser_env.each do |p|
+          Launchy.log "#{self.class.name} : possibility from BROWSER environment variable : #{p}"
+        end
+        app_list.each do |p|
+          Launchy.log "#{self.class.name} : possibility from app_list : #{p}"
+        end
+
+        possibilities = (browser_env + app_list).flatten
 
-      if browser = possibilities.shift then
-        Launchy.log "#{self.class.name} : Using browser value '#{browser}'"
-        return browser
+        if (browser = possibilities.shift)
+          Launchy.log "#{self.class.name} : Using browser value '#{browser}'"
+          return browser
+        end
+        raise Launchy::CommandNotFoundError,
+              "Unable to find a browser command. If this is unexpected, #{Launchy.bug_report_message}"
       end
-      raise Launchy::CommandNotFoundError, "Unable to find a browser command. If this is unexpected, #{Launchy.bug_report_message}"
-    end
 
-    def cmd_and_args( uri, options = {} )
-      cmd = browser_cmdline
-      args = [ uri.to_s ]
-      if cmd =~ /%s/ then
-        cmd.gsub!( /%s/, args.shift )
+      def cmd_and_args(uri, _options = {})
+        cmd = browser_cmdline.to_s
+        args = [uri.to_s]
+        cmd.gsub!("%s", args.shift) if cmd.include?("%s")
+        [cmd, args]
       end
-      return [cmd, args]
-    end
 
-    # final assembly of the command and do %s substitution 
-    # http://www.catb.org/~esr/BROWSER/index.html
-    def open( uri, options = {} )
-      cmd, args = cmd_and_args( uri, options )
-      run( cmd, args )
+      # final assembly of the command and do %s substitution
+      # http://www.catb.org/~esr/BROWSER/index.html
+      def open(uri, options = {})
+        cmd, args = cmd_and_args(uri, options)
+        run(cmd, args)
+      end
     end
   end
 end

data/lib/launchy/argv.rb

@@ -1,12 +1,17 @@
+# frozen_string_literal: true
+
 module Launchy
+  # Internal: Ecapsulate the commandline argumens passed to Launchy
+  #
   class Argv
     attr_reader :argv
-    def initialize( *args )
+
+    def initialize(*args)
       @argv = args.flatten
     end
 
     def to_s
-      @argv.join(' ')
+      @argv.join(" ")
     end
 
     def to_str
@@ -18,18 +23,18 @@ module Launchy
     end
 
     def valid?
-      (not blank?) && executable?
+      !blank? && executable?
     end
 
     def blank?
-      @argv.empty? || (@argv.first.strip.size == 0)
+      @argv.empty? || @argv.first.strip.empty?
     end
 
     def executable?
-      ::Launchy::Application.find_executable( @argv.first )
+      ::Launchy::Application.find_executable(@argv.first)
     end
 
-    def ==( other )
+    def ==(other)
       @argv == other.argv
     end
   end