launchy 2.4.3 → 2.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 020cdb8c9a8e1da529b3d15415fe5e276a4e765d
-  data.tar.gz: 3c0fb5fff34cc96ddcf02434e94771e7cb72f220
+SHA256:
+  metadata.gz: 04d9c66ec0c8dcc2892bc46267fe37f7f1c82d14dad78d62c8adbd869a0d8a0f
+  data.tar.gz: ecf5f8096d6f3ef2a4d9118b18086eba83ed62f50362c1964938faba8d53d624
 SHA512:
-  metadata.gz: 65a8da912395f266b1a2779d1b6a9f2898271569af2ca9457a5eed6294db3ce06f6ea51ed5dd3a6d5b899d3713e4af6d801e0c7eaa9371b61627a70d34edfa15
-  data.tar.gz: 39b920651bf1a11f6c03a8a3028d2933f6b5009e58ce7038c011c650d2a9999a289d37b6a9eab6f6d9f05410eb15ab18beca00b98c642bc35cc28f7fb732602f
+  metadata.gz: 4abd13c2b9c600a9e2a50d07a2a8bfbe6ae21de1972063520669f558b5b7f3eca6dc5e4a2de63d1a19c6dcdeb43a53bddc22da210556a2a6c64ba263afed92ec
+  data.tar.gz: 53feae60f4355edcddaa16497c5606f35eaccabd81d21f35d91ac3188314affd43f722970fe4c31249a89fbfadf7afc74579ee7d97f4740f1d339b0007a577e5

data/CONTRIBUTING.md

@@ -27,9 +27,9 @@ easiest way to contribute.
 * Fork the [repo][].
 * Create a new branch for your issue: `git checkout -b issue/my-issue`
 * Lovingly craft your contribution:
-    * `rake develop` to get started, or if you prefer bundler `rake develop:using_bundler && bundle`.
-    * `rake test` to run tests
-* Make sure that `rake test` passes. It's important, I said it twice.
+    * `rake develop` to get started
+    * `bundle exec rake test` to run tests
+* Make sure that `bundle exec rake test` passes. It's important, I said it twice.
 * Add yourself to the contributors section below.
 * Submit your [pull request][].
 
@@ -50,6 +50,8 @@ easiest way to contribute.
 * [Cédric Félizard](https://github.com/infertux)
 * [Daniel Farina](https://github.com/fdr)
 * [Jack Turnbull](https://github.com/jackturnbull)
+* [Jeremy Moritz](https://github.com/jeremymoritz)
+* [Jamie Donnelly](https://github.com/JamieKDonnelly)
 
 [GitHub Account]: https://github.com/signup/free "GitHub Signup"
 [GitHub Issues]:  https://github.com/copiousfreetime/launchy/issues "Launchy Issues"

data/HISTORY.md

@@ -1,4 +1,16 @@
 # Launchy Changelog
+## Version 2.5.2 - 2022-12-27
+* Update Addressable - <https://github.com/copiousfreetime/launchy/pull/145> - JamieKDonnelly
+* Fix deprecated usage of `Object#=~` - <https://github.com/copiousfreetime/launchy/pull/138> - marcrohloff
+* Move to sempahore for matrix builds and macos tests
+
+## Version 2.5.0 - 2020-02-27
+* Update depedencies
+* Update minimum ruby level
+* Move to `kde-open` on KDE - <https://github.com/copiousfreetime/launchy/pull/105> - wstephenson
+* Applied some grammer / spelling fixes - <https://github.com/copiousfreetime/launchy/pull/130> - jeremymoritz
+* `Pathname` instances do not raise exceptions when opening local files - <https://github.com/copiousfreetime/launchy/issues/101> - dmke
+* Add a fallback console browsers - <https://github.com/copiousfreetime/launchy/issues/93> - trejkaz
 
 ## Version 2.4.3 - 2014-11-03
 * Update documentation - <https://github.com/copiousfreetime/launchy/pull/81> - supremebeing7
@@ -13,12 +25,12 @@
 * Abstract out the argv of the commandline - <https://github.com/copiousfreetime/launchy/issues/71>
 
 ## Version 2.4.0 - 2013-11-12
-* Support `Launchy.open( url, :debug => true )` - <http://github.com/copiousfreetime/launchy/issues/63> - schmich
-* Fix inconsistencies in `debug?` and `dry_run?` methods - <http://github.com/copiousfreetime/launchy/issues/63> - schmich
-* Fix detection of missing *nix desktops - <http://github.com/copiousfreetime/launchy/issues/70>
-* Fix running tests in bare Linux environment - <http://github.com/copiousfreetime/launchy/issues/67> - gioele
-* Fix mistaking windows drive as uri schema - <http://github.com/copiousfreetime/launchy/issues/65>
-* Attempt fixing windows `start` command oddities, again - <http://github.com/copiousfreetime/launchy/issues/62>
+* Support `Launchy.open( url, :debug => true )` - <https://github.com/copiousfreetime/launchy/issues/63> - schmich
+* Fix inconsistencies in `debug?` and `dry_run?` methods - <https://github.com/copiousfreetime/launchy/issues/63> - schmich
+* Fix detection of missing *nix desktops - <https://github.com/copiousfreetime/launchy/issues/70>
+* Fix running tests in bare Linux environment - <https://github.com/copiousfreetime/launchy/issues/67> - gioele
+* Fix mistaking windows drive as uri schema - <https://github.com/copiousfreetime/launchy/issues/65>
+* Attempt fixing windows `start` command oddities, again - <https://github.com/copiousfreetime/launchy/issues/62>
 
 ## Version 2.3.0 - 2013-04-11
 
@@ -26,39 +38,39 @@
 
 ## Version 2.2.0 - 2013-02-06
 
-* Change XFCE detection to not depend on grep <http://github.com/copiousfreetime/launchy/issues/52> - bogdan
-* Suppress forked process output <http://github.com/copiousfreetime/launchy/issues/51>
-* Display help/usage if no url is given <http://github.com/copiousfreetime/launchy/issues/54>
-* Detect the fluxbox environment <http://github.com/copiousfreetime/launchy/issues/53>
-* Automatically detect `http` url's if they are missing the `http://` <http://github.com/copiousfreetime/launchy/issues/55>
+* Change XFCE detection to not depend on grep <https://github.com/copiousfreetime/launchy/issues/52> - bogdan
+* Suppress forked process output <https://github.com/copiousfreetime/launchy/issues/51>
+* Display help/usage if no url is given <https://github.com/copiousfreetime/launchy/issues/54>
+* Detect the fluxbox environment <https://github.com/copiousfreetime/launchy/issues/53>
+* Automatically detect `http` url's if they are missing the `http://` <https://github.com/copiousfreetime/launchy/issues/55>
 * Update to latest project management rake tasks
 
 ## Version 2.1.2 - 2012-08-06
 
-* Fix where HostOS would fail to convert to string on JRuby in 1.9 mode <http://github.com/copiousfreetime/launchy/issues/45>
+* Fix where HostOS would fail to convert to string on JRuby in 1.9 mode <https://github.com/copiousfreetime/launchy/issues/45>
 
 ## Version 2.1.1 - 2012-07-28
 
-* Update addressable runtime dependency <http://github.com/copiousfreetime/launchy/issues/47>
+* Update addressable runtime dependency <https://github.com/copiousfreetime/launchy/issues/47>
 * Bring minitest and ffi development dependencies up to date
 
 ## Version 2.1.0 - 2012-03-18
 
-* Fix raising exception when no browser program found <http://github.com/copiousfreetime/launchy/issues/42>
+* Fix raising exception when no browser program found <https://github.com/copiousfreetime/launchy/issues/42>
 * Add `LAUNCHY_DRY_RUN` environment variable (Mariusz Pietrzyk / wijet)
 * Update dependencies
 
 ## Version 2.0.5 - 2011-07-24
 
-* Fix the case where `$BROWSER` is set and no *nix desktop was found <http://github.com/copiousfreetime/launchy/issues/33>
+* Fix the case where `$BROWSER` is set and no *nix desktop was found <https://github.com/copiousfreetime/launchy/issues/33>
 
 ## Version 2.0.4 - 2011-07-23
 
-* Fix windows `start` commandline <http://github.com/copiousfreetime/launchy/issues/5>
-* Add capability to open local files with no file: scheme present <http://github.com/copiousfreetime/launchy/issues/29>
-* Added `rake how_to_contribute` task <http://github.com/copiousfreetime/launchy/issues/30>
-* Make better decisions on when to do shell escaping <http://github.com/copiousfreetime/launchy/issues/31>
-* Switch to Addressable::URI so UTF-8 urls may be parsed. <http://github.com/copiousfreetime/launchy/issues/32>
+* Fix windows `start` commandline <https://github.com/copiousfreetime/launchy/issues/5>
+* Add capability to open local files with no file: scheme present <https://github.com/copiousfreetime/launchy/issues/29>
+* Added `rake how_to_contribute` task <https://github.com/copiousfreetime/launchy/issues/30>
+* Make better decisions on when to do shell escaping <https://github.com/copiousfreetime/launchy/issues/31>
+* Switch to Addressable::URI so UTF-8 urls may be parsed. <https://github.com/copiousfreetime/launchy/issues/32>
 
 ## Version 2.0.3 - 2011-07-17
 

data/LICENSE

@@ -1,6 +1,6 @@
-ISC LICENSE - http://opensource.org/licenses/isc-license.txt
+ISC LICENSE - https://opensource.org/licenses/isc-license.txt
 
-Copyright (c) 2007-2013 Jeremy Hinegardner
+Copyright (c) 2007-2020 Jeremy Hinegardner
 
 Permission to use, copy, modify, and/or distribute this software for any
 purpose with or without fee is hereby granted, provided that the above

data/README.md

@@ -1,8 +1,9 @@
 # launchy
 
+[![Build Status](https://copiousfreetime.semaphoreci.com/badges/launchy/branches/main.svg)](https://copiousfreetime.semaphoreci.com/projects/launchy)
+
 * [Homepage](https://github.com/copiousfreetime/launchy)
 * [Github Project](https://github.com/copiousfreetime/launchy)
-* email jeremy at hinegardner dot org
 
 ## DESCRIPTION
 
@@ -11,7 +12,7 @@ forget manner.
 
 There are application concepts (browser, email client, etc) that are common
 across all platforms, and they may be launched differently on each platform.
-Launchy is here to make a common approach to launching external application from
+Launchy is here to make a common approach to launching external applications from
 within ruby programs.
 
 ## FEATURES
@@ -20,26 +21,55 @@ Currently only launching a browser is supported.
 
 ## SYNOPSIS
 
-You can use launchy on the commandline, within the Capybara and Rspec-rails testing environment, or via its API.
+You can use launchy on the commandline, within the Capybara and Rspec-rails
+testing environment, or via its API.
 
 ### Commandline
 
-    % launchy http://www.ruby-lang.org/
+    % launchy https://www.ruby-lang.org/
+
+There are additional command line options, use `launchy --help` to see them.
+
+### Using the `BROWSER` environment variable
+
+Launchy has a predefined set of common browsers on each platform that it
+attempts to use, and of course it is not exhaustive. As a fallback you can make
+use of the somewhat standard `BROWSER` environment variable.
+
+`BROWSER` works in a similar same way to `PATH`. It is a colon (`:`) separated
+list of commands to try. You can also put in a `%s` in the command and the URL
+you are attempting to open will be substituted there.
+
+As an example if you set `BROWSER=/usr/local/bin/firefox-bin -new-tab
+'%s':/usr/local/bin/google-chrome-stable` and you call
+`Launchy.open("https://www.ruby-lang.org/")` then Launchy will try, in order:
+
+* `/usr/local/bin/firefox-bin -new-tab 'https://www.ruby-lang.org'`
+* `/usr/local/bin/google-chrome-stable https://www.ruby-lang.org`
+
+Additional links on the use of `BROWSER` as an environment variable.
 
-There are additional commandline options, use `launchy --help` to see them.
+* http://www.catb.org/esr/BROWSER/index.html
+* https://help.ubuntu.com/community/EnvironmentVariables
+* https://wiki.archlinux.org/index.php/environment_variables
 
 ### Capybara Testing
 
-First, install [Capybara](https://github.com/jnicklas/capybara) and [Rspec for Rails](https://github.com/rspec/rspec-rails). Capybara provides the following method:
+First, install [Capybara](https://github.com/jnicklas/capybara) and [Rspec for
+Rails](https://github.com/rspec/rspec-rails). Capybara provides the following
+method:
 
     save_and_open_page
 
-When inserted into your code at the place where you would like to open your program, and when rspec is run, Capybara displays this message:
+When inserted into your code at the place where you would like to open your
+program, and when rspec is run, Capybara displays this message:
 
     Page saved to /home/code/my_app_name/tmp/capybara/capybara-current-date-and-time.html with save_and_open_page.
     Please install the launchy gem to open page automatically.
 
-With Launchy installed, when rspec is run again, it will launch an unstyled instance of the specific page. It can be especially useful when debugging errors in integration tests. For example:
+With Launchy installed, when rspec is run again, it will launch an unstyled
+instance of the specific page. It can be especially useful when debugging errors
+in integration tests. For example:
 
     context "signin" do
       it "lets a user sign in" do
@@ -52,7 +82,7 @@ With Launchy installed, when rspec is run again, it will launch an unstyled inst
 
 ### Public API
 
-In the vein of [Semantic Versioning](http://semver.org), this is the sole
+In the vein of [Semantic Versioning](https://semver.org), this is the sole
 supported public API.
 
     Launchy.open( uri, options = {} ) { |exception| }
@@ -71,11 +101,11 @@ exception that was raised.
 
 ### An example of using the public API:
 
-    Launchy.open( "http://www.ruby-lang.org" )
+    Launchy.open( "https://www.ruby-lang.org" )
 
 ### An example of using the public API and using the error block:
 
-    uri = "http://www.ruby-lang.org"
+    uri = "https://www.ruby-lang.org"
     Launchy.open( uri ) do |exception|
       puts "Attempted to open #{uri} and failed because #{exception}"
     end
@@ -89,11 +119,11 @@ decided to bump all the way to 2.x.y.
 I have attempted to keep backward compatibility with the previous examples. The
 previous API examples of:
 
-    Launchy::Browser.run("http://www.ruby-lang.org/")
+    Launchy::Browser.run("https://www.ruby-lang.org/")
 
 and
 
-    Launchy::Browser.new.visit("http://www.ruby-lang.org/")
+    Launchy::Browser.new.visit("https://www.ruby-lang.org/")
 
 will still work, and you will get a deprecation notice, along with the line
 of code you should probably update. For example, this is what would print out
@@ -117,9 +147,9 @@ API will be the documented one.
 
 ## ISC LICENSE
 
-http://opensource.org/licenses/isc-license.txt
+https://opensource.org/licenses/isc-license.txt
 
-Copyright (c) 2007-2013 Jeremy Hinegardner
+Copyright (c) 2007-2020 Jeremy Hinegardner
 
 Permission to use, copy, modify, and/or distribute this software for any
 purpose with or without fee is hereby granted, provided that the above

data/Rakefile

@@ -4,22 +4,24 @@ load 'tasks/this.rb'
 This.name     = "launchy"
 This.author   = "Jeremy Hinegardner"
 This.email    = "jeremy@copiousfreetime.org"
-This.homepage = "http://github.com/copiousfreetime/#{ This.name }"
+This.homepage = "https://github.com/copiousfreetime/#{ This.name }"
 
 This.ruby_gemspec do |spec|
-  spec.add_dependency( 'addressable', '~> 2.3')
+  spec.add_dependency( 'addressable', '~> 2.8')
 
-  spec.add_development_dependency( 'rake'     , '~> 10.1')
-  spec.add_development_dependency( 'minitest' , '~> 5.0' )
-  spec.add_development_dependency( 'rdoc'     , '~> 4.1' )
-  
-  spec.licenses = ['ISC']
-end
-
-This.java_gemspec( This.ruby_gemspec ) do |spec|
-  spec.add_dependency( 'spoon', '~> 0.0.1' )
+  spec.add_development_dependency( 'rake'     , '~> 13.0')
+  spec.add_development_dependency( 'minitest' , '~> 5.15' )
+  spec.add_development_dependency( 'rdoc'     , '~> 6.4' )
+  spec.add_development_dependency( 'simplecov', '~> 0.21' )
 
   spec.licenses = ['ISC']
+
+  spec.metadata = {
+    "bug_tracker_uri" => "https://github.com/copiousfreetime/launchy/issues",
+    "changelog_uri"   => "https://github.com/copiousfreetime/launchy/blob/master/README.md",
+    "homepage_uri"    => "https://github.com/copiousfreetime/launchy",
+    "source_code_uri" => "https://github.com/copiousfreetime/launchy",
+  }
 end
 
 load 'tasks/default.rake'

data/lib/launchy/application.rb

@@ -27,7 +27,7 @@ module Launchy
       #
       # Find the given executable in the available paths
       def find_executable( bin, *paths )
-        paths = ENV['PATH'].split( File::PATH_SEPARATOR ) if paths.empty?
+        paths = Launchy.path.split( File::PATH_SEPARATOR ) if paths.empty?
         paths.each do |path|
           file = File.join( path, bin )
           if File.executable?( file ) then

data/lib/launchy/applications/browser.rb

@@ -64,12 +64,12 @@ class Launchy::Application
     end
 
     def cmd_and_args( uri, options = {} )
-      cmd = browser_cmdline
+      cmd = browser_cmdline.to_s
       args = [ uri.to_s ]
       if cmd =~ /%s/ then
         cmd.gsub!( /%s/, args.shift )
       end
-      return [cmd, args]
+      [cmd, args]
     end
 
     # final assembly of the command and do %s substitution 

data/lib/launchy/detect/nix_desktop_environment.rb

@@ -19,7 +19,7 @@ module Launchy::Detect
     end
 
     def self.fallback_browsers
-      %w[ firefox iceweasel seamonkey opera mozilla netscape galeon ].map { |x| ::Launchy::Argv.new( x ) }
+      %w[ firefox iceweasel seamonkey opera mozilla netscape galeon links lynx ].map { |x| ::Launchy::Argv.new( x ) }
     end
 
     def self.browsers
@@ -32,11 +32,12 @@ module Launchy::Detect
 
     class Kde < NixDesktopEnvironment
       def self.is_current_desktop_environment?
-        ENV['KDE_FULL_SESSION']
+        ENV['KDE_FULL_SESSION'] &&
+          Launchy::Application.find_executable( 'kde-open' )
       end
 
       def self.browser
-        ::Launchy::Argv.new( %w[ kfmclient openURL ] )
+        ::Launchy::Argv.new( 'kde-open' )
       end
     end
 

data/lib/launchy/detect/runner.rb

@@ -108,8 +108,8 @@ module Launchy::Detect
 
     class Jruby < Runner
       def wet_run( cmd, *args )
-        require 'spoon'
-        Spoon.spawnp( *shell_commands( cmd, *args ) )
+        child_pid = spawn( *shell_commands( cmd, *args ) )
+        Process.detach( child_pid )
       end
     end
 

data/lib/launchy/version.rb

@@ -1,5 +1,5 @@
 module Launchy
-  VERSION = "2.4.3"
+  VERSION = "2.5.2"
 
   module Version
 

data/lib/launchy.rb

@@ -8,7 +8,8 @@ require 'addressable/uri'
 # The currently defined global options are:
 #
 #   :debug        Turn on debugging output
-#   :application  Explicitly state what application class is going to be used
+#   :application  Explicitly state what application class is going to be used.
+#                 This must be a child class of Launchy::Application
 #   :host_os      Explicitly state what host operating system to pretend to be
 #   :ruby_engine  Explicitly state what ruby engine to pretend to be under
 #   :dry_run      Do nothing and print the command that would be executed on $stdout
@@ -48,6 +49,7 @@ module Launchy
     end
 
     def string_to_uri( s )
+      s = s.to_s
       uri = Addressable::URI.parse( s )
       Launchy.log "URI parsing pass 1 : #{s} -> #{uri.to_hash}"
       if not uri.scheme then
@@ -64,6 +66,7 @@ module Launchy
       Launchy.host_os     = nil
       Launchy.ruby_engine = nil
       Launchy.dry_run     = false
+      Launchy.path        = ENV['PATH']
     end
 
     def extract_global_options( options )
@@ -125,6 +128,14 @@ module Launchy
       $stderr.puts "LAUNCHY_DEBUG: #{msg}" if Launchy.debug?
     end
 
+    def path
+      @path
+    end
+
+    def path=(path)
+      @path = path
+    end
+
   private
     def to_bool( arg )
       if arg.is_a? String

data/spec/application_spec.rb

@@ -14,30 +14,30 @@ describe Launchy::Application do
         uri.scheme == "junk2"
       end
     end
-    Launchy::Application.children.must_include( Junk2App )
+    _(Launchy::Application.children).must_include( Junk2App )
     Launchy::Application.children.delete( Junk2App )
   end
 
   it "can find an app" do
-    Launchy::Application.children.must_include( JunkApp )
-    Launchy::Application.children.size.must_equal 3
+    _(Launchy::Application.children).must_include( JunkApp )
+    _(Launchy::Application.children.size).must_equal 3
     uri = Addressable::URI.parse( "junk:///foo" )
-    Launchy::Application.handling( uri ).must_equal( JunkApp  )
+    _(Launchy::Application.handling( uri )).must_equal( JunkApp  )
   end
 
   it "raises an error if an application cannot be found for the given scheme" do
     uri = Addressable::URI.parse( "foo:///bar" )
-    lambda { Launchy::Application.handling( uri ) }.must_raise( Launchy::ApplicationNotFoundError )
+    _(lambda { Launchy::Application.handling( uri ) }).must_raise( Launchy::ApplicationNotFoundError )
   end
 
   it "can find open or curl or xdg-open" do
     found = %w[ open curl xdg-open ].any? do |app|
       Launchy::Application.find_executable( app )
     end
-    found.must_equal true
+    _(found).must_equal true
   end
 
   it "does not find xyzzy" do
-    Launchy::Application.find_executable( "xyzzy" ).must_equal  nil
+    _(Launchy::Application.find_executable( "xyzzy" )).must_be_nil
   end
 end

data/spec/applications/browser_spec.rb

@@ -13,16 +13,18 @@ describe Launchy::Application::Browser do
     ENV.delete( 'BROWSER' )
   end
 
-  { 'windows' => 'start "launchy" /b' ,
-    'darwin'  => '/usr/bin/open',
-    'cygwin'  => 'cmd /C start "launchy" /b',
-
-    # when running these tests on a linux box, this test will fail
-    'linux'   => nil                 }.each  do |host_os, cmdline|
-    it "when host_os is '#{host_os}' the appropriate 'app_list' method is called" do
+  { 'windows' => 'windows_app_list',
+    'darwin'  => 'darwin_app_list',
+    'cygwin'  => 'cygwin_app_list',
+    'linux'   => 'nix_app_list',
+  }.each  do |host_os, called_method|
+    it "when host_os is '#{host_os}' the '#{called_method}' method is called" do
       Launchy.host_os = host_os
       browser = Launchy::Application::Browser.new
-      browser.app_list.first.must_equal cmdline
+      browser.stub(called_method, [:called_me]) do
+        item = browser.app_list.first
+        _(item).must_equal :called_me
+      end
     end
   end
 
@@ -32,14 +34,14 @@ describe Launchy::Application::Browser do
       Launchy.host_os = host_os
       browser = Launchy::Application::Browser.new
       cmd, args = browser.cmd_and_args( @test_url )
-      cmd.must_equal "my_special_browser --new-tab 'http://example.com/'"
-      args.must_equal []
+      _(cmd).must_equal "my_special_browser --new-tab 'http://example.com/'"
+      _(args).must_equal []
     end
   end
 
   it "handles a file on the file system when there is no file:// scheme" do
     uri = Addressable::URI.parse( __FILE__ )
-    Launchy::Application::Browser.handles?( uri ).must_equal true
+    _(Launchy::Application::Browser.handles?( uri )).must_equal true
   end
 
   it "handles the case where $BROWSER is set and no *nix desktop environment is found" do
@@ -48,21 +50,24 @@ describe Launchy::Application::Browser do
     ENV['BROWSER'] = "do-this-instead"
     Launchy.host_os = 'linux'
     browser = Launchy::Application::Browser.new
-    browser.browser_cmdline.must_equal "do-this-instead"
+    _(browser.browser_cmdline).must_equal "do-this-instead"
   end
 
   # NOTE: Unable to figure out how capture the stderr from the child which has
   # moved it at least once. This test just serves the purpose of noting why
-  # something happens, and the proble we are attempting to fix.
-  it "When BROWSER is set to something that is not executable, error still appears on stderr" do
-    ENV['BROWSER'] = "not-an-app"
-    url = "http://example.com/"
+  # something happens, and the problem we are attempting to fix.
+  #it "When BROWSER is set to something that is not executable, error still appears on stderr" do
+  #  ENV['BROWSER'] = "not-an-app"
+  #  url = "http://example.com/"
 
-    _, err = capture_subprocess_io do 
-      Launchy.open( url )
-    end
-    #err.must_match( /wibble/m )
-    err # something
-  end
+  #  _, err = capture_subprocess_io do 
+  #    begin
+  #      Launchy.open( url )
+  #    rescue => nil
+  #    end
+  #  end
+  #  #_(err).must_match( /wibble/m )
+  #  err # something
+  #end
 end
 

data/spec/cli_spec.rb

@@ -21,9 +21,9 @@ describe Launchy::Cli do
     begin
       Launchy::Cli.new.run( argv, env )
     rescue SystemExit => se
-      se.status.must_equal exit_val
-      $stderr.string.must_match stderr_regex if stderr_regex
-      $stdout.string.must_match stdout_regex if stdout_regex
+      _(se.status).must_equal exit_val
+      _($stderr.string).must_match stderr_regex if stderr_regex
+      _($stdout.string).must_match stdout_regex if stdout_regex
     end
   end
 
@@ -45,16 +45,16 @@ describe Launchy::Cli do
 
   it "leaves the url on argv after parsing" do
     l = Launchy::Cli.new
-    argv = %w[ --debug --dry-run http://github.com/copiousfreetime/launchy ]
+    argv = %w[ --debug --dry-run https://github.com/copiousfreetime/launchy ]
     l.parse( argv , {} )
-    argv.size.must_equal 1
-    argv[0].must_equal "http://github.com/copiousfreetime/launchy" 
+    _(argv.size).must_equal 1
+    _(argv[0]).must_equal "https://github.com/copiousfreetime/launchy" 
   end
 
   it "prints the command on stdout when using --dry-run" do
-   argv = %w[ --debug --dry-run http://github.com/copiousfreetime/launchy ]
+   argv = %w[ --debug --dry-run https://github.com/copiousfreetime/launchy ]
    Launchy::Cli.new.good_run( argv, {} )
-   $stdout.string.must_match %r[github.com]
+   _($stdout.string).must_match %r[github.com]
   end
 
   {
@@ -62,13 +62,13 @@ describe Launchy::Cli do
     '--engine'      => [ :ruby_engine, 'rbx'],
     '--host-os'     => [ :host_os,     'cygwin'] }.each_pair do |opt, val|
     it "the commandline option #{opt} sets the program option #{val[0]}" do
-      argv = [ opt, val[1], "http://github.com/copiousfreetime/launchy" ]
+      argv = [ opt, val[1], "https://github.com/copiousfreetime/launchy" ]
       l = Launchy::Cli.new
       rc = l.parse( argv, {} )
-      rc.must_equal true
-      argv.size.must_equal 1
-      argv[0].must_equal "http://github.com/copiousfreetime/launchy"
-      l.options[val[0]].must_equal val[1]
+      _(rc).must_equal true
+      _(argv.size).must_equal 1
+      _(argv[0]).must_equal "https://github.com/copiousfreetime/launchy"
+      _(l.options[val[0]]).must_equal val[1]
     end
   end
 end

data/spec/detect/host_os_family_spec.rb

@@ -13,7 +13,8 @@ describe Launchy::Detect::HostOsFamily do
 
   YAML::load( IO.read( File.expand_path( "../../tattle-host-os.yaml", __FILE__ ) ) )['host_os'].keys.sort.each do |os|
     it "OS family of #{os} is detected" do
-      Launchy::Detect::HostOsFamily.detect( os ).must_be_kind_of Launchy::Detect::HostOsFamily
+      os_family = Launchy::Detect::HostOsFamily.detect( os )
+      _(os_family).must_be_kind_of Launchy::Detect::HostOsFamily
     end
   end
 
@@ -22,19 +23,20 @@ describe Launchy::Detect::HostOsFamily do
     'linux'  => :nix?,
     'cygwin' => :cygwin? }.each_pair do |os, method|
     it "#{method} returns true for #{os} " do
-      Launchy::Detect::HostOsFamily.detect( os ).send( method ).must_equal true
+      r = Launchy::Detect::HostOsFamily.detect( os ).send( method )
+      _(r).must_equal true
     end
   end
 
   it "uses the global host_os overrides" do
     ENV['LAUNCHY_HOST_OS'] = "fake-os-2"
-    lambda { Launchy::Detect::HostOsFamily.detect }.must_raise Launchy::Detect::HostOsFamily::NotFoundError
+    _(lambda { Launchy::Detect::HostOsFamily.detect }).must_raise Launchy::Detect::HostOsFamily::NotFoundError
     ENV.delete('LAUNCHY_HOST_OS')
   end
 
 
   it "does not find an os of 'dos'" do
-    lambda { Launchy::Detect::HostOsFamily.detect( 'dos' ) }.must_raise Launchy::Detect::HostOsFamily::NotFoundError
+    _(lambda { Launchy::Detect::HostOsFamily.detect( 'dos' ) }).must_raise Launchy::Detect::HostOsFamily::NotFoundError
   end
 
 end

data/spec/detect/host_os_spec.rb

@@ -3,16 +3,16 @@ require 'spec_helper'
 describe Launchy::Detect::HostOs do
 
   it "uses the defult host os from ruby's config" do
-    Launchy::Detect::HostOs.new.host_os.must_equal RbConfig::CONFIG['host_os']
+    _(Launchy::Detect::HostOs.new.host_os).must_equal RbConfig::CONFIG['host_os']
   end
 
   it "uses the passed in value as the host os" do
-    Launchy::Detect::HostOs.new( "fake-os-1").host_os.must_equal "fake-os-1"
+    _(Launchy::Detect::HostOs.new( "fake-os-1").host_os).must_equal "fake-os-1"
   end
 
   it "uses the environment variable LAUNCHY_HOST_OS to override ruby's config" do
     ENV['LAUNCHY_HOST_OS'] = "fake-os-2"
-    Launchy::Detect::HostOs.new.host_os.must_equal "fake-os-2"
+    _(Launchy::Detect::HostOs.new.host_os).must_equal "fake-os-2"
     ENV.delete('LAUNCHY_HOST_OS')
   end