launchdarkly-server-sdk 6.1.0 → 6.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 660fcdc21e7d6c74b118c02e180fc0a2a08279d4c936f4d01b45244e2df88732
-  data.tar.gz: 0fc47ce28bb8e66ef1e0c93b06499990366c749adc32250b368d7b25573c971f
+  metadata.gz: 631066b2968b323ed2e12aed1565c76cf1f8bb6284e8372121771577b49bda18
+  data.tar.gz: 3e6b7c3b9769c917996e844c598796912f19c20e796692b877a885886d8fa070
 SHA512:
-  metadata.gz: 8c93e00623d1e6f954974a3128bd19c31b669eaa440460d1b14c30f4b9581b5aee2c06cf040f2fcbdd815a38384388d3b606c65834ffc4057ade87a083d1eda3
-  data.tar.gz: ef7d3c86a418ab1bb07e3b444107fc92d0472e9fe1a2ed9ef87a57527d72a2c63ce6007ad39dd5ff22f242ea420c4524bb292d8a9e3e18d8ebadb4042d82e1d5
+  metadata.gz: 5a885a5714a9cc157e295dd1a88a353a546847a702a771b4edf49f33c081eb19c4141ee7a0b4a8004620c1a4c20ef0111af0c0900ee3a28845f29e2385ebd13c
+  data.tar.gz: 6e604eac4e997431d09257bf97ec115f3a130293e4bc83fa08254baaa921eb28a2230e5bc2bd080c855293e773331e5eed006741db6cd9943132a1f2a1dc243d

data/.circleci/config.yml

@@ -20,7 +20,7 @@ jobs:
       LD_RELEASE_DOCS_TITLE: ""
       LD_RELEASE_PROJECT: "ruby-server-sdk"
       LD_RELEASE_PROJECT_TEMPLATE: "ruby"
-      LD_RELEASE_VERSION: "6.1.0"
+      LD_RELEASE_VERSION: "6.1.1"
       LD_SKIP_DATABASE_TESTS: "1"
     steps:
       - checkout

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -8,7 +8,7 @@ assignees: ''
 ---
 
 **Is this a support request?**
-This issue tracker is maintained by LaunchDarkly SDK developers and is intended for feedback on the SDK code. If you're not sure whether the problem you are having is specifically related to the SDK, or to the LaunchDarkly service overall, it may be more appropriate to contact the LaunchDarkly support team; they can help to investigate the problem and will consult the SDK team if necessary. You can submit a support request by going [here](https://support.launchdarkly.com/) and clicking "submit a request", or by emailing support@launchdarkly.com.
+This issue tracker is maintained by LaunchDarkly SDK developers and is intended for feedback on the SDK code. If you're not sure whether the problem you are having is specifically related to the SDK, or to the LaunchDarkly service overall, it may be more appropriate to contact the LaunchDarkly support team; they can help to investigate the problem and will consult the SDK team if necessary. You can submit a support request by going [here](https://support.launchdarkly.com/hc/en-us/requests/new) or by emailing support@launchdarkly.com.
 
 Note that issues filed on this issue tracker are publicly accessible. Do not provide any private account information on your issues. If your problem is specific to your account, you should submit a support request as described above.
 

data/.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Support request
+    url: https://support.launchdarkly.com/hc/en-us/requests/new
+    about: File your support requests with LaunchDarkly's support team

data/.gitignore

@@ -13,3 +13,4 @@
 mkmf.log
 *.gem
 .DS_Store
+Gemfile.lock

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to the LaunchDarkly Ruby SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [6.1.0] - 2021-02-04
+### Added:
+- Added the `alias` method. This can be used to associate two user objects for analytics purposes by generating an alias event.
+
+
 ## [6.0.0] - 2021-01-26
 ### Added:
 - Added a `socket_factory` configuration option which can be used for socket creation by the HTTP client if provided. The value of `socket_factory` must be an object providing an `open(uri, timeout)` method and returning a connected socket.

data/azure-pipelines.yml

@@ -45,7 +45,7 @@ jobs:
           workingDirectory: $(System.DefaultWorkingDirectory)
           script: |
             ruby -v
-            gem install bundler:2.2.7
+            gem install bundler
             bundle install
             mkdir rspec
             bundle exec rspec --format progress --format RspecJunitFormatter -o ./rspec/rspec.xml spec

data/lib/ldclient-rb/events.rb

@@ -443,7 +443,7 @@ module LaunchDarkly
         if @inline_users || is_debug
           out[:user] = process_user(event)
         else
-          out[:userKey] = event[:user].nil? ? nil : event[:user][:key]
+          out[:userKey] = event[:user][:key]
         end
         out[:reason] = event[:reason] if !event[:reason].nil?
         out
@@ -451,7 +451,7 @@ module LaunchDarkly
         {
           kind: "identify",
           creationDate: event[:creationDate],
-          key: event[:user].nil? ? nil : event[:user][:key].to_s,
+          key: event[:user][:key].to_s,
           user: process_user(event)
         }
       when "custom"
@@ -464,7 +464,7 @@ module LaunchDarkly
         if @inline_users
           out[:user] = process_user(event)
         else
-          out[:userKey] = event[:user].nil? ? nil : event[:user][:key]
+          out[:userKey] = event[:user][:key]
         end
         out[:metricValue] = event[:metricValue] if event.has_key?(:metricValue)
         out[:contextKind] = event[:contextKind] if event.has_key?(:contextKind)

data/lib/ldclient-rb/ldclient.rb

@@ -401,6 +401,12 @@ module LaunchDarkly
         return Evaluator.error_result(EvaluationReason::ERROR_CLIENT_NOT_READY, default)
       end
 
+      unless user
+        @config.logger.error { "[LDClient] Must specify user" }
+        detail = Evaluator.error_result(EvaluationReason::ERROR_USER_NOT_SPECIFIED, default)
+        return detail
+      end
+
       if !initialized?
         if @store.initialized?
           @config.logger.warn { "[LDClient] Client has not finished initializing; using last known values from feature store" }
@@ -421,13 +427,6 @@ module LaunchDarkly
         return detail
       end
 
-      unless user
-        @config.logger.error { "[LDClient] Must specify user" }
-        detail = Evaluator.error_result(EvaluationReason::ERROR_USER_NOT_SPECIFIED, default)
-        @event_processor.add_event(event_factory.new_default_event(feature, user, default, detail.reason))
-        return detail
-      end
-
       begin
         res = @evaluator.evaluate(feature, user, event_factory)
         if !res.events.nil?

data/lib/ldclient-rb/version.rb

@@ -1,3 +1,3 @@
 module LaunchDarkly
-  VERSION = "6.1.0"
+  VERSION = "6.1.1"
 end

data/spec/ldclient_spec.rb

@@ -145,19 +145,11 @@ describe LaunchDarkly::LDClient do
       client.variation("key", user, "default")
     end
 
-    it "queues a feature event for an existing feature when user is nil" do
+    it "does not send an event if user is nil" do
       config.feature_store.init({ LaunchDarkly::FEATURES => {} })
       config.feature_store.upsert(LaunchDarkly::FEATURES, feature_with_value)
-      expect(event_processor).to receive(:add_event).with(hash_including(
-        kind: "feature",
-        key: "key",
-        version: 100,
-        user: nil,
-        value: "default",
-        default: "default",
-        trackEvents: true,
-        debugEventsUntilDate: 1000
-      ))
+      expect(event_processor).not_to receive(:add_event)
+      expect(logger).to receive(:error)
       client.variation("key", nil, "default")
     end
 
@@ -313,6 +305,14 @@ describe LaunchDarkly::LDClient do
       ))
       client.variation_detail("key", user, "default")
     end
+
+    it "does not send an event if user is nil" do
+      config.feature_store.init({ LaunchDarkly::FEATURES => {} })
+      config.feature_store.upsert(LaunchDarkly::FEATURES, feature_with_value)
+      expect(event_processor).not_to receive(:add_event)
+      expect(logger).to receive(:error)
+      client.variation_detail("key", nil, "default")
+    end
   end
 
   describe '#all_flags' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: launchdarkly-server-sdk
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.1.1
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-04 00:00:00.000000000 Z
+date: 2021-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-dynamodb
@@ -243,6 +243,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/config.yml"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/pull_request_template.md"
 - ".gitignore"
@@ -264,7 +265,6 @@ files:
 - CODEOWNERS
 - CONTRIBUTING.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - azure-pipelines.yml

data/Gemfile.lock

@@ -1,116 +0,0 @@
-PATH
-  remote: .
-  specs:
-    launchdarkly-server-sdk (6.1.0)
-      concurrent-ruby (~> 1.1)
-      http (~> 4.4.1)
-      json (~> 2.3.1)
-      ld-eventsource (~> 2.0)
-      semantic (~> 1.6)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.7.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    ansi (1.5.0)
-    ast (2.4.2)
-    aws-eventstream (1.1.0)
-    aws-partitions (1.418.0)
-    aws-sdk-core (3.111.2)
-      aws-eventstream (~> 1, >= 1.0.2)
-      aws-partitions (~> 1, >= 1.239.0)
-      aws-sigv4 (~> 1.1)
-      jmespath (~> 1.0)
-    aws-sdk-dynamodb (1.58.0)
-      aws-sdk-core (~> 3, >= 3.109.0)
-      aws-sigv4 (~> 1.1)
-    aws-sigv4 (1.2.2)
-      aws-eventstream (~> 1, >= 1.0.2)
-    concurrent-ruby (1.1.8)
-    connection_pool (2.2.3)
-    deep_merge (1.2.1)
-    diff-lcs (1.4.4)
-    diplomat (2.4.2)
-      deep_merge (~> 1.0, >= 1.0.1)
-      faraday (>= 0.9, < 1.1.0)
-    domain_name (0.5.20190701)
-      unf (>= 0.0.5, < 1.0.0)
-    faraday (1.0.1)
-      multipart-post (>= 1.2, < 3)
-    ffi (1.14.2)
-    ffi-compiler (1.0.1)
-      ffi (>= 1.0.0)
-      rake
-    http (4.4.1)
-      addressable (~> 2.3)
-      http-cookie (~> 1.0)
-      http-form_data (~> 2.2)
-      http-parser (~> 1.2.0)
-    http-cookie (1.0.3)
-      domain_name (~> 0.5)
-    http-form_data (2.3.0)
-    http-parser (1.2.3)
-      ffi-compiler (>= 1.0, < 2.0)
-    jmespath (1.4.0)
-    json (2.3.1)
-    ld-eventsource (2.0.0)
-      concurrent-ruby (~> 1.0)
-      http (~> 4.4.1)
-    listen (3.4.1)
-      rb-fsevent (~> 0.10, >= 0.10.3)
-      rb-inotify (~> 0.9, >= 0.9.10)
-    multipart-post (2.1.1)
-    oga (2.15)
-      ast
-      ruby-ll (~> 2.1)
-    public_suffix (4.0.6)
-    rake (13.0.3)
-    rb-fsevent (0.10.4)
-    rb-inotify (0.10.1)
-      ffi (~> 1.0)
-    redis (4.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.1)
-    rspec_junit_formatter (0.4.1)
-      rspec-core (>= 2, < 4, != 2.12.0)
-    ruby-ll (2.1.2)
-      ansi
-      ast
-    semantic (1.6.1)
-    timecop (0.9.2)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.7.7)
-    webrick (1.7.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  aws-sdk-dynamodb (~> 1.57)
-  bundler (~> 2.1)
-  connection_pool (~> 2.2.3)
-  diplomat (~> 2.4.2)
-  launchdarkly-server-sdk!
-  listen (~> 3.3)
-  oga (~> 2.2)
-  redis (~> 4.2)
-  rspec (~> 3.10)
-  rspec_junit_formatter (~> 0.4)
-  timecop (~> 0.9)
-  webrick (~> 1.7)
-
-BUNDLED WITH
-   2.2.8