launchdarkly-server-sdk 5.7.2 → 5.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dd5750bde3461f500b79c5542aa1e7bd3c0f54a
-  data.tar.gz: 5f83fba1e17f45975823cae9a6d011a3e4ef22ec
+  metadata.gz: ab666bc37fa5a2f111f10b81d7cf0938b9f9bfc0
+  data.tar.gz: 1f6564ed51bdfc73c62016c27e64571476165b55
 SHA512:
-  metadata.gz: eb39d85a5ad9f752729e0ebf0431c4c76b7b23c9fabec7d9494cfef30946f10f9c8e6a4f3d575fb1d9203c4ad21c53e4db796e878be173f306ae74f3c3c5c5a7
-  data.tar.gz: '07278a34c36c2f952a0e1c503f019959cbd0b45ba13c6cc021cc8a83ddd2895df5650e7c5adafe3ad0bea6e09497831d21581b74ccffd9e3f236770548ea44c8'
+  metadata.gz: d76941981b9b7144d64a49b735b155dd79f0f37163612d5ad88751b7666f133310ecbbc6caae7598d4d775c9ef2e41f21276c8f36e11e0628f6e97a28df94419
+  data.tar.gz: 7dbbd6e3f3cd865a372ab713f528c380f232c186d3c2b153073cb90256159fbd44dc1dcb7a0fcfea23d4518cb63b1ff72cff8fac8d48f2e4f030da1f65c6d648

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly Ruby SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [5.7.2] - 2020-03-27
+### Fixed:
+- Fixed a bug in the 5.7.0 and 5.7.1 releases that caused analytics events not to be sent unless diagnostic events were explicitly disabled. This also caused an error to be logged: `undefined method started?`.
+
 ## [5.7.1] - 2020-03-18
 ### Fixed:
 - The backoff delay logic for reconnecting after a stream failure was broken so that if a failure occurred after a stream had been active for at least 60 seconds, retries would use _no_ delay, potentially causing a flood of requests and a spike in CPU usage. This bug was introduced in version 5.5.0 of the SDK.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    launchdarkly-server-sdk (5.7.2)
+    launchdarkly-server-sdk (5.7.3)
       concurrent-ruby (~> 1.0)
       json (>= 1.8, < 3)
       ld-eventsource (= 1.0.3)

data/launchdarkly-server-sdk.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-  spec.extensions    = 'ext/mkrf_conf.rb'
 
   spec.add_development_dependency "aws-sdk-dynamodb", "~> 1.18"
   spec.add_development_dependency "bundler", "~> 1.7"

data/lib/ldclient-rb/evaluation.rb

@@ -140,35 +140,44 @@ module LaunchDarkly
         end,
       endsWith:
         lambda do |a, b|
-          (a.is_a? String) && (a.end_with? b)
+          (a.is_a? String) && (b.is_a? String) && (a.end_with? b)
         end,
       startsWith:
         lambda do |a, b|
-          (a.is_a? String) && (a.start_with? b)
+          (a.is_a? String) && (b.is_a? String) && (a.start_with? b)
         end,
       matches:
         lambda do |a, b|
-          (b.is_a? String) && !(Regexp.new b).match(a).nil?
+          if (b.is_a? String) && (b.is_a? String)
+            begin
+              re = Regexp.new b
+              !re.match(a).nil?
+            rescue
+              false
+            end
+          else
+            false
+          end
         end,
       contains:
         lambda do |a, b|
-          (a.is_a? String) && (a.include? b)
+          (a.is_a? String) && (b.is_a? String) && (a.include? b)
         end,
       lessThan:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a < b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a < b)
         end,
       lessThanOrEqual:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a <= b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a <= b)
         end,
       greaterThan:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a > b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a > b)
         end,
       greaterThanOrEqual:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a >= b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a >= b)
         end,
       before:
         comparator(DATE_OPERAND) { |n| n < 0 },

data/lib/ldclient-rb/events.rb

@@ -91,6 +91,7 @@ module LaunchDarkly
   # @private
   class EventProcessor
     def initialize(sdk_key, config, client = nil, diagnostic_accumulator = nil, test_properties = nil)
+      raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?  # see LDClient constructor comment on sdk_key
       @logger = config.logger
       @inbox = SizedQueue.new(config.capacity < 100 ? 100 : config.capacity)
       @flush_task = Concurrent::TimerTask.new(execution_interval: config.flush_interval) do

data/lib/ldclient-rb/ldclient.rb

@@ -33,6 +33,16 @@ module LaunchDarkly
     # @return [LDClient] The LaunchDarkly client instance
     #
     def initialize(sdk_key, config = Config.default, wait_for_sec = 5)
+      # Note that sdk_key is normally a required parameter, and a nil value would cause the SDK to
+      # fail in most configurations. However, there are some configurations where it would be OK
+      # (offline = true, *or* we are using LDD mode or the file data source and events are disabled
+      # so we're not connecting to any LD services) so rather than try to check for all of those
+      # up front, we will let the constructors for the data source implementations implement this
+      # fail-fast as appropriate, and just check here for the part regarding events.
+      if !config.offline? && config.send_events
+        raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?
+      end
+
       @sdk_key = sdk_key
 
       @event_factory_default = EventFactory.new(false)
@@ -352,6 +362,7 @@ module LaunchDarkly
       if config.offline?
         return NullUpdateProcessor.new
       end
+      raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?  # see LDClient constructor comment on sdk_key
       requestor = Requestor.new(sdk_key, config)
       if config.stream?
         StreamProcessor.new(sdk_key, config, requestor, diagnostic_accumulator)

data/lib/ldclient-rb/version.rb

@@ -1,3 +1,3 @@
 module LaunchDarkly
-  VERSION = "5.7.2"
+  VERSION = "5.7.3"
 end

data/spec/evaluation_spec.rb

@@ -495,13 +495,13 @@ describe LaunchDarkly::Evaluation do
       # mixed strings and numbers
       [ :in,                 "99", 99, false ],
       [ :in,                  99, "99", false ],
-      #[ :contains,           "99", 99, false ],    # currently throws exception - would return false in Java SDK
-      #[ :startsWith,         "99", 99, false ],  # currently throws exception - would return false in Java SDK
-      #[ :endsWith,           "99", 99, false ]     # currently throws exception - would return false in Java SDK
+      [ :contains,           "99", 99, false ],
+      [ :startsWith,         "99", 99, false ],
+      [ :endsWith,           "99", 99, false ],
       [ :lessThanOrEqual,    "99", 99, false ],
-      #[ :lessThanOrEqual,    99, "99", false ],    # currently throws exception - would return false in Java SDK
+      [ :lessThanOrEqual,    99, "99", false ],
       [ :greaterThanOrEqual, "99", 99, false ],
-      #[ :greaterThanOrEqual, 99, "99", false ], # currently throws exception - would return false in Java SDK
+      [ :greaterThanOrEqual, 99, "99", false ],
       
       # regex
       [ :matches, "hello world", "hello.*rld",     true ],
@@ -509,7 +509,7 @@ describe LaunchDarkly::Evaluation do
       [ :matches, "hello world", "l+",             true ],
       [ :matches, "hello world", "(world|planet)", true ],
       [ :matches, "hello world", "aloha",          false ],
-      #[ :matches, "hello world", "***not a regex", false ]   # currently throws exception - same as Java SDK
+      [ :matches, "hello world", "***not a regex", false ],
 
       # dates
       [ :before, dateStr1, dateStr2,    true ],

data/spec/ldclient_spec.rb

@@ -49,6 +49,46 @@ describe LaunchDarkly::LDClient do
     client.instance_variable_get(:@event_processor)
   end
 
+  describe "constructor requirement of non-nil sdk key" do
+    it "is not enforced when offline" do
+      subject.new(nil, offline_config)
+    end
+
+    it "is not enforced if use_ldd is true and send_events is false" do
+      subject.new(nil, LaunchDarkly::Config.new({ use_ldd: true, send_events: false }))
+    end
+
+    it "is not enforced if using file data and send_events is false" do
+      source = LaunchDarkly::FileDataSource.factory({})
+      subject.new(nil, LaunchDarkly::Config.new({ data_source: source, send_events: false }))
+    end
+
+    it "is enforced in streaming mode even if send_events is false" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ send_events: false }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced in polling mode even if send_events is false" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ stream: false, send_events: false }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced if use_ldd is true and send_events is true" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ use_ldd: true }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced if using file data and send_events is true" do
+      source = LaunchDarkly::FileDataSource.factory({})
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ data_source: source }))
+      }.to raise_error(ArgumentError)
+    end
+  end
+
   describe '#variation' do
     feature_with_value = { key: "key", on: false, offVariation: 0, variations: ["value"], version: 100,
       trackEvents: true, debugEventsUntilDate: 1000 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: launchdarkly-server-sdk
 version: !ruby/object:Gem::Version
-  version: 5.7.2
+  version: 5.7.3
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-27 00:00:00.000000000 Z
+date: 2020-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-dynamodb
@@ -216,8 +216,7 @@ description: Official LaunchDarkly SDK for Ruby
 email:
 - team@launchdarkly.com
 executables: []
-extensions:
-- ext/mkrf_conf.rb
+extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
@@ -239,7 +238,6 @@ files:
 - LICENSE.txt
 - README.md
 - azure-pipelines.yml
-- ext/mkrf_conf.rb
 - launchdarkly-server-sdk.gemspec
 - lib/launchdarkly-server-sdk.rb
 - lib/ldclient-rb.rb

data/ext/mkrf_conf.rb

@@ -1,11 +0,0 @@
-require "rubygems"
-
-
-# From http://stackoverflow.com/questions/5830835/how-to-add-openssl-dependency-to-gemspec
-# the whole reason this file exists:   to return an error if openssl
-# isn't installed.
-require "openssl"
-
-f = File.open(File.join(File.dirname(__FILE__), "Rakefile"), "w")   # create dummy rakefile to indicate success
-f.write("task :default\n")
-f.close