launchdarkly-server-sdk 5.7.0 → 5.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78fa0fd5890ae19f95b19c915694bca33187ef23
-  data.tar.gz: 5dae22ebbc4a8c1d2e6deb3e206ff4d27937da02
+  metadata.gz: 70c964dad6b0915f006bee0d90160fe04bdd4853
+  data.tar.gz: f80c3dfe18ad4a70c0d7156ab06b748ffc897ae9
 SHA512:
-  metadata.gz: 888c327731d50e3d4869b2c6fe72748a9c9bb7f2c80123194eb2d32f1b365a613dbf7bec78a38fcf4f35b16e2ec634725fde25681bad0225dbe9fee41ce674f8
-  data.tar.gz: b8fcaa392b4940838daa060d66eea7dc2413d458875de3bb36905e70b194b9e34f6707d1d014c6e297ac81d396123411060c18761fe1a05c6287419cd902ca27
+  metadata.gz: 8a31c4b4a77caec7e64b54b18aabdecb12f2b5a44432d4ef74c94c2a1b57dff8a4cbf38f8dc894be8fec6f999bdc8bb62ff6095d1670ac892969329c435c9ff7
+  data.tar.gz: 2e21c5ad0cb881d99c905eaefc8952024d8fc12a1f28b1b2f4100cb39a95cdfa65d77b4a2067f3843ca9c79a446e6b071dd9c2470f2d0d0afba64d86365eb6cd

data/CHANGELOG.md

@@ -2,6 +2,35 @@
 
 All notable changes to the LaunchDarkly Ruby SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [5.7.4] - 2020-05-04
+### Fixed:
+- Setting a user's `custom` property explicitly to `nil`, rather than omitting it entirely or setting it to an empty hash, would cause the SDK to log an error and drop the current batch of analytics events. Now, it will be treated the same as an empty hash. ([#147](https://github.com/launchdarkly/ruby-server-sdk/issues/147))
+
+## [5.7.3] - 2020-04-27
+### Changed:
+- Previously, installing the SDK in an environment that did not have `openssl` would cause a failure at build time. The SDK still requires `openssl` at runtime, but this check has been removed because it caused the `rake` problem mentioned below, and because `openssl` is normally bundled in modern Ruby versions.
+
+### Fixed:
+- The `LDClient` constructor will fail immediately with a descriptive `ArgumentError` if you provide a `nil` SDK key in a configuration that requires an SDK key (that is, a configuration that _will_ require communicating with LaunchDarkly services). Previously, it would still fail, but without a clear error message. You are still allowed to omit the SDK key in an offline configuration. ([#154](https://github.com/launchdarkly/ruby-server-sdk/issues/154))
+- Removed a hidden dependency on `rake` which could cause your build to fail if you had a dependency on this SDK and you did not have `rake` installed. ([#155](https://github.com/launchdarkly/ruby-server-sdk/issues/155))
+- Previously a clause in a feature flag rule that used a string operator (such as "starts with") or a numeric operator (such as "greater than") could cause evaluation of the flag to completely fail and return a default value if the value on the right-hand side of the expression did not have the right data type-- for instance, "greater than" with a string value. The LaunchDarkly dashboard does not allow creation of such a rule, but it might be possible to do so via the REST API; the correct behavior of the SDK is to simply treat the expression as a non-match.
+
+## [5.7.2] - 2020-03-27
+### Fixed:
+- Fixed a bug in the 5.7.0 and 5.7.1 releases that caused analytics events not to be sent unless diagnostic events were explicitly disabled. This also caused an error to be logged: `undefined method started?`.
+
+## [5.7.1] - 2020-03-18
+### Fixed:
+- The backoff delay logic for reconnecting after a stream failure was broken so that if a failure occurred after a stream had been active for at least 60 seconds, retries would use _no_ delay, potentially causing a flood of requests and a spike in CPU usage. This bug was introduced in version 5.5.0 of the SDK.
+
+## [5.7.0] - 2020-03-10
+### Added:
+- The SDK now periodically sends diagnostic data to LaunchDarkly, describing the version and configuration of the SDK, the architecture and version of the runtime platform, and performance statistics. No credentials, hostnames, or other identifiable values are included. This behavior can be disabled with `Config.diagnostic_opt_out` or configured with `Config.diagnostic_recording_interval`.
+- New `Config` properties `wrapper_name` and `wrapper_version` allow a library that uses the Ruby SDK to identify itself for usage data if desired.
+
+### Removed:
+- Removed an unused dependency on `rake`.
+
 ## [5.6.2] - 2020-01-15
 ### Fixed:
 - The SDK now specifies a uniquely identifiable request header when sending events to LaunchDarkly to ensure that events are only processed once, even if the SDK sends them two times due to a failed initial attempt.

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    launchdarkly-server-sdk (5.7.0)
+    launchdarkly-server-sdk (5.8.0)
       concurrent-ruby (~> 1.0)
       json (>= 1.8, < 3)
-      ld-eventsource (= 1.0.2)
+      ld-eventsource (= 1.0.3)
       semantic (~> 1.6)
 
 GEM
@@ -40,7 +40,7 @@ GEM
     jmespath (1.4.0)
     json (1.8.6)
     json (1.8.6-java)
-    ld-eventsource (1.0.2)
+    ld-eventsource (1.0.3)
       concurrent-ruby (~> 1.0)
       http_tools (~> 0.4.5)
       socketry (~> 0.5.1)

data/launchdarkly-server-sdk.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-  spec.extensions    = 'ext/mkrf_conf.rb'
 
   spec.add_development_dependency "aws-sdk-dynamodb", "~> 1.18"
   spec.add_development_dependency "bundler", "~> 1.7"
@@ -35,5 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "json", [">= 1.8", "< 3"]
   spec.add_runtime_dependency "semantic", "~> 1.6"
   spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
-  spec.add_runtime_dependency "ld-eventsource", "1.0.2"
+  spec.add_runtime_dependency "ld-eventsource", "1.0.3"
 end

data/lib/ldclient-rb/evaluation.rb

@@ -140,35 +140,44 @@ module LaunchDarkly
         end,
       endsWith:
         lambda do |a, b|
-          (a.is_a? String) && (a.end_with? b)
+          (a.is_a? String) && (b.is_a? String) && (a.end_with? b)
         end,
       startsWith:
         lambda do |a, b|
-          (a.is_a? String) && (a.start_with? b)
+          (a.is_a? String) && (b.is_a? String) && (a.start_with? b)
         end,
       matches:
         lambda do |a, b|
-          (b.is_a? String) && !(Regexp.new b).match(a).nil?
+          if (b.is_a? String) && (b.is_a? String)
+            begin
+              re = Regexp.new b
+              !re.match(a).nil?
+            rescue
+              false
+            end
+          else
+            false
+          end
         end,
       contains:
         lambda do |a, b|
-          (a.is_a? String) && (a.include? b)
+          (a.is_a? String) && (b.is_a? String) && (a.include? b)
         end,
       lessThan:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a < b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a < b)
         end,
       lessThanOrEqual:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a <= b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a <= b)
         end,
       greaterThan:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a > b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a > b)
         end,
       greaterThanOrEqual:
         lambda do |a, b|
-          (a.is_a? Numeric) && (a >= b)
+          (a.is_a? Numeric) && (b.is_a? Numeric) && (a >= b)
         end,
       before:
         comparator(DATE_OPERAND) { |n| n < 0 },

data/lib/ldclient-rb/events.rb

@@ -91,6 +91,7 @@ module LaunchDarkly
   # @private
   class EventProcessor
     def initialize(sdk_key, config, client = nil, diagnostic_accumulator = nil, test_properties = nil)
+      raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?  # see LDClient constructor comment on sdk_key
       @logger = config.logger
       @inbox = SizedQueue.new(config.capacity < 100 ? 100 : config.capacity)
       @flush_task = Concurrent::TimerTask.new(execution_interval: config.flush_interval) do
@@ -319,7 +320,7 @@ module LaunchDarkly
         success = flush_workers.post do
           begin
             events_out = @formatter.make_output_events(payload.events, payload.summary)
-            result = @event_sender.send_event_data(events_out.to_json, false)
+            result = @event_sender.send_event_data(events_out.to_json, "#{events_out.length} events", false)
             @disabled.value = true if result.must_shutdown
             if !result.time_from_server.nil?
               @last_known_past_time.value = (result.time_from_server.to_f * 1000).to_i
@@ -348,7 +349,7 @@ module LaunchDarkly
       uri = URI(@config.events_uri + "/diagnostic")
       diagnostic_event_workers.post do
         begin
-          @event_sender.send_event_data(event.to_json, true)
+          @event_sender.send_event_data(event.to_json, "diagnostic event", true)
         rescue => e
           Util.log_exception(@config.logger, "Unexpected error in event processor", e)
         end

data/lib/ldclient-rb/impl/event_sender.rb

@@ -18,10 +18,9 @@ module LaunchDarkly
         @retry_interval = retry_interval
       end
 
-      def send_event_data(event_data, is_diagnostic)
+      def send_event_data(event_data, description, is_diagnostic)
         uri = is_diagnostic ? @diagnostic_uri : @events_uri
         payload_id = is_diagnostic ? nil : SecureRandom.uuid
-        description = is_diagnostic ? 'diagnostic event' : "#{event_data.length} events"
         res = nil
         (0..1).each do |attempt|
           if attempt > 0
@@ -30,7 +29,7 @@ module LaunchDarkly
           end
           begin
             @client.start if !@client.started?
-            @logger.debug { "[LDClient] sending #{description}: #{body}" }
+            @logger.debug { "[LDClient] sending #{description}: #{event_data}" }
             req = Net::HTTP::Post.new(uri)
             req.content_type = "application/json"
             req.body = event_data

data/lib/ldclient-rb/impl/integrations/redis_impl.rb

@@ -33,6 +33,8 @@ module LaunchDarkly
             @pool = opts[:pool] || ConnectionPool.new(size: max_connections) do
               ::Redis.new(@redis_opts)
             end
+            # shutdown pool on close unless the client passed a custom pool and specified not to shutdown
+            @pool_shutdown_on_close = (!opts[:pool] || opts.fetch(:pool_shutdown_on_close, true))
             @prefix = opts[:prefix] || LaunchDarkly::Integrations::Redis::default_prefix
             @logger = opts[:logger] || Config.default_logger
             @test_hook = opts[:test_hook]  # used for unit tests, deliberately undocumented
@@ -118,6 +120,7 @@ module LaunchDarkly
 
           def stop
             if @stopped.make_true
+              return unless @pool_shutdown_on_close
               @pool.shutdown { |redis| redis.close }
             end
           end

data/lib/ldclient-rb/integrations/redis.rb

@@ -45,6 +45,9 @@ module LaunchDarkly
       # @option opts [Integer] :expiration (15)  expiration time for the in-memory cache, in seconds; 0 for no local caching
       # @option opts [Integer] :capacity (1000)  maximum number of items in the cache
       # @option opts [Object] :pool  custom connection pool, if desired
+      # @option opts [Boolean] :pool_shutdown_on_close whether calling `close` should shutdown the custom connection pool;
+      #   this is true by default, and should be set to false only if you are managing the pool yourself and want its
+      #   lifecycle to be independent of the SDK client
       # @return [LaunchDarkly::Interfaces::FeatureStore]  a feature store object
       #
       def self.new_feature_store(opts)

data/lib/ldclient-rb/ldclient.rb

@@ -33,6 +33,16 @@ module LaunchDarkly
     # @return [LDClient] The LaunchDarkly client instance
     #
     def initialize(sdk_key, config = Config.default, wait_for_sec = 5)
+      # Note that sdk_key is normally a required parameter, and a nil value would cause the SDK to
+      # fail in most configurations. However, there are some configurations where it would be OK
+      # (offline = true, *or* we are using LDD mode or the file data source and events are disabled
+      # so we're not connecting to any LD services) so rather than try to check for all of those
+      # up front, we will let the constructors for the data source implementations implement this
+      # fail-fast as appropriate, and just check here for the part regarding events.
+      if !config.offline? && config.send_events
+        raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?
+      end
+
       @sdk_key = sdk_key
 
       @event_factory_default = EventFactory.new(false)
@@ -56,7 +66,7 @@ module LaunchDarkly
       if @config.offline? || !@config.send_events
         @event_processor = NullEventProcessor.new
       else
-        @event_processor = EventProcessor.new(sdk_key, config, diagnostic_accumulator)
+        @event_processor = EventProcessor.new(sdk_key, config, nil, diagnostic_accumulator)
       end
 
       if @config.use_ldd?
@@ -352,6 +362,7 @@ module LaunchDarkly
       if config.offline?
         return NullUpdateProcessor.new
       end
+      raise ArgumentError, "sdk_key must not be nil" if sdk_key.nil?  # see LDClient constructor comment on sdk_key
       requestor = Requestor.new(sdk_key, config)
       if config.stream?
         StreamProcessor.new(sdk_key, config, requestor, diagnostic_accumulator)

data/lib/ldclient-rb/redis_store.rb

@@ -35,6 +35,7 @@ module LaunchDarkly
     # @option opts [Integer] :expiration  expiration time for the in-memory cache, in seconds; 0 for no local caching
     # @option opts [Integer] :capacity  maximum number of feature flags (or related objects) to cache locally
     # @option opts [Object] :pool  custom connection pool, if desired
+    # @option opts [Boolean] :pool_shutdown_on_close whether calling `close` should shutdown the custom connection pool.
     #
     def initialize(opts = {})
       core = LaunchDarkly::Impl::Integrations::Redis::RedisFeatureStoreCore.new(opts)

data/lib/ldclient-rb/user_filter.rb

@@ -15,8 +15,9 @@ module LaunchDarkly
       user_private_attrs = Set.new((user_props[:privateAttributeNames] || []).map(&:to_sym))
 
       filtered_user_props, removed = filter_values(user_props, user_private_attrs, ALLOWED_TOP_LEVEL_KEYS, IGNORED_TOP_LEVEL_KEYS)
-      if user_props.has_key?(:custom)
-        filtered_user_props[:custom], removed_custom = filter_values(user_props[:custom], user_private_attrs)
+      custom = user_props[:custom]
+      if !custom.nil?
+        filtered_user_props[:custom], removed_custom = filter_values(custom, user_private_attrs)
         removed.merge(removed_custom)
       end
 

data/lib/ldclient-rb/version.rb

@@ -1,3 +1,3 @@
 module LaunchDarkly
-  VERSION = "5.7.0"
+  VERSION = "5.8.0"
 end

data/spec/evaluation_spec.rb

@@ -495,13 +495,13 @@ describe LaunchDarkly::Evaluation do
       # mixed strings and numbers
       [ :in,                 "99", 99, false ],
       [ :in,                  99, "99", false ],
-      #[ :contains,           "99", 99, false ],    # currently throws exception - would return false in Java SDK
-      #[ :startsWith,         "99", 99, false ],  # currently throws exception - would return false in Java SDK
-      #[ :endsWith,           "99", 99, false ]     # currently throws exception - would return false in Java SDK
+      [ :contains,           "99", 99, false ],
+      [ :startsWith,         "99", 99, false ],
+      [ :endsWith,           "99", 99, false ],
       [ :lessThanOrEqual,    "99", 99, false ],
-      #[ :lessThanOrEqual,    99, "99", false ],    # currently throws exception - would return false in Java SDK
+      [ :lessThanOrEqual,    99, "99", false ],
       [ :greaterThanOrEqual, "99", 99, false ],
-      #[ :greaterThanOrEqual, 99, "99", false ], # currently throws exception - would return false in Java SDK
+      [ :greaterThanOrEqual, 99, "99", false ],
       
       # regex
       [ :matches, "hello world", "hello.*rld",     true ],
@@ -509,7 +509,7 @@ describe LaunchDarkly::Evaluation do
       [ :matches, "hello world", "l+",             true ],
       [ :matches, "hello world", "(world|planet)", true ],
       [ :matches, "hello world", "aloha",          false ],
-      #[ :matches, "hello world", "***not a regex", false ]   # currently throws exception - same as Java SDK
+      [ :matches, "hello world", "***not a regex", false ],
 
       # dates
       [ :before, dateStr1, dateStr2,    true ],

data/spec/event_sender_spec.rb

@@ -27,7 +27,7 @@ module LaunchDarkly
         with_sender_and_server do |es, server|
           server.setup_ok_response("/bulk", "")
 
-          result = es.send_event_data(fake_data, false)
+          result = es.send_event_data(fake_data, "", false)
 
           expect(result.success).to be true
           expect(result.must_shutdown).to be false
@@ -49,8 +49,8 @@ module LaunchDarkly
         with_sender_and_server do |es, server|
           server.setup_ok_response("/bulk", "")
 
-          result1 = es.send_event_data(fake_data, false)
-          result2 = es.send_event_data(fake_data, false)
+          result1 = es.send_event_data(fake_data, "", false)
+          result2 = es.send_event_data(fake_data, "", false)
           expect(result1.success).to be true
           expect(result2.success).to be true
 
@@ -66,7 +66,7 @@ module LaunchDarkly
         with_sender_and_server do |es, server|
           server.setup_ok_response("/diagnostic", "")
 
-          result = es.send_event_data(fake_data, true)
+          result = es.send_event_data(fake_data, "", true)
 
           expect(result.success).to be true
           expect(result.must_shutdown).to be false
@@ -94,7 +94,7 @@ module LaunchDarkly
 
               es = make_sender(server)
 
-              result = es.send_event_data(fake_data, false)
+              result = es.send_event_data(fake_data, "", false)
               
               expect(result.success).to be true
 
@@ -116,7 +116,7 @@ module LaunchDarkly
               res.status = req_count == 2 ? 200 : status
             end
 
-            result = es.send_event_data(fake_data, false)
+            result = es.send_event_data(fake_data, "", false)
 
             expect(result.success).to be true
             expect(result.must_shutdown).to be false
@@ -141,7 +141,7 @@ module LaunchDarkly
               res.status = req_count == 3 ? 200 : status
             end
 
-            result = es.send_event_data(fake_data, false)
+            result = es.send_event_data(fake_data, "", false)
 
             expect(result.success).to be false
             expect(result.must_shutdown).to be false
@@ -164,7 +164,7 @@ module LaunchDarkly
               res.status = status
             end
 
-            result = es.send_event_data(fake_data, false)
+            result = es.send_event_data(fake_data, "", false)
 
             expect(result.success).to be false
             expect(result.must_shutdown).to be true

data/spec/events_spec.rb

@@ -408,6 +408,17 @@ describe LaunchDarkly::EventProcessor do
     end
   end
 
+  it "treats nil value for custom the same as an empty hash" do
+    with_processor_and_sender(default_config) do |ep, sender|
+      user_with_nil_custom = { key: "userkey", custom: nil }
+      e = { kind: "identify", key: "userkey", user: user_with_nil_custom }
+      ep.add_event(e)
+
+      output = flush_and_get_events(ep, sender)
+      expect(output).to contain_exactly(e)
+    end
+  end
+
   it "does a final flush when shutting down" do
     with_processor_and_sender(default_config) do |ep, sender|
       e = { kind: "identify", key: user[:key], user: user }
@@ -578,7 +589,7 @@ describe LaunchDarkly::EventProcessor do
       @diagnostic_payloads = Queue.new
     end
 
-    def send_event_data(data, is_diagnostic)
+    def send_event_data(data, description, is_diagnostic)
       (is_diagnostic ? @diagnostic_payloads : @analytics_payloads).push(JSON.parse(data, symbolize_names: true))
       @result
     end

data/spec/ldclient_end_to_end_spec.rb

@@ -0,0 +1,123 @@
+require "http_util"
+require "spec_helper"
+
+
+SDK_KEY = "sdk-key"
+
+USER = { key: 'userkey' }
+
+ALWAYS_TRUE_FLAG = { key: 'flagkey', version: 1, on: false, offVariation: 1, variations: [ false, true ] }
+DATA_WITH_ALWAYS_TRUE_FLAG = {
+  flags: { ALWAYS_TRUE_FLAG[:key  ].to_sym => ALWAYS_TRUE_FLAG },
+  segments: {}
+}
+PUT_EVENT_WITH_ALWAYS_TRUE_FLAG = "event: put\ndata:{\"data\":#{DATA_WITH_ALWAYS_TRUE_FLAG.to_json}}\n\n'"
+
+def with_client(config)
+  client = LaunchDarkly::LDClient.new(SDK_KEY, config)
+  begin
+    yield client
+  ensure
+    client.close
+  end
+end
+
+module LaunchDarkly
+  # Note that we can't do end-to-end tests in streaming mode until we have a test server that can do streaming
+  # responses, which is difficult in WEBrick.
+
+  describe "LDClient end-to-end" do
+    it "starts in polling mode" do
+      with_server do |poll_server|
+        poll_server.setup_ok_response("/sdk/latest-all", DATA_WITH_ALWAYS_TRUE_FLAG.to_json, "application/json")
+        
+        config = Config.new(
+          stream: false,
+          base_uri: poll_server.base_uri.to_s,
+          send_events: false,
+          logger: NullLogger.new
+        )
+        with_client(config) do |client|
+          expect(client.initialized?).to be true
+          expect(client.variation(ALWAYS_TRUE_FLAG[:key], USER, false)).to be true
+        end
+      end
+    end
+
+    it "fails in polling mode with 401 error" do
+      with_server do |poll_server|
+        poll_server.setup_status_response("/sdk/latest-all", 401)
+        
+        config = Config.new(
+          stream: false,
+          base_uri: poll_server.base_uri.to_s,
+          send_events: false,
+          logger: NullLogger.new
+        )
+        with_client(config) do |client|
+          expect(client.initialized?).to be false
+          expect(client.variation(ALWAYS_TRUE_FLAG[:key], USER, false)).to be false
+        end
+      end
+    end
+
+    it "sends event without diagnostics" do
+      with_server do |poll_server|
+        with_server do |events_server|
+          events_server.setup_ok_response("/bulk", "")
+          poll_server.setup_ok_response("/sdk/latest-all", '{"flags":{},"segments":{}}', "application/json")
+          
+          config = Config.new(
+            stream: false,
+            base_uri: poll_server.base_uri.to_s,
+            events_uri: events_server.base_uri.to_s,
+            diagnostic_opt_out: true,
+            logger: NullLogger.new
+          )
+          with_client(config) do |client|
+            client.identify(USER)
+            client.flush
+
+            req, body = events_server.await_request_with_body
+            expect(req.header['authorization']).to eq [ SDK_KEY ]
+            data = JSON.parse(body)
+            expect(data.length).to eq 1
+            expect(data[0]["kind"]).to eq "identify"
+          end
+        end
+      end
+    end
+
+    it "sends diagnostic event" do
+      with_server do |poll_server|
+        with_server do |events_server|
+          events_server.setup_ok_response("/bulk", "")
+          events_server.setup_ok_response("/diagnostic", "")
+          poll_server.setup_ok_response("/sdk/latest-all", '{"flags":{},"segments":{}}', "application/json")
+          
+          config = Config.new(
+            stream: false,
+            base_uri: poll_server.base_uri.to_s,
+            events_uri: events_server.base_uri.to_s,
+            logger: NullLogger.new
+          )
+          with_client(config) do |client|
+            user = { key: 'userkey' }
+            client.identify(user)
+            client.flush
+
+            req0, body0 = events_server.await_request_with_body
+            req1, body1 = events_server.await_request_with_body
+            req = req0.path == "/diagnostic" ? req0 : req1
+            body = req0.path == "/diagnostic" ? body0 : body1
+            expect(req.header['authorization']).to eq [ SDK_KEY ]
+            data = JSON.parse(body)
+            expect(data["kind"]).to eq "diagnostic-init"
+          end
+        end
+      end
+    end
+
+    # TODO: TLS tests with self-signed cert
+  end
+end

data/spec/ldclient_spec.rb

@@ -49,6 +49,46 @@ describe LaunchDarkly::LDClient do
     client.instance_variable_get(:@event_processor)
   end
 
+  describe "constructor requirement of non-nil sdk key" do
+    it "is not enforced when offline" do
+      subject.new(nil, offline_config)
+    end
+
+    it "is not enforced if use_ldd is true and send_events is false" do
+      subject.new(nil, LaunchDarkly::Config.new({ use_ldd: true, send_events: false }))
+    end
+
+    it "is not enforced if using file data and send_events is false" do
+      source = LaunchDarkly::FileDataSource.factory({})
+      subject.new(nil, LaunchDarkly::Config.new({ data_source: source, send_events: false }))
+    end
+
+    it "is enforced in streaming mode even if send_events is false" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ send_events: false }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced in polling mode even if send_events is false" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ stream: false, send_events: false }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced if use_ldd is true and send_events is true" do
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ use_ldd: true }))
+      }.to raise_error(ArgumentError)
+    end
+
+    it "is enforced if using file data and send_events is true" do
+      source = LaunchDarkly::FileDataSource.factory({})
+      expect {
+        subject.new(nil, LaunchDarkly::Config.new({ data_source: source }))
+      }.to raise_error(ArgumentError)
+    end
+  end
+
   describe '#variation' do
     feature_with_value = { key: "key", on: false, offVariation: 0, variations: ["value"], version: 100,
       trackEvents: true, debugEventsUntilDate: 1000 }

data/spec/redis_feature_store_spec.rb

@@ -1,3 +1,4 @@
+require "connection_pool"
 require "feature_store_spec_base"
 require "json"
 require "redis"
@@ -27,11 +28,11 @@ end
 
 describe LaunchDarkly::RedisFeatureStore do
   subject { LaunchDarkly::RedisFeatureStore }
-  
+
   break if ENV['LD_SKIP_DATABASE_TESTS'] == '1'
 
   # These tests will all fail if there isn't a Redis instance running on the default port.
-  
+
   context "real Redis with local cache" do
     include_examples "feature_store", method(:create_redis_store), method(:clear_all_data)
   end
@@ -59,7 +60,7 @@ describe LaunchDarkly::RedisFeatureStore do
     flag = { key: "foo", version: 1 }
     test_hook = make_concurrent_modifier_test_hook(other_client, flag, 2, 4)
     store = create_redis_store({ test_hook: test_hook })
-    
+
     begin
       store.init(LaunchDarkly::FEATURES => { flag[:key] => flag })
 
@@ -77,7 +78,7 @@ describe LaunchDarkly::RedisFeatureStore do
     flag = { key: "foo", version: 1 }
     test_hook = make_concurrent_modifier_test_hook(other_client, flag, 3, 3)
     store = create_redis_store({ test_hook: test_hook })
-    
+
     begin
       store.init(LaunchDarkly::FEATURES => { flag[:key] => flag })
 
@@ -89,4 +90,32 @@ describe LaunchDarkly::RedisFeatureStore do
       other_client.close
     end
   end
+
+  it "shuts down a custom Redis pool by default" do
+    unowned_pool = ConnectionPool.new(size: 1, timeout: 1) { Redis.new({ url: "redis://localhost:6379" }) }
+    store = create_redis_store({ pool: unowned_pool })
+
+    begin
+      store.init(LaunchDarkly::FEATURES => { })
+      store.stop
+
+      expect { unowned_pool.with {} }.to raise_error(ConnectionPool::PoolShuttingDownError)
+    ensure
+      unowned_pool.shutdown { |conn| conn.close }
+    end
+  end
+
+  it "doesn't shut down a custom Redis pool if pool_shutdown_on_close = false" do
+    unowned_pool = ConnectionPool.new(size: 1, timeout: 1) { Redis.new({ url: "redis://localhost:6379" }) }
+    store = create_redis_store({ pool: unowned_pool, pool_shutdown_on_close: false })
+
+    begin
+      store.init(LaunchDarkly::FEATURES => { })
+      store.stop
+
+      expect { unowned_pool.with {} }.not_to raise_error(ConnectionPool::PoolShuttingDownError)
+    ensure
+      unowned_pool.shutdown { |conn| conn.close }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: launchdarkly-server-sdk
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.8.0
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-10 00:00:00.000000000 Z
+date: 2020-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-dynamodb
@@ -204,20 +204,19 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 1.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 1.0.3
 description: Official LaunchDarkly SDK for Ruby
 email:
 - team@launchdarkly.com
 executables: []
-extensions:
-- ext/mkrf_conf.rb
+extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
@@ -239,7 +238,6 @@ files:
 - LICENSE.txt
 - README.md
 - azure-pipelines.yml
-- ext/mkrf_conf.rb
 - launchdarkly-server-sdk.gemspec
 - lib/launchdarkly-server-sdk.rb
 - lib/ldclient-rb.rb
@@ -302,6 +300,7 @@ files:
 - spec/integrations/store_wrapper_spec.rb
 - spec/launchdarkly-server-sdk_spec.rb
 - spec/launchdarkly-server-sdk_spec_autoloadtest.rb
+- spec/ldclient_end_to_end_spec.rb
 - spec/ldclient_spec.rb
 - spec/newrelic_spec.rb
 - spec/polling_spec.rb
@@ -360,6 +359,7 @@ test_files:
 - spec/integrations/store_wrapper_spec.rb
 - spec/launchdarkly-server-sdk_spec.rb
 - spec/launchdarkly-server-sdk_spec_autoloadtest.rb
+- spec/ldclient_end_to_end_spec.rb
 - spec/ldclient_spec.rb
 - spec/newrelic_spec.rb
 - spec/polling_spec.rb

data/ext/mkrf_conf.rb

@@ -1,11 +0,0 @@
-require "rubygems"
-
-
-# From http://stackoverflow.com/questions/5830835/how-to-add-openssl-dependency-to-gemspec
-# the whole reason this file exists:   to return an error if openssl
-# isn't installed.
-require "openssl"
-
-f = File.open(File.join(File.dirname(__FILE__), "Rakefile"), "w")   # create dummy rakefile to indicate success
-f.write("task :default\n")
-f.close