launchdarkly-server-sdk 5.6.1 → 5.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 634c7b652bbff689dc0d705f75536ee40e76648f
-  data.tar.gz: 7c932f06ef8f16e2f5a13f7c34d19aa834acfeb0
+  metadata.gz: 0f95b72da90326fccd6fb823407b61ca1c686e53
+  data.tar.gz: 661768aaa51261feba0018cbc0f3ba793580c3e6
 SHA512:
-  metadata.gz: 81c83640f62d49bed5f91cf9b77f551d0df663491ed96fbfadc69a68a5a09787667c26554a09098bad9b8ba4ef55c78b2e15ab7743c99a3ba43c80b3de48723c
-  data.tar.gz: 72adc3f1ff659659c2093b3f81e680de298a15f20a43df7cc958c9a62040a8670e18505e604254f48401eb8fa5618d61873b7a22ba43fe1fe3a463f16f265a3f
+  metadata.gz: a409099d6bf0e5fb75b8d64ad05e52983bafb22f645620c8adb7403a0435a0ba9bd14068868b2ef1419f291431d6d517dad74284289f166e7ca21ca7156e0462
+  data.tar.gz: 72c021d8519a455da47ad3c5d8eacbbb79ef80ee068be1b37a5f200abdf8248e7741638de1f8811cbde03638635bc6a9029d90f90f2b6474b5d5e2fe8aa82b1e

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly Ruby SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [5.6.1] - 2020-01-06
+### Fixed:
+- In rare circumstances (depending on the exact data in the flag configuration, the flag's salt value, and the user properties), a percentage rollout could fail and return a default value, logging the error "Data inconsistency in feature flag ... variation/rollout object with no variation or rollout". This would happen if the user's hashed value fell exactly at the end of the last "bucket" (the last variation defined in the rollout). This has been fixed so that the user will get the last variation.
+
 ## [5.6.0] - 2019-08-28
 ### Added:
 - Added support for upcoming LaunchDarkly experimentation features. See `LDClient.track()`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    launchdarkly-server-sdk (5.6.1)
+    launchdarkly-server-sdk (5.6.2)
       concurrent-ruby (~> 1.0)
       json (>= 1.8, < 3)
       ld-eventsource (= 1.0.1)

data/lib/ldclient-rb/events.rb

@@ -1,6 +1,7 @@
 require "concurrent"
 require "concurrent/atomics"
 require "concurrent/executors"
+require "securerandom"
 require "thread"
 require "time"
 
@@ -359,6 +360,7 @@ module LaunchDarkly
       events_out = formatter.make_output_events(payload.events, payload.summary)
       res = nil
       body = events_out.to_json
+      payload_id = SecureRandom.uuid
       (0..1).each do |attempt|
         if attempt > 0
           config.logger.warn { "[LDClient] Will retry posting events after 1 second" }
@@ -374,6 +376,7 @@ module LaunchDarkly
           req["Authorization"] = sdk_key
           req["User-Agent"] = "RubyClient/" + LaunchDarkly::VERSION
           req["X-LaunchDarkly-Event-Schema"] = CURRENT_SCHEMA_VERSION.to_s
+          req["X-LaunchDarkly-Payload-ID"] = payload_id
           req["Connection"] = "keep-alive"
           res = client.request(req)
         rescue StandardError => exn

data/lib/ldclient-rb/version.rb

@@ -1,3 +1,3 @@
 module LaunchDarkly
-  VERSION = "5.6.1"
+  VERSION = "5.6.2"
 end

data/spec/events_spec.rb

@@ -416,6 +416,29 @@ describe LaunchDarkly::EventProcessor do
     expect(hc.get_request["authorization"]).to eq "sdk_key"
   end
 
+  it "sends unique payload IDs" do
+    @ep = subject.new("sdk_key", default_config, hc)
+    e = { kind: "identify", user: user }
+  
+    @ep.add_event(e)
+    @ep.flush
+    @ep.wait_until_inactive
+    req0 = hc.get_request
+
+    @ep.add_event(e)
+    @ep.flush
+    @ep.wait_until_inactive
+    req1 = hc.get_request
+
+    id0 = req0["x-launchdarkly-payload-id"]
+    id1 = req1["x-launchdarkly-payload-id"]
+    expect(id0).not_to be_nil
+    expect(id0).not_to eq ""
+    expect(id1).not_to be nil
+    expect(id1).not_to eq ""
+    expect(id1).not_to eq id0
+  end
+
   def verify_unrecoverable_http_error(status)
     @ep = subject.new("sdk_key", default_config, hc)
     e = { kind: "identify", user: user }
@@ -442,8 +465,15 @@ describe LaunchDarkly::EventProcessor do
     @ep.flush
     @ep.wait_until_inactive
 
-    expect(hc.get_request).not_to be_nil
-    expect(hc.get_request).not_to be_nil
+    req0 = hc.get_request
+    expect(req0).not_to be_nil
+    req1 = hc.get_request
+    expect(req1).not_to be_nil
+    id0 = req0["x-launchdarkly-payload-id"]
+    expect(id0).not_to be_nil
+    expect(id0).not_to eq ""
+    expect(req1["x-launchdarkly-payload-id"]).to eq id0
+    
     expect(hc.get_request).to be_nil  # no 3rd request
 
     # now verify that a subsequent flush still generates a request

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: launchdarkly-server-sdk
 version: !ruby/object:Gem::Version
-  version: 5.6.1
+  version: 5.6.2
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-07 00:00:00.000000000 Z
+date: 2020-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-dynamodb