lastfm 0.0.1 → 0.1.0

data/spec/fixtures/track_get_tags.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<tags artist="Sally Shapiro" track="I'll be by your side">
+  <tag>
+    <name>swedish</name>
+    <url>http://www.last.fm/tag/swedish</url>
+  </tag>
+  <tag>
+    <name>xxx</name>
+    <url>http://www.last.fm/tag/xxx</url>
+  </tag>
+</tags>
+</lfm>

data/spec/fixtures/track_get_top_fans.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<topfans artist="Cher" track="Believe">
+
+<user>
+    <name>Through0glass</name>
+    <realname></realname>
+    <url>http://www.last.fm/user/Through0glass</url>
+    <image size="small">http://userserve-ak.last.fm/serve/34/29673533.jpg</image>
+    <image size="medium">http://userserve-ak.last.fm/serve/64/29673533.jpg</image>
+
+    <image size="large">http://userserve-ak.last.fm/serve/126/29673533.jpg</image>
+    <image size="extralarge">http://userserve-ak.last.fm/serve/252/29673533.jpg</image>
+    <weight>796686</weight>
+</user>
+<user>
+    <name>hellobrook</name>
+    <realname>brook</realname>
+
+    <url>http://www.last.fm/user/hellobrook</url>
+    <image size="small">http://userserve-ak.last.fm/serve/34/33834925.jpg</image>
+    <image size="medium">http://userserve-ak.last.fm/serve/64/33834925.jpg</image>
+    <image size="large">http://userserve-ak.last.fm/serve/126/33834925.jpg</image>
+    <image size="extralarge">http://userserve-ak.last.fm/serve/252/33834925.jpg</image>
+    <weight>353088</weight>
+
+</user>
+</topfans></lfm>

data/spec/fixtures/track_get_top_tags.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<toptags artist="Radiohead" track="Paranoid Android">
+<tag>
+    <name>alternative</name> 
+    <count>100</count>
+    <url>www.last.fm/tag/alternative</url>
+</tag>
+<tag>
+    <name>alternative rock</name> 
+    <count>77</count>
+
+    <url>www.last.fm/tag/alternative%20rock</url>
+</tag>
+</toptags></lfm>

data/spec/fixtures/track_search.xml

@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<results for="Believe" xmlns:opensearch="http://a9.com/-/spec/opensearch/1.1/">
+<opensearch:Query role="request" searchTerms="Believe" startPage="3" />
+<opensearch:totalResults>40540</opensearch:totalResults>
+<opensearch:startIndex>20</opensearch:startIndex>
+<opensearch:itemsPerPage>10</opensearch:itemsPerPage>
+<trackmatches>
+<track>
+    <name>Make Me Believe</name>
+    <artist>Godsmack</artist>
+
+    <url>http://www.last.fm/music/Godsmack/_/Make+Me+Believe</url>
+    <streamable fulltrack="0">1</streamable>
+    <listeners>76858</listeners>
+            <image size="small">http://userserve-ak.last.fm/serve/34s/8674971.jpg</image>
+    <image size="medium">http://userserve-ak.last.fm/serve/64s/8674971.jpg</image>
+    <image size="large">http://userserve-ak.last.fm/serve/126/8674971.jpg</image>
+
+    <image size="extralarge">http://userserve-ak.last.fm/serve/300x300/8674971.jpg</image>
+    </track>
+<track>
+    <name>I Believe in You</name>
+    <artist>Kylie Minogue</artist>
+    <url>http://www.last.fm/music/Kylie+Minogue/_/I+Believe+in+You</url>
+    <streamable fulltrack="0">0</streamable>
+
+    <listeners>74295</listeners>
+            <image size="small">http://userserve-ak.last.fm/serve/34s/8822309.jpg</image>
+    <image size="medium">http://userserve-ak.last.fm/serve/64s/8822309.jpg</image>
+    <image size="large">http://userserve-ak.last.fm/serve/126/8822309.jpg</image>
+    <image size="extralarge">http://userserve-ak.last.fm/serve/300x300/8822309.jpg</image>
+    </track>
+</trackmatches>
+</results></lfm>

data/spec/lastfm_spec.rb

@@ -3,6 +3,16 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 describe "Lastfm" do
   before do
     @lastfm = Lastfm.new('xxx', 'yyy')
+    @response_xml = <<XML
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<foo>bar</foo></lfm>
+XML
+    @ok_response = make_response(<<XML)
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+</lfm>
+XML
   end
 
   it 'should have base_uri' do
@@ -22,10 +32,9 @@ describe "Lastfm" do
           :foo => 'bar',
           :method => 'xxx.yyy',
           :api_key => 'xxx',
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, false, false)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, false, false)
     end
 
     it 'should post with signature' do
@@ -35,10 +44,9 @@ describe "Lastfm" do
           :method => 'xxx.yyy',
           :api_key => 'xxx',
           :api_sig => Digest::MD5.hexdigest('api_keyxxxfoobarmethodxxx.yyyyyy'),
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, true, false)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, true, false)
     end
 
     it 'should post with signature and session (request with authentication)' do
@@ -50,11 +58,9 @@ describe "Lastfm" do
           :api_key => 'xxx',
           :api_sig => Digest::MD5.hexdigest('api_keyxxxfoobarmethodxxx.yyyskabcdefyyy'),
           :sk => 'abcdef',
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, true, true)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post, true, true)
     end
 
     it 'should get' do
@@ -63,11 +69,9 @@ describe "Lastfm" do
           :foo => 'bar',
           :method => 'xxx.yyy',
           :api_key => 'xxx',
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, false, false)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, false, false)
     end
 
     it 'should get with signature (request for authentication)' do
@@ -77,11 +81,9 @@ describe "Lastfm" do
           :method => 'xxx.yyy',
           :api_key => 'xxx',
           :api_sig => Digest::MD5.hexdigest('api_keyxxxfoobarmethodxxx.yyyyyy'),
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, true, false)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, true, false)
     end
 
     it 'should get with signature and session' do
@@ -93,47 +95,59 @@ describe "Lastfm" do
           :api_key => 'xxx',
           :api_sig => Digest::MD5.hexdigest('api_keyxxxfoobarmethodxxx.yyyskabcdefyyy'),
           :sk => 'abcdef',
-          :format => 'json'
         }).and_return(mock_response)
-      mock_response.should_receive(:body).and_return('{ "bar": "baz" }')
-
-      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, true, true)['bar'].should eql('baz')
+      mock_response.should_receive(:body).and_return(@response_xml)
+      @lastfm.request('xxx.yyy', { :foo => 'bar' }, :get, true, true)
     end
 
     it 'should raise an error if an api error is ocuured' do
       mock_response = mock(HTTParty::Response)
-      mock_response.should_receive(:body).and_return('{"message": "Invalid Method - No method with that name in this package", "error": 3}')
+      mock_response.should_receive(:body).and_return(open(fixture('ng.xml')).read)
       @lastfm.class.should_receive(:post).and_return(mock_response)
 
       lambda {
         @lastfm.request('xxx.yyy', { :foo => 'bar' }, :post)
-      }.should raise_error(Lastfm::ApiError, 'Invalid Method - No method with that name in this package')
+      }.should raise_error(Lastfm::ApiError, 'Invalid API key - You must be granted a valid key by last.fm')
     end
   end
 
   describe '#auth' do
     it 'should return an instance of Lastfm::Auth' do
-      @lastfm.auth.should be_an_instance_of(Lastfm::Auth)
+      @lastfm.auth.should be_an_instance_of(Lastfm::MethodCategory::Auth)
     end
 
     it 'should get token' do
       @lastfm.should_receive(:request).
         with('auth.getToken', {}, :get, true).
-        and_return({ 'token' => 'xxxyyyzzz' })
+        and_return(make_response(<<XML))
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<token>xxxyyyzzz</token></lfm>
+XML
+
       @lastfm.auth.get_token.should eql('xxxyyyzzz')
     end
 
     it 'should get session' do
       @lastfm.should_receive(:request).
         with('auth.getSession', { :token => 'xxxyyyzzz' }, :get, true).
-        and_return({ 'session' => { 'key' => 'zzzyyyxxx' }})
+        and_return(make_response(<<XML))
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+	<session>
+		<name>MyLastFMUsername</name>
+		<key>zzzyyyxxx</key>
+		<subscriber>0</subscriber>
+	</session>
+</lfm>
+XML
       @lastfm.auth.get_session('xxxyyyzzz').should eql('zzzyyyxxx')
     end
   end
 
   describe '#track' do
     it 'should return an instance of Lastfm::Track' do
-      @lastfm.track.should be_an_instance_of(Lastfm::Track)
+      @lastfm.track.should be_an_instance_of(Lastfm::MethodCategory::Track)
     end
 
     it 'should add tags' do
@@ -141,73 +155,107 @@ describe "Lastfm" do
           :artist => 'foo artist',
           :track => 'foo track',
           :tags => 'aaa,bbb,ccc'
-        }, :post, true, true).and_return({})
+        }, :post, true, true).and_return(@ok_response)
 
-      @lastfm.track.add_tags('foo artist', 'foo track', 'aaa,bbb,ccc')
+      @lastfm.track.add_tags('foo artist', 'foo track', 'aaa,bbb,ccc').should be_true
     end
 
     it 'should ban' do
       @lastfm.should_receive(:request).with('track.ban', {
           :artist => 'foo artist',
           :track => 'foo track',
-        }, :post, true, true).and_return({})
+        }, :post, true, true).and_return(@ok_response)
 
-      @lastfm.track.ban('foo artist', 'foo track')
+      @lastfm.track.ban('foo artist', 'foo track').should be_true
     end
 
     it 'should get info' do
       @lastfm.should_receive(:request).with('track.getInfo', {
-          :artist => 'foo artist',
-          :track => 'foo track',
+          :artist => 'Cher',
+          :track => 'Believe',
           :username => 'youpy',
-        }).and_return({})
+        }).and_return(make_response('track_get_info'))
+
+      track = @lastfm.track.get_info('Cher', 'Believe', 'youpy')
+      track['name'].should eql('Believe')
+      track['album']['image'].size.should eql(4)
+      track['album']['image'].first['size'].should eql('small')
+      track['album']['image'].first['content'].should eql('http://userserve-ak.last.fm/serve/64s/8674593.jpg')
+      track['toptags']['tag'].size.should eql(5)
+      track['toptags']['tag'].first['name'].should eql('pop')
+    end
 
-      @lastfm.track.get_info('foo artist', 'foo track', 'youpy')
+    it 'should get xml with force array option' do
+      @lastfm.should_receive(:request).with('track.getInfo', {
+          :artist => 'Cher',
+          :track => 'Believe',
+          :username => 'youpy',
+        }).and_return(make_response('track_get_info_force_array'))
+
+      track = @lastfm.track.get_info('Cher', 'Believe', 'youpy')
+      track['album']['image'].size.should eql(1)
+      track['album']['image'].first['size'].should eql('small')
+      track['album']['image'].first['content'].should eql('http://userserve-ak.last.fm/serve/64s/8674593.jpg')
+      track['toptags']['tag'].size.should eql(1)
+      track['toptags']['tag'].first['name'].should eql('pop')
     end
 
     it 'should get similar' do
       @lastfm.should_receive(:request).with('track.getSimilar', {
-          :artist => 'foo artist',
-          :track => 'foo track',
-        }).and_return({})
-
-      @lastfm.track.get_similar('foo artist', 'foo track')
+          :artist => 'Cher',
+          :track => 'Believe',
+        }).and_return(make_response('track_get_similar'))
+
+      tracks = @lastfm.track.get_similar('Cher', 'Believe')
+      tracks.size.should eql(250)
+      tracks.first['name'].should eql('Strong Enough')
+      tracks.first['image'][1]['content'].should eql('http://userserve-ak.last.fm/serve/64s/8674593.jpg')
+      tracks[1]['image'][0]['content'].should eql('http://userserve-ak.last.fm/serve/34s/8674593.jpg')
     end
 
     it 'should get tags' do
       @lastfm.should_receive(:request).with('track.getTags', {
           :artist => 'foo artist',
           :track => 'foo track',
-        }, :get, true, true).and_return({})
+        }, :get, true, true).and_return(make_response('track_get_tags'))
 
-      @lastfm.track.get_tags('foo artist', 'foo track')
+      tags = @lastfm.track.get_tags('foo artist', 'foo track')
+      tags.size.should eql(2)
+      tags[0]['name'].should eql('swedish')
+      tags[0]['url'].should eql('http://www.last.fm/tag/swedish')
     end
 
     it 'should get top fans' do
       @lastfm.should_receive(:request).with('track.getTopFans', {
           :artist => 'foo artist',
           :track => 'foo track',
-        }).and_return({})
+        }).and_return(make_response('track_get_top_fans'))
 
-      @lastfm.track.get_top_fans('foo artist', 'foo track')
+      users = @lastfm.track.get_top_fans('foo artist', 'foo track')
+      users.size.should eql(2)
+      users[0]['name'].should eql('Through0glass')
     end
 
     it 'should get top tags' do
       @lastfm.should_receive(:request).with('track.getTopTags', {
           :artist => 'foo artist',
           :track => 'foo track',
-        }).and_return({})
+        }).and_return(make_response('track_get_top_tags'))
 
-      @lastfm.track.get_top_tags('foo artist', 'foo track')
+      tags = @lastfm.track.get_top_tags('foo artist', 'foo track')
+      tags.size.should eql(2)
+      tags[0]['name'].should eql('alternative')
+      tags[0]['count'].should eql('100')
+      tags[0]['url'].should eql('www.last.fm/tag/alternative')
     end
 
     it 'should love' do
       @lastfm.should_receive(:request).with('track.love', {
           :artist => 'foo artist',
           :track => 'foo track',
-        }, :post, true, true).and_return({})
+        }, :post, true, true).and_return(@ok_response)
 
-      @lastfm.track.love('foo artist', 'foo track')
+      @lastfm.track.love('foo artist', 'foo track').should be_true
     end
 
     it 'should remove tag' do
@@ -215,20 +263,24 @@ describe "Lastfm" do
           :artist => 'foo artist',
           :track => 'foo track',
           :tag => 'aaa'
-        }, :post, true, true).and_return({})
+        }, :post, true, true).and_return(@ok_response)
 
-      @lastfm.track.remove_tag('foo artist', 'foo track', 'aaa')
+      @lastfm.track.remove_tag('foo artist', 'foo track', 'aaa').should be_true
     end
 
     it 'should search' do
       @lastfm.should_receive(:request).with('track.search', {
-          :artist => 'foo artist',
-          :track => 'foo track',
+          :artist => nil,
+          :track => 'Believe',
           :limit => 10,
           :page => 3,
-        }).and_return({})
+        }).and_return(make_response('track_search'))
 
-      @lastfm.track.search('foo artist', 'foo track', 10, 3)
+      tracks = @lastfm.track.search('Believe', nil, 10, 3)
+      tracks['results']['for'].should eql('Believe')
+      tracks['results']['totalResults'].should eql('40540')
+      tracks['results']['trackmatches']['track'].size.should eql(2)
+      tracks['results']['trackmatches']['track'][0]['name'].should eql('Make Me Believe')
     end
 
     it 'should share' do
@@ -237,9 +289,37 @@ describe "Lastfm" do
           :track => 'foo track',
           :message => 'this is a message',
           :recipient => 'foo@example.com',
-        }, :post, true, true).and_return({})
+        }, :post, true, true).and_return(@ok_response)
+
+      @lastfm.track.share('foo artist', 'foo track', 'foo@example.com', 'this is a message').should be_true
+    end
+  end
+  
+  describe '#artist' do
+    it 'should return an instance of Lastfm::Artist' do
+      @lastfm.artist.should be_an_instance_of(Lastfm::MethodCategory::Artist)
+    end
 
-      @lastfm.track.share('foo artist', 'foo track', 'foo@example.com', 'this is a message')
+    it 'should get events' do
+      @lastfm.should_receive(:request).with('artist.getEvents', {
+          :artist => 'Cher'
+        }).and_return(make_response('artist_get_events'))
+      
+      events = @lastfm.artist.get_events('Cher')
+      events.size.should eql(1)
+      events[0]['title'].should eql('Cher')
+      events[0]['artists'].size.should == 2
+      events[0]['artists']['headliner'].should eql('Cher')
+      events[0]['venue']['name'].should eql('The Colosseum At Caesars Palace')
+      events[0]['venue']['location']['city'].should eql('Las Vegas(, NV)')
+      events[0]['venue']['location']['point']['lat'].should eql("36.116143")
+      events[0]['image'].size.should eql(4)
+      events[0]['image'][0]['size'].should eql('small')
+      events[0]['image'][0]['content'].should eql('http://userserve-ak.last.fm/serve/34/34814037.jpg')
+      events[0]['startDate'].should eql("Sat, 23 Oct 2010 19:30:00")
+      events[0]['tickets']['ticket']['supplier'].should eql("TicketMaster")
+      events[0]['tickets']['ticket']['content'].should eql("http://www.last.fm/affiliate/byid/29/1584537/12/ws.artist.events.b25b959554ed76058ac220b7b2e0a026")
+      events[0]['tags']['tag'].should == ["pop", "dance", "female vocalists", "80s", "cher"]
     end
   end
 end

data/spec/method_category_spec.rb

@@ -6,6 +6,6 @@ describe 'Lastfm::MethodCategory' do
   end
 
   it 'should have instance of Lastfm' do
-    Lastfm::MethodCategory.new(@lastfm).instance_eval { @lastfm }.should equal(@lastfm)
+    Lastfm::MethodCategory::Base.new(@lastfm).instance_eval { @lastfm }.should equal(@lastfm)
   end
 end