large_text_field 0.3.1 → 1.0.2.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 40f3feb2ddeb7499788d2f89e5e5f6d65944c69f
-  data.tar.gz: 97fd1b431fc477370eb2822f979ab6409186c821
+SHA256:
+  metadata.gz: 02daae5b81c9b3ebef6f0e373e74a773df8bbdaa62df75c09b24b5743dc0fe55
+  data.tar.gz: c87ac6a50da96644a853cb70dc976644bc21dd44a8c0d1b8e70fe90a8b459ac8
 SHA512:
-  metadata.gz: 92550cce241931423df48769f67fb3caf6750c3af8b85445883be0513f346e93b4cae87006fa3054fd589cce4f8036caad17c3373d69850cae196dd02734937a
-  data.tar.gz: 24dec0903a9b9100fc3242519f746151d1e57edf7bf4e3c7ab1382ccad0c914c66e179f84968b296bcfbf5896cc5016fd67a2ab8771c9b788e23534b018a0a05
+  metadata.gz: 413ecb6c2949f64ffb298c9ce35cabd57e4791ad5994cd67b6d26f1092baf90430279910d7b0ac00412753628e4973059ac62df66dfb9f60184c247e81745639
+  data.tar.gz: c809eabe4ee4995de694d5fa41fbaac7e6df37cd36812136389837dc41e58a7310b40b224c1638f682b3be1835fd56a14395199be47d2f3c308a9da964b67322

data/README.md

@@ -6,7 +6,11 @@ This gem allows any model to be associated with multiple named text fields.  Eac
 characters.  Defining new fields on models does not require a database migrations. All text fields are stored in a
 central table that is polymorphically associated with the model, but they act like a column on on the same model.
 
-# How do I use it?
+## Dependencies
+* Ruby >= 2.6
+* Rails >= 4.2, < 7
+
+## How do I use it?
 In you Gemfile add:
 
 ```
@@ -32,7 +36,7 @@ The large_text_field macro takes the following options...
  * **maximum:** - The maximum length of a large text field. By default this is 5,000,000 characters, but it can be set to less using this option.
  * **singularize_errors:** - should validation messages be singularized.
 
-Large text fields default to an empty string.  You cannot store nil in a large text field. 
+Large text fields default to an empty string.  You cannot store nil in a large text field.
 
 **Please note:**  Large text field uses the *before_save* callback on the class that is the owner for book-keeping.   Callbacks are great, but if there are multiple handlers for the same callback the order in which they are called is not predictable.  If you want to make changes to large_text_field values in the before_save callback, use the **large_text_field_save** callback instead.  This will be called before the large text field book-keeping so your changes will be saved.  For example, this will call the save_preprocess method on your class before the large text fields are saved...
 

data/Rakefile

@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -23,14 +25,14 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
 require 'rake/testtask'
 require 'rubocop/rake_task'
 
 namespace :db do
-  task :migrate => [:environment] do |t|
+  task migrate: [:environment] do |_t|
     system("bundle exec rake db:setup RAILS_ENV='test'")
   end
 end
@@ -42,7 +44,7 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = false
 end
 
-task default: [:test, :rubocop]
+task default: %i[test rubocop]
 
 desc 'Run rubocop'
 task :rubocop do

data/db/migrate/20110217210640_add_large_text_fields.rb

@@ -1,5 +1,6 @@
-class AddLargeTextFields < ActiveRecord::Migration
+# frozen_string_literal: true
 
+class AddLargeTextFields < (Rails::VERSION::MAJOR >= 5 ? ActiveRecord::Migration[4.2] : ActiveRecord::Migration)
   def self.up
     create_table :large_text_fields do |t|
       t.string  :field_name, null: false
@@ -7,7 +8,7 @@ class AddLargeTextFields < ActiveRecord::Migration
       t.integer :owner_id, null: false
       t.string  :owner_type, null: false
     end
-    add_index :large_text_fields, [:owner_type, :owner_id, :field_name], unique: true, name: 'large_text_field_by_owner_field'
+    add_index :large_text_fields, %i[owner_type owner_id field_name], unique: true, name: 'large_text_field_by_owner_field'
   end
 
   def self.down

data/lib/large_text_field/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails/engine'
 
 module LargeTextField

data/lib/large_text_field/named_text_value.rb

@@ -1,4 +1,4 @@
-require "protected_attributes"
+# frozen_string_literal: true
 
 module LargeTextField
   class NamedTextValue < ActiveRecord::Base
@@ -8,8 +8,6 @@ module LargeTextField
     #
     # index [ :owner_type, :owner_id, :field_name ], :name => 'large_text_field_by_owner_field', :unique=>true
 
-    attr_accessible :field_name, :value, :owner_type, :owner_id, :owner
-
     belongs_to :owner, polymorphic: true, inverse_of: :large_text_fields
 
     self.table_name = "large_text_fields"

data/lib/large_text_field/owner.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require "invoca/utils"
+
 module LargeTextField
   module Owner
     extend ActiveSupport::Concern
@@ -23,8 +27,8 @@ module LargeTextField
       result
     end
 
-    def reload
-      super
+    def reload(options = nil)
+      super(options)
       @text_field_hash = nil
       self
     end
@@ -38,7 +42,7 @@ module LargeTextField
     end
 
     def get_text_field(field_name)
-      text_field_hash[field_name.to_s]._?.value || ''
+      text_field_hash[field_name.to_s]&.value || ''
     end
 
     def set_text_field(original_field_name, original_value)
@@ -54,13 +58,13 @@ module LargeTextField
     end
 
     def text_field_changed(field_name)
-      text_field_hash_loaded? && @text_field_hash[field_name]._?.changes._?.any?
+      text_field_hash_loaded? && @text_field_hash[field_name]&.changes&.any?
     end
 
     def validate_large_text_fields
       if text_field_hash_loaded?
         large_text_field_options.each do |k, options|
-          value = text_field_hash[k]._?.value
+          value = text_field_hash[k]&.value
           conjugation = options[:singularize_errors] ? "is" : "are"
           maximum = options[:maximum] || MAX_LENGTH
           errors.add k, "#{conjugation} too long (maximum is #{self.class.formatted_integer_value(maximum)} characters)" if value.present? && value.size > maximum
@@ -92,7 +96,7 @@ module LargeTextField
             raise ArgumentError, "maximum must be a number"
           elsif maximum > MAX_LENGTH
             raise ArgumentError, "maximum can't be greater than #{formatted_integer_value(MAX_LENGTH)}"
-          elsif maximum < 0
+          elsif maximum.negative?
             raise ArgumentError, "maximum can't be less than 0"
           end
         end

data/lib/large_text_field/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LargeTextField
-  VERSION = "0.3.1"
+  VERSION = "1.0.2.pre.1"
 end

data/lib/large_text_field.rb

@@ -1,5 +1,4 @@
-require "hobo_support"
-require "protected_attributes"
+# frozen_string_literal: true
 
 require "rails"
 

data/test/dummy/Rakefile

@@ -1,7 +1,9 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 
 Dummy::Application.load_tasks

data/test/dummy/app/assets/config/manifest.js

@@ -0,0 +1 @@
+{}

data/test/dummy/app/models/library.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 class Library < ActiveRecord::Base
   include LargeTextField::Owner
 
   # Schema
   #   name :string, :limit => 255
-  attr_accessible  :name, :description, :catalog, :notes
 
   large_text_field :description, singularize_errors: true
   large_text_field :catalog, maximum: 500, singularize_errors: true

data/test/dummy/config/application.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../boot', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('boot', __dir__)
 
 require 'rails/all'
 

data/test/dummy/config/boot.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
+gemfile = File.expand_path('../../../Gemfile', __dir__)
 
 if File.exist?(gemfile)
   ENV['BUNDLE_GEMFILE'] = gemfile
@@ -7,4 +9,4 @@ if File.exist?(gemfile)
   Bundler.setup
 end
 
-$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)

data/test/dummy/config/database.yml

@@ -12,11 +12,23 @@ development:
 # Warning: The database defined as "test" will be erased and
 # re-generated from your development database when you run "rake".
 # Do not set this db to the same as development or production.
+<% if ENV["USE_MYSQL_DB"] %>
+test:
+  adapter: mysql2
+  encoding: utf8
+  reconnect: false
+  database: large_text_field_test
+  pool: 5
+  username: <%= ENV['DATABASE_MYSQL_USERNAME'] || 'root' %>
+  password: <%= ENV['DATABASE_MYSQL_PASSWORD'] || '' %>
+  host: <%= ENV['DATABASE_MYSQL_HOST'] || 'localhost' %>
+<% else %>
 test:
   adapter: sqlite3
-  database: db/test.sqlite3
+  database: <%= ENV['TEST_DB'].presence || 'db/test.sqlite3' %>
   pool: 5
   timeout: 5000
+<% end %>
 
 production:
   adapter: sqlite3

data/test/dummy/config/environment.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Load the rails application
-require File.expand_path('../application', __FILE__)
+require File.expand_path('application', __dir__)
 
 # Initialize the rails application
 Dummy::Application.initialize!

data/test/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
@@ -22,9 +24,6 @@ Dummy::Application.configure do
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   # config.active_record.auto_explain_threshold_in_seconds = 0.5

data/test/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
@@ -29,9 +31,6 @@ Dummy::Application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
 

data/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

data/test/dummy/db/migrate/20160217033529_create_libraries.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateLibraries < ActiveRecord::Migration
   def self.up
     create_table :libraries do |t|

data/test/dummy/db/schema.rb

@@ -14,16 +14,16 @@
 ActiveRecord::Schema.define(version: 20160217033529) do
 
   create_table "large_text_fields", force: :cascade do |t|
-    t.string  "field_name",                  null: false
+    t.string  "field_name", limit: 255,      null: false
     t.text    "value",      limit: 16777215
-    t.integer "owner_id",                    null: false
-    t.string  "owner_type",                  null: false
+    t.integer "owner_id",   limit: 4,        null: false
+    t.string  "owner_type", limit: 255,      null: false
   end
 
-  add_index "large_text_fields", ["owner_type", "owner_id", "field_name"], name: "large_text_field_by_owner_field", unique: true
+  add_index "large_text_fields", ["owner_type", "owner_id", "field_name"], name: "large_text_field_by_owner_field", unique: true, using: :btree
 
   create_table "libraries", force: :cascade do |t|
-    t.string "name", null: false
+    t.string "name", limit: 255, null: false
   end
 
 end

data/test/dummy/log/development.log

@@ -0,0 +1,39 @@
+   (2.3ms)  CREATE TABLE "large_text_fields" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "field_name" varchar NOT NULL, "value" text(16777215), "owner_id" integer NOT NULL, "owner_type" varchar NOT NULL) 
+   (0.1ms)  select sqlite_version(*)
+   (1.7ms)  CREATE UNIQUE INDEX "large_text_field_by_owner_field" ON "large_text_fields" ("owner_type", "owner_id", "field_name")
+   (1.7ms)  CREATE TABLE "libraries" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar NOT NULL) 
+   (1.5ms)  CREATE TABLE "schema_migrations" ("version" varchar NOT NULL) 
+   (1.4ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+   (0.1ms)  SELECT version FROM "schema_migrations"
+   (1.8ms)  INSERT INTO "schema_migrations" (version) VALUES ('20160217033529')
+   (1.7ms)  INSERT INTO "schema_migrations" (version) VALUES ('20110217210640')
+   (1.8ms)  DROP TABLE "large_text_fields"
+   (1.4ms)  CREATE TABLE "large_text_fields" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "field_name" varchar NOT NULL, "value" text(16777215), "owner_id" integer NOT NULL, "owner_type" varchar NOT NULL) 
+   (0.1ms)  select sqlite_version(*)
+   (6.1ms)  CREATE UNIQUE INDEX "large_text_field_by_owner_field" ON "large_text_fields" ("owner_type", "owner_id", "field_name")
+   (1.3ms)  DROP TABLE "libraries"
+   (1.6ms)  CREATE TABLE "libraries" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar NOT NULL) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.6ms)  DROP TABLE "large_text_fields"
+   (1.1ms)  CREATE TABLE "large_text_fields" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "field_name" varchar NOT NULL, "value" text(16777215), "owner_id" integer NOT NULL, "owner_type" varchar NOT NULL) 
+   (0.0ms)  select sqlite_version(*)
+   (1.2ms)  CREATE UNIQUE INDEX "large_text_field_by_owner_field" ON "large_text_fields" ("owner_type", "owner_id", "field_name")
+   (1.2ms)  DROP TABLE "libraries"
+   (1.0ms)  CREATE TABLE "libraries" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar NOT NULL) 
+   (0.3ms)  SELECT version FROM "schema_migrations"
+   (1.2ms)  DROP TABLE "large_text_fields"
+   (1.2ms)  CREATE TABLE "large_text_fields" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "field_name" varchar NOT NULL, "value" text(16777215), "owner_id" integer NOT NULL, "owner_type" varchar NOT NULL) 
+   (0.0ms)  select sqlite_version(*)
+   (1.1ms)  CREATE UNIQUE INDEX "large_text_field_by_owner_field" ON "large_text_fields" ("owner_type", "owner_id", "field_name")
+   (1.1ms)  DROP TABLE "libraries"
+   (1.2ms)  CREATE TABLE "libraries" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar NOT NULL) 
+   (0.1ms)  SELECT version FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (1.4ms)  DROP TABLE "large_text_fields"
+   (1.2ms)  CREATE TABLE "large_text_fields" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "field_name" varchar NOT NULL, "value" text(16777215), "owner_id" integer NOT NULL, "owner_type" varchar NOT NULL) 
+   (0.0ms)  select sqlite_version(*)
+   (1.1ms)  CREATE UNIQUE INDEX "large_text_field_by_owner_field" ON "large_text_fields" ("owner_type", "owner_id", "field_name")
+   (1.1ms)  DROP TABLE "libraries"
+   (0.9ms)  CREATE TABLE "libraries" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "name" varchar NOT NULL) 
+   (0.1ms)  SELECT version FROM "schema_migrations"