language_server 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f539c291399eeb7ea1e033307134aa1fd8b86c5
-  data.tar.gz: 3f5c47d75fe00323a36ddc34d426e538e3a258f5
+  metadata.gz: 7139ff0bb62fcf30de5f216cc102cc2e06a52f8a
+  data.tar.gz: '019a3200bde8868ffa962478c9a0f5347adeebdb'
 SHA512:
-  metadata.gz: 412ff31e6c1c49cd0ef3ab42afd604e35a9c7b2d02bfe86e2422644e02a44d86f73705e3c33a081b787c1d70d1590d179e4c817ade7084ef3734112e2d734dc6
-  data.tar.gz: b431130afd449e31ba64a233c7649974840509ca6a048d9cb686e8866487ae9cf6c3c6ff1dd9a0297efe8fd0e066df3337690266323e23e1185b44e6b0f85937
+  metadata.gz: dae2397674045b4c88433c9efd9d4191739f2ed0cd36f908a86aca03d634bde4f1741900539439a72c252600f89008f7149d28b24cba6fc62e4d1963c724b406
+  data.tar.gz: 6c49f740e25807d8856df833c297d02a42802863d1abeb2b9c5278c9968d87c69c69b7be59ef7c79a1ebbc5d14a2a6e290adc91390e196aff4b75c54ca854818

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Not released
 
+## 0.8.0
+
+- Use RubyVM::InstructionSequence.compile instead of open3
 
 ## 0.7.0
 

data/benchmark/ruby_wc

@@ -0,0 +1,22 @@
+#!/usr/bin/env ruby
+
+require 'bundler/setup'
+require 'benchmark/ips'
+require 'language_server'
+
+error_code = <<-EOS
+require "foo
+if a == "\\n"
+EOS
+warn_code = <<-EOS
+a = 1
+EOS
+valid_code = File.read(__FILE__)
+
+Benchmark.ips do |x|
+  x.report do
+    [error_code, warn_code, valid_code].each do |code|
+      LanguageServer::Linter::RubyWC.new(code).call
+    end
+  end
+end

data/language_server.gemspec

@@ -35,4 +35,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest-power_assert"
   spec.add_development_dependency "m"
   spec.add_development_dependency "awesome_print"
+  spec.add_development_dependency "benchmark-ips"
 end

data/lib/language_server/linter/ruby_wc.rb

@@ -1,4 +1,4 @@
-require "open3"
+require "stringio"
 
 module LanguageServer
   module Linter
@@ -26,12 +26,55 @@ module LanguageServer
       end
 
       def call
-        _, err, _ = Open3.capture3("ruby -wc", stdin_data: @source)
-
-        err.scan(/.+:(\d+):\s*(.+?)[,:]\s(.+)/).map do |line_num, type,  message|
+        error_message.scan(/.+:(\d+):\s*(.+?)[,:]\s(.+)/).map do |line_num, type,  message|
           Error.new(line_num: line_num.to_i - 1, message: message, type: type)
         end
       end
+
+      private
+
+      # Since Ruby 2.4, syntax error information is outputted to Exception#message instead of stderr
+      if begin; stderr = $stderr; $stderr = StringIO.new; RubyVM::InstructionSequence.compile('='); rescue SyntaxError => e; e.message != 'compile error'; ensure; $stderr = stderr; end
+        def error_message
+          with_verbose do
+            begin
+              capture_stderr { RubyVM::InstructionSequence.compile(@source) }
+            rescue SyntaxError => e
+              e.message
+            end
+          end
+        end
+      else
+        def error_message
+          with_verbose do
+            capture_stderr do
+              begin
+                RubyVM::InstructionSequence.compile(@source)
+              rescue SyntaxError
+              end
+            end
+          end
+        end
+      end
+
+      def with_verbose
+        origin = $VERBOSE
+        $VERBOSE = true
+        yield
+      ensure
+        $VERBOSE = origin
+      end
+
+      def capture_stderr
+        origin = $stderr
+        $stderr = StringIO.new
+
+        yield
+
+        $stderr.string
+      ensure
+        $stderr = origin
+      end
     end
   end
 end

data/lib/language_server/version.rb

@@ -1,3 +1,3 @@
 module LanguageServer
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: language_server
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Fumiaki MATSUSHIMA
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rcodetools
@@ -136,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Ruby Language Server implementation
 email:
 - mtsmfm@gmail.com
@@ -154,6 +168,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- benchmark/ruby_wc
 - bin/console
 - bin/language_server-ruby
 - bin/m