language-operator 0.1.31 → 0.1.35

data/lib/language_operator/cli/commands/persona.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require 'thor'
 require 'yaml'
+require_relative '../base_command'
 require_relative '../formatters/progress_formatter'
 require_relative '../formatters/table_formatter'
 require_relative '../helpers/cluster_validator'
-require_relative '../helpers/cluster_context'
 require_relative '../helpers/user_prompts'
 require_relative '../helpers/resource_dependency_checker'
 require_relative '../helpers/editor_helper'
@@ -18,113 +17,96 @@ module LanguageOperator
   module CLI
     module Commands
       # Persona management commands
-      class Persona < Thor
+      class Persona < BaseCommand
         include Helpers::ClusterValidator
         include Helpers::PastelHelper
 
         desc 'list', 'List all personas in current cluster'
         option :cluster, type: :string, desc: 'Override current cluster context'
         def list
-          ctx = Helpers::ClusterContext.from_options(options)
+          handle_command_error('list personas') do
+            personas = list_resources_or_empty('LanguagePersona') do
+              puts
+              puts 'Personas define the personality and capabilities of agents.'
+              puts
+              puts 'Create a persona with:'
+              puts '  aictl persona create <name>'
+            end
 
-          personas = ctx.client.list_resources('LanguagePersona', namespace: ctx.namespace)
+            return if personas.empty?
 
-          if personas.empty?
-            Formatters::ProgressFormatter.info("No personas found in cluster '#{ctx.name}'")
-            puts
-            puts 'Personas define the personality and capabilities of agents.'
-            puts
-            puts 'Create a persona with:'
-            puts '  aictl persona create <name>'
-            return
-          end
+            # Get agents to count usage
+            agents = ctx.client.list_resources('LanguageAgent', namespace: ctx.namespace)
 
-          # Get agents to count usage
-          agents = ctx.client.list_resources('LanguageAgent', namespace: ctx.namespace)
+            table_data = personas.map do |persona|
+              name = persona.dig('metadata', 'name')
+              used_by = agents.count { |a| a.dig('spec', 'persona') == name }
 
-          table_data = personas.map do |persona|
-            name = persona.dig('metadata', 'name')
-            used_by = agents.count { |a| a.dig('spec', 'persona') == name }
+              {
+                name: name,
+                tone: persona.dig('spec', 'tone') || 'neutral',
+                used_by: used_by,
+                description: persona.dig('spec', 'description') || ''
+              }
+            end
 
-            {
-              name: name,
-              tone: persona.dig('spec', 'tone') || 'neutral',
-              used_by: used_by,
-              description: persona.dig('spec', 'description') || ''
-            }
+            Formatters::TableFormatter.personas(table_data)
           end
-
-          Formatters::TableFormatter.personas(table_data)
-        rescue StandardError => e
-          Formatters::ProgressFormatter.error("Failed to list personas: #{e.message}")
-          raise if ENV['DEBUG']
-
-          exit 1
         end
 
         desc 'show NAME', 'Display full persona details'
         option :cluster, type: :string, desc: 'Override current cluster context'
         def show(name)
-          ctx = Helpers::ClusterContext.from_options(options)
+          handle_command_error('show persona') do
+            persona = get_resource_or_exit('LanguagePersona', name)
 
-          begin
-            persona = ctx.client.get_resource('LanguagePersona', name, ctx.namespace)
-          rescue K8s::Error::NotFound
-            Formatters::ProgressFormatter.error("Persona '#{name}' not found in cluster '#{ctx.name}'")
-            exit 1
-          end
+            puts
+            puts "Persona: #{pastel.cyan.bold(name)}"
+            puts '═' * 80
+            puts
 
-          puts
-          puts "Persona: #{pastel.cyan.bold(name)}"
-          puts '═' * 80
-          puts
-
-          # Format and display key persona details
-          spec = persona['spec'] || {}
-          puts "#{pastel.bold('Display Name:')} #{spec['displayName']}"
-          puts "#{pastel.bold('Tone:')} #{pastel.yellow(spec['tone'])}" if spec['tone']
-          puts
-          puts pastel.bold('Description:')
-          puts "  #{spec['description']}"
-          puts
-
-          if spec['systemPrompt']
-            puts pastel.bold('System Prompt:')
-            puts "  #{spec['systemPrompt']}"
+            # Format and display key persona details
+            spec = persona['spec'] || {}
+            puts "#{pastel.bold('Display Name:')} #{spec['displayName']}"
+            puts "#{pastel.bold('Tone:')} #{pastel.yellow(spec['tone'])}" if spec['tone']
+            puts
+            puts pastel.bold('Description:')
+            puts "  #{spec['description']}"
             puts
-          end
 
-          if spec['capabilities']&.any?
-            puts pastel.bold('Capabilities:')
-            spec['capabilities'].each do |cap|
-              puts "  #{pastel.green('•')} #{cap}"
+            if spec['systemPrompt']
+              puts pastel.bold('System Prompt:')
+              puts "  #{spec['systemPrompt']}"
+              puts
             end
-            puts
-          end
 
-          if spec['toolPreferences']&.any?
-            puts pastel.bold('Tool Preferences:')
-            spec['toolPreferences'].each do |pref|
-              puts "  #{pastel.green('•')} #{pref}"
+            if spec['capabilities']&.any?
+              puts pastel.bold('Capabilities:')
+              spec['capabilities'].each do |cap|
+                puts "  #{pastel.green('•')} #{cap}"
+              end
+              puts
             end
-            puts
-          end
 
-          if spec['responseFormat']
-            puts "#{pastel.bold('Response Format:')} #{spec['responseFormat']}"
-            puts
-          end
+            if spec['toolPreferences']&.any?
+              puts pastel.bold('Tool Preferences:')
+              spec['toolPreferences'].each do |pref|
+                puts "  #{pastel.green('•')} #{pref}"
+              end
+              puts
+            end
 
-          puts '═' * 80
-          puts
-          Formatters::ProgressFormatter.info('Use this persona when creating agents:')
-          puts "  aictl agent create \"description\" --persona #{name}"
-          puts
-        rescue StandardError => e
-          Formatters::ProgressFormatter.error("Failed to show persona: #{e.message}")
-          raise if ENV['DEBUG']
+            if spec['responseFormat']
+              puts "#{pastel.bold('Response Format:')} #{spec['responseFormat']}"
+              puts
+            end
 
-          exit 1
+            puts '═' * 80
+            puts
+            Formatters::ProgressFormatter.info('Use this persona when creating agents:')
+            puts "  aictl agent create \"description\" --persona #{name}"
+            puts
+          end
         end
 
         desc 'create NAME', 'Create a new persona'
@@ -138,124 +120,115 @@ module LanguageOperator
         option :cluster, type: :string, desc: 'Override current cluster context'
         option :from, type: :string, desc: 'Copy from existing persona as starting point'
         def create(name)
-          ctx = Helpers::ClusterContext.from_options(options)
-
-          # Check if persona already exists
-          begin
-            ctx.client.get_resource('LanguagePersona', name, ctx.namespace)
-            Formatters::ProgressFormatter.error("Persona '#{name}' already exists in cluster '#{ctx.name}'")
-            puts
-            puts 'Use a different name or delete the existing persona first:'
-            puts "  aictl persona delete #{name}"
-            exit 1
-          rescue K8s::Error::NotFound
-            # Good - persona doesn't exist yet
-          end
-
-          # If --from flag provided, copy from existing persona
-          base_persona = nil
-          if options[:from]
+          handle_command_error('create persona') do
+            # Check if persona already exists
             begin
-              base_persona = ctx.client.get_resource('LanguagePersona', options[:from], ctx.namespace)
-              Formatters::ProgressFormatter.info("Copying from persona '#{options[:from]}'")
+              ctx.client.get_resource('LanguagePersona', name, ctx.namespace)
+              Formatters::ProgressFormatter.error("Persona '#{name}' already exists in cluster '#{ctx.name}'")
               puts
-            rescue K8s::Error::NotFound
-              Formatters::ProgressFormatter.error("Source persona '#{options[:from]}' not found")
+              puts 'Use a different name or delete the existing persona first:'
+              puts "  aictl persona delete #{name}"
               exit 1
+            rescue K8s::Error::NotFound
+              # Good - persona doesn't exist yet
             end
-          end
 
-          # Interactive prompts
-          require 'tty-prompt'
-          prompt = TTY::Prompt.new
+            # If --from flag provided, copy from existing persona
+            base_persona = nil
+            if options[:from]
+              base_persona = get_resource_or_exit('LanguagePersona', options[:from],
+                                                  error_message: "Source persona '#{options[:from]}' not found")
+              Formatters::ProgressFormatter.info("Copying from persona '#{options[:from]}'")
+              puts
+            end
 
-          puts
-          puts '=' * 80
-          puts '  Create New Persona'
-          puts '=' * 80
-          puts
+            # Interactive prompts
+            require 'tty-prompt'
+            prompt = TTY::Prompt.new
 
-          # Get display name
-          default_display_name = base_persona&.dig('spec', 'displayName') || name.split('-').map(&:capitalize).join(' ')
-          display_name = prompt.ask('Display Name:', default: default_display_name)
+            puts
+            puts '=' * 80
+            puts '  Create New Persona'
+            puts '=' * 80
+            puts
 
-          # Get description
-          default_description = base_persona&.dig('spec', 'description') || ''
-          description = prompt.ask('Description:', default: default_description) do |q|
-            q.required true
-          end
+            # Get display name
+            default_display_name = base_persona&.dig('spec', 'displayName') || name.split('-').map(&:capitalize).join(' ')
+            display_name = prompt.ask('Display Name:', default: default_display_name)
 
-          # Get tone
-          default_tone = base_persona&.dig('spec', 'tone') || 'neutral'
-          tone = prompt.select('Tone:', %w[neutral friendly professional technical creative], default: default_tone)
+            # Get description
+            default_description = base_persona&.dig('spec', 'description') || ''
+            description = prompt.ask('Description:', default: default_description) do |q|
+              q.required true
+            end
 
-          # Get system prompt
-          puts
-          puts 'System Prompt (press Enter to open editor):'
-          prompt.keypress('Press any key to continue...')
+            # Get tone
+            default_tone = base_persona&.dig('spec', 'tone') || 'neutral'
+            tone = prompt.select('Tone:', %w[neutral friendly professional technical creative], default: default_tone)
 
-          default_system_prompt = base_persona&.dig('spec', 'systemPrompt') || ''
-          system_prompt = edit_in_editor(default_system_prompt, 'persona-system-prompt')
+            # Get system prompt
+            puts
+            puts 'System Prompt (press Enter to open editor):'
+            prompt.keypress('Press any key to continue...')
 
-          if system_prompt.strip.empty?
-            Formatters::ProgressFormatter.error('System prompt cannot be empty')
-            exit 1
-          end
+            default_system_prompt = base_persona&.dig('spec', 'systemPrompt') || ''
+            system_prompt = Helpers::EditorHelper.edit_content(default_system_prompt, 'persona-system-prompt', '.txt')
 
-          # Get capabilities
-          puts
-          puts 'Capabilities (optional, press Enter to open editor, or leave empty to skip):'
-          puts 'Describe what this persona can do, one per line.'
-          prompt.keypress('Press any key to continue...')
-
-          default_capabilities = base_persona&.dig('spec', 'capabilities')&.join("\n") || ''
-          capabilities_text = edit_in_editor(default_capabilities, 'persona-capabilities')
-          capabilities = capabilities_text.strip.empty? ? [] : capabilities_text.strip.split("\n").map(&:strip).reject(&:empty?)
-
-          # Build persona resource
-          persona_spec = {
-            'displayName' => display_name,
-            'description' => description,
-            'tone' => tone,
-            'systemPrompt' => system_prompt.strip
-          }
-          persona_spec['capabilities'] = capabilities unless capabilities.empty?
-
-          persona_resource = Kubernetes::ResourceBuilder.build_persona(
-            name: name,
-            spec: persona_spec,
-            namespace: ctx.namespace
-          )
-
-          # Show preview
-          puts
-          puts '=' * 80
-          puts 'Preview:'
-          puts '=' * 80
-          puts YAML.dump(persona_resource)
-          puts '=' * 80
-          puts
-
-          # Confirm creation
-          unless prompt.yes?('Create this persona?')
-            puts 'Creation cancelled'
-            return
-          end
+            if system_prompt.strip.empty?
+              Formatters::ProgressFormatter.error('System prompt cannot be empty')
+              exit 1
+            end
 
-          # Create persona
-          Formatters::ProgressFormatter.with_spinner("Creating persona '#{name}'") do
-            ctx.client.create_resource(persona_resource)
-          end
+            # Get capabilities
+            puts
+            puts 'Capabilities (optional, press Enter to open editor, or leave empty to skip):'
+            puts 'Describe what this persona can do, one per line.'
+            prompt.keypress('Press any key to continue...')
+
+            default_capabilities = base_persona&.dig('spec', 'capabilities')&.join("\n") || ''
+            capabilities_text = Helpers::EditorHelper.edit_content(default_capabilities, 'persona-capabilities', '.txt')
+            capabilities = capabilities_text.strip.empty? ? [] : capabilities_text.strip.split("\n").map(&:strip).reject(&:empty?)
+
+            # Build persona resource
+            persona_spec = {
+              'displayName' => display_name,
+              'description' => description,
+              'tone' => tone,
+              'systemPrompt' => system_prompt.strip
+            }
+            persona_spec['capabilities'] = capabilities unless capabilities.empty?
+
+            persona_resource = Kubernetes::ResourceBuilder.build_persona(
+              name: name,
+              spec: persona_spec,
+              namespace: ctx.namespace
+            )
+
+            # Show preview
+            puts
+            puts '=' * 80
+            puts 'Preview:'
+            puts '=' * 80
+            puts YAML.dump(persona_resource)
+            puts '=' * 80
+            puts
+
+            # Confirm creation
+            unless prompt.yes?('Create this persona?')
+              puts 'Creation cancelled'
+              return
+            end
 
-          Formatters::ProgressFormatter.success("Persona '#{name}' created successfully")
-          puts
-          puts 'Use this persona when creating agents:'
-          puts "  aictl agent create \"description\" --persona #{name}"
-        rescue StandardError => e
-          Formatters::ProgressFormatter.error("Failed to create persona: #{e.message}")
-          raise if ENV['DEBUG']
+            # Create persona
+            Formatters::ProgressFormatter.with_spinner("Creating persona '#{name}'") do
+              ctx.client.create_resource(persona_resource)
+            end
 
-          exit 1
+            Formatters::ProgressFormatter.success("Persona '#{name}' created successfully")
+            puts
+            puts 'Use this persona when creating agents:'
+            puts "  aictl agent create \"description\" --persona #{name}"
+          end
         end
 
         desc 'edit NAME', 'Edit an existing persona'
@@ -270,122 +243,83 @@ module LanguageOperator
         DESC
         option :cluster, type: :string, desc: 'Override current cluster context'
         def edit(name)
-          ctx = Helpers::ClusterContext.from_options(options)
-
-          # Get current persona
-          begin
-            persona = ctx.client.get_resource('LanguagePersona', name, ctx.namespace)
-          rescue K8s::Error::NotFound
-            Formatters::ProgressFormatter.error("Persona '#{name}' not found in cluster '#{ctx.name}'")
-            exit 1
-          end
-
-          # Open in editor
-          original_yaml = YAML.dump(persona)
-          edited_yaml = edit_in_editor(original_yaml, "persona-#{name}")
-
-          # Check if changed
-          if edited_yaml.strip == original_yaml.strip
-            Formatters::ProgressFormatter.info('No changes made')
-            return
-          end
+          handle_command_error('edit persona') do
+            # Get current persona
+            persona = get_resource_or_exit('LanguagePersona', name)
+
+            # Open in editor
+            original_yaml = YAML.dump(persona)
+            edited_yaml = Helpers::EditorHelper.edit_content(original_yaml, "persona-#{name}", '.txt')
+
+            # Check if changed
+            if edited_yaml.strip == original_yaml.strip
+              Formatters::ProgressFormatter.info('No changes made')
+              return
+            end
 
-          # Parse edited YAML
-          begin
-            edited_persona = YAML.safe_load(edited_yaml)
-          rescue Psych::SyntaxError => e
-            Formatters::ProgressFormatter.error("Invalid YAML: #{e.message}")
-            exit 1
-          end
+            # Parse edited YAML
+            begin
+              edited_persona = YAML.safe_load(edited_yaml)
+            rescue Psych::SyntaxError => e
+              Formatters::ProgressFormatter.error("Invalid YAML: #{e.message}")
+              exit 1
+            end
 
-          # Validate structure
-          unless edited_persona.is_a?(Hash) && edited_persona['spec']
-            Formatters::ProgressFormatter.error('Invalid persona structure: missing spec')
-            exit 1
-          end
+            # Validate structure
+            unless edited_persona.is_a?(Hash) && edited_persona['spec']
+              Formatters::ProgressFormatter.error('Invalid persona structure: missing spec')
+              exit 1
+            end
 
-          # Update persona
-          Formatters::ProgressFormatter.with_spinner("Updating persona '#{name}'") do
-            ctx.client.update_resource(edited_persona)
-          end
+            # Update persona
+            Formatters::ProgressFormatter.with_spinner("Updating persona '#{name}'") do
+              ctx.client.update_resource(edited_persona)
+            end
 
-          Formatters::ProgressFormatter.success("Persona '#{name}' updated successfully")
+            Formatters::ProgressFormatter.success("Persona '#{name}' updated successfully")
 
-          # Check for agents using this persona
-          agents = ctx.client.list_resources('LanguageAgent', namespace: ctx.namespace)
-          agents_using = Helpers::ResourceDependencyChecker.agents_using_persona(agents, name)
+            # Check for agents using this persona
+            agents = ctx.client.list_resources('LanguageAgent', namespace: ctx.namespace)
+            agents_using = Helpers::ResourceDependencyChecker.agents_using_persona(agents, name)
 
-          if agents_using.any?
-            puts
-            Formatters::ProgressFormatter.info("#{agents_using.count} agent(s) will be re-synthesized automatically:")
-            agents_using.each do |agent|
-              puts "  - #{agent.dig('metadata', 'name')}"
+            if agents_using.any?
+              puts
+              Formatters::ProgressFormatter.info("#{agents_using.count} agent(s) will be re-synthesized automatically:")
+              agents_using.each do |agent|
+                puts "  - #{agent.dig('metadata', 'name')}"
+              end
             end
           end
-        rescue StandardError => e
-          Formatters::ProgressFormatter.error("Failed to edit persona: #{e.message}")
-          raise if ENV['DEBUG']
-
-          exit 1
         end
 
         desc 'delete NAME', 'Delete a persona'
         option :cluster, type: :string, desc: 'Override current cluster context'
         option :force, type: :boolean, default: false, desc: 'Skip confirmation'
         def delete(name)
-          ctx = Helpers::ClusterContext.from_options(options)
-
-          # Get persona
-          begin
-            persona = ctx.client.get_resource('LanguagePersona', name, ctx.namespace)
-          rescue K8s::Error::NotFound
-            Formatters::ProgressFormatter.error("Persona '#{name}' not found in cluster '#{ctx.name}'")
-            exit 1
-          end
-
-          # Check for agents using this persona
-          agents = ctx.client.list_resources('LanguageAgent', namespace: ctx.namespace)
-          agents_using = Helpers::ResourceDependencyChecker.agents_using_persona(agents, name)
-
-          if agents_using.any? && !options[:force]
-            Formatters::ProgressFormatter.warn("Persona '#{name}' is in use by #{agents_using.count} agent(s)")
-            puts
-            puts 'Agents using this persona:'
-            agents_using.each do |agent|
-              puts "  - #{agent.dig('metadata', 'name')}"
+          handle_command_error('delete persona') do
+            # Get persona
+            persona = get_resource_or_exit('LanguagePersona', name)
+
+            # Check dependencies and get confirmation
+            return unless check_dependencies_and_confirm('persona', name, force: options[:force])
+
+            # Confirm deletion unless --force
+            if confirm_deletion(
+              'persona', name, ctx.name,
+              details: {
+                'Tone' => persona.dig('spec', 'tone'),
+                'Description' => persona.dig('spec', 'description')
+              },
+              force: options[:force]
+            )
+              # Delete persona
+              Formatters::ProgressFormatter.with_spinner("Deleting persona '#{name}'") do
+                ctx.client.delete_resource('LanguagePersona', name, ctx.namespace)
+              end
+
+              Formatters::ProgressFormatter.success("Persona '#{name}' deleted successfully")
             end
-            puts
-            puts 'Delete these agents first, or use --force to delete anyway.'
-            puts
-            return unless Helpers::UserPrompts.confirm('Are you sure?')
-          end
-
-          # Confirm deletion unless --force
-          unless options[:force] || agents_using.any?
-            puts "This will delete persona '#{name}' from cluster '#{ctx.name}':"
-            puts "  Tone:        #{persona.dig('spec', 'tone')}"
-            puts "  Description: #{persona.dig('spec', 'description')}"
-            puts
-            return unless Helpers::UserPrompts.confirm('Are you sure?')
-          end
-
-          # Delete persona
-          Formatters::ProgressFormatter.with_spinner("Deleting persona '#{name}'") do
-            ctx.client.delete_resource('LanguagePersona', name, ctx.namespace)
           end
-
-          Formatters::ProgressFormatter.success("Persona '#{name}' deleted successfully")
-        rescue StandardError => e
-          Formatters::ProgressFormatter.error("Failed to delete persona: #{e.message}")
-          raise if ENV['DEBUG']
-
-          exit 1
-        end
-
-        private
-
-        def edit_in_editor(content, filename_prefix)
-          Helpers::EditorHelper.edit_content(content, filename_prefix, '.txt')
         end
       end
     end

data/lib/language_operator/cli/commands/quickstart.rb

@@ -1,18 +1,17 @@
 # frozen_string_literal: true
 
-require 'thor'
+require_relative '../base_command'
 require_relative '../formatters/progress_formatter'
-require_relative '../wizards/quickstart_wizard'
+require_relative '../../ux/quickstart'
 
 module LanguageOperator
   module CLI
     module Commands
       # Quickstart wizard for first-time users
-      class Quickstart < Thor
+      class Quickstart < BaseCommand
         desc 'start', 'Interactive setup wizard for first-time users'
         def start
-          wizard = Wizards::QuickstartWizard.new
-          wizard.run
+          Ux::Quickstart.execute
         end
 
         default_task :start