kward 0.80.0 → 0.81.0

data/lib/kward/skills/registry.rb

@@ -1,4 +1,5 @@
 require "pathname"
+require_relative "trust_store"
 
 # Namespace for the Kward CLI agent runtime.
 module Kward
@@ -13,8 +14,9 @@ module Kward
     # @api public
     class Registry
       SkillSource = Struct.new(:root, :label, :scope, :precedence, keyword_init: true)
+      SkillCandidate = Struct.new(:path, :root, :label, :scope, :digest, keyword_init: true)
 
-      def initialize(config_dir:, workspace_root:, project_skills_trusted:, skill_class:, max_file_bytes:, markdown_parser:, inside_directory:)
+      def initialize(config_dir:, workspace_root:, project_skills_trusted:, skill_class:, max_file_bytes:, markdown_parser:, inside_directory:, warning_sink: nil, project_skill_paths: nil)
         @config_dir = config_dir
         @workspace_root = workspace_root
         @project_skills_trusted = project_skills_trusted
@@ -22,6 +24,33 @@ module Kward
         @max_file_bytes = max_file_bytes
         @markdown_parser = markdown_parser
         @inside_directory = inside_directory
+        @warning_sink = warning_sink
+        @project_skill_paths = project_skill_paths&.map do |path|
+          File.realpath(path)
+        rescue SystemCallError
+          File.expand_path(path)
+        end
+      end
+
+      # Returns project skill files without activating their instructions.
+      #
+      # @return [Array<SkillCandidate>]
+      # @api public
+      def project_skill_candidates
+        skill_sources.select { |source| source.scope == :project }.flat_map do |source|
+          discover_source(source).filter_map do |path|
+            SkillCandidate.new(
+              path: path,
+              root: source.root,
+              label: source.label,
+              scope: source.scope,
+              digest: skill_digest(path)
+            )
+          rescue StandardError => e
+            emit_warning "Warning: skipping Kward skill #{path}: #{e.message}"
+            nil
+          end
+        end
       end
 
       # Returns discovered, validated skills in precedence order.
@@ -36,7 +65,7 @@ module Kward
             next unless skill
 
             if seen[skill.name]
-              warn "Warning: skipping duplicate Kward skill #{skill.name.inspect}: #{path}"
+              emit_warning "Warning: skipping duplicate Kward skill #{skill.name.inspect}: #{path}"
               next
             end
 
@@ -45,7 +74,7 @@ module Kward
           end
         end
       rescue StandardError => e
-        warn "Warning: skipping Kward skills: #{e.message}"
+        emit_warning "Warning: skipping Kward skills: #{e.message}"
         []
       end
 
@@ -98,17 +127,39 @@ module Kward
 
       def scan_source(source)
         return [] unless Dir.exist?(source.root)
-        if source.scope == :project && !@project_skills_trusted
-          warn "Warning: skipping #{source.label} in #{source.root}: project skills are not trusted"
+        if source.scope == :project && @project_skill_paths.nil? && !@project_skills_trusted
+          emit_warning "Warning: skipping #{source.label} in #{source.root}: project skills are not trusted"
           return []
         end
 
+        paths = discover_source(source)
+        return paths unless source.scope == :project && @project_skill_paths
+
+        paths.select { |path| @project_skill_paths.include?(canonical_path(path)) }
+      end
+
+      def canonical_path(path)
+        File.realpath(path)
+      rescue SystemCallError
+        File.expand_path(path)
+      end
+
+      def discover_source(source)
         Dir.glob(File.join(source.root, "*", "SKILL.md")).sort
       rescue StandardError => e
-        warn "Warning: skipping #{source.label} in #{source.root}: #{e.message}"
+        emit_warning "Warning: skipping #{source.label} in #{source.root}: #{e.message}"
         []
       end
 
+      def skill_digest(path)
+        TrustStore.digest_files(skill_files(path), root: @workspace_root)
+      end
+
+      def skill_files(path)
+        folder = File.dirname(path)
+        [path] + skill_resources(folder).map { |resource| File.join(folder, resource) }
+      end
+
       def skill_content(skill, content)
         lines = [
           %(<skill_content name="#{xml_escape(skill.name)}">),
@@ -151,12 +202,12 @@ module Kward
         return warn_skip(path, "missing description") if description.empty?
         return warn_skip(path, "description exceeds 1024 characters") if description.length > 1024
 
-        warn "Warning: Kward skill #{path}: name does not match parent directory" if name != File.basename(File.dirname(path))
-        warn "Warning: Kward skill #{path}: name exceeds 64 characters" if name.length > 64
-        warn "Warning: Kward skill #{path}: name contains invalid characters" unless valid_name?(name)
+        emit_warning "Warning: Kward skill #{path}: name does not match parent directory" if name != File.basename(File.dirname(path))
+        emit_warning "Warning: Kward skill #{path}: name exceeds 64 characters" if name.length > 64
+        emit_warning "Warning: Kward skill #{path}: name contains invalid characters" unless valid_name?(name)
 
         compatibility = optional_text(frontmatter["compatibility"])
-        warn "Warning: Kward skill #{path}: compatibility exceeds 500 characters" if compatibility && compatibility.length > 500
+        emit_warning "Warning: Kward skill #{path}: compatibility exceeds 500 characters" if compatibility && compatibility.length > 500
 
         @skill_class.new(
           name: name,
@@ -169,7 +220,7 @@ module Kward
           allowed_tools: optional_text(frontmatter["allowed-tools"])
         )
       rescue StandardError => e
-        warn "Warning: skipping Kward skill #{path}: #{e.message}"
+        emit_warning "Warning: skipping Kward skill #{path}: #{e.message}"
         nil
       end
 
@@ -183,9 +234,13 @@ module Kward
       end
 
       def warn_skip(path, reason)
-        warn "Warning: skipping Kward skill #{path}: #{reason}"
+        emit_warning "Warning: skipping Kward skill #{path}: #{reason}"
         nil
       end
+
+      def emit_warning(message)
+        @warning_sink ? @warning_sink.call(message) : warn(message)
+      end
     end
   end
 end

data/lib/kward/skills/trust_coordinator.rb

@@ -0,0 +1,45 @@
+require_relative "trust_store"
+
+# Namespace for Agent Skills discovery and trust management.
+module Kward
+  module Skills
+    # Resolves which discovered project skills need a user decision.
+    class TrustCoordinator
+      def initialize(workspace_root:, trust_store:)
+        @workspace_root = workspace_root
+        @trust_store = trust_store
+      end
+
+      def decision(candidate)
+        @trust_store.decision(
+          workspace_root: @workspace_root,
+          skill_path: candidate.path,
+          digest: candidate.digest
+        )
+      end
+
+      def pending(candidates)
+        candidates.reject { |candidate| decision(candidate) }
+      end
+
+      def allowed_paths(candidates)
+        candidates.filter_map { |candidate| candidate.path if decision(candidate) == "allow" }
+      end
+
+      def remove_workspace!
+        @trust_store.remove_workspace!(workspace_root: @workspace_root)
+      end
+
+      def record!(candidates, decision)
+        candidates.each do |candidate|
+          @trust_store.set_decision!(
+            workspace_root: @workspace_root,
+            skill_path: candidate.path,
+            digest: candidate.digest,
+            decision: decision
+          )
+        end
+      end
+    end
+  end
+end

data/lib/kward/skills/trust_store.rb

@@ -0,0 +1,107 @@
+require "digest"
+require "json"
+require "pathname"
+require_relative "../path_guard"
+require_relative "../private_file"
+
+# Namespace for Agent Skills discovery and trust management.
+module Kward
+  module Skills
+    # Persists workspace-scoped decisions for project skill snapshots.
+    class TrustStore
+      DECISIONS = %w[allow deny].freeze
+
+      attr_reader :path
+
+      def initialize(config_dir:)
+        @path = File.join(File.expand_path(config_dir), "trusted_project_skills.json")
+      end
+
+      def decision(workspace_root:, skill_path:, digest:)
+        record = skill_record(workspace_root: workspace_root, skill_path: skill_path)
+        return unless record
+        return unless record["digest"] == digest.to_s
+
+        decision = record["decision"]
+        decision if DECISIONS.include?(decision)
+      end
+
+      def set_decision!(workspace_root:, skill_path:, digest:, decision:)
+        decision = decision.to_s
+        raise ArgumentError, "invalid project skill trust decision: #{decision}" unless DECISIONS.include?(decision)
+
+        config = read_config
+        workspace = workspace_key(workspace_root)
+        skill = skill_key(workspace_root, skill_path)
+        config["workspaces"] ||= {}
+        config["workspaces"][workspace] ||= { "skills" => {} }
+        config["workspaces"][workspace]["skills"] ||= {}
+        config["workspaces"][workspace]["skills"][skill] = {
+          "digest" => digest.to_s,
+          "decision" => decision
+        }
+        PrivateFile.write_json(path, config)
+      end
+
+      def remove_workspace!(workspace_root:)
+        config = read_config
+        config.fetch("workspaces", {}).delete(workspace_key(workspace_root))
+        PrivateFile.write_json(path, config)
+      end
+
+      def remove_skill!(workspace_root:, skill_path:)
+        config = read_config
+        workspace = config.fetch("workspaces", {})[workspace_key(workspace_root)]
+        workspace&.fetch("skills", {})&.delete(skill_key(workspace_root, skill_path))
+        PrivateFile.write_json(path, config)
+      end
+
+      def self.digest_files(paths, root: nil)
+        root = File.realpath(root) if root
+        digest = Digest::SHA256.new
+        paths.map { |path| File.realpath(path) }.sort.each do |path|
+          raise ArgumentError, "file is outside digest root" if root && !PathGuard.inside?(path, root)
+
+          relative_path = root ? Pathname.new(path).relative_path_from(Pathname.new(root)).to_s : path
+          digest.update(relative_path)
+          digest.update("\0")
+          digest.update(File.binread(path))
+          digest.update("\0")
+        end
+        digest.hexdigest
+      end
+
+      private
+
+      def skill_record(workspace_root:, skill_path:)
+        workspace = read_config.fetch("workspaces", {})[workspace_key(workspace_root)]
+        workspace&.fetch("skills", {})&.[](skill_key(workspace_root, skill_path))
+      end
+
+      def read_config
+        return {} unless File.file?(path)
+
+        config = JSON.parse(File.read(path))
+        config.is_a?(Hash) ? config : {}
+      rescue JSON::ParserError, SystemCallError
+        {}
+      end
+
+      def workspace_key(workspace_root)
+        File.realpath(workspace_root)
+      rescue SystemCallError
+        File.expand_path(workspace_root)
+      end
+
+      def skill_key(workspace_root, skill_path)
+        workspace = workspace_key(workspace_root)
+        skill = File.realpath(skill_path)
+        raise ArgumentError, "project skill is outside workspace" unless PathGuard.inside?(skill, workspace)
+
+        Pathname.new(skill).relative_path_from(Pathname.new(workspace)).to_s
+      rescue SystemCallError
+        raise ArgumentError, "project skill path does not exist"
+      end
+    end
+  end
+end

data/lib/kward/telemetry/logger.rb

@@ -20,13 +20,14 @@ module Kward
     DEFAULT_MAX_BYTES = 10 * 1024 * 1024
 
     # Creates an object for telemetry event logging.
-    def initialize(config_path: ConfigFiles.config_path, log_dir: nil, max_bytes: DEFAULT_MAX_BYTES, clock: Time, monotonic_clock: Process, error_output: $stderr)
+    def initialize(config_path: ConfigFiles.config_path, log_dir: nil, max_bytes: DEFAULT_MAX_BYTES, clock: Time, monotonic_clock: Process, error_output: $stderr, warning_sink: nil)
       @config_path = config_path
       @log_dir = log_dir
       @max_bytes = max_bytes.to_i.positive? ? max_bytes.to_i : DEFAULT_MAX_BYTES
       @clock = clock
       @monotonic_clock = monotonic_clock
       @error_output = error_output
+      @warning_sink = warning_sink
       @mutex = Mutex.new
       @warned = false
     end
@@ -192,7 +193,9 @@ module Kward
       return if @warned
 
       @warned = true
-      @error_output&.puts("Warning: telemetry logging failed: #{error.message}")
+      message = "Warning: telemetry logging failed: #{error.message}"
+      sink = @warning_sink || ConfigFiles.warning_sink
+      sink ? sink.call(message) : @error_output&.puts(message)
     rescue StandardError
       nil
     end

data/lib/kward/version.rb

@@ -1,5 +1,5 @@
 # Namespace for the Kward CLI agent runtime.
 module Kward
   # Current gem version.
-  VERSION = "0.80.0"
+  VERSION = "0.81.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kward
 version: !ruby/object:Gem::Version
-  version: 0.80.0
+  version: 0.81.0
 platform: ruby
 authors:
 - Kai Wood
@@ -191,6 +191,8 @@ files:
 - lib/kward/cli/memory_commands.rb
 - lib/kward/cli/openrouter_commands.rb
 - lib/kward/cli/plugins.rb
+- lib/kward/cli/project_skills.rb
+- lib/kward/cli/project_skills_commands.rb
 - lib/kward/cli/prompt_interface.rb
 - lib/kward/cli/rendering.rb
 - lib/kward/cli/runtime_helpers.rb
@@ -353,6 +355,8 @@ files:
 - lib/kward/session_tree_tool_display.rb
 - lib/kward/skills/capture.rb
 - lib/kward/skills/registry.rb
+- lib/kward/skills/trust_coordinator.rb
+- lib/kward/skills/trust_store.rb
 - lib/kward/starter_pack_installer.rb
 - lib/kward/steering.rb
 - lib/kward/tab_driver.rb