kuroko2 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee6f951f3ef7d0813243f6d35f114c95080a76fd
-  data.tar.gz: ebd90290d5c23208cdac92e33ac2180f27713690
+  metadata.gz: 051e564e4aaa5ec04697344bfe05aec09352b497
+  data.tar.gz: b0564f4086668ce4d6d200fd8d9bca0feb4c2282
 SHA512:
-  metadata.gz: dbb2ee2e3fc299cc4991940f18f0170ee8f1eacdb4a2383f5edc30698debe4340213257970882f6bb348be9688ca1818b0a6d80bc3ef60b88dde537cd00e4300
-  data.tar.gz: a6d0e22eab15a1c8b859511ab919ecebc37a397b4419deded95e1821dc25b34f5fa40f14b14ae514084102c91ceecd8c7fd7137619ff800d7a688d011084ae18
+  metadata.gz: '0446977e4059b15f880a905e0a2fde9949b4c676d791984f29ea2ec15cbd4e855fa9e4e73543b79fbf57b65031f13ca84b4017525de03bbdf7d810d46eb50ea7'
+  data.tar.gz: df867061f7bc67b6486959ef33f2a2555b817b88c53e7029d0997dc4173515b0eb07f698b89171464d214f6e6092ae66b9cbe279b74ae213267374981e7d82d9

data/README.md

@@ -32,6 +32,8 @@ Documentation is available at [docs/index.md](docs/index.md).
 - hogelog
 - gfx
 - kaorimatz
+- makimoto
+- shigemk2
 
 ## License
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/app/models/kuroko2/job_definition.rb

@@ -67,10 +67,12 @@ class Kuroko2::JobDefinition < Kuroko2::ApplicationRecord
   validate :script_syntax
   validate :validate_number_of_admins
   validates :hipchat_additional_text, length: { maximum: 180 }
-  validates :slack_channel, length: { maximum: 21 }, format: {
-    with: /\A#[^\.\s]+\z/, allow_blank: true,
-    message: ' must start with # and must not include any dots or spaces'
-  }
+  validates :slack_channel,
+    length: { maximum: 22, too_long: ' is too long (maximum is 21 characters without `#` symbol at the head)' },
+    format: {
+      with: /\A#[^\.\s]+\z/, allow_blank: true,
+      message: ' must start with # and must not include any dots or spaces'
+    }
   validates :webhook_url, format: { with: /\A#{URI::regexp(%w(http https))}\z/, allow_blank: true }
 
   def proceed_multi_instance?

data/lib/autoload/kuroko2/workflow/node.rb

@@ -2,7 +2,7 @@ module Kuroko2
   module Workflow
     class Node
       PATH_REGEXP = %r(\A(?:/|(?:/\d+-[a-z0-9_]+)+)\z)
-      TASK_REGISTORY = {
+      TASK_REGISTRY = {
         root:                  Task::Sequence,
         noop:                  Task::Noop,
         sequence:              Task::Sequence,
@@ -28,20 +28,20 @@ module Kuroko2
       def self.register(key: nil, klass:)
         key ||= klass.to_s.demodulize.underscore.to_sym
 
-        unless TASK_REGISTORY.has_key?(key)
-          TASK_REGISTORY.store(key, klass)
+        unless TASK_REGISTRY.has_key?(key)
+          TASK_REGISTRY.store(key, klass)
         else
-          Kuroko2.logger.warn("Unable to add '#{klass}' to task registory. '#{TASK_REGISTORY[key]}' is already registered.")
+          Kuroko2.logger.warn("Unable to add '#{klass}' to task registry. '#{TASK_REGISTRY[key]}' is already registered.")
         end
       end
 
       def self.deregister(key)
-        TASK_REGISTORY.delete(key)
+        TASK_REGISTRY.delete(key)
       end
 
       def initialize(type, option = nil)
         @type       = type.to_sym
-        @task_klass = TASK_REGISTORY.fetch(@type, nil)
+        @task_klass = TASK_REGISTRY.fetch(@type, nil)
         @option     = option.try(:strip)
         @parent     = nil
         @children   = []

data/lib/kuroko2/engine.rb

@@ -31,7 +31,7 @@ module Kuroko2
 
       if Kuroko2.config.custom_tasks
         Kuroko2.config.custom_tasks.each do |key, klass|
-          unless Workflow::Node::TASK_REGISTORY.has_key?(key)
+          unless Workflow::Node::TASK_REGISTRY.has_key?(key)
             Workflow::Node.register(
               key: key.to_sym,
               klass: Workflow::Task.const_get(klass, false)

data/lib/kuroko2/version.rb

@@ -1,3 +1,3 @@
 module Kuroko2
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/spec/settings_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 module Kuroko2
   describe 'Check if settings is loaded' do
     it 'loads custom tasks' do
-      expect(Workflow::Node::TASK_REGISTORY).to have_key(:custom_task1)
+      expect(Workflow::Node::TASK_REGISTRY).to have_key(:custom_task1)
       expect(Workflow::ScriptParser.new('custom_task1:').parse).to be_a(Workflow::Node)
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kuroko2
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Naoto Takai
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-09 00:00:00.000000000 Z
+date: 2017-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails