kuroko2 0.2.3 → 0.3.0

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/-Q/-QhKaYdB1JJGAsq6Ih7uQZJD46XkY5Gw0-38DBDVg3Y.cache

@@ -0,0 +1 @@
+"%�>r~�:Q_q����)o\e��v�;b�r�e

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/-h/-h4P8jVHGGfJVwG36J8kBUkHFa3HHGNiJQz0936uaxg.cache

@@ -0,0 +1 @@
+"%^]�bs�:==P�0z)�曤X�u�X�D�d���:

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/24/24laeo7m53bkbst3Gxu4hlJY-EbnK-rQxH-DA4ujzwY.cache

@@ -0,0 +1 @@
+"%a���ۢo@*uX=*1�߂���X�jO����

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/2e/2eEFzw4UUZHJizptl3nT5jVv3IL25_RdYImr3lAVlJ4.cache

@@ -0,0 +1 @@
+"%����+���oZ�fh�v&�=�z�9$�ʏ���

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/4K/4Ky9Fg4qo8d_i8bJF6NOhDpxHuJ5kIX8n0w6C8wdHDU.cache

@@ -0,0 +1,3 @@
+[o:Set:
+@hash}
+I"environment-version:ETTI"environment-paths;TTI"rails-env;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI"kfile-digest:///Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/definition_linker.js;TTF

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Ex/ExgjnrLZM8Hc_uT_sWVaQSNR26tGYCGUsbJDXs9GYO0.cache

@@ -0,0 +1 @@
+"%����+���oZ�fh�v&�=�z�9$�ʏ���

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Iq/IqSpSELRWrOQtOK8F6mGZFPvfafM4yn8gB_VquH9E50.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/application.js?type=application/javascript&pipeline=self&id=b59d847a0b725260cffbce7b628b03606eef7755828321249216aaaadab08916:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/JJ/JJ2dvNSAjiGkZZs_1Dz2TMWDJs4HypQ95b26cHN13I0.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/application.js?type=application/javascript&id=213fbc03156fcffe6e60e900fa4a48b704afbde00b4ce497af761b574d7576f8:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/LJ/LJsVKu6GCC14s20BfJEDXwajK6-xWF72ANX5ONOTX1w.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/application.js?type=application/javascript&pipeline=self&id=b2af374bd742bbeb4d501b91b645cf94cf339e503f86007ca27f2c674b7addf5:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/LL/LLCxb9El_km568UsA8DDOe8Vh3pPKE8IU6ZNww9ie8s.cache

@@ -0,0 +1 @@
+"%L�S�'ƛ#92��Ƴ�2��d*�SUI�q

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Q9/Q9TwXzoqqs8Dm9v25gjZxYIkZW1UKm2X8g2koo5aYhQ.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/definition_linker.js?type=application/javascript&pipeline=self&id=7137ec83c8e33187e38a60817db6ea67fde9f57f171e176d53a269d3abba1772:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/QJ/QJNiKbGgll2T_0mhQus6ZL9a2SM4Xqz7vs2V2KbELPw.cache

@@ -0,0 +1 @@
+"%�Lq��������|��לsR4�fa��Nf

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/Vj/VjICw6h8uQ_278ekFlu1znnPR8Gz1vWF_mRgy0KjZXs.cache

@@ -0,0 +1 @@
+"%�Lq��������|��לsR4�fa��Nf

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/dH/dHFrKzzqtF3aoKs2wAI8z0CNHZoNuytfiHur9Zgz9z0.cache

@@ -0,0 +1 @@
+"%�#2�c����]�ak�hGR�7t�[o��

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/fE/fEFAQG1Uqt2e58VitSFoPsjVjntfPtgL9RKoKHUTS9U.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/javascripts/kuroko2/application.js?type=application/javascript&id=1600da13d3b170e3cc4d4ef7e2224696f8ecec1489c22fb3726ac22fb7a8c4fa:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/fM/FMdA_jabowoG5SAWE93G7Hu8A-5GhfzC9Gjy3EJp1Ts.cache

@@ -0,0 +1 @@
+"%�TȰ�VwD�󿉾����4B)�0���P�

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/hW/hWOkA9ZbQJy1YfEXThjYPOiXRDVRgAeW8TmLm-uQCYk.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/stylesheets/kuroko2/application.scss?type=text/css&id=52bc14dbf6845af55db91bb2f3406df3e99da22b1e84596943aeceb6f896f2ef:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/ou/ouMQatdL-PPhPVPw5o0xm5EBkVeVWLti06EUEVmfOBo.cache

@@ -0,0 +1 @@
+I"
�/Users/eisuke-oishi/work/kuroko2_oss/app/assets/stylesheets/kuroko2/application.scss?type=text/css&pipeline=self&id=13acc59b0e86c99c12d312359c80d5b43801fdcc907877fa0479194c26afdae1:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/rc/rcceqGk009vh5_tK6Y-i1dvbYQwuUtRF888xZcnZrj8.cache

@@ -0,0 +1 @@
+"%����+���oZ�fh�v&�=�z�9$�ʏ���

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/sh/shGRyWpXjqxMTGB3As4Vibs8VGS0bZHHd4s0qabhwXI.cache

@@ -0,0 +1 @@
+"%�Lq��������|��לsR4�fa��Nf

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/sr/SRfo3vCtDVy0qd-OB9dv5a-xIVTHkJZDn8XwY_ymy7g.cache

@@ -0,0 +1 @@
+"%a���ۢo@*uX=*1�߂���X�jO����

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/vV/vV3Loym0NolgPoXFEVPOr5rDgB_Q5kvUA3InuEEvEvQ.cache

@@ -0,0 +1 @@
+"%�#2�c����]�ak�hGR�7t�[o��

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/wm/wm_qI7_LCxbnH6p7BK1Pqcocl-6TcULzTERICGZIdL0.cache

@@ -0,0 +1 @@
+"%L�S�'ƛ#92��Ƴ�2��d*�SUI�q

data/spec/features/dashborad_spec.rb

@@ -66,15 +66,22 @@ RSpec.describe "User shows dashboard", type: :feature do
 
       expect(page).to have_content(common_tag)
 
-      click_on(common_tag)
+      within '#tags' do
+        click_on(common_tag)
+      end
+
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 10)
 
-      click_on("tag_1")
+      within '#tags' do
+        click_on("tag_1")
+      end
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 1)
 
-      click_on("tag_1")
+      within '#tags' do
+        click_on("tag_1")
+      end
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 10)
     end

data/spec/features/users_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe "Users management", type: :feature do
     expect(page).to have_content("##{user.id} #{user.name}")
   end
 
-  it 'creates group users' do
+  it 'creates and edits group users' do
     visit kuroko2.users_path
     fill_in 'Name', with: 'Test Group User'
     fill_in 'Email', with: 'test_group_user@example.com'
@@ -32,6 +32,16 @@ RSpec.describe "Users management", type: :feature do
 
     expect(page).to have_selector('#users tbody tr', count: 1)
     expect(page).to have_content('Test Group User')
+
+    visit kuroko2.users_path(target: 'group')
+    click_on('View Details')
+    click_on('Edit User')
+
+    fill_in 'Name', with: 'Test Group User v2'
+    fill_in 'Email', with: 'test_group_userv2@example.com'
+    click_on('Update')
+
+    expect(page).to have_content('Test Group User v2')
   end
 
   context 'A user has some tagged job_definitions', js: true do
@@ -62,15 +72,21 @@ RSpec.describe "Users management", type: :feature do
 
       expect(page).to have_content(common_tag)
 
-      click_on(common_tag)
+      within '#tags' do
+        click_on(common_tag)
+      end
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 10)
 
-      click_on("tag_1")
+      within '#tags' do
+        click_on("tag_1")
+      end
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 1)
 
-      click_on("tag_1")
+      within '#tags' do
+        click_on("tag_1")
+      end
       wait_for_ajax
       expect(page).to have_selector('#definitions_list table tbody tr', count: 10)
     end

data/spec/models/job_instance_spec.rb

@@ -38,7 +38,7 @@ describe Kuroko2::JobInstance do
     let(:definition) { create(:job_definition) }
     let(:instance) { definition.job_instances.create! }
 
-    subject! { instance.cancel }
+    subject! { instance.cancel(by: 'test') }
 
     it do
       expect(instance).to be_canceled_at

data/spec/models/token_spec.rb

@@ -51,4 +51,42 @@ describe Kuroko2::Token do
 
     end
   end
+
+  describe "#skippable?" do
+    subject! { create(:token, status: status) }
+
+    context 'When token is failure status' do
+      let(:status) { Kuroko2::Token::FAILURE }
+      it { is_expected.to be_skippable }
+    end
+
+    context 'When token is waiting status' do
+      let(:status) { Kuroko2::Token::WAITING }
+      it { is_expected.to be_skippable }
+    end
+
+    context 'When token is working status' do
+      let(:status) { Kuroko2::Token::WORKING }
+      it { is_expected.not_to be_skippable }
+    end
+  end
+
+  describe "#retryable?" do
+    subject! { create(:token, status: status) }
+
+    context 'When token is failure status' do
+      let(:status) { Kuroko2::Token::FAILURE }
+      it { is_expected.to be_retryable }
+    end
+
+    context 'When token is waiting status' do
+      let(:status) { Kuroko2::Token::WAITING }
+      it { is_expected.not_to be_retryable }
+    end
+
+    context 'When token is working status' do
+      let(:status) { Kuroko2::Token::WORKING }
+      it { is_expected.not_to be_retryable }
+    end
+  end
 end

data/spec/workflow/notifier/hipchat_spec.rb

@@ -50,6 +50,7 @@ module Kuroko2::Workflow
 
     describe '#notify_cancellation' do
       before do
+        instance.logs.warn('warn')
         instance.job_definition.notify_cancellation = true
         instance.save!
       end
@@ -103,6 +104,96 @@ module Kuroko2::Workflow
       end
     end
 
+    describe '#notify_retrying' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends retrying mesasge' do
+          expect(hipchat_room_object).to receive(:send) do |_, message, option|
+            expect(message).to include('SUCCESS')
+            expect(option[:color]).to eq('yellow')
+          end
+
+          notifier.notify_retrying
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends retrying mesasge' do
+          expect(hipchat_room_object).not_to receive(:send)
+          notifier.notify_retrying
+        end
+      end
+    end
+
+    describe '#notify_skipping' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends skipping mesasge' do
+          expect(hipchat_room_object).to receive(:send) do |_, message, option|
+            expect(message).to include('SUCCESS')
+            expect(option[:color]).to eq('yellow')
+          end
+
+          notifier.notify_skipping
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends skipping mesasge' do
+          expect(hipchat_room_object).not_to receive(:send)
+          notifier.notify_skipping
+        end
+      end
+    end
+
+    describe '#notify_launch' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends launch mesasge' do
+          expect(hipchat_room_object).to receive(:send) do |_, message, option|
+            expect(message).to include('SUCCESS')
+            expect(option[:color]).to eq('yellow')
+          end
+
+          notifier.notify_launch
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends launch mesasge' do
+          expect(hipchat_room_object).not_to receive(:send)
+          notifier.notify_launch
+        end
+      end
+    end
+
     describe '#notify_long_elapsed_time' do
       it 'sends warning mesasge' do
         expect(hipchat_room_object).to receive(:send) do |_, message, option|

data/spec/workflow/notifier/mail_spec.rb

@@ -75,9 +75,25 @@ module Kuroko2::Workflow
       end
     end
 
-    describe '#notify_working' do
+    describe '#notify_retrying' do
       it 'does not send mail' do
-        expect { notifier.notify_working }.not_to change {
+        expect { notifier.notify_retrying }.not_to change {
+          ActionMailer::Base.deliveries.size
+        }
+      end
+    end
+
+    describe '#notify_skipping' do
+      it 'does not send mail' do
+        expect { notifier.notify_skipping }.not_to change {
+          ActionMailer::Base.deliveries.size
+        }
+      end
+    end
+
+    describe '#notify_launch' do
+      it 'does not send mail' do
+        expect { notifier.notify_launch }.not_to change {
           ActionMailer::Base.deliveries.size
         }
       end

data/spec/workflow/notifier/slack_spec.rb

@@ -45,6 +45,7 @@ module Kuroko2::Workflow
 
     describe '#notify_cancellation' do
       before do
+        instance.logs.warn('warn')
         instance.job_definition.notify_cancellation = true
         instance.save!
       end
@@ -89,6 +90,90 @@ module Kuroko2::Workflow
       end
     end
 
+    describe '#notify_retrying' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends retrying mesasge' do
+          expect(notifier).to receive(:send_to_slack).
+            with(hash_including(channel: slack_channel)).and_call_original
+
+          notifier.notify_retrying
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends retrying mesasge' do
+          expect(notifier).not_to receive(:send_to_slack)
+          notifier.notify_retrying
+        end
+      end
+    end
+
+    describe '#notify_skipping' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends skipping mesasge' do
+          expect(notifier).to receive(:send_to_slack).
+            with(hash_including(channel: slack_channel)).and_call_original
+
+          notifier.notify_skipping
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends skipping mesasge' do
+          expect(notifier).not_to receive(:send_to_slack)
+          notifier.notify_skipping
+        end
+      end
+    end
+
+    describe '#notify_launch' do
+      context 'with notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = true
+          instance.save!
+        end
+
+        it 'sends launch mesasge' do
+          expect(notifier).to receive(:send_to_slack).
+            with(hash_including(channel: slack_channel)).and_call_original
+
+          notifier.notify_launch
+        end
+      end
+
+      context 'without notify_finished' do
+        before do
+          instance.job_definition.hipchat_notify_finished = false
+          instance.save!
+        end
+
+        it 'sends launch mesasge' do
+          expect(notifier).not_to receive(:send_to_slack)
+          notifier.notify_launch
+        end
+      end
+    end
+
     describe '#notify_long_elapsed_time' do
       it 'sends warning mesasge' do
         expect(notifier).to receive(:send_to_slack).