kumi 0.0.24 → 0.0.26

data/docs/UNSAT_DETECTION.md

@@ -0,0 +1,83 @@
+# UNSAT Detection & Constraint Analysis
+
+Kumi includes static analysis to detect **unsatisfiable constraints**—impossible conditions that can never be true given input domains.
+
+## How It Works
+
+### Direct Contradictions
+Kumi detects when the same variable is constrained to multiple different values:
+
+```ruby
+schema do
+  input { integer :x }
+
+  # ✓ Detected as UNSAT: x cannot be both 5 and 10
+  trait :impossible, fn(:and, input.x == 5, input.x == 10)
+end
+```
+
+### Domain Violations
+Kumi checks when constraints violate input domains:
+
+```ruby
+schema do
+  input { integer :age, domain: 0..150 }
+
+  # ✓ Detected as UNSAT: age can never be 200
+  trait :impossible_age, input.age == 200
+end
+```
+
+### Constraint Propagation (Phase 2)
+Kumi propagates constraints through operations to detect derived impossibilities:
+
+```ruby
+schema do
+  input { integer :x, domain: 0..10 }
+
+  value :doubled, fn(:mul, input.x, 2)  # doubled ∈ [0, 20]
+
+  # ✓ Detected as UNSAT: doubled can never be 50
+  trait :impossible_doubled, doubled == 50
+end
+```
+
+**Reverse propagation** derives input constraints from output constraints:
+
+```ruby
+schema do
+  input { integer :x, domain: 0..10 }
+
+  value :result, fn(:add, input.x, 100)  # result ∈ [100, 110]
+
+  # ✓ Detected as UNSAT: result == 50 would require x == -50 (outside domain)
+  trait :impossible_result, result == 50
+end
+```
+
+## Error Messages
+
+Impossible constraints raise `Kumi::Core::Errors::SemanticError`:
+
+```
+conjunction `impossible_doubled` is impossible
+```
+
+This message appears at schema compilation time, catching bugs before execution.
+
+## When UNSAT Detection Runs
+
+UNSAT detection is performed during the **HIR-to-LIR compilation phase**, after:
+- Function IDs are resolved
+- Type information is inferred
+- Dimensional metadata is computed
+
+This ensures detection has access to complete operation semantics.
+
+## Future Enhancements
+
+- **Multi-level propagation**: Chain constraints through multiple operations
+- **Inequality constraints**: Handle `<`, `>`, `<=`, `>=` constraints
+- **Combined constraints**: Detect contradictions across multiple traits
+
+See `spec/integration/unsat_with_propagation_spec.rb` for examples and pending tests.

data/golden/array_element/expected/nast.txt

@@ -1,6 +1,6 @@
 (NAST
   (VALUE v_sum_y
-    (Call :"agg.sum"
+    (Call :sum
     (InputRef [:x, :y, :v])
   )
   )

data/golden/array_element/expected/schema_ruby.rb

@@ -1,5 +1,5 @@
 # Autogenerated by Kumi Codegen
-module Kumi::Compiled::KUMI_1c8ed5675ebbb47c48988ebc1e7a688bdfe46a08c8c7fa3343ae03cb81feb8d2
+module Kumi::Compiled::KUMI_1cd98cf56c50f763cab5055e1275d07ac58aaee708cbd081d7773ac43c8d9d33
   def self.from(input_data = nil)
     instance = Object.new
     instance.extend(self)

data/golden/array_index/expected/nast.txt

@@ -1,12 +1,12 @@
 (NAST
   (VALUE W
-    (Call :"core.array_size"
+    (Call :array_size
     (InputRef [:x, :y])
   )
   )
   (VALUE box
-    (Call :"core.add"
-    (Call :"core.mul"
+    (Call :add
+    (Call :multiply
       #<struct Kumi::Core::NAST::IndexRef id=83, loc=nil, meta={}>
       (Ref W)
     )
@@ -14,10 +14,10 @@
   )
   )
   (VALUE col_major
-    (Call :"core.add"
-    (Call :"core.mul"
+    (Call :add
+    (Call :multiply
       #<struct Kumi::Core::NAST::IndexRef id=91, loc=nil, meta={}>
-      (Call :"core.array_size"
+      (Call :array_size
         (InputRef [:x])
       )
     )
@@ -25,7 +25,7 @@
   )
   )
   (VALUE sum_ij
-    (Call :"core.add"
+    (Call :add
     #<struct Kumi::Core::NAST::IndexRef id=100, loc=nil, meta={}>
     #<struct Kumi::Core::NAST::IndexRef id=102, loc=nil, meta={}>
   )

data/golden/array_index/expected/schema_ruby.rb

@@ -1,5 +1,5 @@
 # Autogenerated by Kumi Codegen
-module Kumi::Compiled::KUMI_045c4888923226ccaa83f46e8cbb54fb076042110dd637c5df35f0717b18886d
+module Kumi::Compiled::KUMI_f0ed06608ce6a4d5050abd38d6642055bd22c10f7ed1ba5c5b32a1c61c78736d
   def self.from(input_data = nil)
     instance = Object.new
     instance.extend(self)

data/golden/array_operations/expected/nast.txt

@@ -1,12 +1,12 @@
 (NAST
   (VALUE subtotals
-    (Call :"core.mul"
+    (Call :multiply
     (InputRef [:items, :item, :price])
     (InputRef [:items, :item, :quantity])
   )
   )
   (VALUE discounted_price
-    (Call :"core.mul"
+    (Call :multiply
     (InputRef [:items, :item, :price])
     (Const 0.9)
   )

data/golden/array_operations/expected/schema_ruby.rb

@@ -1,5 +1,5 @@
 # Autogenerated by Kumi Codegen
-module Kumi::Compiled::KUMI_ad5e88ef777b7ff03fc054fb2532e158fd95f50237e7a7431485f2433e7b8998
+module Kumi::Compiled::KUMI_98624b0772f11031b22df384c3c7f33db6dd17485e3f9cf2f69c17ad1d79a9d9
   def self.from(input_data = nil)
     instance = Object.new
     instance.extend(self)

data/golden/array_operations/expected/snast.txt

@@ -11,19 +11,19 @@
       (Const 0.9) :: [] -> float
     ) :: [items] -> float
   ) :: [items] -> float
-  (TRAIT is_valid_quantity
+  (VALUE is_valid_quantity
     (Call :core.gt
       (InputRef items.item.quantity key_chain=[]) :: [items] -> integer
       (Const 0) :: [] -> integer
     ) :: [items] -> boolean
   ) :: [items] -> boolean
-  (TRAIT expensive_items
+  (VALUE expensive_items
     (Call :core.gt
       (InputRef items.item.price key_chain=[]) :: [items] -> float
       (Const 100.0) :: [] -> float
     ) :: [items] -> boolean
   ) :: [items] -> boolean
-  (TRAIT electronics
+  (VALUE electronics
     (Call :core.eq
       (InputRef items.item.category key_chain=[]) :: [items] -> string
       (Const "electronics") :: [] -> string

data/golden/cascade_logic/expected/lir_02_inlined.txt

@@ -20,17 +20,17 @@
     %t24 = call core.gt(%t22, %t23) :: boolean
     %t9 = call core.and(%t21, %t24) :: boolean
     %t10 = const "both positive" :: string
-    %t22 = load_input "x" :: integer
-    %t23 = const 0 :: integer
-    %t24 = call core.gt(%t22, %t23) :: boolean
+    %t25 = load_input "x" :: integer
+    %t26 = const 0 :: integer
+    %t27 = call core.gt(%t25, %t26) :: boolean
     %t12 = const "x positive" :: string
-    %t19 = load_input "y" :: integer
-    %t20 = const 0 :: integer
-    %t21 = call core.gt(%t19, %t20) :: boolean
+    %t28 = load_input "y" :: integer
+    %t29 = const 0 :: integer
+    %t30 = call core.gt(%t28, %t29) :: boolean
     %t14 = const "y positive" :: string
     %t15 = const "neither positive" :: string
-    %t16 = select %t21, %t14, %t15 :: string
-    %t17 = select %t24, %t12, %t16 :: string
+    %t16 = select %t30, %t14, %t15 :: string
+    %t17 = select %t27, %t12, %t16 :: string
     %t18 = select %t9, %t10, %t17 :: string
     yield %t18
   )

data/golden/cascade_logic/expected/schema_ruby.rb

@@ -1,5 +1,5 @@
 # Autogenerated by Kumi Codegen
-module Kumi::Compiled::KUMI_c60fd677ad0c8a7b4023f22e28bd9ff4c05455c34a57687b7e6d186c59eb360c
+module Kumi::Compiled::KUMI_a359b484890e040a5fdd419b92800fddad006edffc49f277f28525eef4e3d9bd
   def self.from(input_data = nil)
     instance = Object.new
     instance.extend(self)

data/golden/cascade_logic/expected/snast.txt

@@ -1,11 +1,11 @@
 (SNAST
-  (TRAIT y_positive
+  (VALUE y_positive
     (Call :core.gt
       (InputRef y key_chain=[]) :: [] -> integer
       (Const 0) :: [] -> integer
     ) :: [] -> boolean
   ) :: [] -> boolean
-  (TRAIT x_positive
+  (VALUE x_positive
     (Call :core.gt
       (InputRef x key_chain=[]) :: [] -> integer
       (Const 0) :: [] -> integer

data/golden/chained_fusion/expected/lir_02_inlined.txt

@@ -68,46 +68,46 @@
       %t56 = load_input "departments" :: array
       %acc58 = decl_acc :: integer
       %t59 = load_field departments_el_48["employees"] :: any
-      loop employees id=L10 in %t59 as el=%employees_el_6, idx=%employees_i_7
-        %t60 = load_field employees_el_6["salary"] :: integer
-        %acc58 = acc_add agg.sum(%acc58, %t60) :: integer
+      loop employees id=L10 in %t59 as el=%t60, idx=%t61
+        %t62 = load_field t60["salary"] :: integer
+        %acc58 = acc_add agg.sum(%acc58, %t62) :: integer
       end_loop
-      %t61 = acc_load %acc58 :: integer
-      %t62 = load_input "departments" :: array
-      %acc64 = decl_acc :: integer
-      %t65 = load_field departments_el_48["employees"] :: any
-      loop employees id=L11 in %t65 as el=%employees_el_15, idx=%employees_i_16
-        %t66 = load_field employees_el_15["role"] :: string
-        %t67 = const "manager" :: string
-        %t68 = call core.eq(%t66, %t67) :: boolean
-        %t69 = const 1 :: integer
-        %t70 = const 0 :: integer
-        %t71 = select %t68, %t69, %t70 :: integer
-        %acc64 = acc_add agg.sum(%acc64, %t71) :: integer
+      %t63 = acc_load %acc58 :: integer
+      %t64 = load_input "departments" :: array
+      %acc66 = decl_acc :: integer
+      %t67 = load_field departments_el_48["employees"] :: any
+      loop employees id=L11 in %t67 as el=%t68, idx=%t69
+        %t70 = load_field t68["role"] :: string
+        %t71 = const "manager" :: string
+        %t72 = call core.eq(%t70, %t71) :: boolean
+        %t73 = const 1 :: integer
+        %t74 = const 0 :: integer
+        %t75 = select %t72, %t73, %t74 :: integer
+        %acc66 = acc_add agg.sum(%acc66, %t75) :: integer
       end_loop
-      %t72 = acc_load %acc64 :: integer
-      %t73 = load_input "departments" :: array
-      %acc75 = decl_acc :: integer
-      %t76 = load_field departments_el_48["employees"] :: any
-      loop employees id=L12 in %t76 as el=%employees_el_29, idx=%employees_i_30
-        %t77 = load_field employees_el_29["role"] :: string
-        %t78 = const "senior" :: string
-        %t79 = call core.eq(%t77, %t78) :: boolean
-        %t80 = const 1 :: integer
-        %t81 = const 0 :: integer
-        %t82 = select %t79, %t80, %t81 :: integer
-        %acc75 = acc_add agg.sum(%acc75, %t82) :: integer
+      %t76 = acc_load %acc66 :: integer
+      %t77 = load_input "departments" :: array
+      %acc79 = decl_acc :: integer
+      %t80 = load_field departments_el_48["employees"] :: any
+      loop employees id=L12 in %t80 as el=%t81, idx=%t82
+        %t83 = load_field t81["role"] :: string
+        %t84 = const "senior" :: string
+        %t85 = call core.eq(%t83, %t84) :: boolean
+        %t86 = const 1 :: integer
+        %t87 = const 0 :: integer
+        %t88 = select %t85, %t86, %t87 :: integer
+        %acc79 = acc_add agg.sum(%acc79, %t88) :: integer
       end_loop
-      %t83 = acc_load %acc75 :: integer
-      %t84 = load_input "departments" :: array
-      %acc86 = decl_acc :: integer
-      %t87 = load_field departments_el_48["employees"] :: any
-      loop employees id=L13 in %t87 as el=%employees_el_43, idx=%employees_i_44
-        %t88 = load_field employees_el_43["salary"] :: integer
-        %acc86 = acc_add agg.max(%acc86, %t88) :: integer
+      %t89 = acc_load %acc79 :: integer
+      %t90 = load_input "departments" :: array
+      %acc92 = decl_acc :: integer
+      %t93 = load_field departments_el_48["employees"] :: any
+      loop employees id=L13 in %t93 as el=%t94, idx=%t95
+        %t96 = load_field t94["salary"] :: integer
+        %acc92 = acc_add agg.max(%acc92, %t96) :: integer
       end_loop
-      %t89 = acc_load %acc86 :: integer
-      %t55 = make_object{name: %t50, total_payroll: %t61, manager_count: %t72, senior_count: %t83, top_salary: %t89} :: object
+      %t97 = acc_load %acc92 :: integer
+      %t55 = make_object{name: %t50, total_payroll: %t63, manager_count: %t76, senior_count: %t89, top_salary: %t97} :: object
       yield %t55
     end_loop
   )

data/golden/chained_fusion/expected/lir_03_cse.txt

@@ -67,30 +67,30 @@
       %t50 = load_field departments_el_48["name"] :: string
       %acc58 = decl_acc :: integer
       %t59 = load_field departments_el_48["employees"] :: any
-      %acc64 = decl_acc :: integer
-      %acc75 = decl_acc :: integer
-      %acc86 = decl_acc :: integer
-      loop employees id=L10 in %t59 as el=%employees_el_6, idx=%employees_i_7
-        %t60 = load_field employees_el_6["salary"] :: integer
-        %acc58 = acc_add agg.sum(%acc58, %t60) :: integer
-        %t66 = load_field employees_el_6["role"] :: string
-        %t67 = const "manager" :: string
-        %t68 = call core.eq(%t66, %t67) :: boolean
-        %t69 = const 1 :: integer
-        %t70 = const 0 :: integer
-        %t71 = select %t68, %t69, %t70 :: integer
-        %acc64 = acc_add agg.sum(%acc64, %t71) :: integer
-        %acc86 = acc_add agg.max(%acc86, %t60) :: integer
-        %t78 = const "senior" :: string
-        %t79 = call core.eq(%t66, %t78) :: boolean
-        %t82 = select %t79, %t69, %t70 :: integer
-        %acc75 = acc_add agg.sum(%acc75, %t82) :: integer
+      %acc66 = decl_acc :: integer
+      %acc79 = decl_acc :: integer
+      %acc92 = decl_acc :: integer
+      loop employees id=L10 in %t59 as el=%t60, idx=%t61
+        %t62 = load_field t60["salary"] :: integer
+        %acc58 = acc_add agg.sum(%acc58, %t62) :: integer
+        %t70 = load_field t60["role"] :: string
+        %t71 = const "manager" :: string
+        %t72 = call core.eq(%t70, %t71) :: boolean
+        %t73 = const 1 :: integer
+        %t74 = const 0 :: integer
+        %t75 = select %t72, %t73, %t74 :: integer
+        %acc66 = acc_add agg.sum(%acc66, %t75) :: integer
+        %acc92 = acc_add agg.max(%acc92, %t62) :: integer
+        %t84 = const "senior" :: string
+        %t85 = call core.eq(%t70, %t84) :: boolean
+        %t88 = select %t85, %t73, %t74 :: integer
+        %acc79 = acc_add agg.sum(%acc79, %t88) :: integer
       end_loop
-      %t61 = acc_load %acc58 :: integer
-      %t72 = acc_load %acc64 :: integer
-      %t89 = acc_load %acc86 :: integer
-      %t83 = acc_load %acc75 :: integer
-      %t55 = make_object{name: %t50, total_payroll: %t61, manager_count: %t72, senior_count: %t83, top_salary: %t89} :: object
+      %t63 = acc_load %acc58 :: integer
+      %t76 = acc_load %acc66 :: integer
+      %t97 = acc_load %acc92 :: integer
+      %t89 = acc_load %acc79 :: integer
+      %t55 = make_object{name: %t50, total_payroll: %t63, manager_count: %t76, senior_count: %t89, top_salary: %t97} :: object
       yield %t55
     end_loop
   )

data/golden/chained_fusion/expected/lir_04_1_loop_fusion.txt

@@ -67,32 +67,32 @@
       %t50 = load_field departments_el_48["name"] :: string
       %acc58 = decl_acc :: integer
       %t59 = load_field departments_el_48["employees"] :: any
-      %acc64 = decl_acc :: integer
-      %acc75 = decl_acc :: integer
-      %acc86 = decl_acc :: integer
-      loop employees id=L10 in %t59 as el=%employees_el_6, idx=%employees_i_7
-        %t60 = load_field employees_el_6["salary"] :: integer
-        %acc58 = acc_add agg.sum(%acc58, %t60) :: integer
-        %t66 = load_field employees_el_6["role"] :: string
-        %t67 = const "manager" :: string
-        %t68 = call core.eq(%t66, %t67) :: boolean
-        %t69 = const 1 :: integer
-        %t70 = const 0 :: integer
-        %t71 = select %t68, %t69, %t70 :: integer
-        %acc64 = acc_add agg.sum(%acc64, %t71) :: integer
-        %t88 = load_field employees_el_6["salary"] :: integer
-        %acc86 = acc_add agg.max(%acc86, %t88) :: integer
-        %t77 = load_field employees_el_6["role"] :: string
-        %t78 = const "senior" :: string
-        %t79 = call core.eq(%t77, %t78) :: boolean
-        %t82 = select %t79, %t69, %t70 :: integer
-        %acc75 = acc_add agg.sum(%acc75, %t82) :: integer
+      %acc66 = decl_acc :: integer
+      %acc79 = decl_acc :: integer
+      %acc92 = decl_acc :: integer
+      loop employees id=L10 in %t59 as el=%t60, idx=%t61
+        %t62 = load_field t60["salary"] :: integer
+        %acc58 = acc_add agg.sum(%acc58, %t62) :: integer
+        %t70 = load_field t60["role"] :: string
+        %t71 = const "manager" :: string
+        %t72 = call core.eq(%t70, %t71) :: boolean
+        %t73 = const 1 :: integer
+        %t74 = const 0 :: integer
+        %t75 = select %t72, %t73, %t74 :: integer
+        %acc66 = acc_add agg.sum(%acc66, %t75) :: integer
+        %t96 = load_field t60["salary"] :: integer
+        %acc92 = acc_add agg.max(%acc92, %t96) :: integer
+        %t83 = load_field t60["role"] :: string
+        %t84 = const "senior" :: string
+        %t85 = call core.eq(%t83, %t84) :: boolean
+        %t88 = select %t85, %t73, %t74 :: integer
+        %acc79 = acc_add agg.sum(%acc79, %t88) :: integer
       end_loop
-      %t61 = acc_load %acc58 :: integer
-      %t72 = acc_load %acc64 :: integer
-      %t89 = acc_load %acc86 :: integer
-      %t83 = acc_load %acc75 :: integer
-      %t55 = make_object{name: %t50, total_payroll: %t61, manager_count: %t72, senior_count: %t83, top_salary: %t89} :: object
+      %t63 = acc_load %acc58 :: integer
+      %t76 = acc_load %acc66 :: integer
+      %t97 = acc_load %acc92 :: integer
+      %t89 = acc_load %acc79 :: integer
+      %t55 = make_object{name: %t50, total_payroll: %t63, manager_count: %t76, senior_count: %t89, top_salary: %t97} :: object
       yield %t55
     end_loop
   )

data/golden/chained_fusion/expected/lir_04_loop_invcm.txt

@@ -63,34 +63,34 @@
   )
   (Declaration department_summary
     %t47 = load_input "departments" :: array
-    %t67 = const "manager" :: string
-    %t69 = const 1 :: integer
-    %t70 = const 0 :: integer
-    %t78 = const "senior" :: string
+    %t71 = const "manager" :: string
+    %t73 = const 1 :: integer
+    %t74 = const 0 :: integer
+    %t84 = const "senior" :: string
     loop departments id=L9 in %t47 as el=%departments_el_48, idx=%departments_i_49
       %t50 = load_field departments_el_48["name"] :: string
       %acc58 = decl_acc :: integer
       %t59 = load_field departments_el_48["employees"] :: any
-      %acc64 = decl_acc :: integer
-      %acc75 = decl_acc :: integer
-      %acc86 = decl_acc :: integer
-      loop employees id=L10 in %t59 as el=%employees_el_6, idx=%employees_i_7
-        %t60 = load_field employees_el_6["salary"] :: integer
-        %acc58 = acc_add agg.sum(%acc58, %t60) :: integer
-        %t66 = load_field employees_el_6["role"] :: string
-        %t68 = call core.eq(%t66, %t67) :: boolean
-        %t71 = select %t68, %t69, %t70 :: integer
-        %acc64 = acc_add agg.sum(%acc64, %t71) :: integer
-        %acc86 = acc_add agg.max(%acc86, %t60) :: integer
-        %t79 = call core.eq(%t66, %t78) :: boolean
-        %t82 = select %t79, %t69, %t70 :: integer
-        %acc75 = acc_add agg.sum(%acc75, %t82) :: integer
+      %acc66 = decl_acc :: integer
+      %acc79 = decl_acc :: integer
+      %acc92 = decl_acc :: integer
+      loop employees id=L10 in %t59 as el=%t60, idx=%t61
+        %t62 = load_field t60["salary"] :: integer
+        %acc58 = acc_add agg.sum(%acc58, %t62) :: integer
+        %t70 = load_field t60["role"] :: string
+        %t72 = call core.eq(%t70, %t71) :: boolean
+        %t75 = select %t72, %t73, %t74 :: integer
+        %acc66 = acc_add agg.sum(%acc66, %t75) :: integer
+        %acc92 = acc_add agg.max(%acc92, %t62) :: integer
+        %t85 = call core.eq(%t70, %t84) :: boolean
+        %t88 = select %t85, %t73, %t74 :: integer
+        %acc79 = acc_add agg.sum(%acc79, %t88) :: integer
       end_loop
-      %t61 = acc_load %acc58 :: integer
-      %t72 = acc_load %acc64 :: integer
-      %t89 = acc_load %acc86 :: integer
-      %t83 = acc_load %acc75 :: integer
-      %t55 = make_object{name: %t50, total_payroll: %t61, manager_count: %t72, senior_count: %t83, top_salary: %t89} :: object
+      %t63 = acc_load %acc58 :: integer
+      %t76 = acc_load %acc66 :: integer
+      %t97 = acc_load %acc92 :: integer
+      %t89 = acc_load %acc79 :: integer
+      %t55 = make_object{name: %t50, total_payroll: %t63, manager_count: %t76, senior_count: %t89, top_salary: %t97} :: object
       yield %t55
     end_loop
   )

data/golden/chained_fusion/expected/lir_06_const_prop.txt

@@ -63,34 +63,34 @@
   )
   (Declaration department_summary
     %t47 = load_input "departments" :: array
-    %t67 = const "manager" :: string
-    %t69 = const 1 :: integer
-    %t70 = const 0 :: integer
-    %t78 = const "senior" :: string
+    %t71 = const "manager" :: string
+    %t73 = const 1 :: integer
+    %t74 = const 0 :: integer
+    %t84 = const "senior" :: string
     loop departments id=L9 in %t47 as el=%departments_el_48, idx=%departments_i_49
       %t50 = load_field departments_el_48["name"] :: string
       %acc58 = decl_acc :: integer
       %t59 = load_field departments_el_48["employees"] :: any
-      %acc64 = decl_acc :: integer
-      %acc75 = decl_acc :: integer
-      %acc86 = decl_acc :: integer
-      loop employees id=L10 in %t59 as el=%employees_el_6, idx=%employees_i_7
-        %t60 = load_field employees_el_6["salary"] :: integer
-        %acc58 = acc_add agg.sum(%acc58, %t60) :: integer
-        %t66 = load_field employees_el_6["role"] :: string
-        %t68 = call core.eq(%t66, %t67) :: boolean
-        %t71 = select %t68, %t69, %t70 :: integer
-        %acc64 = acc_add agg.sum(%acc64, %t71) :: integer
-        %acc86 = acc_add agg.max(%acc86, %t60) :: integer
-        %t79 = call core.eq(%t66, %t78) :: boolean
-        %t82 = select %t79, %t69, %t70 :: integer
-        %acc75 = acc_add agg.sum(%acc75, %t82) :: integer
+      %acc66 = decl_acc :: integer
+      %acc79 = decl_acc :: integer
+      %acc92 = decl_acc :: integer
+      loop employees id=L10 in %t59 as el=%t60, idx=%t61
+        %t62 = load_field t60["salary"] :: integer
+        %acc58 = acc_add agg.sum(%acc58, %t62) :: integer
+        %t70 = load_field t60["role"] :: string
+        %t72 = call core.eq(%t70, %t71) :: boolean
+        %t75 = select %t72, %t73, %t74 :: integer
+        %acc66 = acc_add agg.sum(%acc66, %t75) :: integer
+        %acc92 = acc_add agg.max(%acc92, %t62) :: integer
+        %t85 = call core.eq(%t70, %t84) :: boolean
+        %t88 = select %t85, %t73, %t74 :: integer
+        %acc79 = acc_add agg.sum(%acc79, %t88) :: integer
       end_loop
-      %t61 = acc_load %acc58 :: integer
-      %t72 = acc_load %acc64 :: integer
-      %t89 = acc_load %acc86 :: integer
-      %t83 = acc_load %acc75 :: integer
-      %t55 = make_object{name: %t50, total_payroll: %t61, manager_count: %t72, senior_count: %t83, top_salary: %t89} :: object
+      %t63 = acc_load %acc58 :: integer
+      %t76 = acc_load %acc66 :: integer
+      %t97 = acc_load %acc92 :: integer
+      %t89 = acc_load %acc79 :: integer
+      %t55 = make_object{name: %t50, total_payroll: %t63, manager_count: %t76, senior_count: %t89, top_salary: %t97} :: object
       yield %t55
     end_loop
   )

data/golden/chained_fusion/expected/nast.txt

@@ -1,6 +1,6 @@
 (NAST
   (VALUE total_payroll
-    (Call :"agg.sum"
+    (Call :sum
     (InputRef [:departments, :dept, :employees, :emp, :salary])
   )
   )
@@ -29,7 +29,7 @@
   )
   )
   (VALUE max_salary
-    (Call :"agg.max"
+    (Call :max
     (InputRef [:departments, :dept, :employees, :emp, :salary])
   )
   )

data/golden/chained_fusion/expected/schema_javascript.mjs

@@ -75,39 +75,39 @@ export function _max_salary(input) {
 export function _department_summary(input) {
   let out = [];
   let t47 = input["departments"];
-  const t67 = "manager";
-  const t69 = 1;
-  const t70 = 0;
-  const t78 = "senior";
+  const t71 = "manager";
+  const t73 = 1;
+  const t74 = 0;
+  const t84 = "senior";
   t47.forEach((departments_el_48, departments_i_49) => {
     let t50 = departments_el_48["name"];
     let acc58 = 0;
     let t59 = departments_el_48["employees"];
-    let acc64 = 0;
-    let acc75 = 0;
-    let acc86 = null;
-    t59.forEach((employees_el_6, employees_i_7) => {
-      let t60 = employees_el_6["salary"];
-      acc58 += t60;
-      let t66 = employees_el_6["role"];
-      let t68 = t66 == t67;
-      let t71 = t68 ? t69 : t70;
-      acc64 += t71;
-      if (acc86 === null || acc86 === undefined) {
-        acc86 = t60;
+    let acc66 = 0;
+    let acc79 = 0;
+    let acc92 = null;
+    t59.forEach((t60, t61) => {
+      let t62 = t60["salary"];
+      acc58 += t62;
+      let t70 = t60["role"];
+      let t72 = t70 == t71;
+      let t75 = t72 ? t73 : t74;
+      acc66 += t75;
+      if (acc92 === null || acc92 === undefined) {
+        acc92 = t62;
       } else {
-        acc86 = (acc86 === null || t60 > acc86) ? t60 : acc86;
+        acc92 = (acc92 === null || t62 > acc92) ? t62 : acc92;
       }
-      let t79 = t66 == t78;
-      let t82 = t79 ? t69 : t70;
-      acc75 += t82;
+      let t85 = t70 == t84;
+      let t88 = t85 ? t73 : t74;
+      acc79 += t88;
     });
     let t55 = {
       "name": t50,
       "total_payroll": acc58,
-      "manager_count": acc64,
-      "senior_count": acc75,
-      "top_salary": acc86
+      "manager_count": acc66,
+      "senior_count": acc79,
+      "top_salary": acc92
     };
     out.push(t55);
   });