kumade 0.4.0 → 0.5.0

data/spec/kumade/packager_spec.rb

@@ -1,318 +1,109 @@
 require 'spec_helper'
 
-require 'jammit'
+describe Kumade::Packager, ".available_packager", :with_mock_outputter do
+  let(:packager_1) { "1st packager" }
+  let(:packager_2) { "2nd packager" }
 
-shared_context "with a fake Git" do
-  let(:git) { stub() }
-  subject   { Kumade::Packager.new(git) }
-end
-
-describe Kumade::Packager, "#run" do
-  include_context "with a fake Git"
-
-  before do
-    subject.stubs(:package_with_jammit)
+  it "returns the first available packager" do
+    Kumade::PackagerList.stubs(:new => [packager_1, packager_2])
+    Kumade::Packager.available_packager.should == packager_1
   end
 
-  context "with Jammit installed" do
-    it "calls package_with_jammit" do
-      subject.run
-
-      subject.should have_received(:package_with_jammit)
-    end
-  end
-
-  context "with Jammit not installed" do
-    before { subject.stubs(:jammit_installed? => false) }
-
-    it "does not call package_with_jammit" do
-      subject.run
-
-      subject.should_not have_received(:package_with_jammit)
-    end
-  end
-
-  context "with More installed" do
-    before do
-      subject.stubs(:jammit_installed? => false)
-      subject.stubs(:more_installed? => true)
-      subject.stubs(:package_with_more)
-    end
-
-    it "calls package_with_more" do
-      subject.run
-
-      subject.should have_received(:package_with_more)
-    end
-  end
-
-  context "with More not installed" do
-    before do
-      subject.stubs(:jammit_installed? => false)
-      subject.stubs(:more_installed? => false)
-    end
-
-    it "does not call package_with_more" do
-      subject.run
-
-      subject.should_not have_received(:package_with_more)
-    end
-  end
-
-  context "with custom rake task installed" do
-    before do
-      subject.stubs(:jammit_installed?  => false,
-                    :more_installed?    => false,
-                    :invoke_custom_task => nil,
-                    :custom_task?       => true)
-    end
-
-    it "invokes custom task" do
-      subject.run
-
-      subject.should have_received(:invoke_custom_task)
-    end
-  end
-
-  context "with custom rake task not installed" do
-    before do
-      subject.stubs(:jammit_installed?  => false,
-                    :more_installed?    => false,
-                    :invoke_custom_task => nil,
-                    :custom_task?       => false)
-    end
-
-    it "does not invoke custom task" do
-      subject.run
-
-      subject.should_not have_received(:invoke_custom_task)
-    end
+  it "returns nil if no packagers are availabke" do
+    Kumade::PackagerList.stubs(:new => [])
+    Kumade::Packager.available_packager.should be_nil
   end
 end
 
-describe Kumade::Packager, "#invoke_custom_task" do
-  include_context "with a fake Git"
-
-  let(:task) { stub('kumade:before_asset_compilation task', :invoke => nil) }
+describe Kumade::Packager, "#run", :with_mock_outputter do
+  let(:git)              { stub("git", :dirty? => true, :add_and_commit_all_assets_in => true) }
+  let(:packager)         { stub("packager", :name => "MyPackager", :package => true, :assets_path => 'fake_assets_path') }
+  let(:rake_task_runner) { stub("RakeTaskRunner", :invoke => true) }
 
   before do
-    subject.stubs(:say)
-    Rake::Task.stubs(:[] => task)
+    Kumade::RakeTaskRunner.stubs(:new => rake_task_runner)
   end
 
-  it "calls deploy task" do
-    Rake::Task.expects(:[]).with("kumade:before_asset_compilation").returns(task)
-
-    subject.invoke_custom_task
+  subject { Kumade::Packager.new(git, packager) }
 
-    task.should have_received(:invoke)
+  it "precompiles assets" do
+    subject.run
+    Kumade::RakeTaskRunner.should have_received(:new).with("kumade:before_asset_compilation")
+    rake_task_runner.should have_received(:invoke)
   end
-end
 
-describe Kumade::Packager, "#custom_task?" do
-  include_context "with a fake Git"
+  context "when packaging with a packager" do
+    context "when pretending" do
+      before do
+        Kumade.configuration.pretending = true
+      end
 
-  before do
-    Rake::Task.clear
-  end
+      it "prints a success message" do
+        subject.run
+        Kumade.configuration.outputter.should have_received(:success).with("Packaged with MyPackager")
+      end
 
-  it "returns true if it task found" do
-    namespace :kumade do
-      task :before_asset_compilation do
+      it "does not package" do
+        subject.run
+        packager.should have_received(:package).never
       end
     end
 
-    subject.custom_task?.should be_true
-  end
-
-  it "returns false if task not found" do
-    subject.custom_task?.should be_false
-  end
-end
-
-describe Kumade::Packager, "#package_with_jammit" do
-  include_context "with a fake Git"
-
-  before do
-    subject.stubs(:git_add_and_commit_all_assets_in)
-    subject.stubs(:success)
-    subject.stubs(:error)
-    Jammit.stubs(:package!)
-  end
-
-  it "calls Jammit.package!" do
-    subject.package_with_jammit
-
-    Jammit.should have_received(:package!).once
-  end
-
-  context "with updated assets" do
-    before { subject.git.stubs(:dirty? => true) }
-
-    it "prints the correct message" do
-      subject.package_with_jammit
+    context "when not pretending" do
+      before do
+        Kumade.configuration.pretending = false
+      end
 
-      subject.should have_received(:success).with("Packaged assets with Jammit")
-    end
+      it "prints a success message" do
+        subject.run
+        Kumade.configuration.outputter.should have_received(:success).with("Packaged with MyPackager")
+      end
 
-    it "calls git_add_and_commit_all_assets_in" do
-      subject.stubs(:jammit_assets_path => 'jammit-assets')
-      subject.expects(:git_add_and_commit_all_assets_in).
-        with('jammit-assets').
-        returns(true)
+      it "packages" do
+        subject.run
+        packager.should have_received(:package).once
+      end
 
-      subject.package_with_jammit
+      it "prints an error if an exception is raised" do
+        packager.stubs(:package).raises(RuntimeError.new("my specific error"))
+        subject.run
+        Kumade.configuration.outputter.should have_received(:error).with("Error: RuntimeError: my specific error")
+      end
     end
   end
 
-  it "prints an error if packaging failed" do
-    Jammit.expects(:package!).raises(Jammit::MissingConfiguration.new("random Jammit error"))
-
-    subject.package_with_jammit
-
-    subject.should have_received(:error).with("Error: Jammit::MissingConfiguration: random Jammit error")
-  end
-end
-
-describe Kumade::Packager, "#package_with_more" do
-  include_context "with a fake Git"
-
-  before do
-    subject.stubs(:git_add_and_commit_all_assets_in => true,
-                 :more_assets_path                 => 'assets')
-    subject.stubs(:say)
-  end
-
-  it "calls the more:generate task" do
-    git.expects(:dirty?).returns(true)
-    subject.expects(:run).with("bundle exec rake more:generate")
-    subject.package_with_more
-  end
-
-  context "with changed assets" do
+  context "when packaging and the repository becomes dirty" do
     before do
+      Kumade.configuration.pretending = false
       git.stubs(:dirty? => true)
     end
 
-    it "prints a success message" do
-      subject.stubs(:run).with("bundle exec rake more:generate")
-      subject.expects(:success).with("Packaged assets with More")
-
-      subject.package_with_more
-    end
-
-    it "calls git_add_and_commit_all_assets_in if assets were added" do
-      subject.stubs(:more_assets_path => 'blerg')
-      subject.stubs(:run).with("bundle exec rake more:generate")
-      subject.expects(:git_add_and_commit_all_assets_in).
-        with('blerg').
-        returns(true)
-
-      subject.package_with_more
-    end
-  end
-
-  context "with no changed assets" do
-    it "prints no message" do
-      subject.stubs(:run).with("bundle exec rake more:generate")
-      subject.stubs(:git => mock(:dirty? => false))
-      subject.expects(:say).never
-
-      subject.package_with_more
-    end
-
-    it "does not call git_add_and_commit_all_more_assets" do
-      subject.stubs(:run).with("bundle exec rake more:generate")
-      subject.stubs(:git => mock(:dirty? => false))
-      subject.expects(:git_add_and_commit_all_assets_in).never
-
-      subject.package_with_more
+    it "performs a commit" do
+      subject.run
+      git.should have_received(:add_and_commit_all_assets_in).with(packager.assets_path)
     end
-  end
-
-  it "prints an error if packaging failed" do
-    subject.stubs(:run).with("bundle exec rake more:generate").raises("blerg")
-
-    subject.expects(:error).with("Error: RuntimeError: blerg")
-
-    subject.package_with_more
-  end
-end
-
-describe Kumade::Packager, "#git_add_and_commit_all_assets_in" do
-  include_context "with a fake Git"
-
-  it "should call git.add_and_commit_all_in" do
-    git.expects(:add_and_commit_all_in).with("dir", 'deploy', 'Compiled assets', "Added and committed all assets", "couldn't commit assets")
-    subject.git_add_and_commit_all_assets_in("dir")
-  end
-end
-
-describe Kumade::Packager, "#jammit_assets_path" do
-  let(:git)      { stub() }
-  let(:packager) { Kumade::Packager.new(git) }
-
-  before do
-    Jammit.stubs(:package_path).returns('blerg')
-  end
-
-  subject { packager.jammit_assets_path }
-
-  it { should == File.join(Jammit::PUBLIC_ROOT, 'blerg') }
-end
-
-describe Kumade::Packager, "#more_assets_path" do
-  include_context "with a fake Git"
 
-  it "returns the correct asset path" do
-    module ::Less
-      class More
-        def self.destination_path
-          'blerg'
-        end
-      end
+    it "prints the success message after committing" do
+      git.stubs(:add_and_commit_all_assets_in).raises(RuntimeError.new("something broke"))
+      subject.run
+      Kumade.configuration.outputter.should have_received(:success).never
     end
-    subject.more_assets_path.should == 'public/blerg'
   end
-end
-
-describe Kumade::Packager, "#jammit_installed?" do
-  include_context "with a fake Git"
-
-  it "returns true because it's loaded by the Gemfile" do
-    subject.jammit_installed?.should be_true
-  end
-
-  it "returns false if jammit is not installed" do
-    subject.jammit_installed?.should be_true
-  end
-end
-
-describe Kumade::Packager, "#more_installed?" do
-  include_context "with a fake Git"
 
-  context "when More is not installed" do
+  context "when packaging and the repository is not dirty" do
     before do
-      if defined?(Less)
-        Object.send(:remove_const, :Less)
-      end
-    end
-
-    it "returns false" do
-      subject.more_installed?.should be_false
+      Kumade.configuration.pretending = false
+      git.stubs(:dirty? => false)
     end
-  end
 
-  context "when More is installed" do
-    before do
-      module Less
-        class More
-        end
-      end
+    it "does not print a success message" do
+      subject.run
+      Kumade.configuration.outputter.should have_received(:success).never
     end
 
-    it "returns true" do
-      subject.more_installed?.should be_true
+    it "doesn't perform a commit" do
+      subject.run
+      git.should have_received(:add_and_commit_all_assets_in).never
     end
   end
 end

data/spec/kumade/packagers/jammit_packager_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+require "jammit"
+
+describe Kumade::JammitPackager, :with_mock_outputter do
+  subject { Kumade::JammitPackager }
+
+  it_should_behave_like "packager"
+
+  its(:assets_path) { should == File.join(Jammit::PUBLIC_ROOT, Jammit.package_path) }
+
+  it "knows how to package itself" do
+    ::Jammit.stubs(:package!)
+    subject.package
+    ::Jammit.should have_received(:package!).once
+  end
+
+  context "when Jammit is defined" do
+    before { Jammit }
+    it     { should be_installed }
+  end
+
+  context "when Jammit is not defined" do
+    before { Object.send(:remove_const, :Jammit) }
+    it     { should_not be_installed }
+  end
+end

data/spec/kumade/packagers/more_packager_spec.rb

@@ -0,0 +1,37 @@
+require "spec_helper"
+
+require "less"
+
+describe Kumade::MorePackager, :with_mock_outputter do
+  subject { Kumade::MorePackager }
+
+  before do
+    define_constant "Less::More" do
+      def self.destination_path
+        "awesome_destination"
+      end
+    end
+  end
+
+  it_should_behave_like "packager"
+
+  its(:assets_path) { should == File.join('public', ::Less::More.destination_path) }
+
+  it "knows how to package itself" do
+    Less::More.stubs(:generate_all)
+
+    subject.package
+
+    Less::More.should have_received(:generate_all).once
+  end
+
+  context "when More is defined" do
+    before { Less::More }
+    it     { should be_installed }
+  end
+
+  context "when Less::More is not defined" do
+    before { Less.send(:remove_const, :More) }
+    it     { should_not be_installed }
+  end
+end

data/spec/kumade/packagers/noop_packager_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+describe Kumade::NoopPackager, :with_mock_outputter do
+  subject { Kumade::NoopPackager }
+
+  it_should_behave_like "packager"
+
+  its(:assets_path) { should == "" }
+end