kuby-sidekiq 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3d59d851bea4b84f5e198288cb2392b374a1a5bbd750cc669e771598bd0c828
-  data.tar.gz: 8360b03ccdb9e024cb92c3b2511d08349e4ffedabd4ef128cbfb947e61b091a4
+  metadata.gz: 96b955437e20df29e41ac12d18bcb7ae804af4858a35e58c1a29b54b76b16ee7
+  data.tar.gz: 183546d8e03bba59e1baa60e253a6abf682dfbbb1d450e5c550109016e7f1c5f
 SHA512:
-  metadata.gz: 00d1ba24c781023e82453e345bc8fdb68a28cb138b9e7181ba80b5692b1964b8dd138e01b46d7d67e1b414f741380e78c7a9417f9da93e5a6352a8077112c91e
-  data.tar.gz: c001858e4d4b8a82c631482a990da8c3b3aa5eb8fdf89766f4e1e067406ae641512919be2f8f893519b0a9d49ed41e64f52e67d4b03b8c1bf334e3e18c56310c
+  metadata.gz: 64178547f2fa845ab5879cbe39d6d98d62e2fb56d8433fbc7748e69e93eff3502cd1c503ca563a270a233ee6b5d7cfe4145962817597eb1f52111daffe26a17f
+  data.tar.gz: 85516c3f5ba4c5f87ddf0e46dd13fe159eccf2d4ab86685840d7ff3e7ba3df3574df477ff498b6eea8ad0fd6a0b2bcbd1f2f22accdb568ac4f55de19a93c176a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.5.0
+* Support for multiple configurable Sidekiq processes (#2, @zhall0624)
+
 ## 0.4.0
 * Use kuby-redis v0.2, which uses the Spotahome Redis operator instead of KubeDB.
 

data/README.md

@@ -66,6 +66,37 @@ bundle exec kuby -e production push
 bundle exec kuby -e production deploy
 ```
 
+## Advanced Configuration
+
+If you have a more complex setup for Sidekiq you can specify the processes you need to create. The options method allow you to
+provide command line arguments to Sidekiq in order to either specify a non-default `sidekiq.yml` file or queues for a process to
+run. The process name is required.
+
+```ruby
+require 'kuby/sidekiq'
+
+Kuby.define(:production) do
+  kubernetes do
+
+    add_plugin(:sidekiq) do
+      replicas 2  # sets the default number of replicas for each process
+
+
+      process('default') # sidekiq uses sidekiq.yml by default and has 2 replicas
+
+      process('slow_process') do
+        options ['-C', 'config/slow_sidekiq.yml']
+        replicas 4 # override default number of replicas
+      end
+
+      process('queue_processor') do
+        options ['-q', 'critical', '-q', 'less_critical']
+      end
+    end
+  end
+end
+```
+
 ## License
 
 Licensed under the MIT license. See LICENSE for details.

data/lib/kuby/sidekiq/plugin.rb

@@ -1,5 +1,6 @@
 require 'securerandom'
 require 'kuby/redis'
+require_relative 'sidekiq_process'
 
 module Kuby
   module Sidekiq
@@ -10,6 +11,10 @@ module Kuby
 
       value_field :replicas, default: 1
 
+      def processes
+        @processes ||= []
+      end
+
       def connection_params
         redis_instance.connection_params
       end
@@ -19,6 +24,10 @@ module Kuby
       end
 
       def after_configuration
+        if processes.empty?
+          processes << SidekiqProcess.new(plugin: self, default_replicas: replicas)
+        end
+
         environment.kubernetes.add_plugin(:redis) do
           instance :sidekiq do
             custom_config (custom_config || []).concat(['maxmemory-policy noeviction'])
@@ -27,24 +36,28 @@ module Kuby
 
         return unless rails_app
 
-        deployment.spec.template.spec.container(:worker).merge!(
-          rails_app.deployment.spec.template.spec.container(:web), fields: [:env_from]
-        )
+        processes.each do |process|
+          process.deployment.spec.template.spec.container(:worker).merge!(
+            rails_app.deployment.spec.template.spec.container(:web), fields: [:env_from]
+          )
 
-        if rails_app.manage_database? && database = Kuby::Plugins::RailsApp::Database.get(rails_app)
-          database.plugin.configure_pod_spec(deployment.spec.template.spec)
+          if rails_app.manage_database? && database = Kuby::Plugins::RailsApp::Database.get(rails_app)
+            database.plugin.configure_pod_spec(process.deployment.spec.template.spec)
+          end
         end
       end
 
       def before_deploy(manifest)
         image_with_tag = "#{docker.image.image_url}:#{kubernetes.tag || Kuby::Docker::LATEST_TAG}"
 
-        deployment do
-          spec do
-            template do
-              spec do
-                container(:worker) do
-                  image image_with_tag
+        processes.each do |process|
+          process.deployment do
+            spec do
+              template do
+                spec do
+                  container(:worker) do
+                    image image_with_tag
+                  end
                 end
               end
             end
@@ -53,10 +66,7 @@ module Kuby
       end
 
       def resources
-        @resources ||= [
-          service_account,
-          deployment
-        ]
+        @resources ||= [service_account, *processes.map(&:deployment)]
       end
 
       def service_account(&block)
@@ -78,67 +88,11 @@ module Kuby
         @service_account
       end
 
-      def deployment(&block)
-        context = self
-
-        @deployment ||= KubeDSL.deployment do
-          metadata do
-            name "#{context.selector_app}-sidekiq-#{ROLE}"
-            namespace context.namespace.metadata.name
-
-            labels do
-              add :app, context.selector_app
-              add :role, ROLE
-            end
-          end
-
-          spec do
-            replicas context.replicas
-
-            selector do
-              match_labels do
-                add :app, context.selector_app
-                add :role, ROLE
-              end
-            end
-
-            strategy do
-              type 'RollingUpdate'
-
-              rolling_update do
-                max_surge '25%'
-                max_unavailable 0
-              end
-            end
-
-            template do
-              metadata do
-                labels do
-                  add :app, context.selector_app
-                  add :role, ROLE
-                end
-              end
-
-              spec do
-                container(:worker) do
-                  name "#{context.selector_app}-sidekiq-#{ROLE}"
-                  image_pull_policy 'IfNotPresent'
-                  command %w(bundle exec sidekiq)
-                end
-
-                image_pull_secret do
-                  name context.kubernetes.registry_secret.metadata.name
-                end
-
-                restart_policy 'Always'
-                service_account_name context.service_account.metadata.name
-              end
-            end
-          end
+      def process(name, &block)
+        SidekiqProcess.new(name: name, plugin: self, default_replicas: replicas).tap do |process|
+          process.instance_eval(&block) if block
+          processes << process
         end
-
-        @deployment.instance_eval(&block) if block
-        @deployment
       end
 
       def redis_instance

data/lib/kuby/sidekiq/sidekiq_process.rb

@@ -0,0 +1,89 @@
+require 'securerandom'
+
+module Kuby
+  module Sidekiq
+    # This class creates a deployment for a Sidekiq Process. A process is a single instance
+    # of Sidekiq. Each instance can be provided command line options to specify concurrency,
+    # config files or queues.
+    # https://github.com/sidekiq/sidekiq/wiki/Best-Practices#4-use-precise-terminology
+    class SidekiqProcess
+      extend ::KubeDSL::ValueFields
+
+      ROLE='worker'
+
+      attr_reader :plugin, :name, :default_replicas
+
+      value_field :replicas, default: nil
+      value_field :options, default: []
+
+      def initialize(name: 'default', plugin:, default_replicas:)
+        @name = name
+        @plugin = plugin
+        @default_replicas = default_replicas
+      end
+
+      def deployment(&block)
+        context = self
+
+        @deployment ||= KubeDSL.deployment do
+          metadata do
+            name "#{context.plugin.selector_app}-sidekiq-#{ROLE}-#{context.name}"
+            namespace context.plugin.namespace.metadata.name
+
+            labels do
+              add :app, context.plugin.selector_app
+              add :role, ROLE
+            end
+          end
+
+          spec do
+            replicas (context.replicas || context.default_replicas)
+
+            selector do
+              match_labels do
+                add :app, context.plugin.selector_app
+                add :role, ROLE
+              end
+            end
+
+            strategy do
+              type 'RollingUpdate'
+
+              rolling_update do
+                max_surge '25%'
+                max_unavailable 0
+              end
+            end
+
+            template do
+              metadata do
+                labels do
+                  add :app, context.plugin.selector_app
+                  add :role, ROLE
+                end
+              end
+
+              spec do
+                container(:worker) do
+                  name "#{context.plugin.selector_app}-sidekiq-#{ROLE}-#{context.name}"
+                  image_pull_policy 'IfNotPresent'
+                  command ['bundle', 'exec', 'sidekiq', *context.options]
+                end
+
+                image_pull_secret do
+                  name context.plugin.kubernetes.registry_secret.metadata.name
+                end
+
+                restart_policy 'Always'
+                service_account_name context.plugin.service_account.metadata.name
+              end
+            end
+          end
+        end
+
+        @deployment.instance_eval(&block) if block
+        @deployment
+      end
+    end
+  end
+end

data/lib/kuby/sidekiq/version.rb

@@ -1,5 +1,5 @@
 module Kuby
   module Sidekiq
-    VERSION = '0.4.0'
+    VERSION = '0.5.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kuby-sidekiq
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Cameron Dutro
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-07 00:00:00.000000000 Z
+date: 2023-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kuby-core
@@ -73,6 +73,7 @@ files:
 - kuby-sidekiq.gemspec
 - lib/kuby/sidekiq.rb
 - lib/kuby/sidekiq/plugin.rb
+- lib/kuby/sidekiq/sidekiq_process.rb
 - lib/kuby/sidekiq/version.rb
 homepage: http://github.com/getkuby/kuby-sidekiq
 licenses: []
@@ -92,7 +93,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.4.5
 signing_key:
 specification_version: 4
 summary: Sidekiq plugin for Kuby.