kuby-core 0.11.14 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfd902325b0bf78437ea91ba6021ee0cc27f83c67d60a703508a8b0c5a84bc86
-  data.tar.gz: 9598df94486a386235a3566c4c0422f824c30870551251ce3f4836fc94677b39
+  metadata.gz: a443b66d4dff19f6a2112b6365a9579b0490b049ef51ab612ad9e6cf4a807901
+  data.tar.gz: 2b38151be094c758a64ecdc95c585f184f4e9eea1affbdc4d071cc7a20d499a0
 SHA512:
-  metadata.gz: 2ba1c29f18311795a39c8038940c6bc53ae6868523d520af81a52543ee6726282696f07af78b2cd8d6736ce5d0e7bc98ffd14f61693cf0b7421b7cccbbe6ea70
-  data.tar.gz: 801f401ba743d5375e59c33e1be57b6ae7767d5580e37bef0186dd2e299e7293f1a9e2e277a10b43b94977e0f982be8908e57153fb14d136a9e54aea92031fdf
+  metadata.gz: 6cf93a88bc24ab142fa497daddc7227d417c138391f46db6f5b77a862c96e9c2733d880eded21d464170963902364ac0f2806f84cd083d0a5b408231987bcf2b
+  data.tar.gz: dab2dcd180ff19421ef44aef1a3384e1faa0b49511925e6557d54500a652a5c854217a8c463cd738cd6a745b2eb1804262e35539635fdb4d98ed13d2abc90aa2

data/CHANGELOG.md

@@ -1,3 +1,32 @@
+## 0.13.0
+* Fix handling rails/rake options in remote exec (@palkan, #60)
+* Add `bundler_phase.gemfiles(*paths)` to allow adding additional gemfiles (@palkan, #61)
+
+## 0.12.0
+* Fix issue causing volume mount errors when k8s tries to schedule asset pods on multiple nodes (fixes #42).
+  - Persistent volumes can only be mounted on a single physical node.
+  - Kuby now creates a separate assets image powered by nginx.
+  - Ingress routes requests to either the Rails service or assets service depending on the URL (i.e. /assets).
+  - Since the ingress layer is now essential, the Docker Desktop provider no longer deletes ingresses or monkeys with service objects. You'll have to either 1) add an entry for your hostname to your hosts file, or 2) set the `Host` header when making requests to your app.
+* Plugins can now specify additional Dockerfiles to build during `kuby build`.
+* Switch from TravisCI to Github Actions.
+* Remove support for development environments.
+  - Proved to be too difficult to maintain.
+  - Kuby is a _deployment_ tool anyway, not a dev tool.
+  - Maybe we can turn the dev stuff into a gem at some point.
+* Refactor Docker image logic.
+  - Introduced the `Image` class and friends.
+  - Deleted the `Kuby::Docker::Metadata` class.
+* Add missing git dependency to Alpine distro.
+* Add a bare metal provider (fixes #10).
+
+## 0.11.16
+* Fix yarn phase
+  - Apparently you have to copy at least one file, TIL.
+
+## 0.11.15
+* Copy over .npmrc and .yarnrc before running yarn install.
+
 ## 0.11.14
 * Don't include port in image host for registry secrets (no idea why)
 

data/Gemfile

@@ -5,10 +5,10 @@ gemspec
 group :development, :test do
   gem 'pry-byebug'
   gem 'rake'
-  gem 'sorbet', '~> 0.5'
+  # lock to a specific version to prevent breaking CI when new versions come out
+  gem 'sorbet', '= 0.5.6433'
 end
 
 group :test do
   gem 'rspec', '~> 3.0'
-  gem 'timecop', '~> 0.9'
 end

data/README.md

@@ -1,6 +1,7 @@
 ## Kuby
 
-[![Build Status](https://travis-ci.com/getkuby/kuby-core.svg?branch=master)](https://travis-ci.com/getkuby/kuby-core)
+![Unit Tests](https://github.com/getkuby/kuby-core/actions/workflows/unit_tests.yml/badge.svg?branch=master)
+![Integration Tests](https://github.com/getkuby/kuby-core/actions/workflows/integration_tests.yml/badge.svg?branch=master)
 
 Deploy your Rails app the easy way.
 

data/bin/kuby

@@ -1,4 +1,6 @@
 #! /usr/bin/env ruby
 
+$stdout.sync = true
+
 require 'kuby'
 exit Kuby::Commands.run(ARGV)

data/kuby-core.gemspec

@@ -1,4 +1,4 @@
-$:.unshift File.join(File.dirname(__FILE__), 'lib')
+$:.unshift File.expand_path('lib', __dir__)
 require 'kuby/version'
 
 Gem::Specification.new do |s|
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
 
   s.add_dependency 'colorize', '~> 0.8'
-  s.add_dependency 'docker-remote', '~> 0.5'
+  s.add_dependency 'docker-remote', '~> 0.6'
   s.add_dependency 'gli', '~> 2.0'
   s.add_dependency 'helm-cli', '~> 0.3'
   # See: https://github.com/Shopify/krane/pull/720

data/lib/kuby/basic_logger.rb

@@ -52,7 +52,7 @@ module Kuby
         block: T.nilable(T.proc.returns(T.untyped))
       ).void
     }
-    def fatal(progname_or_msg, &block)
+    def fatal(progname_or_msg = nil, &block)
       if block
         super(progname_or_msg) { ColorizedString[block.call].red }
       else

data/lib/kuby/cli_base.rb

@@ -7,21 +7,26 @@ module Kuby
   class CLIBase
     extend T::Sig
 
+    BeforeCallback = T.type_alias { T.proc.params(cmd: T::Array[String]).void }
+    AfterCallback = T.type_alias do
+      T.proc.params(cmd: T::Array[String], last_status: T.nilable(Process::Status)).void
+    end
+
     sig { returns(T.nilable(Process::Status)) }
     def last_status
       Thread.current[status_key]
     end
 
-    sig { params(block: T.proc.params(cmd: String).void).void }
+    sig { params(block: BeforeCallback).void }
     def before_execute(&block)
-      @before_execute = T.let(@before_execute, T.nilable(T::Array[T.proc.params(cmd: String).void]))
+      @before_execute = T.let(@before_execute, T.nilable(T::Array[BeforeCallback]))
       @before_execute ||= []
       @before_execute << block
     end
 
-    sig { params(block: T.proc.params(cmd: String).void).void }
+    sig { params(block: AfterCallback).void }
     def after_execute(&block)
-      @after_execute = T.let(@after_execute, T.nilable(T::Array[T.proc.params(cmd: String).void]))
+      @after_execute = T.let(@after_execute, T.nilable(T::Array[AfterCallback]))
       @after_execute ||= []
       @after_execute << block
     end

data/lib/kuby/commands.rb

@@ -25,9 +25,10 @@ module Kuby
       def run(args)
         if idx = args.index('rails') || idx = args.index('rake')
           @rails_options = T.let(@rails_options, T.nilable(T::Array[String]))
-          @rails_options = args[idx..-1]
+          @rails_options = args[(idx + 1)..-1]
           super(args[0..idx])
         else
+          @rails_options = []
           super
         end
       end
@@ -38,13 +39,6 @@ module Kuby
       Kuby::Tasks.new(Kuby.environment)
     end
 
-    sig { void }
-    def self.must_be_dev_env!
-      unless Kuby.environment.development?
-        fail "Command not supported in the '#{Kuby.environment.name}' environment"
-      end
-    end
-
     program_desc 'Kuby command-line interface. Kuby is a convention '\
       'over configuration approach for running Rails apps in Kubernetes.'
 
@@ -68,59 +62,19 @@ module Kuby
       true
     end
 
-    # These are only stubs included to fill out the help screens. Rails
-    # commands are handled by the RailsCommands class.
-    desc 'Runs a Rails command.'
-    command :rails do |rc|
-      rc.action do |global_options, options, args|
-        must_be_dev_env!
-        exit 1 unless tasks.dev_deployment_ok
-        @rails_options = T.let(@rails_options, T.nilable(T::Array[String]))
-        Kuby::RailsCommands.run(@rails_options)
-      end
-
-      rc.desc 'Runs the rails server (run `rails server --help` for options)'
-      rc.command [:server, :s] do |c|
-        c.action do |global_options, options, args|
-          must_be_dev_env!
-          exit 1 unless tasks.dev_deployment_ok
-          Kuby::RailsCommands.run(@rails_options)
-        end
-      end
-
-      rc.desc 'Runs a script in the Rails environment (run `rails runner --help` for options)'
-      rc.command [:runner, :r] do |c|
-        c.action do |global_options, options, args|
-          must_be_dev_env!
-          exit 1 unless tasks.dev_deployment_ok
-          Kuby::RailsCommands.run(@rails_options)
-        end
-      end
-
-      rc.desc 'Starts an interactive Ruby console with the Rails environment loaded '\
-        '(run `rails console --help` for options)'
-      rc.command [:console, :c] do |c|
-        c.action do |global_options, options, args|
-          must_be_dev_env!
-          exit 1 unless tasks.dev_deployment_ok
-          Kuby::RailsCommands.run(@rails_options)
-        end
-      end
-    end
-
-    desc 'Runs a rake task.'
-    command :rake do |rc|
-      rc.action do |global_options, options, args|
-        must_be_dev_env!
-        exit 1 unless tasks.dev_deployment_ok
-        Kuby::RailsCommands.run(@rails_options)
-      end
-    end
-
     desc 'Builds the Docker image.'
     command :build do |c|
+      c.flag [:a, :arg], required: false, multiple: true
       c.action do |global_options, options, args|
-        tasks.build
+        build_args = {}.tap do |build_args|
+          (options[:arg] || []).each do |a|
+            key, value = a.split('=')
+            value = value[1..-2] if value.start_with?('"') || value.start_with?("'")
+            build_args[key] = value
+          end
+        end
+
+        tasks.build(build_args)
       end
     end
 
@@ -138,10 +92,10 @@ module Kuby
       end
     end
 
-    desc 'Prints the effective Dockerfile used to build the Docker image.'
-    command :dockerfile do |c|
+    desc 'Prints the effective Dockerfiles used to build Docker images.'
+    command :dockerfiles do |c|
       c.action do |global_options, options, args|
-        tasks.print_dockerfile
+        tasks.print_dockerfiles
       end
     end
 
@@ -197,7 +151,6 @@ module Kuby
       rc.desc 'Tails (i.e. continuously streams) the Rails log from your running application.'
       rc.command :logs do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_logs
         end
       end
@@ -205,7 +158,6 @@ module Kuby
       rc.desc 'Lists running Kubernetes pods.'
       rc.command :status do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_status
         end
       end
@@ -213,15 +165,13 @@ module Kuby
       rc.desc 'Runs an arbitrary command inside a running Rails pod.'
       rc.command :exec do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
-          tasks.remote_exec(args)
+          tasks.remote_exec([*args, *@rails_options])
         end
       end
 
       rc.desc 'Establishes a shell inside a running Rails pod.'
       rc.command :shell do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_shell
         end
       end
@@ -229,7 +179,6 @@ module Kuby
       rc.desc 'Establishes a Rails console inside a running Rails pod.'
       rc.command :console do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_console
         end
       end
@@ -237,7 +186,6 @@ module Kuby
       rc.desc 'Establishes a database console inside a running Rails pod.'
       rc.command :dbconsole do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_dbconsole
         end
       end
@@ -245,7 +193,6 @@ module Kuby
       rc.desc "Restarts the Rails app's web pods."
       rc.command :restart do |c|
         c.action do |global_options, options, args|
-          exit 1 unless tasks.dev_deployment_ok
           tasks.remote_restart
         end
       end

data/lib/kuby/docker/alpine.rb

@@ -10,7 +10,8 @@ module Kuby
         [:nodejs, '12.14.1'],
         [:yarn, '1.21.1'],
         [:c_toolchain, nil],
-        [:tzdata, nil]
+        [:tzdata, nil],
+        [:git, nil]
       ].freeze, T::Array[[Symbol, T.nilable(String)]])
 
       sig { returns(Layer) }

data/lib/kuby/docker/app_image.rb

@@ -0,0 +1,19 @@
+
+# typed: strict
+
+module Kuby
+  module Docker
+    class AppImage < ::Kuby::Docker::TimestampedImage
+      extend T::Sig
+
+      sig { params(build_args: T::Hash[String, String]).returns(AppImage) }
+      def build(build_args = {})
+        unless ENV.fetch('RAILS_MASTER_KEY', '').empty?
+          build_args['RAILS_MASTER_KEY'] = T.must(ENV['RAILS_MASTER_KEY'])
+        end
+
+        super(build_args)
+      end
+    end
+  end
+end

data/lib/kuby/docker/bundler_phase.rb

@@ -35,6 +35,7 @@ module Kuby
 
         @version = T.let(@version, T.nilable(String))
         @gemfile = T.let(@gemfile, T.nilable(String))
+        @gemfiles = T.let([], T::Array[String])
         @without = T.let(@without, T.nilable(T::Array[String]))
       end
 
@@ -51,9 +52,9 @@ module Kuby
         dockerfile.copy(gf, '.')
         dockerfile.copy(lf, '.')
 
-        # set bundle path so docker will cache the bundle
-        dockerfile.run('mkdir', './bundle')
-        dockerfile.env('BUNDLE_PATH=./bundle')
+        @gemfiles.each do |file|
+          dockerfile.copy(file, file)
+        end
 
         unless wo.empty?
           dockerfile.env("BUNDLE_WITHOUT='#{wo.join(' ')}'")
@@ -71,6 +72,11 @@ module Kuby
         dockerfile.env("PATH=./bin:$PATH")
       end
 
+      sig { params(paths: String).void }
+      def gemfiles(*paths)
+        @gemfiles.concat(paths)
+      end
+
       private
 
       sig { returns(String) }

data/lib/kuby/docker/cli.rb

@@ -53,19 +53,11 @@ module Kuby
         config.fetch('auths', {}).keys
       end
 
-      sig {
-        params(
-          dockerfile: Dockerfile,
-          image_url: String,
-          tags: T::Array[String],
-          build_args: T::Hash[T.any(Symbol, String), String]
-        )
-        .void
-      }
-      def build(dockerfile:, image_url:, tags:, build_args: {})
+      sig { params(image: Image, build_args: T::Hash[T.any(Symbol, String), String]).void }
+      def build(image, build_args: {})
         cmd = [
           executable, 'build',
-          *tags.flat_map { |tag| ['-t', "#{image_url}:#{tag}"] },
+          *image.tags.flat_map { |tag| ['-t', "#{image.image_url}:#{tag}"] },
           *build_args.flat_map do |arg, val|
             ['--build-arg', Shellwords.shellescape("#{arg}=#{val}")]
           end,
@@ -73,7 +65,7 @@ module Kuby
         ]
 
         open3_w(cmd) do |stdin, _wait_threads|
-          stdin.puts(dockerfile.to_s)
+          stdin.puts(image.dockerfile.to_s)
         end
 
         unless T.must(last_status).success?

data/lib/kuby/docker/docker_uri.rb

@@ -1,11 +1,14 @@
-# typed: false
+# typed: strict
 
 module Kuby
   module Docker
     class DockerURI
-      DEFAULT_REGISTRY_HOST = 'index.docker.io'.freeze
-      DEFAULT_REGISTRY_PORT = 443
+      extend T::Sig
 
+      DEFAULT_REGISTRY_HOST = T.let('index.docker.io'.freeze, String)
+      DEFAULT_REGISTRY_PORT = T.let(443, Integer)
+
+      sig { params(url: String).returns(DockerURI) }
       def self.parse(url)
         if idx = url.index('://')
           url = url[(idx + 3)..-1] || ''
@@ -13,17 +16,25 @@ module Kuby
 
         host_port, *path = url.split('/')
         host, port, *path = if host_port =~ /[.:]/
-          hst, prt = host_port.split(':')
-          [hst, prt || DEFAULT_REGISTRY_PORT, *path]
+          hst, prt = T.must(host_port).split(':')
+          [T.must(hst), prt || DEFAULT_REGISTRY_PORT, *path]
         else
           [DEFAULT_REGISTRY_HOST, DEFAULT_REGISTRY_PORT, host_port, *path]
         end
 
-        new(host, port.to_i, path.join('/'))
+        new(host.to_s, port.to_i, (path || []).join('/'))
       end
 
-      attr_reader :host, :port, :path
+      sig { returns(String) }
+      attr_reader :host
+
+      sig { returns(Integer) }
+      attr_reader :port
+
+      sig { returns(String) }
+      attr_reader :path
 
+      sig { params(host: String, port: Integer, path: String).void }
       def initialize(host, port, path)
         @host = host
         @port = port

data/lib/kuby/docker/errors.rb

@@ -6,25 +6,7 @@ module Kuby
     class PushError < StandardError; end
     class PullError < StandardError; end
     class LoginError < StandardError; end
-
-    class MissingTagError < StandardError
-      extend T::Sig
-
-      sig { returns(String) }
-      attr_reader :tag
-
-      sig { params(tag: String).void }
-      def initialize(tag)
-        @tag = tag
-        @message = T.let(@message, T.nilable(String))
-      end
-
-      sig { returns(String) }
-      def message
-        @message ||= "Could not find tag '#{tag}'."
-      end
-    end
-
+    class MissingTagError < StandardError; end
     class UnsupportedDistroError < StandardError; end
     class MissingPackageError < StandardError; end
     class MissingDistroError < StandardError; end

data/lib/kuby/docker/image.rb

@@ -0,0 +1,115 @@
+# typed: strict
+
+module Kuby
+  module Docker
+    class Image
+      extend T::Sig
+
+      sig { returns(String) }
+      attr_reader :image_url
+
+      sig { returns(Credentials) }
+      attr_reader :credentials
+
+      sig { returns(T.nilable(String)) }
+      attr_reader :main_tag
+
+      sig { returns T::Array[String] }
+      attr_reader :alias_tags
+
+      sig {
+        params(
+          dockerfile: T.any(Dockerfile, T.proc.returns(Dockerfile)),
+          image_url: String,
+          credentials: Credentials,
+          main_tag: T.nilable(String),
+          alias_tags: T::Array[String]
+        ).void
+      }
+      def initialize(dockerfile, image_url, credentials, main_tag = nil, alias_tags = [])
+        @dockerfile = T.let(dockerfile, T.any(Dockerfile, T.proc.returns(Dockerfile)))
+        @image_url = T.let(image_url, String)
+        @credentials = T.let(credentials, Credentials)
+        @main_tag = T.let(main_tag, T.nilable(String))
+        @alias_tags = T.let(alias_tags, T::Array[String])
+
+        @image_host = T.let(@image_host, T.nilable(String))
+        @image_hostname = T.let(@image_hostname, T.nilable(String))
+        @image_repo = T.let(@image_repo, T.nilable(String))
+        @full_image_uri = T.let(@full_image_uri, T.nilable(DockerURI))
+        @docker_cli = T.let(@docker_cli, T.nilable(Docker::CLI))
+      end
+
+      sig { returns(Image) }
+      def new_version
+        raise NotImplementedError, 'please use a Docker::Image subclass'
+      end
+
+      sig { returns(Image) }
+      def current_version
+        raise NotImplementedError, 'please use a Docker::Image subclass'
+      end
+
+      sig { params(current_tag: T.nilable(String)).returns(Image) }
+      def previous_version(current_tag = nil)
+        raise NotImplementedError, 'please use a Docker::Image subclass'
+      end
+
+      sig { returns(Dockerfile) }
+      def dockerfile
+        if @dockerfile.respond_to?(:call)
+          T.cast(@dockerfile, T.proc.returns(Dockerfile)).call
+        else
+          T.cast(@dockerfile, Dockerfile)
+        end
+      end
+
+      sig { returns(String) }
+      def image_host
+        @image_host ||= "#{image_uri.host}:#{image_uri.port}"
+      end
+
+      sig { returns(String) }
+      def image_hostname
+        @image_hostname ||= image_uri.host
+      end
+
+      sig { returns(String) }
+      def image_repo
+        @image_repo ||= image_uri.path
+      end
+
+      sig { returns(DockerURI) }
+      def image_uri
+        @full_image_uri ||= DockerURI.parse(image_url)
+      end
+
+      sig { returns(T::Array[String]) }
+      def tags
+        [main_tag, *alias_tags].compact
+      end
+
+      sig { params(build_args: T::Hash[String, String]).void }
+      def build(build_args = {})
+        raise NotImplementedError, 'please use a Docker::Image subclass'
+      end
+
+      sig { params(tag: String).void }
+      def push(tag)
+        raise NotImplementedError, 'please use a Docker::Image subclass'
+      end
+
+      sig { returns(Docker::CLI) }
+      def docker_cli
+        @docker_cli ||= Docker::CLI.new
+      end
+
+      private
+
+      sig { params(main_tag: String, alias_tags: T::Array[String]).returns(Image) }
+      def duplicate_with_tags(main_tag, alias_tags)
+        self.class.new(dockerfile, image_url, credentials, main_tag, alias_tags)
+      end
+    end
+  end
+end

data/lib/kuby/docker/layer.rb

@@ -21,13 +21,6 @@ module Kuby
         raise NotImplementedError,
           "#{__method__} must be defined in derived classes"
       end
-
-      private
-
-      sig { returns(Metadata) }
-      def metadata
-        environment.docker.metadata
-      end
     end
   end
 end

data/lib/kuby/docker/local_tags.rb

@@ -8,37 +8,36 @@ module Kuby
       sig { returns CLI }
       attr_reader :cli
 
-      sig { returns(Metadata) }
-      attr_reader :metadata
+      sig { returns(String) }
+      attr_reader :image_url
 
       sig {
         params(
           cli: CLI,
-          metadata: Metadata
+          image_url: String
         )
         .void
       }
-      def initialize(cli, metadata)
+      def initialize(cli, image_url)
         @cli = cli
-        @metadata = metadata
-
+        @image_url = image_url
         @latest_timestamp_tag = T.let(@latest_timestamp_tag, T.nilable(TimestampTag))
       end
 
       sig { returns(T::Array[String]) }
       def tags
-        images = cli.images(metadata.image_url)
+        images = cli.images(image_url)
         images.map { |image| T.must(image[:tag]) }
       end
 
       sig { returns(T::Array[String]) }
       def latest_tags
         # find "latest" tag
-        images = cli.images(metadata.image_url)
-        latest = images.find { |image| image[:tag] == Tags::LATEST }
+        images = cli.images(image_url)
+        latest = images.find { |image| image[:tag] == Kuby::Docker::LATEST_TAG }
 
         unless latest
-          raise MissingTagError.new(Tags::LATEST)
+          raise MissingTagError, "could not find tag #{Kuby::Docker::LATEST_TAG}"
         end
 
         # find all tags that point to the same image as 'latest'

data/lib/kuby/docker/package_phase.rb

@@ -69,11 +69,6 @@ module Kuby
           raise MissingPackageError, "package '#{package_name}' hasn't been registered"
         end
       end
-
-      sig { returns(Metadata) }
-      def metadata
-        environment.docker.metadata
-      end
     end
   end
 end

data/lib/kuby/docker/packages.rb

@@ -1,4 +1,5 @@
 # typed: strict
+
 module Kuby
   module Docker
     module Packages