kubes 0.7.10 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6529d951f35f31cf105591f8d5ea0f3b8819e358f0b3388f22d17340af1f2bbf
-  data.tar.gz: d1c6e87a899a75a8f7078046c4058c69c46328c3b7138b4a934dae7fe287be4d
+  metadata.gz: abdaace0c3b6e26fb4e1ec508f6495821f53dd91874adef0957b18d4dd7d26ef
+  data.tar.gz: bc026da9756049bee53a4a0041e54f8696912aec29ce98d7ead5dd7df87ae5a7
 SHA512:
-  metadata.gz: 245ca41ceec0499da84ef056b19ad6f99e422f3c1013718d3e466128aeab6503fc1d0c3be19892633dab1acff1865816885fa6f7d1589c60d5ebe65cfaffab50
-  data.tar.gz: 551a265282d0a6af874517382859492bbe27bcd201790e94f3f7a9540d6ffeb4b6dc678b0aa1cfeab4e5983a0a591625da21ef7ec59bb01fe8c33fdbf681e8c2
+  metadata.gz: de24256a61e96baef7ae15831474638e262dc30667f461af8929a420405b1413c30cdb21f750f3eb9377ea112aedbf82561677a730599d492d4597973eca8847
+  data.tar.gz: 45892fec7a9af86fdf69fd91d8508874ec18918eedecd6fad8f3622bd12c70f7487ffe532c246877427bedf0b6578210f70389a5f9b13fb4a86d4e8821c62e71

data/CHANGELOG.md

@@ -3,6 +3,19 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [0.8.3] - 2022-02-16
+- [#60](https://github.com/boltops-tools/kubes/pull/60) Config files
+
+## [0.8.2] - 2022-02-07
+- improve gem dependency version specifiers
+
+## [0.8.1] - 2022-02-06
+- allow --version command to run outside project
+
+## [0.8.0] - 2022-02-06
+- [#58](https://github.com/boltops-tools/kubes/pull/58) standalone install docs
+- [#59](https://github.com/boltops-tools/kubes/pull/59) central deployer support
+
 ## [0.7.10] - 2021-12-18
 - [#56](https://github.com/boltops-tools/kubes/pull/56) New hook generator
 - [#57](https://github.com/boltops-tools/kubes/pull/57) Fix activesupport require

data/docs/Gemfile

@@ -2,6 +2,7 @@ source "https://rubygems.org"
 
 gem "html-proofer"
 gem "jekyll"
+gem "jekyll-include-cache"
 gem "opal"
 gem "opal-browser"
 gem "opal-jquery"

data/docs/_config.yml

@@ -70,4 +70,10 @@ defaults:
 plugins_dir:
   # - jekyll-gzip - GitHub pages does not support this plugin.
 
+# List of supported plugins:
+# https://pages.github.com/versions.json
+# https://github.com/github/pages-gem/issues/171
+plugins:
+- jekyll-include-cache # Supported by GitHub pages
+
 ads_url: "https://ads.boltops.com"

data/docs/_docs/config/app-overrides.md

@@ -0,0 +1,7 @@
+---
+title: App Overrides Cheatsheet
+---
+
+Kubes supports app-level overrides. This is especially useful for the [Central Deployer Pattern]({% link _docs/patterns/central-deployer.md %}).
+
+{% include config/app-overrides-cheatsheet.md %}

data/docs/_docs/config/boot.md

@@ -0,0 +1,46 @@
+---
+title: Boot Hooks
+---
+
+If you need to hook into the Kubes boot process super-early on, Kubes boot hooks are designed for that.
+
+* They run very early in the Kubes boot process.
+* They are useful for setting shared global values like env vars.
+* Boot hooks are ruby files that get required. It's nice and simple. There's no interface to learn.
+
+## Hooks
+
+Kubes will searches 2 files in the `config` folder. If the files exist, they will be ran in this order.
+
+1. **.kubes/config/boot.rb**: Always runs.
+2. **.kubes/config/boot/KUBES_ENV.rb**: Runs based on the env. IE: `KUBES_ENV=dev` => `.kubes/config/boot/dev.rb`
+
+Both files are required and ran if they both exists. Since the `KUBES_ENV` one runs second, it can be used to override previously set values.
+
+## Example: Default KUBES_ENV
+
+If you prefer a different default than `KUBES_ENV=dev`.
+
+config/boot.rb
+
+```ruby
+ENV['KUBES_ENV'] ||= 'development'
+```
+
+This changes the default for everyone using the project, but still allows them to control the default by adding `export KUBES_ENV=development` to their `~/.bash_profile`.
+
+## Example: Auto-Switch AWS_PROFILE
+
+One useful example is switching `AWS_PROFILE` based on the `KUBES_ENV`. Example:
+
+config/boot/dev.rb
+
+```ruby
+ENV['AWS_PROFILE'] = 'dev'
+```
+
+This example is for AWS, but you can can do similiar switch logic with `GOOGLE_APPLICATION_CREDENTIALS`, etc.
+
+## Boot Source
+
+Please refer to the boot source code for more details: [kubes/booter.rb](https://github.com/boltops-tools/kubes/blob/master/lib/kubes/booter.rb)

data/docs/_docs/config/env.md

@@ -16,7 +16,9 @@ Kubes.configure do |config|
 end
 ```
 
-## Layering
+## Config Overrides
+
+### Env Overrides
 
 You can override configs on a per-env basis with `config/env` files. Examples:
 
@@ -38,7 +40,32 @@ Kubes.configure do |config|
 end
 ```
 
-For more details refer to the [Layering Docs]({% link _docs/layering.md %}).
+### App Overrides
+
+If KUBES_APP is set, app-scoped configs can be used to override settings further. Here are some with `config/env/app` example files:
+
+.kubes/config/env/app1/dev.rb
+
+```ruby
+Kubes.configure do |config|
+  config.repo = "222222222222.dkr.ecr.us-west-2.amazonaws.com/demo"
+  config.kubectl.context = "dev-cluster"
+end
+```
+
+.kubes/config/env/app2/prod.rb
+
+```ruby
+Kubes.configure do |config|
+  config.repo = "333333333333.dkr.ecr.us-west-2.amazonaws.com/demo"
+  config.kubectl.context = "prod-cluster"
+end
+```
+
+This allows you to set specific app-level settings with:
+
+    KUBES_APP=app1 kubes deploy
+    KUBES_APP=app2 kubes deploy
 
 ## Auto-Switching Context
 

data/docs/_docs/config/reference.md

@@ -8,7 +8,7 @@ auto_prune | Prune and delete old hashed resources like Secret and ConfigMap. |
 builder | What docker build command to use. Can use `docker` or `gcloud` to build the Docker image. | docker
 image | Set a prebuilt Docker image to use. This is optional. Usually, you want to build an image from the Dockerfile.  Setting this will change the `docker_image` helper to use a predefined image. See: [Docker Image]({% link _docs/intro/docker-image.md %}) | nil
 kubectl.context | What kubectl context to auto-switch to. | nil
-kubectl.context_keep | Whether or not to keep the context switched | true
+kubectl.context_keep | Whether or not to keep the context switched | false
 kubectl.exit_on_fail.apply  | Whether or not continue if the `kubectl apply` fails. Note, can use `KUBES_EXIT_ON_FAIL=0` env var to set to false. | true
 kubectl.exit_on_fail.delete | Whether or not continue if the `kubectl delete` fails. | false
 kubectl.order.kinds | Change ordering for Kubernetes Kinds. | See [source code](https://github.com/boltops-tools/kubes/blob/master/lib/kubes/config.rb#L52)
@@ -18,6 +18,6 @@ logger.level | Logger level. Can also be set with `KUBES_LOG_LEVEL` env var | in
 repo | The Docker repo to use. Required to be set. | nil
 repo_auto_auth | Whether or not to try to auth authorize docker repo registry if not yet logged in. Can also be set with env var `KUBES_REPO_AUTO_AUTO` | true
 skip | List of resources to skip. Can also be set with the `KUBES_SKIP` env var. `KUBES_SKIP` should be a list of strings separated by spaces. It adds onto the `config.skip` option. | []
-state.path | Where to store the state file with the last build Docker image. | .kubes/state/KUBES_ENV/data.json
+state.path | Where to store the state file with the last build Docker image. | .kubes/state/KUBES_APP/KUBES_ENV/data.json
 suffix_hash | Whether or not to append suffix hash to ConfigMap and Secret | true
 merger.options | Merger options that control how Hashes are merged. More info: [Merger Options]({% link _docs/layering/merge-options.md %}) | `{overwrite_arrays: true}`

data/docs/_docs/config/skip.md

@@ -56,3 +56,25 @@ You can also us ethe `KUBES_SKIP` env var. It takes list of strings separated by
     KUBES_SKIP="cleanup/job" kubes delete
 
 This can be useful for one-off use cases.
+
+## Skip With kubes skip metdata
+
+You can also skip a resource from being written by using `kubes.skip = true`. This is useful if you want to conditionally not create a resource with a variable. Example:
+
+.kubes/resources/config_map.yaml
+
+```yaml
+<% if @skip %>
+kubes:
+  skip: true
+<% end %>
+metadata:
+  namespace: demo-dev
+  labels:
+    app: demo-dev
+  name: demo-dev-configmap-495c18844b
+apiVersion: v1
+kind: ConfigMap
+```
+
+If the variable is set to `@skip = true`, then the config_map.yaml will not get created.

data/docs/_docs/helpers/aws/secret_data.md

@@ -0,0 +1,55 @@
+---
+title: AWS Secrets
+nav_text: Secrets Data
+categories: helpers-aws
+---
+
+The `aws_secret_data` helper fetches secret data that is one single file from AWS Secrets.
+
+## Example
+
+For example if you have these secret values stored as one file with multiple values separated by `=`.
+
+    $ aws secretsmanager get-secret-value --secret-id demo-dev-secret-data | jq '.SecretString'
+    KEY1=secretvalue1
+    KEY2=secretvalue2
+
+Kubes can fetch the secret data and base64 encode the values properly.  Example:
+
+.kubes/resources/shared/secret.yaml
+
+```yaml
+apiVersion: v1
+kind: Secret
+metadata:
+  name: demo
+  labels:
+    app: demo
+data:
+<%= aws_secret_data("demo-dev-secret-data") %>
+```
+
+Notice how the text is idented properly by 2 spaces and the values are automatically base64 encoded.
+
+.kubes/output/shared/secret.yaml
+
+```yaml
+metadata:
+  namespace: demo
+  name: demo-2a78a13682
+  labels:
+    app: demo
+apiVersion: v1
+kind: Secret
+data:
+  KEY1: c2VjcmV0dmFsdWUx
+  KEY2: c2VjcmV0dmFsdWUy
+```
+
+## Options
+
+Here's an example of the available options for `aws_secret_data`.
+
+```ruby
+aws_secret_data("demo-#{Kubes.env}-secret-data", base64: true, ident: 2)
+```

data/docs/_docs/helpers/builtin/config-map-files.md

@@ -0,0 +1,63 @@
+---
+title: Config Map Files
+nav_text: Config Map Files
+---
+
+The `config_map_files` helper allows you to add config map data from a list of files. The files support layerying.
+
+## Example
+
+Here's how to use it.
+
+.kubes/resources/shared/config_map.yaml
+
+```yaml
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: demo
+  labels:
+    app: demo
+data:
+<%= config_map_files %>
+```
+
+You can conveniently set multiple configmap values in files like so:
+
+.kubes/resources/shared/config_map/base.txt
+
+    KEY1=cmvalue1
+    KEY2=cmvalue2
+
+.kubes/resources/shared/config_map/dev.txt
+
+    KEY2=cmvalue2-dev-override
+    KEY3=cmvalue3
+
+The resulting generated ConfigMap will be:
+
+```yaml
+---
+metadata:
+  namespace: demo-dev
+  labels:
+    app: demo
+  name: demo-928146dd24
+apiVersion: v1
+kind: ConfigMap
+data:
+  KEY1: cmvalue1
+  KEY2: cmvalue2-dev-override
+  KEY3: cmvalue3
+```
+
+## Layering Details
+
+Layering for Config Map Files and also supports app-scoped layers.
+
+Name | Example
+--- | ---
+configmap root | .kubes/resources/shared/config_map/{base,dev}.txt
+configmap app-scoped | .kubes/resources/shared/config_map/app1/{base,dev}.txt
+
+So if `KUBES_APP=app1`, then the app-scoped layer is also used. This handles the [Central Deployer Pattern]({% link _docs/patterns/central-deployer.md %}).

data/docs/_docs/helpers/builtin.md

@@ -0,0 +1,16 @@
+---
+title: Core Built-In Helpers
+---
+
+Kubes provides some helper methods to help write Kubernetes YAML files.  Here's a list of the helper methods. These are available whether you write your resources in YAML or DSL.
+
+Helper | Description
+--- | ---
+decode64 | Base64 decode a string.
+docker_image | Method refers to the latest Docker image built by Kubes. This spares you from having to update the image manually in the deployment resource. Note, this can be overridden with the `--image` cli option or the `Kubes.config.image` setting. See: [Docker Image]({% link _docs/intro/docker-image.md %})
+dockerfile_port	| Exposed port extracted from the Dockerfile of the project.
+encode64 | Base64 encode a string. Also available as `base64` method.
+extra | The `KUBES_EXTRA` value.
+with_extra | Appends the `KUBES_EXTRA` value to a string if it's set. It's covered in the [Extra Env Docs]({% link _docs/extra-env.md %}).
+
+Here's also the source code with most of the helpers: [helpers.rb](https://github.com/boltops-tools/kubes/blob/master/lib/kubes/compiler/shared/helpers.rb).

data/docs/_docs/helpers/google/secret_data.md

@@ -0,0 +1,55 @@
+---
+title: Google Secrets
+nav_text: Secrets Data
+categories: helpers-google
+---
+
+The `google_secret_data` helper fetches secret data that is one single file from Google Secrets.
+
+## Example
+
+For example if you have these secret values stored as one file with multiple values separated by `=`.
+
+    $ gcloud secrets versions access latest --secret demo-dev-secret-data
+    KEY1=secretvalue1
+    KEY2=secretvalue2
+
+Kubes can fetch the secret data and base64 encode the values properly.  Example:
+
+.kubes/resources/shared/secret.yaml
+
+```yaml
+apiVersion: v1
+kind: Secret
+metadata:
+  name: demo
+  labels:
+    app: demo
+data:
+<%= google_secret_data("demo-dev-secret-data") %>
+```
+
+Notice how the text is idented properly by 2 spaces and the values are automatically base64 encoded.
+
+.kubes/output/shared/secret.yaml
+
+```yaml
+metadata:
+  namespace: demo
+  name: demo-2a78a13682
+  labels:
+    app: demo
+apiVersion: v1
+kind: Secret
+data:
+  KEY1: c2VjcmV0dmFsdWUx
+  KEY2: c2VjcmV0dmFsdWUy
+```
+
+## Options
+
+Here's an example of the available options for `google_secret_data`.
+
+```ruby
+google_secret_data("demo-#{Kubes.env}-secret-data", base64: true, ident: 2)
+```

data/docs/_docs/helpers.md

@@ -2,18 +2,9 @@
 title: Helpers
 ---
 
-Kubes provides some helper methods to help write Kubernetes YAML files.  Here's a list of the helper methods. These are available whether you write your resources in YAML or DSL.
-
-Helper | Description
---- | ---
-decode64 | Base64 decode a string.
-docker_image | Method refers to the latest Docker image built by Kubes. This spares you from having to update the image manually in the deployment resource. Note, this can be overridden with the `--image` cli option or the `Kubes.config.image` setting. See: [Docker Image]({% link _docs/intro/docker-image.md %})
-dockerfile_port	| Exposed port extracted from the Dockerfile of the project.
-encode64 | Base64 encode a string. Also available as `base64` method.
-extra | The `KUBES_EXTRA` value.
-with_extra | Appends the `KUBES_EXTRA` value to a string if it's set. It's covered in the [Extra Env Docs]({% link _docs/extra-env.md %}).
-
-Here's also the source code with most of the helpers: [helpers.rb](https://github.com/boltops-tools/kubes/blob/master/lib/kubes/compiler/shared/helpers.rb).
+## Built-In Helpers
+
+Kubes provides core helper methods to help write Kubernetes YAML files. Docs: [Built-In Helpers]({% link _docs/helpers/builtin.md %}).
 
 ## DSL Specific Methods
 

data/docs/{_includes/intro/install.md → _docs/install/dependencies.md}

@@ -1,10 +1,9 @@
-## RubyGems
+---
+title: Install Dependencies
+---
 
-Install kubes via RubyGems.
+These dependencies are not included with any of the installers. This allows you to install and run the versions you want to use.
 
-    gem install kubes
-
-Ruby 2.7 and above is recommended.
 
 ## kubectl
 

data/docs/_docs/install/gem/custom-version.md

@@ -0,0 +1,70 @@
+---
+title: How to Use Custom Version of Kubes
+nav_text: Custom Version
+category: gem
+order: 1
+---
+
+If you want or need to run a forked version of kubes, here's how:
+
+## Change Version Number
+
+First, clone down the source and change version number so you can identify that it's a custom version.  Clone down the project:
+
+    $ git clone https://github.com/boltops-tools/kubes
+
+Update [lib/kubes/version.rb](https://github.com/boltops-tools/kubes/blob/master/lib/kubes/version.rb) so you'll be able to tell that it's a custom build.  For example:
+
+```ruby
+module kubes
+  VERSION = "0.8.2.custom"
+end
+```
+
+There are 2 ways to use the custom version:
+
+1. Gemfile: Forked Git Source
+2. Gem Package: Build and Install
+
+## Gemfile: Forked Git Source
+
+Point `kubes ` to use your repo with the forked version.  Example:
+
+Gemfile:
+
+```ruby
+source "https://rubygems.org"
+gem 'kubes', git: 'https://github.com/REPO/kubes', branch: "master"
+```
+
+Remember to change `REPO`, to your repo name.
+
+Then run:
+
+    bundle
+
+## Gem Package: Build and Install
+
+Build the gem package:
+
+    $ bundle
+    $ rake build
+    pkg/kubes-0.8.2.custom.gem
+
+The produced `.gem` file can used to install the gem. You can install it locally:
+
+    $ gem install pkg/kubes-0.8.2.custom.gem
+    $ kubes -v
+    0.8.2.custom
+
+Or on any machine with Ruby installed. You can copy it to the machine, ssh into it, and install the custom gem:
+
+    $ scp pkg/kubes-0.8.2.custom.gem user@server.com:
+    $ ssh user@server.com
+    $ gem install kubes-0.8.2.custom.gem
+    $ kubes -v
+    0.8.2.custom
+
+## Contributing
+
+Learning how to run a forked version of kubes allows you to make changes to the tool. Consider improving kubes by submitting a Pull Request. See: [Contributing]({% link _docs/contributing.md %}).

data/docs/_docs/install/gem.md

@@ -0,0 +1,6 @@
+---
+title: Gem Installation
+---
+
+{% include install/gem.md %}
+

data/docs/_docs/install/standalone/centos.md

@@ -0,0 +1,70 @@
+---
+title: "Install: CentOS/RedHat/Fedora"
+nav_text: CentOS
+category: standalone
+order: 2
+---
+
+This page shows you how to install kubes on CentOS, RedHat, Fedora and other Linux systems that use the yum-based package manager.
+
+## CentOS/RedHat/Fedora
+
+Configure repo
+
+    sudo su
+    curl -so /etc/yum.repos.d/boltops.repo https://yum.boltops.com/boltops.repo
+    rpm --import https://yum.boltops.com/boltops-key.public
+
+Install
+
+    yum install -y kubes
+
+Upgrade
+
+    yum makecache
+    yum update -y kubes
+
+Uninstall
+
+    yum remove -y kubes
+
+{% include install/wrapper.md %}
+
+## Fedora Notes
+
+For Fedora, you may also need the libxcrypt-compat package.
+
+    dnf install libxcrypt-compat -y
+
+Or you'll get this error:
+
+    $ kubes -h
+    /opt/kubes/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.1: cannot open shared object file: No such file or directory
+    $
+
+Fedora is a bleeding edge distro and is quicker about upgrading their system. The `libcrypt.so` has been removed. The libxcrypt-compat package installs it back.
+
+## Amazon Linux 2 Notes
+
+The standalone installer does not support Amazon Linux 1.  Please use Amazon Linux 2 instead.
+
+## Rpm Install
+
+You can also download the rpm package and install it directly. Here are the commands:
+
+    wget https://yum.boltops.com/packages/kubes/kubes-latest.rpm
+    sudo su
+    rpm -ivh kubes-latest.rpm
+    kubes -h
+
+To upgrade an existing install also use the `-U` flag.
+
+    rpm -Uivh kubes-latest.rpm
+
+You can check [kubes-latest.rpm.metadata.json](https://yum.boltops.com/packages/kubes/kubes-latest.rpm.metadata.json) to verify the package checksum. Here's the checksum command.
+
+    sha256sum kubes-latest.rpm
+
+To uninstall
+
+    rpm -e kubes-latest.rpm

data/docs/_docs/install/standalone/details/permissions.md

@@ -0,0 +1,44 @@
+---
+title: "Standalone Permissions"
+nav_text: Permissions
+category: standalone-details
+---
+
+The kubes standalone installer will make sure that the owner and permissions of the `/opt/kubes` folder is your user.
+
+If the `/opt/kubes` folder is not owned by your user for whatever reason, here are the commands to change it:
+
+For macosx:
+
+    sudo chown -R `whoami`:staff /opt/kubes
+
+For other Linux OSes, this is generally:
+
+    sudo chown -R `whoami`:`whoami` /opt/kubes
+
+## Why?
+
+When the `/opt/kubes` folder is not owned by your user, you won't be able to write to it without sudo. This results in a sudo prompt when kubes calls `bundle` and tries to install new gems. You will see this:
+
+    => Installing dependencies with: bundle install
+    Following files may not be writable, so sudo is needed:
+      /opt/kubes/embedded/bin
+      /opt/kubes/embedded/lib/ruby/gems/2.7.0
+      /opt/kubes/embedded/lib/ruby/gems/2.7.0/cache
+      /opt/kubes/embedded/lib/ruby/gems/2.7.0/extensions
+      /opt/kubes/embedded/lib/ruby/gems/2.7.0/gems
+      /opt/kubes/embedded/lib/ruby/gems/2.7.0/specifications
+
+    Your user account isn't allowed to install to the system RubyGems.
+      You can cancel this installation and run:
+
+          bundle install --path vendor/bundle
+
+      to install the gems into ./vendor/bundle/, or you can enter your password
+      and install the bundled gems to RubyGems using sudo.
+
+      Password:
+
+To fix this issue, make sure `/opt/kubes` is owned by your user, instead of repeatedly having to type your password for sudo.
+
+Also, running `sudo` means you're using bare shell with pretty much none of your environment settings or variables configured. Though there are ways to [preserve](https://stackoverflow.com/questions/8633461/how-to-keep-environment-variables-when-using-sudo) environment variables with `--preserve-env`, it's often better to avoid sudo as you'll run into different environmental differences and quirks.

data/docs/_docs/install/standalone/details/uninstall.md

@@ -0,0 +1,16 @@
+---
+title: "Uninstall Cleanup"
+nav_text: Uninstall
+category: standalone-details
+order: 4
+---
+
+Some packager managers will not clean up the installed files completely. The apt-get and yum package manager generally cleans up everything. Homebrew doesn't seem to clean up currently though.
+
+To fully clean up and uninstall kubes. First, run the package manger uninstall command and then clean up with:
+
+    rm -rf /opt/kubes
+
+Then remove the kubes wrappers in `/usr/local/bin`. You can remove them with this command:
+
+    grep -l /opt/kubes /usr/local/bin/* | xargs rm -f

data/docs/_docs/install/standalone/details.md

@@ -0,0 +1,20 @@
+---
+title: "Standalone Details"
+nav_text: Details
+category: standalone
+order: 9
+---
+
+The standalone installer packages are built within a few minutes of the kubes gem release. This page covers more details on how the standalone installation works.
+
+## Isolated: /opt/kubes
+
+The standalone kubes package installs kubes in `/opt/kubes`. This folder contains everything like system libraries, Ruby, and gems needed for kubes to work as a standalone package. Additionally, this also makes it easy to remove kubes.
+
+## Wrapper: /usr/local/bin
+
+The installer creates a wrapper script in `/usr/local/bin`.
+
+    /usr/local/bin/kubes
+
+Most users have `/usr/local/bin` configured in there PATH. So this wrapper should work.