kubeclient_exec 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 783c277e38da6c47f173c388cfcfc1a23ea49195897fee58a84769e1235d9f03
-  data.tar.gz: 4e846cd12ff72208a3a1a2000080c8308984a928650d83653d51475b0abe1fbe
+  metadata.gz: 17b3e2d61714b926cddbdd6735e6f6e068a32831313753597a2d05fcf4de6eb0
+  data.tar.gz: 03b121f120609632f793217d42e7f1cab6b95c8655086fa68a7ed28e9b9e15e4
 SHA512:
-  metadata.gz: 3790f4faba66b7baff66880cbdb70b0d6ed2ddb2295be8d83d6a3a117fc6aef7613ead79d0175c96beb746fe3597b23363a736a91ce13a2cadb711e99d01ed39
-  data.tar.gz: 9bb51d192bafe61cc3be76fd7feea6f5b9eac40d4313ff542190abd227a784b525e5d9887b2b1c5a7439157b466a8fefb41b8dc2c1468c11713c021e565507a8
+  metadata.gz: 33986e59d05b7c4cf4a0e1c98bc97b7c227689da60cb6932176ac2dea8ce35fe26b1dfe1802cb1435fcb7ec10fb203abaacaa3747a666b932659c03ab017c116
+  data.tar.gz: d37fcd4f1e3cf30449a8b8a73c0084c6f202d6a12b0599d394ecca3d5f9bbb14207077b3413522282d3ae3286834114cf99b293f8fac03d4df782b246930d438

data/lib/kubeclient_exec/copy/copy.rb

@@ -9,7 +9,7 @@ module KubeclientExec
     DEFAULT_CP_OPTIONS = {
       container: nil,
       reverse_direction: false,
-      suppress_errors: true,
+      suppress_errors: false,
       tls: {
         cert_chain_file: nil,
         private_key_file: nil,
@@ -42,13 +42,22 @@ module KubeclientExec
 
       if copy_file
         exec_pod("tar xf - -C #{remote_path.split('/')[0...-1].join('/')}", name, namespace, options: { tty: false }.merge!(options)) do |executor|
-          executor.write(tar_file.string)
+          chunks = split_string_into_chunks(tar_file.string, 1024 * 1024) # 1MB
+          chunks.each do |chunk|
+            executor.write(chunk)
+          end
 
           # Feels like there should be a better way for this
+          stopping = false
           EM.add_periodic_timer(0.1) do
-            if executor.done?
+            if executor.done? && !stopping
+              stopping = true
               executor.stop
             end
+
+            if executor.ready_state == 3
+              EM.stop_event_loop
+            end
           end
         end
       else
@@ -56,10 +65,16 @@ module KubeclientExec
           executor.write(tar_file.string)
 
           # Feels like there should be a better way for this
+          stopping = false
           EM.add_periodic_timer(0.1) do
-            if executor.done?
+            if executor.done? && !stopping
+              stopping = true
               executor.stop
             end
+
+            if executor.ready_state == 3
+              EM.stop_event_loop
+            end
           end
         end
       end
@@ -70,22 +85,40 @@ module KubeclientExec
 
       exec_pod("tar cf - #{remote_path}", name, namespace, options: { tty: false }.merge!(options)) do |executor|
         count = 0
+        content = ''
 
         executor.on_stdout do |data|
-          if count == 1
-            if local_path.is_a? String
-              untar(StringIO.new(data), local_path)
-            elsif local_path == :single_result
-              result = single_untar(StringIO.new(data))
-            end
-            executor.stop
+          if count >= 1
+            content += data
           end
 
           count += 1
         end
+
+        executor.on_close do
+          if local_path.is_a? String
+            untar(StringIO.new(content), local_path)
+          elsif local_path == :single_result
+            result = single_untar(StringIO.new(content))
+          end
+        end
       end
 
       result
     end
+
+    private
+    def split_string_into_chunks(string, chunk_size)
+      chunks = []
+      start_index = 0
+
+      while start_index < string.length
+        chunk = string[start_index, chunk_size]
+        chunks << chunk
+        start_index += chunk_size
+      end
+
+      chunks
+    end
   end
 end

data/lib/kubeclient_exec/execute/execute.rb

@@ -10,7 +10,7 @@ module KubeclientExec
       stdout: true,
       stderror: true,
       tty: true,
-      suppress_errors: true,
+      suppress_errors: false,
       tls: {
         cert_chain_file: nil,
         private_key_file: nil,

data/lib/kubeclient_exec/execute/executor.rb

@@ -55,8 +55,12 @@ module KubeclientExec
       end
 
       def stop
-        @ws.close if @ws
+        @ws.instance_variable_get(:@stream).close_connection_after_writing
         @on_close.call if @on_close
+      end
+
+      def stop!
+        stop
         EM.stop_event_loop
       end
 
@@ -64,6 +68,10 @@ module KubeclientExec
         @ws.instance_variable_get(:@driver).instance_variable_get(:@queue).empty?
       end
 
+      def ready_state
+        @ws.ready_state
+      end
+
       private
       def setup
         @ws = Faye::WebSocket::Client.new(@url, nil, {
@@ -73,12 +81,13 @@ module KubeclientExec
             cert_chain_file: @kubeclient_options[:tls][:cert_chain_file],
             private_key_file: @kubeclient_options[:tls][:private_key_file],
             verify_peer: @kubeclient_options[:tls][:verify_peer],
-          }
+          },
+          max_length: 2**32,
         })
 
         @ws.on(:message) do |msg|
           if msg.type == :close
-            stop
+            stop!
             return
           end
 
@@ -91,7 +100,7 @@ module KubeclientExec
             if @options[:mode] == :adhoc
               @last_stdout = 1 if type == EXEC_STDOUT
               @last_stderr = 1 if type == EXEC_STDERR || EXEC_DCKERR
-              stop
+              stop!
             end
           end
 
@@ -112,7 +121,7 @@ module KubeclientExec
         end
 
         @ws.on(:close) do
-          stop
+          stop!
         end
 
         @ws.on(:open) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kubeclient_exec
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Wout Ceulemans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-20 00:00:00.000000000 Z
+date: 2024-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kubeclient
@@ -52,7 +52,8 @@ files:
 homepage: https://github.com/WoutDev/kubeclient_exec
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/WoutDev/kubeclient_exec
 post_install_message: 
 rdoc_options: []
 require_paths: