kuality-coeus 0.0.3 → 0.0.4

data/features/step_definitions/grants_gov/s2s_submission.rb

@@ -33,19 +33,44 @@ end
 Then /^the PHS training and fellowship questionnaires should appear in the proposal$/ do
   on(S2S).questions
   on Questions do |page|
-    %w{'PHS398 Training Budget V1-0',
-     'PHS Fellowship Form V1-2'}.each { |title| page.form_tab(title).should be_present }
+    ['PHS398 Training Budget V1-0',
+     'PHS Fellowship Form V1-2'].each { |title| page.form_tab(title).should be_present }
   end
 end
 
 When /^I? ?complete their respective questionnaires$/ do
-  #on(PHS398TrainingBudgetQuestionnaire).complete_phs_training_questionnaire
   @proposal.complete_phs_fellowship_questionnaire
 end
 
 Then /^the questionnaire titles should indicate that the questionnaires have been completed$/ do
+  on(S2S).questions
   on Questions do |page|
-    %w{PHS398 Training Budget V1-0
-     PHS Fellowship Form V1-2}.each { |form_tab| page.form_status(form_tab).should=='Complete'}
+    ['PHS398 Training Budget V1-0',
+     'PHS Fellowship Form V1-2'].each { |form_tab| page.form_status(form_tab).should=='Complete'}
   end
+end
+
+When /^I? ?add and mark complete all the required attachments$/ do
+  attachments = {
+      'RR-TEST-NIH-FORMS2' =>
+          %w{Equipment Bibliography BudgetJustification ProjectSummary Narrative Facilities
+          PHS_ResearchPlan_SpecificAims PHS_ResearchPlan_ResearchStrategy PHS_Cover_Letter},
+      'RR-FORMFAMILY-009-2010' =>
+          %w{BudgetJustification ProjectSummary Narrative},
+      'CAL-TEST-DOD2' =>
+          %w{BudgetJustification ProjectSummary Narrative},
+      'CAL-FDP-JAD' =>
+          %w{BudgetJustification},
+      'CSS-120809-SF424RR-V12' =>
+          %w{BudgetJustification ProjectSummary Narrative Budget_Justification_10YR
+          Budget_Justification_10YR_Fed_NonFed},
+      'RR-FORMFAMILY-004-2010' =>
+          %w{}
+  }
+  attachments[@proposal.opportunity_id].shuffle.each { |type| @proposal.add_proposal_attachment type: type, file_name: 'test.pdf', status: 'Complete' }
+  @proposal.key_personnel.each { |person| @proposal.add_personnel_attachment person: person.full_name, type: 'Biosketch', file_name: 'test.pdf' }
+end
+When(/^add a co-investigator$/) do
+  @proposal.add_key_person role: 'Co-Investigator'
+  on(KeyPersonnel).save
 end

data/features/step_definitions/proposal_development/create_proposal.rb

@@ -23,11 +23,11 @@ end
 
 When /^I? ?initiate a proposal but miss a required field$/ do
   # Pick a field at random for the test...
-  @required_field = ['Description', 'Proposal Type', 'Lead Unit', 'Activity Type',
+  @required_field = ['Description', 'Proposal Type', 'Activity Type',
            'Project Title', 'Sponsor Code', 'Project Start Date', 'Project End Date'
           ].sample
   # Properly set the nil value depending on the field type...
-  @required_field=~/Type/ || @required_field=='Lead Unit' ? value='select' : value=''
+  @required_field=~/Type/ ? value='select' : value=''
   # Transform the field name to the appropriate symbol...
   field = snake_case(@required_field)
   @proposal = create ProposalDevelopmentObject, field=>value
@@ -140,13 +140,6 @@ And /^I? ?add and mark complete all the required attachments for an NSF proposal
   end
 end
 
-When /^I? ?add and mark complete all the required attachments for an NIH proposal$/ do
-  %w{Equipment Bibliography BudgetJustification ProjectSummary Narrative Facilities
-     PHS_ResearchPlan_SpecificAims PHS_ResearchPlan_ResearchStrategy}
-  .shuffle.each { |type| @proposal.add_proposal_attachment type: type, file_name: 'test.pdf', status: 'Complete' }
-  @proposal.key_personnel.each { |person| @proposal.add_personnel_attachment person: person.full_name, type: 'Biosketch', file_name: 'test.pdf' }
-end
-
 Then /^I should see an error that says the field is required$/ do
   text="#{@required_field} is a required field."
   @required_field=='Description' ? error='Document '+text : error=text

data/features/step_definitions/proposal_development/edit_proposal.rb

@@ -30,7 +30,7 @@ Then /^The proposal route log's 'Pending Action Requests' should include '(.*)'$
 end
 
 Then /^The S2S tab should become available$/ do
-  @proposal.view :s2s
+  @proposal.view 'S2S'
   on(S2S).s2s_header.should be_present
 end
 
@@ -52,7 +52,7 @@ When /^I? ?push the proposal's project start date ahead a year$/ do
 end
 
 Then /^I can recall the proposal$/ do
-  @proposal.view :proposal
+  @proposal.view 'Proposal'
   on(Proposal).recall_button.should exist
 end
 
@@ -65,8 +65,7 @@ Given /^I? ?set the proposal type to '(\w+)'$/ do |type|
 end
 
 When /^I go to the proposal's (.*) page$/ do |page|
-  pages = { 'S2S'=>:s2s }
-  @proposal.view pages[page]
+  @proposal.view page
 end
 
 When /^I? ?save the proposal$/ do

data/features/step_definitions/proposal_development/key_personnel_validations.rb

@@ -1,6 +1,7 @@
 And /^I? ?add the (.*) user as an? (.*) to the key personnel proposal roles$/ do |user_role, proposal_role|
   user = get(user_role)
   @proposal.add_key_person first_name: user.first_name, last_name: user.last_name, role: proposal_role
+  @proposal.set_valid_credit_splits
 end
 
 When /^I? ?add (.*) as a Key Person with a role of (.*)$/ do |user_name, kp_role|
@@ -35,12 +36,15 @@ Then /^a key personnel error should say (.*)$/ do |error|
             'to select a valid unit' => 'Please select a valid Unit.',
             'a key person role is required' => 'Key Person Role is a required field.',
             'the credit split is not a valid percentage' => 'Credit Split is not a valid percentage.',
-            'the co-investigator requires at least one unit' => "At least one Unit is required for #{@proposal.key_personnel.co_investigator.full_name}.",
             'only one PI is allowed' => 'Only one proposal role of Principal Investigator is allowed.'
   }
   on(KeyPersonnel).errors.should include errors[error]
 end
 
+Then /^a key personnel error should appear, saying the co-investigator requires at least one unit$/ do
+  on(KeyPersonnel).errors.should include "At least one Unit is required for #{@proposal.key_personnel.co_investigator.full_name}."
+end
+
 When /^I? ?add a principal investigator$/ do
   @proposal.add_principal_investigator
 end
@@ -69,6 +73,11 @@ end
 When /^the (.*) user approves the proposal$/ do |role|
   get(role).sign_in
   @proposal.open_proposal
+
+
+sleep 20
+
+
   on(ProposalSummary).approve
   on(Confirmation).yes
 end

data/features/step_definitions/proposal_development/proposal_actions_validations.rb

@@ -12,15 +12,16 @@ end
 
 Then /^a validation error should say (.*)$/ do |error|
   errors = {'there is no principal investigator' => 'There is no Principal Investigator selected. Please enter a Principal Investigator.',
-  'proposal questions were not answered' => 'Answer is required for Question 1 in group A. Proposal Questions.',
   'sponsor deadline date not entered' => 'Sponsor deadline date has not been entered.',
   'questionnaire must be completed' => %|You must complete the questionnaire "S2S FAT & Flat Questionnaire"|,
-  'you must complete the compliance question' => 'Answer is required for Question 1 in group B. Compliance.',
-  'the investigator needs to be certified' => 'The Investigators are not all certified. Please certify Dick  COIAdmin.',
-  'the key person needs to be certified' => 'The Investigators are not all certified. Please certify Jeff  Covey.'}
+  'you must complete the compliance question' => 'Answer is required for Question 1 in group B. Compliance.'}
   on(ProposalActions).validation_errors_and_warnings.should include errors[error]
 end
 
+Then /^one of the errors should say the investigators aren't all certified$/ do
+  on(ProposalActions).validation_errors_and_warnings.should include "The Investigators are not all certified. Please certify #{@proposal.key_personnel[0].first_name}  #{@proposal.key_personnel[0].last_name}."
+end
+
 Then /^one of the validation errors should say that (.*)$/ do |error|
   errors = { 'an original proposal ID is needed'=>'Please provide an original institutional proposal ID that has been previously submitted to Grants.gov for a Change\/Corrected Application.',
              'the prior award number is required'=>'require the sponsor\'s prior award number in the "sponsor proposal number."'}
@@ -37,11 +38,11 @@ When /^I? ?initiate a proposal with an un-certified (.*)$/ do |role|
   @proposal.add_key_person role: @role, certified: false
 end
 
-Given /^I? ?initiate a proposal where the un-certified key person has certification questions$/ do
+Given /^I? ?initiate a proposal where the un-certified key person has included certification questions$/ do
   @role = 'Key Person'
   @proposal = create ProposalDevelopmentObject
   @proposal.add_key_person role: @role, key_person_role: 'default', certified: false
-  on(KeyPersonnel).include_certification_questions @proposal.key_personnel.uncertified_key_person(@role).full_name
+  on(KeyPersonnel).include_certification_questions @proposal.key_personnel.uncertified_person(@role).full_name
 end
 
 Then /^checking the key personnel page shows an error that says (.*)$/ do |error|

data/features/step_definitions/proposal_development/proposal_permissions.rb

@@ -1,10 +1,5 @@
 When /^I? ?visit the proposal's (.*) page$/ do |page|
-  # Ensure we're where we need to be in the system...
-  @proposal.open_document
-  # Be sure that the page name used in the scenario
-  # will be converted to the snake case value of
-  # the method that clicks on the proposal's page tab.
-  on(Proposal).send(snake_case(page))
+  @proposal.view page
 end
 
 Then /^the (.*) user is listed as an? (.*) in the proposal permissions$/ do |username, role|
@@ -23,20 +18,10 @@ Then /^the (.*) user can access the proposal$/ do |role|
   on(Researcher).error_table.should_not be_present
 end
 
-Then /^the proposal is in the (.*) user's action list$/ do |username|
-  get(username).sign_in
-  visit(ActionList).filter
-  on ActionListFilter do |page|
-    page.document_title.set @proposal.project_title
-    page.filter
-  end
-  on(ActionList).item_row(@proposal.document_id).should exist
-end
-
-And /^their proposal permissions allow them to only update the Abstracts and Attachments page$/ do
-  on(Proposal).abstracts_and_attachments
-  @proposal.close
-  on(Confirmation).yes
+Then /^their proposal permissions do not allow them to edit budget details$/ do
+  expect{@proposal.edit(project_title: 'edit')}.not_to raise_error
+  expect{@budget_version.open_budget}.not_to raise_error
+  expect{@budget_version.edit(total_direct_cost_limit: '100')}.should raise_error(Watir::Exception::UnknownObjectException, /unable to locate element/)
 end
 
 And /^their proposal permissions allow them to edit all parts of the proposal$/ do
@@ -61,10 +46,6 @@ And /^their proposal permissions allow them to edit all parts of the proposal$/
     page.proposal_actions
   end
   on ProposalActions do |page|
-    page.save_button.should be_present
-    page.questions
-  end
-  on Questions do |page|
     page.save_button.should be_present
     page.special_review
   end
@@ -73,62 +54,67 @@ And /^their proposal permissions allow them to edit all parts of the proposal$/
   end
 end
 
-And /^their proposal permissions allow them to only update the budget$/ do
-      on(Proposal).budget_versions
-      @proposal.close
-      on(Confirmation).yes
+And /^their proposal permissions allow them to update the budget, not the narrative$/ do
+  expect{
+    @proposal.add_proposal_attachment file_name: 'test.pdf', type: 'Narrative'
+  }.should raise_error
+  expect{@proposal.add_budget_version}.not_to raise_error
 end
 
 And /^their proposal permissions allow them to only read the proposal$/ do
-      on Proposal do |page|
-        page.save_button.should_not be_present
-        page.abstracts_and_attachments
-      end
-      on AbstractsAndAttachments do |page|
-        page.save_button.should_not be_present
-        page.custom_data
-      end
-      on PDCustomData do |page|
-        page.save_button.should_not be_present
-        page.key_personnel
-      end
-      on KeyPersonnel do |page|
-        page.save_button.should_not be_present
-        page.permissions
-      end
-      on Permissions do |page|
-        page.save_button.should_not be_present
-        page.proposal_actions
-      end
-      on ProposalActions do |page|
-        page.save_button.should_not be_present
-        page.questions
-      end
-      on Questions do |page|
-        page.save_button.should_not be_present
-        page.special_review
-      end
-      on SpecialReview do |page|
-        page.save_button.should_not be_present
-      end
+  on Proposal do |page|
+    page.save_button.should_not be_present
+    page.abstracts_and_attachments
+  end
+  on AbstractsAndAttachments do |page|
+    page.save_button.should_not be_present
+    page.custom_data
+  end
+  on PDCustomData do |page|
+    page.save_button.should_not be_present
+    page.key_personnel
+  end
+  on KeyPersonnel do |page|
+    page.save_button.should_not be_present
+    page.permissions
+  end
+  on Permissions do |page|
+    page.save_button.should_not be_present
+    page.proposal_actions
+  end
+  on ProposalActions do |page|
+    page.save_button.should_not be_present
+    page.special_review
+  end
+  on SpecialReview do |page|
+    page.save_button.should_not be_present
+  end
 end
 
 And /^their proposal permissions allow them to delete the proposal$/ do
-      on(Proposal).proposal_actions
-      @proposal.delete
+  on(Proposal).proposal_actions
+  lambda{@proposal.delete}.should_not raise_error
 end
 
 Then /^there should be an error message that says not to select other roles alongside aggregator$/ do
-   on(Roles).errors.should include 'Do not select other roles when Aggregator is selected.'
+  on(Roles).errors.should include 'Do not select other roles when Aggregator is selected.'
 end
 
 When /^I? ?attempt to add an additional proposal role to the (.*) user$/ do |system_role|
-  role = [:viewer, :budget_creator, :narrative_writer, :aggregator].sample
-  on(Permissions).edit_role.(get(system_role).user_name)
+  if system_role=='Proposal Creator'
+    role='aggregator'
+  else
+    role=system_role
+  end
+  role_to_add = ([:viewer, :budget_creator, :narrative_writer, :aggregator]-[StringFactory.damballa(role)]).sample
+  on(Permissions).edit_role(get(system_role).user_name)
   on Roles do |page|
     page.use_new_tab
-    page.send(role).set
+    page.send(role_to_add).set
     page.save
+    # Note: This step def does not go beyond clicking the Save button here
+    # because the expectation is that the Roles window will not close,
+    # but will instead display an error message.
   end
 end
 

data/features/step_definitions/proposal_development/proposal_workflow.rb

@@ -21,14 +21,6 @@ When /^I? ?send a notification to the (.*) users?$/ do |role|
   on(NotificationEditor).send_fyi
 end
 
-When /^I? ?recall the proposal for revisions$/ do
-  @proposal.recall :revisions
-end
-
-When /^I? ?recall and cancel the proposal$/ do
-  @proposal.recall :cancel
-end
-
 Then /^the proposal status should be (.*)$/ do |status|
   @proposal.status.should == status
 end
@@ -62,13 +54,6 @@ Then /^I can acknowledge the requested action list item$/ do
 end
 
 When /^I? ?submit the routed proposal to the sponsor$/ do
-
-
-
-sleep 30
-
-
-
   @proposal.submit :to_sponsor
 end
 

data/features/step_definitions/test.rb

@@ -1,3 +1 @@
-Then /^add a subaward budget$/ do
-  @budget_version.add_subaward_budget
-end
+

data/features/step_definitions/users.rb

@@ -7,7 +7,7 @@
 #    a class instance variable based on the username
 # 3) Logs that user in (if they're not already)...
 Given /^I'm logged in with (.*)$/ do |username|
-  user = make_user username
+  user = make_user user: username
   user.sign_in
 end
 
@@ -26,7 +26,7 @@ end
 # 2) Creates the user in the system if they don't exist already,
 #    by first logging in with the admin user
 Given /^a user exists with the user name (.*)$/ do |username|
-  user = make_user username
+  user = make_user user: username
   user.create unless user.exists?
 end
 
@@ -36,7 +36,7 @@ end
 # them if they don't exist in the system (again by first
 # logging in with the admin user to do the creation).
 Given /^a user exists with the system role: '(.*)'$/ do |role|
-  user = make_role role
+  user = make_user role: role
   user.create unless user.exists?
 end
 
@@ -46,7 +46,7 @@ end
 
 Given /^users exist with the following roles: (.*)$/ do |roles|
   roles.split(', ').each do |r|
-    user = make_role r
+    user = make_user role: r
     user.create unless user.exists?
   end
 end
@@ -54,12 +54,12 @@ end
 Given /^a user exists that can be a PI for Grants.gov proposals$/ do
   # TODO: Make this more robust when we really know what it takes
   # to be a grants.gov PI...
-  @grants_gov_pi = make_user UserObject::USERS.era_commons_user('grantsgov')
+  @grants_gov_pi = make_user user: UserObject::USERS.era_commons_user('grantsgov')
   @grants_gov_pi.create unless @grants_gov_pi.exists?
 end
 
 Given /^an AOR user exists$/ do
   # TODO: Using the quickstart user here is cheating. Fix this.
-  @aor = make_user 'quickstart'
+  @aor = make_user user: 'quickstart'
   @aor.create unless @aor.exists?
 end

data/features/support/env.rb

@@ -3,7 +3,7 @@ require 'yaml'
 @config = YAML.load_file("#{File.dirname(__FILE__)}/config.yml")[:basic]
 
 $base_url = @config[:url]
-$file_folder = @config[:files]
+$file_folder = "#{File.dirname(__FILE__)}/../../lib/resources/"
 
 if @config[:browser]==:saucelabs
   sauce = YAML.load_file("#{File.dirname(__FILE__)}/config.yml")[:saucelabs]

data/features/test.feature

@@ -10,4 +10,6 @@ Feature: Submitting Proposals via s2s to Grants.gov
   Scenario: bal
     Given I initiate a proposal with NIH as the sponsor
     And   create a budget version for the proposal
-    And   add a subaward budget
+    And   add an employee to the budget's project personnel
+    And   add a non-employee to the budget's project personnel
+    And   add a to-be-named person to the budget's project personnel

data/kuality-coeus.gemspec

@@ -1,6 +1,6 @@
 spec = Gem::Specification.new do |s|
   s.name = 'kuality-coeus'
-  s.version = '0.0.3'
+  s.version = '0.0.4'
   s.summary = %q{rSmart's test framework for BDD testing of Kuali Coeus}
   s.description = %q{This gem is used for creating test scripts for Kuali Coeus.}
   s.files = Dir.glob("**/**/**")

data/lib/kuality-coeus.rb

@@ -1,11 +1,11 @@
 require 'test-factory'
 require 'date'
 require 'yaml'
-Dir["#{File.dirname(__FILE__)}/kuality-coeus/*.rb"].each {|f| require f }
-Dir["#{File.dirname(__FILE__)}/kuality-coeus/page_objects/*.rb"].each {|f| require f }
-Dir["#{File.dirname(__FILE__)}/kuality-coeus/page_objects/*/*.rb"].each {|f| require f }
-Dir["#{File.dirname(__FILE__)}/kuality-coeus/data_objects/*.rb"].each {|f| require f }
-Dir["#{File.dirname(__FILE__)}/kuality-coeus/data_objects/*/*.rb"].each {|f| require f }
+Dir["#{File.dirname(__FILE__)}/kuality-coeus/*.rb"].alphabetize.each {|f| require f }
+Dir["#{File.dirname(__FILE__)}/kuality-coeus/page_objects/*.rb"].alphabetize.each {|f| require f }
+Dir["#{File.dirname(__FILE__)}/kuality-coeus/page_objects/*/*.rb"].alphabetize.each {|f| require f }
+Dir["#{File.dirname(__FILE__)}/kuality-coeus/data_objects/*.rb"].alphabetize.each {|f| require f }
+Dir["#{File.dirname(__FILE__)}/kuality-coeus/data_objects/*/*.rb"].alphabetize.each {|f| require f }
 
 # Initialize this class at the start of your test cases to
 # open the specified test browser at the specified welcome page URL.