kt-paperclip 5.4.0 → 7.1.1

data/spec/paperclip/url_generator_spec.rb

@@ -1,5 +1,4 @@
-# encoding: utf-8
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::UrlGenerator do
   it "uses the given interpolator" do
@@ -25,20 +24,20 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(default_url),
-      "expected the interpolator to be passed #{default_url.inspect} but it wasn't"
+           "expected the interpolator to be passed #{default_url.inspect} but it wasn't"
   end
 
   it "executes the default URL lambda when no file is assigned" do
     mock_interpolator = MockInterpolator.new
-    default_url = lambda {|attachment| "the #{attachment.class.name} default url" }
-    options = { interpolator: mock_interpolator, default_url: default_url}
+    default_url = lambda { |attachment| "the #{attachment.class.name} default url" }
+    options = { interpolator: mock_interpolator, default_url: default_url }
     mock_attachment = MockAttachment.new(options)
 
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?("the MockAttachment default url"),
-      %{expected the interpolator to be passed "the MockAttachment default url", but it wasn't}
+           %{expected the interpolator to be passed "the MockAttachment default url", but it wasn't}
   end
 
   it "executes the method named by the symbol as the default URL when no file is assigned" do
@@ -56,7 +55,7 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(mock_model.to_s),
-      %{expected the interpolator to be passed #{mock_model.to_s}, but it wasn't}
+           %{expected the interpolator to be passed #{mock_model}, but it wasn't}
   end
 
   it "URL-escapes spaces if asked to" do
@@ -66,7 +65,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: true})
+    result = url_generator.for(:style_name, escape: true)
 
     assert_equal "the%20expected%20result", result
   end
@@ -82,7 +81,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: true})
+    result = url_generator.for(:style_name, escape: true)
 
     assert_equal "the escaped result", result
   end
@@ -94,7 +93,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {escape: false})
+    result = url_generator.for(:style_name, escape: false)
 
     assert_equal "the expected result", result
   end
@@ -118,7 +117,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal expected, result
   end
@@ -134,7 +133,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal expected, result
   end
@@ -147,7 +146,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal "#{expected}?#{updated_at}", result
   end
@@ -160,7 +159,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: true})
+    result = url_generator.for(:style_name, timestamp: true)
 
     assert_equal "#{expected}&#{updated_at}", result
   end
@@ -173,7 +172,7 @@ describe Paperclip::UrlGenerator do
     mock_attachment = MockAttachment.new(options)
     url_generator = Paperclip::UrlGenerator.new(mock_attachment)
 
-    result = url_generator.for(:style_name, {timestamp: false})
+    result = url_generator.for(:style_name, timestamp: false)
 
     assert_equal expected, result
   end
@@ -192,7 +191,7 @@ describe Paperclip::UrlGenerator do
     url_generator.for(:style_name, {})
 
     assert mock_interpolator.has_interpolated_pattern?(expected),
-      "expected the interpolator to be passed #{expected.inspect} but it wasn't"
+           "expected the interpolator to be passed #{expected.inspect} but it wasn't"
   end
 
   it "doesn't emit deprecation warnings" do
@@ -206,7 +205,7 @@ describe Paperclip::UrlGenerator do
   end
 
   describe "should be able to escape (, ), [, and ]." do
-    def generate(expected, updated_at=nil)
+    def generate(expected, updated_at = nil)
       mock_interpolator = MockInterpolator.new(result: expected)
       options = { interpolator: mock_interpolator, updated_at: updated_at }
       mock_attachment = MockAttachment.new(options)
@@ -214,7 +213,7 @@ describe Paperclip::UrlGenerator do
       def url_generator.respond_to(params)
         false if params == :escape
       end
-      url_generator.for(:style_name, {escape: true, timestamp: !!updated_at})
+      url_generator.for(:style_name, escape: true, timestamp: !!updated_at)
     end
 
     it "not timestamp" do
@@ -226,7 +225,7 @@ describe Paperclip::UrlGenerator do
       expected = "the(expected)result[]"
       updated_at = 1231231234
       assert_equal "the%28expected%29result%5B%5D?#{updated_at}",
-        generate(expected, updated_at)
+                   generate(expected, updated_at)
     end
   end
 end

data/spec/paperclip/validators/attachment_content_type_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentContentTypeValidator do
   before do
@@ -8,14 +8,14 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
 
   def build_validator(options)
     @validator = Paperclip::Validators::AttachmentContentTypeValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                             attributes: :avatar
+                                                                           ))
   end
 
   context "with a nil content type" do
     before do
       build_validator content_type: "image/jpg"
-      @dummy.stubs(avatar_content_type: nil)
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
       @validator.validate(@dummy)
     end
 
@@ -28,7 +28,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as true" do
       before do
         build_validator content_type: "image/png", allow_nil: true
-        @dummy.stubs(avatar_content_type: nil)
+        allow(@dummy).to receive_messages(avatar_content_type: nil)
         @validator.validate(@dummy)
       end
 
@@ -40,7 +40,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as false" do
       before do
         build_validator content_type: "image/png", allow_nil: false
-        @dummy.stubs(avatar_content_type: nil)
+        allow(@dummy).to receive_messages(avatar_content_type: nil)
         @validator.validate(@dummy)
       end
 
@@ -53,13 +53,13 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
   context "with a failing validation" do
     before do
       build_validator content_type: "image/png", allow_nil: false
-      @dummy.stubs(avatar_content_type: nil)
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
       @validator.validate(@dummy)
     end
 
     it "adds error to the base object" do
       assert @dummy.errors[:avatar].present?,
-        "Error not added to base attribute"
+             "Error not added to base attribute"
     end
 
     it "adds error to base object as a string" do
@@ -67,16 +67,104 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     end
   end
 
+  context "with add_validation_errors_to not set (implicitly :both)" do
+    it "adds error to both attribute and base" do
+      build_validator content_type: "image/png", allow_nil: false
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_content_type].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :attribute
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to attribute not base" do
+      build_validator content_type: "image/png", allow_nil: false
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_content_type].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :base
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to base not attribute" do
+      build_validator content_type: "image/png", allow_nil: false
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_content_type].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute" do
+    it "only adds error to attribute not base" do
+      build_validator content_type: "image/png", allow_nil: false,
+        add_validation_errors_to: :attribute
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_content_type].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base" do
+    it "only adds error to base not attribute" do
+      build_validator content_type: "image/png", allow_nil: false,
+        add_validation_errors_to: :base
+      allow(@dummy).to receive_messages(avatar_content_type: nil)
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_content_type].blank?,
+             "Error added to attribute"
+    end
+  end
+
   context "with a successful validation" do
     before do
       build_validator content_type: "image/png", allow_nil: false
-      @dummy.stubs(avatar_content_type: "image/png")
+      allow(@dummy).to receive_messages(avatar_content_type: "image/png")
       @validator.validate(@dummy)
     end
 
     it "does not add error to the base object" do
       assert @dummy.errors[:avatar].blank?,
-        "Error was added to base attribute"
+             "Error was added to base attribute"
     end
   end
 
@@ -84,7 +172,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as true" do
       before do
         build_validator content_type: "image/png", allow_blank: true
-        @dummy.stubs(avatar_content_type: "")
+        allow(@dummy).to receive_messages(avatar_content_type: "")
         @validator.validate(@dummy)
       end
 
@@ -96,7 +184,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     context "as false" do
       before do
         build_validator content_type: "image/png", allow_blank: false
-        @dummy.stubs(avatar_content_type: "")
+        allow(@dummy).to receive_messages(avatar_content_type: "")
         @validator.validate(@dummy)
       end
 
@@ -111,7 +199,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator content_type: "image/jpg"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -123,7 +211,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as an regexp" do
         before do
           build_validator content_type: /^image\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -135,7 +223,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a list" do
         before do
           build_validator content_type: ["image/png", "image/jpg", "image/jpeg"]
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -149,7 +237,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator content_type: "image/png"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -162,7 +250,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a regexp" do
         before do
           build_validator content_type: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -176,7 +264,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "without interpolation" do
           before do
             build_validator content_type: "image/png", message: "should be a PNG image"
-            @dummy.stubs(avatar_content_type: "image/jpg")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
             @validator.validate(@dummy)
           end
 
@@ -188,7 +276,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "with interpolation" do
           before do
             build_validator content_type: "image/png", message: "should have content type %{types}"
-            @dummy.stubs(avatar_content_type: "image/jpg")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
             @validator.validate(@dummy)
           end
 
@@ -205,7 +293,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator not: "image/gif"
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -217,7 +305,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as an regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "image/jpg")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/jpg")
           @validator.validate(@dummy)
         end
 
@@ -229,7 +317,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a list" do
         before do
           build_validator not: ["image/png", "image/jpg", "image/jpeg"]
-          @dummy.stubs(avatar_content_type: "image/gif")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/gif")
           @validator.validate(@dummy)
         end
 
@@ -243,7 +331,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a string" do
         before do
           build_validator not: "image/png"
-          @dummy.stubs(avatar_content_type: "image/png")
+          allow(@dummy).to receive_messages(avatar_content_type: "image/png")
           @validator.validate(@dummy)
         end
 
@@ -256,7 +344,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
       context "as a regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_content_type: "text/plain")
+          allow(@dummy).to receive_messages(avatar_content_type: "text/plain")
           @validator.validate(@dummy)
         end
 
@@ -270,7 +358,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "without interpolation" do
           before do
             build_validator not: "image/png", message: "should not be a PNG image"
-            @dummy.stubs(avatar_content_type: "image/png")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/png")
             @validator.validate(@dummy)
           end
 
@@ -282,7 +370,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
         context "with interpolation" do
           before do
             build_validator not: "image/png", message: "should not have content type %{types}"
-            @dummy.stubs(avatar_content_type: "image/png")
+            allow(@dummy).to receive_messages(avatar_content_type: "image/png")
             @validator.validate(@dummy)
           end
 
@@ -300,7 +388,7 @@ describe Paperclip::Validators::AttachmentContentTypeValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_content_type }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_content_type }
     end
   end
 

data/spec/paperclip/validators/attachment_file_name_validator_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Paperclip::Validators::AttachmentFileNameValidator do
   before do
@@ -8,20 +8,20 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
   def build_validator(options)
     @validator = Paperclip::Validators::AttachmentFileNameValidator.new(options.merge(
-      attributes: :avatar
-    ))
+                                                                          attributes: :avatar
+                                                                        ))
   end
 
   context "with a failing validation" do
     before do
       build_validator matches: /.*\.png$/, allow_nil: false
-      @dummy.stubs(avatar_file_name: "data.txt")
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
       @validator.validate(@dummy)
     end
 
     it "adds error to the base object" do
       assert @dummy.errors[:avatar].present?,
-        "Error not added to base attribute"
+             "Error not added to base attribute"
     end
 
     it "adds error to base object as a string" do
@@ -29,9 +29,99 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     end
   end
 
+  context "with add_validation_errors_to not set (implicitly :both)" do
+    it "adds error to both attribute and base" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :attribute
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to attribute not base" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base globally" do
+    before do
+      Paperclip.options[:add_validation_errors_to] = :base
+    end
+
+    after do
+      Paperclip.options[:add_validation_errors_to] = :both
+    end
+
+    it "only adds error to base not attribute" do
+      build_validator matches: /.*\.png$/, allow_nil: false
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_name].blank?,
+             "Error added to attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :attribute" do
+    it "only adds error to attribute not base" do
+      build_validator matches: /.*\.png$/, allow_nil: false,
+                      add_validation_errors_to: :attribute
+
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar_file_name].present?,
+             "Error not added to attribute"
+
+      assert @dummy.errors[:avatar].blank?,
+             "Error added to base attribute"
+    end
+  end
+
+  context "with add_validation_errors_to set to :base" do
+    it "only adds error to base not attribute" do
+      build_validator matches: /.*\.png$/, allow_nil: false,
+                      add_validation_errors_to: :base
+
+      allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
+      @validator.validate(@dummy)
+
+      assert @dummy.errors[:avatar].present?,
+             "Error not added to base attribute"
+
+      assert @dummy.errors[:avatar_file_name].blank?,
+             "Error added to attribute"
+    end
+  end
+
   it "does not add error to the base object with a successful validation" do
     build_validator matches: /.*\.png$/, allow_nil: false
-    @dummy.stubs(avatar_file_name: "image.png")
+    allow(@dummy).to receive_messages(avatar_file_name: "image.png")
     @validator.validate(@dummy)
 
     assert @dummy.errors[:avatar].blank?, "Error was added to base attribute"
@@ -42,7 +132,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a single regexp" do
         before do
           build_validator matches: /.*\.jpg$/
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -54,7 +144,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a list" do
         before do
           build_validator matches: [/.*\.png$/, /.*\.jpe?g$/]
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -67,7 +157,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     context "with a disallowed type" do
       it "sets a correct default error message" do
         build_validator matches: /^text\/.*/
-        @dummy.stubs(avatar_file_name: "image.jpg")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
         @validator.validate(@dummy)
 
         assert @dummy.errors[:avatar_file_name].present?
@@ -76,7 +166,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
       it "sets a correct custom error message" do
         build_validator matches: /.*\.png$/, message: "should be a PNG image"
-        @dummy.stubs(avatar_file_name: "image.jpg")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
         @validator.validate(@dummy)
 
         expect(@dummy.errors[:avatar_file_name]).to include "should be a PNG image"
@@ -89,7 +179,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a single regexp" do
         before do
           build_validator not: /^text\/.*/
-          @dummy.stubs(avatar_file_name: "image.jpg")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.jpg")
           @validator.validate(@dummy)
         end
 
@@ -101,7 +191,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
       context "as a list" do
         before do
           build_validator not: [/.*\.png$/, /.*\.jpe?g$/]
-          @dummy.stubs(avatar_file_name: "image.gif")
+          allow(@dummy).to receive_messages(avatar_file_name: "image.gif")
           @validator.validate(@dummy)
         end
 
@@ -114,7 +204,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     context "with a disallowed type" do
       it "sets a correct default error message" do
         build_validator not: /data.*/
-        @dummy.stubs(avatar_file_name: "data.txt")
+        allow(@dummy).to receive_messages(avatar_file_name: "data.txt")
         @validator.validate(@dummy)
 
         assert @dummy.errors[:avatar_file_name].present?
@@ -123,7 +213,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
 
       it "sets a correct custom error message" do
         build_validator not: /.*\.png$/, message: "should not be a PNG image"
-        @dummy.stubs(avatar_file_name: "image.png")
+        allow(@dummy).to receive_messages(avatar_file_name: "image.png")
         @validator.validate(@dummy)
 
         expect(@dummy.errors[:avatar_file_name]).to include "should not be a PNG image"
@@ -137,7 +227,7 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     end
 
     it "adds the validator to the class" do
-      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_file_name }
+      assert Dummy.validators_on(:avatar).any? { |validator| validator.kind == :attachment_file_name }
     end
   end
 
@@ -157,4 +247,3 @@ describe Paperclip::Validators::AttachmentFileNameValidator do
     end
   end
 end
-