krikri 0.5.4 → 0.5.5

data/spec/lib/krikri/enrichments/move_non_dcmi_type_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::MoveNonDcmiType do
+  it_behaves_like 'a generic enrichment'
+
+  it 'returns strings as found' do
+    string = 'moomin'
+    expect(subject.enrich_value(string)).to eq string
+  end
+
+  it 'returns typed data as found' do
+    date = Date.today
+    expect(subject.enrich_value(date)).to eq date
+  end
+
+  it 'returns Resources as found' do
+    resource = ActiveTriples::Resource.new
+    expect(subject.enrich_value(resource)).to eq resource
+  end
+
+  it 'returns nil for DCMI Type values' do
+    resource = DPLA::MAP::Controlled::DCMIType.new
+    expect(subject.enrich_value(resource)).to be_nil
+  end
+end

data/spec/lib/krikri/enrichments/move_non_dcmi_type_spec.rb~

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::MoveNonDcmiType do
+  it_behaves_like 'an enrichment'

data/spec/lib/krikri/enrichments/parse_date_spec.rb~

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripPunctuation do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => '',
+              :start => "\tmoominpapa;... !@#$ moominmama  ",
+              :end => "\tmoominpapa  moominmama  "
+            },
+            { :string => 'leaves other fields unaltered',
+              :start => "\tmoominpapa moominmama",
+              :end => "\tmoominpapa moominmama"
+            }]
+
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/split_coordinates_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::SplitCoordinates do
+  it_behaves_like 'a field enrichment'
+
+  context 'with place object' do
+    let(:lat) { nil }
+    let(:long) { nil }
+    let(:place) { build(:place, lat: lat, long: long) }
+
+    shared_examples 'latitude and longitude' do |expected_lat, expected_long|
+      it 'assigns latitude' do
+        expect(subject.enrich_value(place).lat).to eq expected_lat
+      end
+      it 'assigns longitude' do
+        expect(subject.enrich_value(place).long).to eq expected_long
+      end
+    end
+
+    shared_examples 'nonsensical coordinates' do
+      it 'retains original coordinates' do
+        rv = subject.enrich_value(place)
+        expect(rv.lat).to eq [lat].compact
+        expect(rv.long).to eq [long].compact
+      end
+    end
+
+    context 'with latitude first' do
+      let(:lat) { '40.7127,74.0059' }
+      include_examples 'latitude and longitude', ['40.7127'], ['74.0059']
+    end
+
+    context 'with longitude first' do
+      let(:long) { '40.7127,74.0059' }
+      include_examples 'latitude and longitude', ['74.0059'], ['40.7127']
+    end
+
+    context 'with a space character' do
+      let(:lat) { '40.7127, 74.0059' }
+      include_examples 'latitude and longitude', ['40.7127'], ['74.0059']
+    end
+
+    context 'with a latitude that does not split' do
+      let(:lat) { '40.0' }
+      include_examples 'nonsensical coordinates'
+    end
+
+    context 'with a latitude that splits into too many values' do
+      let(:lat) { '1.0,2.0,3.0' }
+      include_examples 'nonsensical coordinates'
+    end
+
+    context 'with a latitude containing non-decimal characters' do
+      let(:lat) { '10.0,10;' }
+      include_examples 'nonsensical coordinates'
+    end
+  end  # context 'with place object'
+
+  context 'with something other than a place object' do
+    it 'returns the given object' do
+      val = 'something'
+      expect(subject.enrich_value(val)).to equal val
+    end
+  end
+end

data/spec/lib/krikri/enrichments/strip_ending_punctuation_spec.rb~

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripLeadingPunctuation do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => 'removes punctuation from beginning of field',
+              :start => "([!.;:\tmoominpapa;:;:; moominmama! ...\n",
+              :end => "\tmoominpapa;:;:; moominmama! ...\n"
+            },
+            { :string => 'leaves other fields unaltered',
+              :start => "'moominpapa;:;:; moominmama! ...\n'",
+              :end => "'moominpapa;:;:; moominmama! ...\n'"
+            }]
+
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/strip_leading_colons_spec.rb~

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripLeadingColons do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => 'removes (semi)colons from beginning of field',
+              :start => "\tmoominpapa;... !@#$ moominmama  ",
+              :end => "\tmoominpapa  moominmama  "
+            },
+            { :string => 'leaves other fields unaltered',
+              :start => "\tmoominpapa;:;:; moominmama",
+              :end => "\tmoominpapa;:;:; moominmama"
+            }]
+
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/strip_leading_punctuation_spec.rb~

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripLeadingPunctuation do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => 'removes punctuation from beginning of field',
+              :start => ";:\tmoominpa()pa;;;",
+              :end => "\tmoominpa()pa;;;"
+            },
+            { :string => 'leaves other fields unaltered',
+              :start => ";:\tmoominpapa;:;:; moominmama! ...\n",
+              :end => "\tmoominpapa;:;:; moominmama! ...\n"
+            }]
+
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/timespan_spec.rb~

@@ -0,0 +1,10 @@
+module Krikri::Enrichments
+  ##
+  # Normalizes date strings to EDTF or Date objects.
+  #
+
+  class ParseDate
+    include Krikri::FieldEnrichment
+
+    def enrich_value(value)
+    end

data/spec/lib/krikri/enrichments/timespan_split_spec.rb~

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::TimespanSplit do
+  it_behaves_like 'a field enrichment'
+
+  let(:timespan) do
+    build(:timespan, providedLabel: label, begin: begin_date, end: end_date)
+  end
+  let(:label) { nil }
+  let(:begin_date) { nil }
+  let(:end_date) { nil }
+
+  context 'with a non-timespan object' do
+    it 'returns nil' do
+      expect(subject.enrich_value(RDF::Node.new)).to be nil
+    end
+  end
+
+  context 'with string' do
+  end
+
+  context 'with timespan label' do
+    let(:label) { '1642 - 1726?' }
+
+    it do
+      subject.enrich_value(timespan)
+    end
+  end
+
+  describe '#partial_edtf' do
+    context 'with YYYY-MM-DD/DD' do
+      let(:start_date) { Date.new(2014,1,27) }
+      let(:end_date) { Date.new(2014,1,28) }
+
+      it 'parses date' do
+        expect(subject.partial_edtf('2014-01-27/28'))
+          .to have_attributes(:from => start_date,:to => end_date)
+      end
+
+      it 'gives nil for invalid date' do
+        expect(subject.partial_edtf('2014-01-98/28')).to eq nil
+      end
+    end
+
+    context 'with YYYY-MM/MM' do
+      let(:start_date) { Date.new(2014,1,1) }
+      let(:end_date) { Date.new(2014,3,1) }
+
+      it 'parses date' do
+        expect(subject.partial_edtf('2014-01/03'))
+          .to have_attributes(:from => start_date,:to => end_date)
+      end
+
+      it 'gives nil for invalid date' do
+        expect(subject.partial_edtf('2014-33/03')).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/krikri/harvesters/api_harvester_spec.rb~

@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe Krikri::Harvesters::ApiHarvester do
+  it_behaves_like 'a harvester'
+
+  let(:args) { { uri: 'http://example.org/endpoint' } }
+  subject { described_class.new(args) }
+
+  shared_context 'with responses' do
+    let(:query_opts) { { :q => 'tags_ssim:dpla' } }
+    let(:response_string) do
+      <<EOM
+{ "response": {
+    "numFound": 467354,
+    "start": 0,
+    "docs": []
+  }
+}
+EOM
+    end
+
+    before do
+      allow(RestClient).to recieve(:get).with(args[:uri], query_opts)
+                            .and_return(response_string)
+    end
+  end
+
+  describe '#new' do
+    it 'accepts api parameters' do
+      described_class.new()
+      require 'pry'
+      binding.pry
+    end
+  end
+
+  describe '.expected_opts' do
+    it 'returns a hash with key and options' do
+    end
+  end
+
+  describe '#count' do
+    it 'returns a count' do
+      expect(subject.count).to eq 100
+    end
+  end
+end

data/spec/lib/krikri/harvesters/basic_save_behavior_spec.rb~

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::BasicSaveBehavior do
+  it_behaves_like 'a harvest behavior'
+
+  subject { described_class.new(record, activity_uri) }
+
+
+  describe '#process_record' do
+    it ''
+  end
+end

data/spec/lib/krikri/harvesters/file_harvester_spec.rb~

@@ -0,0 +1,3 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::FileHarvester do

data/spec/lib/krikri/harvesters/harvest_behavior_spec.rb~

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::HarvestBehavior do
+  it_behaves_like 'a harvest behavior'
+end

data/spec/lib/krikri/harvesters/mdl_api_harvester_spec.rb~

@@ -0,0 +1,11 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe Krikri::Harvesters::MdlApiHarvester do
+  it_behaves_like 'a harvester'
+
+  let(:args) { { uri: 'http://example.org/endpoint' } }
+  subject { described_class.new(args) }
+
+
+end

data/spec/lib/krikri/harvesters/mdl_harvester_spec.rb~

@@ -0,0 +1,8 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::MdlHarvester do
+  let(:args) { { uri: 'http://example.org/endpoint', api: query_opts } }
+  let(:query_opts) { {} }
+  subject { described_class.new(args) }
+
+end

data/spec/lib/krikri/harvesters/oai_skip_deleted_behavior.rb~

@@ -0,0 +1,7 @@
+module Krikri::Harvesters
+  class BasicSaveBehavior < HarvestBehavior
+    def process_record
+      record.save(activity_uri)
+    end
+  end
+end

data/spec/lib/krikri/harvesters/oai_skip_deleted_behavior_spec.rb~

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::OAISkipDeletedBehavior do
+  it_behaves_like 'a harvest behavior'
+
+  subject { described_class.new(record, activity_uri) }
+  let(:record) { double('record') }
+  let(:activity_uri) { double('activity URI') }
+
+  describe '#process_record' do
+    it 'calls save when record is not deleted' do
+      expect(record).to receive(:save).with(activity_uri)
+    end
+  end
+end

data/spec/lib/krikri/id_service_spec.rb~

@@ -0,0 +1,3 @@
+require 'spec_helper'
+
+describe Krikri::IdService do

data/spec/lib/krikri/job_spec.rb~

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Krikri::Job do
+  describe '.perform' do
+    it 'calls run on activity by id' do
+      activity_id = 1
+      activity = double('activity')
+    end
+  end
+
+  describe '.run' do
+  end
+end

data/spec/lib/krikri/mapper_agent_spec.rb~

@@ -0,0 +1,64 @@
+describe Krikri::Mapper::Agent do
+  opts = { name: :agent_map, generator_uri: 'http://example.org/agent/gen/1' }
+  it_behaves_like 'a software agent', opts, Krikri::MappingJob
+
+  subject { described_class.new(opts) }
+
+  let(:generator_uri) { 'http://example.org/agent/gen/1' }
+  let(:activity_uri) { 'http://example.org/agent/act/1' }
+  let(:mapping_name) { :agent_map }
+  let(:opts) { { name: mapping_name, generator_uri: generator_uri } }
+
+  describe '#run' do
+    let(:record_double) { double(DPLA::MAP::Aggregation) }
+    let(:records) do
+      [record_double, record_double.clone, record_double.clone]
+    end
+
+    before do
+      allow(subject).to receive(:records).and_return([:record1, :record2])
+      allow(record_double).to receive(:set_subject!)
+      allow(record_double).to receive(:save)
+      expect(Krikri::Mapper).to receive(:map).with(mapping_name, subject.records)
+        .and_return(records)
+    end
+
+    it 'calls mapper' do
+      subject.run
+    end
+
+    it 'sets generator' do
+      records.each do |rec|
+        statement = double
+        allow(RDF).to receive(:Statement)
+          .with(rec, RDF::PROV.wasGeneratedBy, activity_uri)
+          .and_return(statement)
+        expect(rec).to receive(:<<).with(statement)
+      end
+      subject.run(activity_uri)
+    end
+  end
+
+  # TODO: these tests are tied closely to implementation.
+  #       This is a code smell. Consider refactor of ProvenanceQueryClient
+  #       and #records.
+  describe '#records' do
+    let(:solutions) { double(RDF::Query::Solutions) }
+    let(:solution) { double(RDF::Query::Solutions) }
+    let(:record_double) { double(Krikri::OriginalRecord) }
+
+    it 'returns a lazy enum' do
+      expect(subject.records).to be_a Enumerator::Lazy
+    end
+
+    it 'gets records for generated by harvest_activity' do
+      expect_any_instance_of(Krikri::ProvenanceQueryClient)
+        .to receive(:find_by_activity).with(generator_uri).and_return(solutions)
+      expect(solutions).to receive(:lazy).and_return([solution])
+      expect(solution).to receive(:record).and_return(:uri)
+      expect(OriginalRecord).to receive(:load).with(:uri.to_s)
+        .and_return(:record)
+      expect(subject.records).to eq [:record]
+    end
+  end
+end