krikri 0.3.1 → 0.3.2

data/spec/lib/krikri/harvesters/file_harvester_spec.rb~

@@ -0,0 +1,3 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::FileHarvester do

data/spec/lib/krikri/harvesters/oai_harvester_spec.rb

@@ -276,7 +276,7 @@ EOM
           expect(subject.client).to receive(request_type)
             .with(:metadata_prefix => args[:oai][:metadata_prefix])
             .and_return(result)
-          subject.send(method)
+          subject.send(method).first
         end
 
         it 'adds options passed into request' do
@@ -284,7 +284,7 @@ EOM
             .with(:metadata_prefix => args[:oai][:metadata_prefix],
                   :set => request_opts[:set])
             .and_return(result)
-          subject.send(method, request_opts)
+          subject.send(method, request_opts).first
         end
 
         context 'with multiple sets' do
@@ -294,7 +294,7 @@ EOM
             opts.delete(:set)
             expect(subject.client).to receive(request_type).with(opts)
                                        .and_return(result)
-            subject.send(method, { :skip_set => 'moomin' })
+            subject.send(method, { :skip_set => 'moomin' }).first
           end
 
           it 'skips sets from full list when none given' do
@@ -305,7 +305,7 @@ EOM
             allow(subject).to receive(:sets).and_return(['valid', 'moomin'])
             expect(subject.client).to receive(request_type).with(opts)
                                        .and_return(result)
-            subject.send(method, { :skip_set => 'moomin' })
+            subject.send(method, { :skip_set => 'moomin' }).first
           end
         end
       end
@@ -360,6 +360,24 @@ EOM
       end
     end
 
+    describe '#request_with_sets' do
+      it 'is lazy' do
+        sets = [double('first'), double('second')]
+        opts = { :set => sets }
+        expect { |b| subject.send(:request_with_sets, opts, &b) }
+          .not_to yield_control
+      end
+
+      it 'sends requests' do
+        sets = [double('first'), double('second')]
+        opts = { :set => sets }
+        expect { |b| subject.send(:request_with_sets, opts, &b) }
+          .not_to yield_successive_args({ :set => opts[:set][0] },
+                                        { :set => opts[:set][1] })
+      end
+
+    end
+
     describe '#enqueue' do
       let(:args) do
         {uri: 'http://example.org/endpoint', oai: {metadata_prefix: 'mods'}}
@@ -400,14 +418,14 @@ EOM
     describe 'concat_enum' do
 
       it 'concatenates enums' do
-        expect(subject.concat_enum((1..10), (100..110)).to_a)
+        expect(subject.concat_enum([(1..10), (100..110)]).to_a)
           .to eq (1..10).to_a.concat((100..110).to_a)
       end
 
       it 'works with lazy' do
         enum = double
         expect(enum).not_to receive :each
-        subject.concat_enum((1..10), enum).lazy.take(10)
+        subject.concat_enum([(1..10), enum]).lazy.take(10)
       end
     end
 

data/spec/lib/krikri/mapper_spec.rb

@@ -26,7 +26,7 @@ describe Krikri::Mapper do
       mapped = Krikri::Mapper.map(:integration, record).first
 
       expect(mapped.sourceResource.first.creator.first.providedLabel)
-        .to eq record.root['dc:creator'].map(&:value)
+        .to eq record.root['dc:creator'].to_a.map(&:value)
 
       expect(mapped.sourceResource.first.identifier)
         .to eq Array(record.header.first['xmlns:identifier'].first.value)

data/spec/lib/krikri/parser_value_array_spec.rb

@@ -23,9 +23,20 @@ describe Krikri::Parser::ValueArray do
   end
 
   describe '#values' do
+    before do
+      values.each do |v|
+        allow(v).to receive(:respond_to?).with(:value).and_return(true)
+      end
+    end
+
     it 'gives values for items in array' do
       expect(subject.values).to eq ['value_0', 'value_1', 'value_2']
     end
+
+    it 'gives item when item has no value property' do
+      values << double('valueless')
+      expect(subject.values).to eq ['value_0', 'value_1', 'value_2', values.last]
+    end
   end
 
   shared_context 'with fields' do
@@ -183,6 +194,16 @@ describe Krikri::Parser::ValueArray do
     end
   end
 
+  describe '#map' do
+    it 'calls block on all' do
+      expect { |b| subject.map(&b) }.to yield_successive_args(*subject.to_a)
+    end
+
+    it 'returns an instance of its class' do
+      expect(subject.map {}).to be_a described_class
+    end
+  end
+
   describe '#reject' do
     it 'creates new array not containing rejected values' do
       expect(subject.reject { |v| v.value == 'value_1'})

data/spec/models/activity_spec.rb

@@ -14,6 +14,14 @@ end
 describe Krikri::Activity, type: :model do
   subject { create(:krikri_activity) }
 
+  describe '#save' do
+    subject { build(:krikri_activity_with_long_opts) }
+
+    it 'saves long :opts values successfully' do
+      expect { subject.save }.not_to raise_error
+    end
+  end
+
   describe '#rdf_subject' do
     it 'is a URI' do
       expect(subject.rdf_subject).to be_a RDF::URI

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: krikri
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Audrey Altman
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-06 00:00:00.000000000 Z
+date: 2015-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -358,6 +358,7 @@ files:
 - db/migrate/20141113200643_create_krikri_harvest_sources.rb
 - db/migrate/20141212220924_create_krikri_activities.rb
 - db/migrate/20150106164218_add_opts_to_krikri_harvest_sources.rb
+- db/migrate/20150309160112_change_opts_in_krikri_activities.rb
 - lib/aggregation.rb~
 - lib/blacklight.rb~
 - lib/generators/krikri/install_generator.rb
@@ -396,6 +397,7 @@ files:
 - lib/krikri/harvesters/basic_save_behavior.rb
 - lib/krikri/harvesters/basic_save_behavior.rb~
 - lib/krikri/harvesters/couchdb_harvester.rb
+- lib/krikri/harvesters/file_harvester.rb~
 - lib/krikri/harvesters/harvest_behavior.rb
 - lib/krikri/harvesters/harvest_behavior.rb~
 - lib/krikri/harvesters/oai_harvester.rb
@@ -699,6 +701,7 @@ files:
 - spec/lib/krikri/harvesters/basic_save_behavior_spec.rb
 - spec/lib/krikri/harvesters/basic_save_behavior_spec.rb~
 - spec/lib/krikri/harvesters/couchdb_harvester_spec.rb
+- spec/lib/krikri/harvesters/file_harvester_spec.rb~
 - spec/lib/krikri/harvesters/harvest_behavior_spec.rb
 - spec/lib/krikri/harvesters/harvest_behavior_spec.rb~
 - spec/lib/krikri/harvesters/oai_harvester_spec.rb
@@ -820,6 +823,7 @@ test_files:
 - spec/lib/krikri/harvesters/oai_skip_deleted_behavior_spec.rb~
 - spec/lib/krikri/harvesters/couchdb_harvester_spec.rb
 - spec/lib/krikri/harvesters/harvest_behavior_spec.rb
+- spec/lib/krikri/harvesters/file_harvester_spec.rb~
 - spec/lib/krikri/harvesters/harvest_behavior_spec.rb~
 - spec/lib/krikri/mapping_dsl/property_declaration_spec.rb~
 - spec/lib/krikri/mapping_dsl/child_declaration_spec.rb