krikri 0.2.1 → 0.3.1

data/spec/lib/krikri/enrichment_agent_spec.rb~

@@ -0,0 +1,4 @@
+describe Krikri::Enrichment::Agent do
+  opts = {}
+  it_behaves_like 'a software agent', opts
+end

data/spec/lib/krikri/enrichments/capitalize_spec.rb~

@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe Krikri::Enrichments::Capitalize do
+  it_behaves_like 'a field enrichment'
+
+  let(:start_value) do
+    'THE MOOMIN BOOKS MAKE FOR BOTH SPLENDID BEDTIME READ-ALOUDS AND SOLITARY SAVORING. IT’S MORE THAN FORTY YEARS SINCE JANSSON’S MOOMINTROLLS FIRST APPEARED. I FOUND THE WRITING AND INVENTION AS APPEALING AS EVER. SHE HAS A THISTLEDOWN TOUCH.'
+  end
+
+  let(:end_value) do
+
+  end
+
+  it 'skips non-string values' do
+    date = Date.today
+    expect(subject.enrich_value(date)).to eq date
+  end
+
+  it 'capitalizes fields' do
+    expect(subject.enrich_value(start_value))
+      .to eq end_value
+  end
+end

data/spec/lib/krikri/enrichments/deduplication_spec.rb~

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::Deduplication do
+  it_behaves_like 'a field enrichment'
+end

data/spec/lib/krikri/enrichments/genre_filter_spec.rb~

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::GenreFilter do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => 'removes non-genre terms',
+              :start => 'Not A Term',
+              :end => nil
+            },
+            { :string => 'retains genre terms',
+              :start => 'Book',
+              :end => 'Book'
+            },
+            { :string => 'normalizes string form',
+              :start => "\n bO  O-k!   \t",
+              :end => 'Book'
+            }]
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/iso_enrich_spec.rb~

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripHtml do
+  it_behaves_like 'a field enrichment'

data/spec/lib/krikri/enrichments/parse_date_spec.rb~

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::StripPunctuation do
+  it_behaves_like 'a field enrichment'
+
+  values = [{ :string => '',
+              :start => "\tmoominpapa;... !@#$ moominmama  ",
+              :end => "\tmoominpapa  moominmama  "
+            },
+            { :string => 'leaves other fields unaltered',
+              :start => "\tmoominpapa moominmama",
+              :end => "\tmoominpapa moominmama"
+            }]
+
+  it_behaves_like 'a string enrichment', values
+end

data/spec/lib/krikri/enrichments/timespan_spec.rb~

@@ -0,0 +1,10 @@
+module Krikri::Enrichments
+  ##
+  # Normalizes date strings to EDTF or Date objects.
+  #
+
+  class ParseDate
+    include Krikri::FieldEnrichment
+
+    def enrich_value(value)
+    end

data/spec/lib/krikri/enrichments/timespan_split_spec.rb~

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Krikri::Enrichments::TimespanSplit do
+  it_behaves_like 'a field enrichment'
+
+  let(:timespan) do
+    build(:timespan, providedLabel: label, begin: begin_date, end: end_date)
+  end
+  let(:label) { nil }
+  let(:begin_date) { nil }
+  let(:end_date) { nil }
+
+  context 'with a non-timespan object' do
+    it 'returns nil' do
+      expect(subject.enrich_value(RDF::Node.new)).to be nil
+    end
+  end
+
+  context 'with string' do
+  end
+
+  context 'with timespan label' do
+    let(:label) { '1642 - 1726?' }
+
+    it do
+      subject.enrich_value(timespan)
+    end
+  end
+
+  describe '#partial_edtf' do
+    context 'with YYYY-MM-DD/DD' do
+      let(:start_date) { Date.new(2014,1,27) }
+      let(:end_date) { Date.new(2014,1,28) }
+
+      it 'parses date' do
+        expect(subject.partial_edtf('2014-01-27/28'))
+          .to have_attributes(:from => start_date,:to => end_date)
+      end
+
+      it 'gives nil for invalid date' do
+        expect(subject.partial_edtf('2014-01-98/28')).to eq nil
+      end
+    end
+
+    context 'with YYYY-MM/MM' do
+      let(:start_date) { Date.new(2014,1,1) }
+      let(:end_date) { Date.new(2014,3,1) }
+
+      it 'parses date' do
+        expect(subject.partial_edtf('2014-01/03'))
+          .to have_attributes(:from => start_date,:to => end_date)
+      end
+
+      it 'gives nil for invalid date' do
+        expect(subject.partial_edtf('2014-33/03')).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/krikri/harvester_spec.rb

@@ -24,14 +24,50 @@ describe Krikri::Harvester do
     end
   end
 
+  describe '.expected_opts' do
+    it do
+      expect { described_class.expected_opts }
+        .to raise_error NotImplementedError
+    end
+  end
+
+  describe '#record_ids' do
+    it { expect { subject.record_ids }.to raise_error NotImplementedError }
+  end
+
+  describe '#records' do
+    it { expect { subject.records }.to raise_error NotImplementedError }
+  end
+
+  describe '#get_record' do
+    it { expect { subject.get_record(1) }.to raise_error NotImplementedError }
+  end
+
   describe '#run' do
-    let(:records) { [double, double] }
+    let(:records) { [double('record'), double('record2')] }
 
     before do
       allow(subject).to receive(:records).and_return(records)
     end
 
-    context 'when save fails' do
+    context 'with non-default behavior' do
+      subject { klass.include(Krikri::Harvester).new(opts) }
+      let(:opts) do
+        { :uri => 'urn:fake_uri',
+          :harvest_behavior => 'Krikri::Harvesters::OAISkipDeletedBehavior' }
+      end
+
+      it 'sends record to behavior for processing' do
+        activity_uri = double('activity uri')
+        records.each do |rec|
+          expect(Krikri::Harvesters::OAISkipDeletedBehavior)
+            .to receive(:process_record).with(rec, activity_uri).and_return(true)
+        end
+        subject.run(activity_uri)
+      end
+    end
+
+    context 'when behavior fails' do
       it 'logs error' do
         records.each do |rec|
           allow(rec).to receive(:save)

data/spec/lib/krikri/harvesters/basic_save_behavior_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::BasicSaveBehavior do
+  it_behaves_like 'a harvest behavior'
+
+  subject { described_class.new(record, activity_uri) }
+  let(:record) { double('record') }
+  let(:activity_uri) { double('activity URI') }
+
+  describe '#process_record' do
+    it 'calls save with activity_uri on the record' do
+      expect(record).to receive(:save).with(activity_uri)
+      subject.process_record
+    end
+  end
+end

data/spec/lib/krikri/harvesters/basic_save_behavior_spec.rb~

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::BasicSaveBehavior do
+  it_behaves_like 'a harvest behavior'
+
+  subject { described_class.new(record, activity_uri) }
+
+
+  describe '#process_record' do
+    it ''
+  end
+end

data/spec/lib/krikri/harvesters/harvest_behavior_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::HarvestBehavior do
+  it_behaves_like 'a harvest behavior'
+end

data/spec/lib/krikri/harvesters/harvest_behavior_spec.rb~

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Krikri::Harvesters::HarvestBehavior do
+  it_behaves_like 'a harvest behavior'
+end

data/spec/lib/krikri/harvesters/oai_harvester_spec.rb

@@ -47,6 +47,50 @@ describe Krikri::Harvesters::OAIHarvester do
                    :headers => {})
 
       # ListRecords -- Multiple record OAI Request (w/ resumption)
+      response_body = <<EOM
+<?xml version="1.0" encoding="UTF-8"?><?xml-stylesheet type="text/xsl" href="static/oai2.xsl"?><OAI-PMH xmlns="http://www.openarchives.org/OAI/2.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd"><responseDate>2014-10-27T23:05:33Z</responseDate><request verb="ListRecords" metadataPrefix="oai_dc">http://oaipmh.huygens.knaw.nl/</request><ListRecords><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000010</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction:manuscript</setSpec><setSpec>arthurianfiction</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
+   <dc:title>Aberystwyth, National Library of Wales, 446-E</dc:title>
+   <dc:creator>Bart Besamusca</dc:creator>
+   <dc:identifier>https://service.arthurianfiction.org/manuscript/MAN0000000010</dc:identifier>
+   <dc:date>2012-07-13T14:27:31Z</dc:date>
+   <dc:contributor>Bart Besamusca</dc:contributor>
+   <dc:type>model</dc:type>
+   <dc:language>eng</dc:language>
+</oai_dc:dc></metadata></record><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000011</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction</setSpec><setSpec>arthurianfiction:manuscript</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
+   <dc:title>Aberystwyth, National Library of Wales, 5018-D</dc:title>
+   <dc:creator>Bart Besamusca</dc:creator>
+   <dc:identifier>https://service.arthurianfiction.org/manuscript/MAN0000000011</dc:identifier>
+   <dc:date>2012-07-13T14:27:31Z</dc:date>
+   <dc:contributor>Bart Besamusca</dc:contributor>
+   <dc:type>model</dc:type>
+   <dc:language>eng</dc:language>
+</oai_dc:dc></metadata></record><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000012</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction</setSpec><setSpec>arthurianfiction:manuscript</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
+   <dc:title>Aberystwyth, National Library of Wales, 445-D</dc:title>
+   <dc:creator>Bart Besamusca</dc:creator>
+   <dc:identifier>https://service.arthurianfiction.org/manuscript/MAN0000000012</dc:identifier>
+   <dc:date>2012-07-13T14:27:31Z</dc:date>
+   <dc:contributor>Bart Besamusca</dc:contributor>
+   <dc:type>model</dc:type>
+   <dc:language>eng</dc:language>
+</oai_dc:dc></metadata><about>
+<oaiProvenance:provenance xmlns:oaiProvenance="http://www.openarchives.org/OAI/2.0/provenance" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/provenance http://www.openarchives.org/OAI/2.0/provenance.xsd">
+<oaiProvenance:originDescription harvestDate="2015-01-07" altered="true">
+<oaiProvenance:baseURL>http://cdm16694.contentdm.oclc.org/oai/oai.php</oaiProvenance:baseURL>
+<oaiProvenance:identifier>oai:cdm16694.contentdm.oclc.org:R6A001/1</oaiProvenance:identifier>
+<oaiProvenance:datestamp>2015-01-07</oaiProvenance:datestamp>
+<oaiProvenance:metadataNamespace>http://www.openarchives.org/OAI/2.0/</oaiProvenance:metadataNamespace>
+</oaiProvenance:originDescription>
+</oaiProvenance:provenance>
+</about></record><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000013</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction:manuscript</setSpec><setSpec>arthurianfiction</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
+   <dc:title>Aberystwyth, National Library of Wales, 5667 E</dc:title>
+   <dc:creator>Bart Besamusca</dc:creator>
+   <dc:identifier>https://service.arthurianfiction.org/manuscript/MAN0000000013</dc:identifier>
+   <dc:date>2012-07-13T14:27:31Z</dc:date>
+   <dc:contributor>Bart Besamusca</dc:contributor>
+   <dc:type>model</dc:type>
+   <dc:language>eng</dc:language>
+</oai_dc:dc></metadata></record><resumptionToken cursor="1">MToxMHwyOnwzOnw0Onw1Om9haV9kYw==</resumptionToken></ListRecords></OAI-PMH>
+EOM
       stub_request(:get,
                    'http://example.org/endpoint?metadataPrefix=oai_dc&verb='\
                    'ListRecords')
@@ -55,7 +99,12 @@ describe Krikri::Harvesters::OAIHarvester do
                 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'
               })
         .to_return(:status => 200,
-                   :body => '<?xml version="1.0" encoding="UTF-8"?><?xml-stylesheet type="text/xsl" href="static/oai2.xsl"?><OAI-PMH xmlns="http://www.openarchives.org/OAI/2.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd"><responseDate>2014-10-27T23:05:33Z</responseDate><request verb="ListRecords" metadataPrefix="oai_dc">http://oaipmh.huygens.knaw.nl/</request><ListRecords><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000010</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction:manuscript</setSpec><setSpec>arthurianfiction</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
+                   :body => response_body,
+                   :headers => {})
+
+      # with set
+      response_body = <<EOM
+<?xml version="1.0" encoding="UTF-8"?><?xml-stylesheet type="text/xsl" href="static/oai2.xsl"?><OAI-PMH xmlns="http://www.openarchives.org/OAI/2.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd"><responseDate>2014-10-27T23:05:33Z</responseDate><request verb="ListRecords" metadataPrefix="oai_dc">http://oaipmh.huygens.knaw.nl/</request><ListRecords><record><header><identifier>oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000010</identifier><datestamp>2012-07-13T14:27:31Z</datestamp><setSpec>arthurianfiction:manuscript</setSpec><setSpec>arthurianfiction</setSpec></header><metadata><oai_dc:dc xmlns:cmdi="http://www.clarin.eu/cmd/" xmlns:database="http://www.oclc.org/pears/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:oai="http://www.openarchives.org/OAI/2.0/" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd http://www.clarin.eu/cmd/ http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/profiles/clarin.eu:cr1:p_1345561703673/xsd">
    <dc:title>Aberystwyth, National Library of Wales, 446-E</dc:title>
    <dc:creator>Bart Besamusca</dc:creator>
    <dc:identifier>https://service.arthurianfiction.org/manuscript/MAN0000000010</dc:identifier>
@@ -96,7 +145,18 @@ describe Krikri::Harvesters::OAIHarvester do
    <dc:contributor>Bart Besamusca</dc:contributor>
    <dc:type>model</dc:type>
    <dc:language>eng</dc:language>
-</oai_dc:dc></metadata></record><resumptionToken cursor="1">MToxMHwyOnwzOnw0Onw1Om9haV9kYw==</resumptionToken></ListRecords></OAI-PMH>',
+</oai_dc:dc></metadata></record><resumptionToken cursor="1">MToxMHwyOnwzOnw0Onw1Om9haV9kYw==</resumptionToken></ListRecords></OAI-PMH>
+EOM
+
+      stub_request(:get,
+                   'http://example.org/endpoint?metadataPrefix=mods&set=moomin&' \
+                   'verb=ListRecords')
+        .with(:headers => {
+                'Accept' => '*/*',
+                'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'
+              })
+        .to_return(:status => 200,
+                   :body => response_body,
                    :headers => {})
 
       # ListRecords -- Multiple record OAI Request (resumed)
@@ -152,6 +212,52 @@ describe Krikri::Harvesters::OAIHarvester do
       end
     end
 
+    describe '#sets' do
+      before do
+        response_body = <<EOM
+<?xml version="1.0" encoding="UTF-8"?>
+<OAI-PMH xmlns="http://www.openarchives.org/OAI/2.0/"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/
+                             http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd">
+  <responseDate>2015-02-21T17:07:46Z</responseDate>
+  <request verb="ListSets">http://fedora.digitalcommonwealth.org/oaiprovider/</request>
+<ListSets>
+<set>
+  <setSpec>commonwealth-oai:1r66j283x</setSpec>
+  <setName>History of the Academy</setName>
+</set>
+<set>
+  <setSpec>commonwealth-oai:1r66j2871</setSpec>
+  <setName>List of Vessels Belonging to the District of Gloucester</setName>
+</set>
+<set>
+  <setSpec>commonwealth-oai:wp988k074</setSpec>
+  <setName>NOBLE Collection</setName>
+</set>
+</ListSets>
+</OAI-PMH>
+EOM
+        stub_request(:get, "http://example.org/endpoint?verb=ListSets").
+          with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'}).
+          to_return(:status => 200,
+                    :body => response_body,
+                    :headers => {})
+      end
+
+      it 'returns sets' do
+        expect(subject.sets).to contain_exactly(an_instance_of(OAI::Set),
+                                                an_instance_of(OAI::Set),
+                                                an_instance_of(OAI::Set))
+      end
+
+      it 'passes block to sets' do
+        expect(subject.sets(&:spec)).to contain_exactly(an_instance_of(String),
+                                                       an_instance_of(String),
+                                                       an_instance_of(String))
+      end
+    end
+
     describe 'options' do
       let(:result) { double }
       let(:args) do
@@ -172,6 +278,7 @@ describe Krikri::Harvesters::OAIHarvester do
             .and_return(result)
           subject.send(method)
         end
+
         it 'adds options passed into request' do
           expect(subject.client).to receive(request_type)
             .with(:metadata_prefix => args[:oai][:metadata_prefix],
@@ -179,6 +286,28 @@ describe Krikri::Harvesters::OAIHarvester do
             .and_return(result)
           subject.send(method, request_opts)
         end
+
+        context 'with multiple sets' do
+          before { args[:oai][:set] = ['moomin', 'moomin'] }
+          it 'skips sets when specific sets are selected' do
+            opts = args[:oai].dup
+            opts.delete(:set)
+            expect(subject.client).to receive(request_type).with(opts)
+                                       .and_return(result)
+            subject.send(method, { :skip_set => 'moomin' })
+          end
+
+          it 'skips sets from full list when none given' do
+            args[:oai].delete(:set)
+            opts = args[:oai].dup
+            opts[:set] = 'valid'
+
+            allow(subject).to receive(:sets).and_return(['valid', 'moomin'])
+            expect(subject.client).to receive(request_type).with(opts)
+                                       .and_return(result)
+            subject.send(method, { :skip_set => 'moomin' })
+          end
+        end
       end
 
       describe '#records' do
@@ -187,6 +316,12 @@ describe Krikri::Harvesters::OAIHarvester do
 
         let(:request_type) { :list_records }
         let(:method) { :records }
+
+        it 'combines sets' do
+          args[:oai][:set] = ['moomin', 'moomin']
+          single_set = subject.records(:set => 'moomin').to_a
+          expect(subject.records.to_a).to eq single_set.concat(single_set)
+        end
       end
 
       describe 'record_ids' do
@@ -243,6 +378,39 @@ describe Krikri::Harvesters::OAIHarvester do
       end
     end
 
+    describe '#record_xml' do
+      let(:oai_record) { OAI::Record.new('') }
+
+      it 'produces valid xml' do
+        expect do
+          Nokogiri::XML(subject.send(:record_xml, oai_record)) do |config|
+            config.options = Nokogiri::XML::ParseOptions::STRICT
+          end
+        end.not_to raise_error
+      end
+
+      it 'sets header status' do
+        allow(oai_record.header).to receive(:status).and_return('deleted')
+        node = Nokogiri::XML(subject.send(:record_xml, oai_record))
+               .at_css('header')
+        expect(node['status']).to eq 'deleted'
+      end
+    end
+
+    describe 'concat_enum' do
+
+      it 'concatenates enums' do
+        expect(subject.concat_enum((1..10), (100..110)).to_a)
+          .to eq (1..10).to_a.concat((100..110).to_a)
+      end
+
+      it 'works with lazy' do
+        enum = double
+        expect(enum).not_to receive :each
+        subject.concat_enum((1..10), enum).lazy.take(10)
+      end
+    end
+
     it_behaves_like 'a harvester'
   end
 end