krane 3.5.0 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c1d40b511ff2e7ad4c2e761954e547291257b2392e162fa5d85858ecc1628d
-  data.tar.gz: 6acb35faad05f8369063c5bd4eb54b3c09789f215f0d4c8de04de46b6d6fbfbe
+  metadata.gz: 52cc9b71135229c675d72b67b871b4247fb473ab58805980640c126eab8c378b
+  data.tar.gz: 20ab95c9842ec0b7c309ad13d0246fdab355724642638198cb20dec17fbc4576
 SHA512:
-  metadata.gz: b2fe1f07cc83ca37b75e36994e03c7b70710d0bce032d3ee385ff6a5c323e53c4a34026dfe1c087d7e606b4f5f11bd8651ac076c5726a0d83f5db7e8ad71a9b1
-  data.tar.gz: 4a1a42234bc5cf09f9ebc1ce07994997e9c51e40d8ec236f53f26139b90bd646629d46cbbd57dfa6c1ddbb82f38c16778f1b23605cb4b8e00a2f82c2ad3eab28
+  metadata.gz: ccf18bf09655b599d8cf1a25c85c602713dbf3110e1acaeec7212de5fefd8b478eea26bd2b1ac4191cd48b072f07808927bb9ae668862ab7540c40ac575b7bf9
+  data.tar.gz: 79e18c3bd9d219924cc42dc6a9136b5d190b9c8009c3342ca2457c373749e202f78d1957bbf4c82b6cfee410a8aabe0fa008ee5fbf159e947f9bd937911ead27

data/.github/workflows/ci.yml

@@ -5,6 +5,8 @@ on: [push]
 jobs:
   ruby-tests:
     runs-on: ubuntu-latest
+    env:
+      CI: true
 
     name: "Tests (${{matrix.test_suite}}) - Ruby ${{ matrix.ruby }} with Kubernetes ${{ matrix.kubernetes_version }}"
     strategy:

data/CHANGELOG.md

@@ -1,20 +1,28 @@
 ## next
 
-# 3.5.0
+## 3.5.2
+
+- Fixed an issue where deploying StatefulSets monitored the health of the previous revision's pods instead of the updated one.
+
+## 3.5.1
+
+- Fixed successful deployment check for StatefulSets introduced in v3.3.0.
+
+## 3.5.0
 
 - Test against k8s 1.28
 - Drop support for k8s 1.23
 
-# 3.4.2
+## 3.4.2
 
 - Remove flag `--skip-dry-run` (see [#946](https://github.com/Shopify/krane/pull/946))
 - Remove support for batched server-side dry-run ([#946](https://github.com/Shopify/krane/pull/946))
 
-# 3.4.1
+## 3.4.1
 
 - Added flag `--skip-dry-run` to completely opt out of dry run validation.
 
-# 3.4.0
+## 3.4.0
 
 - Use `prune-allowlist` instead of `prune-whitelist` for 1.26+ clusters. Clusters running 1.25 or less will continue to use `--prune-whitelist`. [#940](https://github.com/Shopify/krane/pull/940)
 

data/Gemfile

@@ -4,4 +4,4 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in krane.gemspec
 gemspec
 
-gem "ruby-lsp", "~> 0.2.0", :group => :development
+gem "ruby-lsp", "~> 0.2.0", group: :development

data/lib/krane/kubernetes_resource/stateful_set.rb

@@ -22,26 +22,15 @@ module Krane
     def deploy_succeeded?
       success = observed_generation == current_generation
 
-      @pods.each do |pod|
-        success &= pod.definition["metadata"]["labels"]["controller-revision-hash"] == status_data['updateRevision']
-      end
-
-      if update_strategy == 'RollingUpdate'
-        success &= status_data['currentRevision'] == status_data['updateRevision']
-        success &= desired_replicas == status_data['readyReplicas'].to_i
-        success &= desired_replicas == status_data['currentReplicas'].to_i
-
-      elsif update_strategy == ONDELETE
+      if update_strategy == ONDELETE && required_rollout != "full"
         unless @success_assumption_warning_shown
-          @logger.warn("WARNING: Your StatefulSet's updateStrategy is set to OnDelete, "\
-                       "which means the deployment won't succeed until all pods are updated by deletion.")
+          @logger.warn("WARNING: Your StatefulSet's updateStrategy is set to #{update_strategy}, "\
+                       "which means updates will not be applied until its pods are deleted.")
           @success_assumption_warning_shown = true
         end
-
-        if required_rollout == 'full'
-          success &= desired_replicas == status_data['readyReplicas'].to_i
-          success &= desired_replicas == status_data['updatedReplicas'].to_i
-        end
+      else
+        success &= desired_replicas == status_data['readyReplicas'].to_i
+        success &= desired_replicas == status_data['updatedReplicas'].to_i
       end
 
       success
@@ -76,7 +65,7 @@ module Krane
     def parent_of_pod?(pod_data)
       return false unless pod_data.dig("metadata", "ownerReferences")
       pod_data["metadata"]["ownerReferences"].any? { |ref| ref["uid"] == @instance_data["metadata"]["uid"] } &&
-      @instance_data["status"]["currentRevision"] == pod_data["metadata"]["labels"]["controller-revision-hash"]
+      @instance_data["status"]["updateRevision"] == pod_data["metadata"]["labels"]["controller-revision-hash"]
     end
 
     def required_rollout

data/lib/krane/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Krane
-  VERSION = "3.5.0"
+  VERSION = "3.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: krane
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.2
 platform: ruby
 authors:
 - Katrina Verey
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-08 00:00:00.000000000 Z
+date: 2024-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -525,7 +525,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.5.9
 signing_key: 
 specification_version: 4
 summary: A command line tool that helps you ship changes to a Kubernetes namespace