kramdown-prismic 0.3.7 → 0.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c409891cb5fb66652154697c053d2f4898c2bdbdb40f90a42df53eb2c41994f2
-  data.tar.gz: aa59f8c4ea6b262abbadea2a810e91901a3bb719bf28dd94206b17d2f46a5204
+  metadata.gz: 9fe817ad7275c3d276c64cd35609274de82861b51dd33a96b91b712681c3ccec
+  data.tar.gz: 86564f1a73cecc37c72584f01d028fcc477479e8256c6d5d8c70e456811267c5
 SHA512:
-  metadata.gz: 7da022135525388a0fb64b091804e65cef0e1307e7ff2cfb0203f3c007fc736393d600dd3119441073fcb73fed956ad45b015d90d4b720ecfacc8851d7132a4e
-  data.tar.gz: 7fbf4b233127d8bba128bcad4624ca13008f1a0dbc6e8c8a7121ac87c8fd72e11f90b046a738cb516965da42ef9c228fcab13fee2bbbc931e98ebbc5a3871701
+  metadata.gz: 5b08711e01100c77f6ba4aac0034cf44a08ce04cabfc7bccf9ffe5687670f2156bc3ee9d07c5ba3990b0df38982b50e3c16bd2807b93b6805987d0baa3103ecc
+  data.tar.gz: 43c728bbaad8e7edd47e287d615b152179ebde1b6255464f0f9d2b489c96a416932abae1c813fc3dbf430ae6f841baa3912b7f8113d23a5074a2166287525095

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## Version 0.3.10
+
+- Fix the embed_url conversion
+
+## Version 0.3.9
+
+- Convert the target attribute on links
+
+## Version 0.3.8
+
+- Convert nested html_elements when converting from HTML.
+
 ## Version 0.3.7
 
 - Fix converting nested headers

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    kramdown-prismic (0.3.7)
+    kramdown-prismic (0.3.10)
       kramdown (>= 1, < 3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    kramdown (2.3.1)
+    kramdown (2.4.0)
       rexml
     minitest (5.10.3)
     rake (13.0.6)

data/lib/kramdown/converter/prismic.rb

@@ -179,7 +179,7 @@ module Kramdown
             },
             type: 'embed',
             data: {
-              embed_url: 'https://www.youtube.com/watch?v=dQw4w9WgXcQ',
+              embed_url: element.attr['src'],
               type: 'link'
             }
           }
@@ -249,10 +249,12 @@ module Kramdown
       end
 
       def extract_span_a(element, memo)
+        target = element.attr['target']
         insert_span(element, memo, {
                       type: 'hyperlink',
                       data: {
-                        url: element.attr['href']
+                        url: element.attr['href'],
+                        **(target ? { target: target } : {}),
                       }
                     })
       end
@@ -282,8 +284,12 @@ module Kramdown
         memo[:text] += element.value
       end
 
-      def extract_span_html_element(_element, _memo)
-        warning('translating html elements is not supported')
+      def extract_span_html_element(element, memo)
+        if respond_to?("extract_span_#{element.value}", true)
+          send("extract_span_#{element.value}", element, memo)
+        else
+          warning("translating html element '#{element.value}' is not supported")
+        end
       end
 
       def extract_span_footnote(_element, _memo)

data/lib/kramdown-prismic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KramdownPrismic
-  VERSION = '0.3.7'
+  VERSION = '0.3.10'
 end

data/test/converter_test.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 # frozen_string_literal: true
 
 require 'minitest/autorun'
@@ -322,7 +321,7 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal 2, doc.warnings.size
   end
 
- def test_convert_heading_in_list
+  def test_convert_heading_in_list
     expected = [
       {
         type: 'list-item',
@@ -576,11 +575,16 @@ class KramdownPrismicConverterTest < Minitest::Test
   end
 
   def test_convert_html_with_no_tags
+    expected_text = if Gem::Version.new(Kramdown::VERSION) >= Gem::Version.new("2.3.2")
+                      "Test "
+                    else
+                      "Test\n"
+                    end
     expected = [
       {
         type: 'paragraph',
         content: {
-          text: "Test\n",
+          text: expected_text,
           spans: []
         }
       }
@@ -608,6 +612,21 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal expected, doc.to_prismic
   end
 
+  def test_convert_link
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: 'Test',
+          spans: [{type: 'hyperlink', data: {url: 'http://example.net', target: '_blank'}, start: 0, end: 4}]
+        }
+      }
+    ]
+    html = '<a href="http://example.net" target="_blank">Test</a>'
+    doc = Kramdown::Document.new(html, input: :markdown)
+    assert_equal expected, doc.to_prismic
+  end
+
   def test_convert_html
     expected = []
     html = '<div></div>'
@@ -616,12 +635,34 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal 1, doc.warnings.size
   end
 
-  def test_convert_span_html
+  def test_convert_span_html_strong
     expected = [
       {
         type: 'paragraph',
         content: {
-          text: '',
+          text: 'This is a  paragraph',
+          spans: [
+            {
+              type: 'strong',
+              start: 10,
+              end: 20
+            }
+          ]
+        }
+      }
+    ]
+    html = '<p>This is a <strong> paragraph</strong></p>'
+    doc = Kramdown::Document.new(html, input: :html)
+    assert_equal expected, doc.to_prismic
+    assert_equal 0, doc.warnings.size
+  end
+
+  def test_convert_span_html_br
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: "\n",
           spans: []
         }
       }
@@ -629,7 +670,24 @@ class KramdownPrismicConverterTest < Minitest::Test
     html = '<br>'
     doc = Kramdown::Document.new(html, input: :markdown)
     assert_equal expected, doc.to_prismic
+    assert_equal 0, doc.warnings.size
+  end
+
+  def test_convert_span_html_unknown
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: 'This is a ',
+          spans: []
+        }
+      }
+    ]
+    html = '<p>This is a <details>detail</details></p>'
+    doc = Kramdown::Document.new(html, input: :html)
+    assert_equal expected, doc.to_prismic
     assert_equal 1, doc.warnings.size
+    assert_equal "translating html element 'details' is not supported", doc.warnings.first
   end
 
   def test_convert_table

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kramdown-prismic
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.10
 platform: ruby
 authors:
 - François de Metz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-13 00:00:00.000000000 Z
+date: 2022-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kramdown