kramdown-prismic 0.3.6 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f68acd9978784949a29e81dc9109f155a5aaa3fbe278142a48b5ea0d667f327b
-  data.tar.gz: eabfc7d18d6ad918f14645d8988d818f27dee74d885ac2e5d22241f633fbc43b
+  metadata.gz: 76a75c9530dc6b9336112a445b9fc4cd811e17059e4677c2094c1b22b585fa06
+  data.tar.gz: 77315988401b9fc306026b3d6a1b9d184b2a92a579fddd2871ba27dbc4000292
 SHA512:
-  metadata.gz: f98e7ec71902a5b7314a978ccae442d2eda5922e69a8217cc6fefcb78c33c19db41244901e50c8fa31517ee468ca62625ffaff987ef683e81532d9cdd2cafe1d
-  data.tar.gz: 7246ec24dd0a0d96b0f736c9f08e0d4c7a8477af0d920091091c8cfee817fb350aeace1175bc33dc7776770c3737fe96054baed3299733c9be4d75af1a3dbf13
+  metadata.gz: 576fc16369c963b6a1215e834dd72e88231177773cd2e62cfba973f4ae59288a508965db55759b214aebab1a0239c0b8d067b9e4a95a861ef7be6c002b3434d3
+  data.tar.gz: c6cd045fa16db194a3f6e3e78fc8cf2c86029e68e8a3b6194140c4f9c08f9db12f92ce0c1abd9b4ef391fc57112a34daac0166b6f5e14378178f7ab852466431

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## Version 0.3.9
+
+- Convert the target attribute on links
+
+## Version 0.3.8
+
+- Convert nested html_elements when converting from HTML.
+
+## Version 0.3.7
+
+- Fix converting nested headers
+
 ## Version 0.3.6
 
 - Fix converting nested numbered list.

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    kramdown-prismic (0.3.6)
+    kramdown-prismic (0.3.9)
       kramdown (>= 1, < 3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    kramdown (2.3.1)
+    kramdown (2.4.0)
       rexml
     minitest (5.10.3)
     rake (13.0.6)

data/lib/kramdown/converter/prismic.rb

@@ -44,6 +44,10 @@ module Kramdown
             warning('nested list moved to the top level')
             elements << element
             extract_non_nestable_elements(element, elements)
+          elsif element.type == :header
+            warning('header moved to the top level')
+            elements << element
+            extract_non_nestable_elements(element, elements)
           else
             memo << element
             extract_non_nestable_elements(element, elements)
@@ -245,10 +249,12 @@ module Kramdown
       end
 
       def extract_span_a(element, memo)
+        target = element.attr['target']
         insert_span(element, memo, {
                       type: 'hyperlink',
                       data: {
-                        url: element.attr['href']
+                        url: element.attr['href'],
+                        **(target ? { target: target } : {}),
                       }
                     })
       end
@@ -278,8 +284,12 @@ module Kramdown
         memo[:text] += element.value
       end
 
-      def extract_span_html_element(_element, _memo)
-        warning('translating html elements is not supported')
+      def extract_span_html_element(element, memo)
+        if respond_to?("extract_span_#{element.value}", true)
+          send("extract_span_#{element.value}", element, memo)
+        else
+          warning("translating html element '#{element.value}' is not supported")
+        end
       end
 
       def extract_span_footnote(_element, _memo)

data/lib/kramdown-prismic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KramdownPrismic
-  VERSION = '0.3.6'
+  VERSION = '0.3.9'
 end

data/test/converter_test.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 # frozen_string_literal: true
 
 require 'minitest/autorun'
@@ -322,6 +321,29 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal 2, doc.warnings.size
   end
 
+  def test_convert_heading_in_list
+    expected = [
+      {
+        type: 'list-item',
+        content: {
+          text: "",
+          spans: []
+        }
+      },
+      {
+        type: 'heading4',
+        content: {
+          text: 'Title',
+          spans: []
+        }
+      }
+    ]
+    html = "<ul><li><h4>Title</h4></li></ul>"
+    doc = Kramdown::Document.new(html, input: :html)
+    assert_equal expected, doc.to_prismic
+    assert_equal 1, doc.warnings.size
+  end
+
   def test_convert_preformatted
     expected = [
       {
@@ -553,11 +575,16 @@ class KramdownPrismicConverterTest < Minitest::Test
   end
 
   def test_convert_html_with_no_tags
+    expected_text = if Gem::Version.new(Kramdown::VERSION) >= Gem::Version.new("2.3.2")
+                      "Test "
+                    else
+                      "Test\n"
+                    end
     expected = [
       {
         type: 'paragraph',
         content: {
-          text: "Test\n",
+          text: expected_text,
           spans: []
         }
       }
@@ -585,6 +612,21 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal expected, doc.to_prismic
   end
 
+  def test_convert_link
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: 'Test',
+          spans: [{type: 'hyperlink', data: {url: 'http://example.net', target: '_blank'}, start: 0, end: 4}]
+        }
+      }
+    ]
+    html = '<a href="http://example.net" target="_blank">Test</a>'
+    doc = Kramdown::Document.new(html, input: :markdown)
+    assert_equal expected, doc.to_prismic
+  end
+
   def test_convert_html
     expected = []
     html = '<div></div>'
@@ -593,12 +635,34 @@ class KramdownPrismicConverterTest < Minitest::Test
     assert_equal 1, doc.warnings.size
   end
 
-  def test_convert_span_html
+  def test_convert_span_html_strong
     expected = [
       {
         type: 'paragraph',
         content: {
-          text: '',
+          text: 'This is a  paragraph',
+          spans: [
+            {
+              type: 'strong',
+              start: 10,
+              end: 20
+            }
+          ]
+        }
+      }
+    ]
+    html = '<p>This is a <strong> paragraph</strong></p>'
+    doc = Kramdown::Document.new(html, input: :html)
+    assert_equal expected, doc.to_prismic
+    assert_equal 0, doc.warnings.size
+  end
+
+  def test_convert_span_html_br
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: "\n",
           spans: []
         }
       }
@@ -606,7 +670,24 @@ class KramdownPrismicConverterTest < Minitest::Test
     html = '<br>'
     doc = Kramdown::Document.new(html, input: :markdown)
     assert_equal expected, doc.to_prismic
+    assert_equal 0, doc.warnings.size
+  end
+
+  def test_convert_span_html_unknown
+    expected = [
+      {
+        type: 'paragraph',
+        content: {
+          text: 'This is a ',
+          spans: []
+        }
+      }
+    ]
+    html = '<p>This is a <details>detail</details></p>'
+    doc = Kramdown::Document.new(html, input: :html)
+    assert_equal expected, doc.to_prismic
     assert_equal 1, doc.warnings.size
+    assert_equal "translating html element 'details' is not supported", doc.warnings.first
   end
 
   def test_convert_table

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kramdown-prismic
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.3.9
 platform: ruby
 authors:
 - François de Metz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-09 00:00:00.000000000 Z
+date: 2022-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kramdown
@@ -107,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A Kramdown converter to convert documents into prismic rich text format and